Odoo Changelog — 2024-06-04

Tuesday, June 4, 2024

56 changes · saas-17.3

Improvements(2)

Enhancements to existing features

[FIX] im_livechat: do not rely on cookies to save data

Coresaas-17.3im_livechat

Live chat now stores visitor information such as recent operator and page history in browser local storage instead of cookies. This follows modern browser guidance and reduces unnecessary cookie use while keeping the chat experience consistent.

Original PR description

The live chat uses cookies to save information such as the last
operator ID or page history. However, the use of cookies as a way to
save data is discouraged ([1]).

This commit replaces the use of cookies in the live chat module with
local storage.

[1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#data_storage

task-3965140

#live chat#local storage#cookies

[IMP] appointment_sale: improve appointment sale related flow

PR #63447

Enterprisesaas-17.3sale_project_forecastwebsite_appointment_sale

Appointment-related sales products are now presented more clearly by hiding planning options when they do not apply. Booking type checks are also narrowed to the most relevant products, helping keep appointment sales behavior more accurate and efficient.

Original PR description

### [IMP] sale_project_forecast: hide planning enable for other tracking

This commit hide planning enabled field and related content for
not project related type from product form view.

### [IMP] website_appointment_sale: improve filter in booking type computation

This commit add more condition in booking type field computation
so we only do query for product we that is closest to being
booking_type.

task-3959899

#appointments#sales#planning#booking

Bug Fixes(6)

Resolved issues and error corrections

[FIXES] web: position properly graph legend tooltips

PR #167972

Coresaas-17.3web

This fixes misplaced tooltips that appear when users hover over graph legends. The correction restores clear, predictable chart interactions so users can read graph details without confusion.

#graph#tooltips#user interface

[FIX] mail: clear need action counter when a channel is open

PR #167943

Coresaas-17.3

Refactoring(1)

Code cleanup and technical improvements

[REF] web: hotkeys tests

PR #167715

Coresaas-17.3web

The web module’s automated hotkey tests were simplified by removing an older helper that is no longer needed. This makes the test suite easier to maintain and helps ensure keyboard shortcut behavior remains reliably checked across operating systems.

#tests#hotkeys#maintenance

Other(47)

Miscellaneous changes

[FW][FIX] analytic: analytic widget glitching line height

PR #168051

Coresaas-17.3analytic

Original PR description

Description of the issue this commit addresses:

When creating an invoice line with the analytic module installed, if the analytic field is show, focusing in on a line adds a little height offset to the entire line which makes the view shaky. This is not wanted.

---

Steps to reproduce:

1 - Install analytic app
2 - Open a new invoice and display the analytic field in the invoice lines
3 - Add a new line, don't add any data inside it.
4 - Focus out, focus in, focus out, focus in.
5 - You can see that focus in adds a few px and focus out removes them.

---

Desired behavior after this commit is merged:

This commit adds a fixed default height to the analyti widget to make sure there is no weird height computation when the focus happens. This way, we can make sure that the line height stays constant whether the focus is in or out of the line.

---

no task-feedback

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#167723

The live chat uses cookies to save information such as the last operator ID or page history. However, the use of cookies as a way to save data is discouraged ([1]). This commit replaces the use of cookies in the live chat module with local storage. [1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#data_storage task-3965140

### [IMP] sale_project_forecast: hide planning enable for other tracking This commit hide planning enabled field and related content for not project related type from product form view. ### [IMP] website_appointment_sale: improve filter in booking type computation This commit add more condition in booking type field computation so we only do query for product we that is closest to being booking_type. task-3959899

Description of the issue this commit addresses: When creating an invoice line with the analytic module installed, if the analytic field is show, focusing in on a line adds a little height offset to the entire line which makes the view shaky. This is not wanted. --- Steps to reproduce: 1 - Install analytic app 2 - Open a new invoice and display the analytic field in the invoice lines 3 - Add a new line, don't add any data inside it. 4 - Focus out, focus in, focus out, focus in. 5 - You can see that focus in adds a few px and focus out removes them. --- Desired behavior after this commit is merged: This commit adds a fixed default height to the analyti widget to make sure there is no weird height computation when the focus happens. This way, we can make sure that the line height stays constant whether the focus is in or out of the line. --- no task-feedback --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167723

**Steps to reproduce:** - open attendance module - go to overview and create a new attendance within 5:30 AM **Issue:** - Extra hours[overtime_hours] are not calculated accurately[output = 0]. **Cause:** The [SQL Query](https://github.com/odoo/odoo/blob/17.0/addons/hr_attendance/models/hr_attendance.py#L77-L91) [condition : date_trunc('day',att.check_in) = date_trunc('day', ot.date)] compares `att.check_in` time stored in UTC with `ot.date` stored in employee timezone, leading to incorrect calculations. **Solution:** Modify SQL query to convert `att.check_in` time to employee timezone before comparison with `ot.date`. In saas-16.4, This [SQL Query](https://github.com/odoo/odoo/blob/saas-16.4/addons/hr_attendance/report/hr_attendance_report.py#L40-L46) is responsible for converting `check_in` time to employee timezone. Description of the issue/feature this PR addresses: **Current behavior before PR:** RUNBOT-17.0 ![runbot_17](https://github.com/odoo/odoo/assets/145324147/93e63367-54f4-49e0-b1e3-363af002bbc2) **Desired behavior after PR is merged:** ![image](https://github.com/odoo/odoo/assets/145324147/ac73655d-9cc0-4a93-9494-5517fa262d6e) UPG - 1573228 TASK - 3900287 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167574 Forward-Port-Of: odoo/odoo#166302

Steps to reproduce [17.0]: - Go to website (in "Edit" mode) > Click on the "Contact Us" button - Save the page > The menu will be saved with the "oe_edited_link" class applied to it. Technical explanation (one of many scenarios causing the bug) [1]: After the website headers redesign in [2], two header navbars were added (for the desktop view and mobile). Which means that the "Contact Us" field is duplicated in the DOM. When clicking on the "Contact Us" desktop link, the `LinkPopoverWidget` will initialize a popover on it. The bootstrap code is automatically adding `data-original-title` and 'title' attributes to the targeted link (see: [3]), and as a consequence, the field observer will take in consideration the mutations and copy the DOM in the mobile version, leading to save the link in the same state when the BS popover was applied to it (with the `oe_edited_link` class). Remarks: - This behaviour was detected on 17.0, but we target 15.0 here to prevent similar issues linked to duplicated fields with links in the DOM. - The bootstrap attributes mutations (as explained in [1]) are just an example of many possible mutations (filtered by `observerUnactive()` in the main editor observer) that can cause the issue... Since we cannot set filters for all these mutations in the fields' observer, we ignore the `oe_edited_link` (and all editor's rendering classes) when copying the field content to solve the issue here. The field observer logic needs to be refactored to probably disable / enable the fields' synchronization when the editor's observer is disabled / enabled. [2]: https://github.com/odoo/odoo/pull/119650 [3]: https://github.com/odoo/odoo/blob/15.0/addons/web/static/lib/bootstrap/js/tooltip.js#L664 opw-3938383 Forward-Port-Of: odoo/odoo#167619 Forward-Port-Of: odoo/odoo#166736

- Re-using results for domains duplicated - Ordering by id instead of default heavy unused order Opening a POS sessions our SQL profiler shows the following query executed too many times: - <img width="770" alt="Screenshot 2024-05-07 at 8 41 09 a m" src="https://github.com/odoo/odoo/assets/6644187/80d7ac19-a042-40bc-a525-063b4074ec0e"> Checking the PY profilers the following method is reported as slow: https://github.com/odoo/odoo/blob/42f5e84eeb1d649feed5e032d65ff74d148b49b8/addons/pos_coupon/models/coupon_program.py#L80 - <img width="1508" alt="Screenshot 2024-05-07 at 8 42 17 a m" src="https://github.com/odoo/odoo/assets/6644187/e46b60f0-cac2-480b-b588-d681f0bc5607"> The reason it is executing the same query too many times with the same domain So, I have created this change to re-use the result if the domain is repeated Also, the query generated has heavy `order by` `order by "res_partner"."type", coalesce("res_partner"."is_company", false) desc, "res_partner"."display_name", "res_partner"."id"; ` Replacing by `order by "res_partner"."id"` it is faster Before `Execution Time: 104.256 ms` Now `Execution Time: 31.802 ms` So, it is ~4x faster for each query and it is re-using data for the same query using a LRU-Cache locally in the method Manual Forward-Port-Of: https://github.com/odoo/odoo/pull/164771 since the module was renamed and the python code refactored so the bot was not able to forward-port it automatically from https://github.com/odoo/odoo/pull/166447 Also, i didn't find the part of the partners in this new version Forward-Port-Of: odoo/odoo#166608

Steps to reproduce: - Install Time off module - Create a public holiday with Working Hours 'calendar_id' - Go to env user Time off dashboard Current behavior before PR: The public holidays that has 'calendar_id' assigned to it will not be shown in Legend when checking the dashboard of the env user. This is happening because we assign the self 'hr.employee' with the employee_id in context https://github.com/odoo/odoo/blob/c6142d9f1432cfabedcaa7264af9e5bc8e538c20/addons/hr_holidays/models/hr_employee.py#L313 and in '_get_contextual_employee' we just check if employee_id exists in ctx or not https://github.com/odoo/odoo/blob/17.0/addons/hr_holidays/models/hr_employee.py#L388:L392 but we don't check the value so if ctx is like {'employee_id': None} it will return None. Desired behavior after PR is merged: We are now checking if the 'employee_id' in ctx has a valid value as if it is not we need to return the employee object of the env user. Other solution that we can add in this line https://github.com/odoo/odoo/blob/c6142d9f1432cfabedcaa7264af9e5bc8e538c20/addons/hr_holidays/models/hr_employee.py#L313 to check if the self._get_contetxtual_employee is None we assign self to self.env.user.employee_id opw-3863947 Forward-Port-Of: odoo/odoo#166548

Currently, an exception is generated when the user tries to access embed view of slides by following the steps: - Install "eLearning" with a demo data - Open external embed view of slide 1 by "/slides/embed_external/1" in url Stack Trace: ``` AttributeError: 'slide.channel' object has no attribute 'website_share_url' File "<1405>", line 313, in template_1405 File "<1405>", line 151, in template_1405_content File "<1405>", line 18, in template_1405_t_call_0 QWebException: Error while render the template AttributeError: 'slide.channel' object has no attribute 'website_share_url' Template: ir.ui.view(1405,) Path: /t/html/body/div/div[2]/t[1]/t/t[4] Node: <t t-set="include_embed" t-value="True"/> ``` This error is because commit [1] added code that tries to access the 'website_share_url' field in the 'slide.channel' model in template 'embed_slide' , but it actually belongs to 'slide.slide'. This commit resolved the above issue by accessing "website_share_url" with "slide" instead of "slide.channel". [1] - https://github.com/odoo/odoo/commit/db63c03af9932ae4d9b786620e88e62ce938589a sentry-5095823727 Forward-Port-Of: odoo/odoo#159561 Forward-Port-Of: odoo/odoo#159238

Description of the issue/feature this PR addresses: If the user has two invoices/bills selected where one falls within the parameters of a discounted payment and the other does not, the calculated payment total and payment difference will be wrong. Current behavior before PR: If I have two Bills, both for $25.00 where one falls within the parameters of a discount for 2% in 10 Days and the other doesn't, and I select both of them and click register payment, and the select "Group Payments" (group_payment), the "Amount" (amount) will be $0.50 and the Payment Difference (payment_difference) will be $49.50. Desired behavior after PR is merged: In the same scenario, I would expect the "Amount" to be $49.50 and the "Payment Difference" to be $0.50 To Reproduce: - Create Payment Term "2% 10, Net 30" this payment term should be configured to have a discount of 2% if paid in the first 10 days, and then 100% of the bill is due in 30 Days. - Create two Purchase Orders (doesn't matter which products you purchase), receive products, and create bills. Make sure one has the new payment term you created and its bill date puts it within the discount parameters. The other bill should either have a different payment term that doesn't have a discount or the same term but not be within the parameters to have the discount apply (bill is older than 10 days in this case) - Go to Accounting --> Vendors --> Bills and select both of these new bills and click "Register Payment" - In the wizard, click "Group Payments" and you will see the amount and payment difference are incorrect. **This process can also be done with sale orders instead, you will get the same result with two invoices for customers. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167214 Forward-Port-Of: odoo/odoo#165539

The problem is that the message ``` This invoice will be paid using direct debit and is only sent for informative purposes. sent for informative purposes ``` is displayed even in invoices that doesn't use Direct Debit after a studio change. Steps: - install `account_sepa_direct_debit` - install `web_studio` - Edit `Invoices` report on studio - Save - Try to print an invoice report - SDD (Sepa Direct Debit) message will be displayed even if this invoice doesn't use SDD This inconsistency was due to two errors in the report generated by SDD ```xml This invoice will be paid using direct debit and is only sent for informative purposes. Please do not pay it manually, the payment will be asked to your bank to be processed automatically. ``` A ``/`` can't contains another `` as defined here https://html.spec.whatwg.org/#the-p-element or https://html.spec.whatwg.org/#the-span-element ``/`` can only contains "Phrasing content" (https://html.spec.whatwg.org/#phrasing-content-2) `<div>` and `` for example are not phrasing content opw-3908411 Forward-Port-Of: odoo/enterprise#63345

Improvements(2)

[FIX] im_livechat: do not rely on cookies to save data

[IMP] appointment_sale: improve appointment sale related flow

Bug Fixes(6)

[FIXES] web: position properly graph legend tooltips

[FIX] mail: clear need action counter when a channel is open

Refactoring(1)

[REF] web: hotkeys tests

Other(47)

[FW][FIX] analytic: analytic widget glitching line height

Improvements(2)

[FIX] im_livechat: do not rely on cookies to save data

[IMP] appointment_sale: improve appointment sale related flow

Bug Fixes(6)

[FIXES] web: position properly graph legend tooltips

[FIX] mail: clear need action counter when a channel is open

Refactoring(1)

[REF] web: hotkeys tests

Other(47)

[FW][FIX] analytic: analytic widget glitching line height

[FIX] pos_self_order: fix test_self_order_mobile

[FIX] account_*: tests without accountant

[FIX] mail: only show new message separator in the relevant thread

[FIX] account_*: invoice plus tours and test

[FW][FIX] web: take account decimal point in the input

[FW][FIX] bus: fix websocket rate limiting tests with noble

[FW][FIX] web_editor: fix component destroy error

[FW][FIX] hr_attendance: Calculating extra hours based on timezone

[FW][FIX] hr_expense: use taxes from parent company

[FW][FIX] web_editor: prevent adding rendering classes on the field observer

[FW][FW][IMP] pos_coupon: Speed-up computing domain for products

[FW][CLA] signature for lingjiawen

[FW][FIX] l10n_it: add missing accounts to tax repartition lines

[FW][FIX] hr_homeworking: 1 work location when remote

[FW][IMP] web: add a note to hotkey options

[FW][FIX] hr_holidays : Set env user as self if not employee in context

[FW][FIX] cli: invalid login for SaaS

[FW][FIX] website_slides: prevent exception while accessing embed external of slide

[FW][FIX] website_event_exhibitor: correct long name display

[FW][FIX] base_import_module: fix tree view

[FW][IMP] cli: obfuscate datas

[FW][IMP] web_editor: background color opacity

[FW][FIX] account: bank dashboard misc entry currency

[FW][FIX] hr_holidays: avoid auto-cancel of valid leaves

[FW][FIX] website: hide cookies bar on policy page

[FW][FIX] sale_loyalty: taxes on gift cards

[FW][FIX] l10n_at: Fix account tags on accounts.

[FW][FIX] im_livechat: fix failing embed test

[FW][FIX] pos_self_order: display order number for a command with a price of 0.00

[FW][FIX] pos_restaurant: display table number in product screen

[FW][FIX] mail: add get modelParam in ActivityController

[FW][FIX] pos_restaurant: visibility of table creating on floor plan

[FW][FIX] l10n_ug: Taxes payable account type

[FW][17.0][FIX] account: Correct payment amount in wizard when grouping discounted and non-discounted bills

[FW][IMP] web: allow overriding router url-state conversion

[FW][FIX] base: remove real person's phone number

[FW][FIX] account: ensure payment terms validation when enabling EPDs

[FW][FIX] account_peppol: display warning if missing info

[FW][FIX] hr_timesheet: fixed total time not showing in portal

[FW][FIX] web_editor: don't remove some links codeview

[FW][FIX] l10n_be_hr_payroll: fix missing column in eco voucher file

[FW][FIX] l10n_pe_edi: set default document type

[FW][FIX] account_reports: adapt ubuntu noble

[FW][FIX] l10n_mx_edi_extended: update tariff fraction

[FW][FIX]sale_amazon: picking sync failed message fix

[FW][IMP] l10n_be_codabox: auto update Soda mapping when entry line with Suspense Account is updated

[FW][FIX] account_reports: Error when branch access Journal Report

[FW][FIX] account_sepa_direct_debit: Prevent sdd linked text

[FW][FIX] documents: fix update document in activity view

[FW][FIX] knowledge: fix inconsistent id in article url for portal users