Wednesday, June 5, 2024
12 changes · 17.0
Resolved issues and error corrections
Fixes an issue where sharing a spreadsheet could fail if a From/To global filter was left blank. Users can now share spreadsheets with empty date range filters without encountering an error.
Original PR description
Steps to reproduce: - insert a pivot in a spreadsheet - create a From/To global filter - leave the filter values empty - click on the Share button => boom because of `cell.value.toString()` `cannot read toString of undefined` opw-3971278 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures spreadsheets correctly recognize when a pivot table is still being used from another sheet. Users will no longer see active pivots incorrectly marked as unused, reducing the risk of accidental cleanup or confusion in the Data menu.
Original PR description
Steps to reproduce in 17.0: There's no way to reproduce the issue in 17.0 because the faulty getter in only called on positions in the active sheet (pivot autofill, global filter auto-matching) Steps to reproduce in saas-17.1: - insert a pivot in a blank spreadsheet - delete all pivot formulas - insert a new sheet - in the new sheet: - in A1: type "1" - in A2: =ODOO.PIVOT(A1) - activate the first sheet again - Open the Data menu => the pivot 1 is marked as being unused, even though it's used in the second sheet Task: 3859472 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents users from changing detailed stock movement information after an inventory transfer has been completed and locked. It avoids an error that could occur when editing the “Pick From” field on validated delivery orders, helping keep completed inventory records stable and reliable.
Original PR description
### Steps to reproduce: - In the inventory, create a delivery order for 1 unit of any product - Validate the picking and click on detailed operations - Click on the field of the move named "Pick From", type and create new #### > Traceback error ### Cause of the issue: You should not be able to edit the moves of a done locked picking. However the `quant_id` field is not set to `read_only` in this case: https://github.com/odoo/odoo/blob/c016a5306dd90b90c88e083cc0f0d2ae9c0b649f/addons/stock/views/stock_move_views.xml#L263-L267 ### Fix: We add the same `read_only` condition as for the other fields visible on the move. opw-3935214 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A spreadsheet interface style rule was updated to match a recent naming change in the shared library. This keeps the affected button styling working consistently in Odoo after the library rename.
Original PR description
We recently renamed `o-sidePanelButton` to `o-button` in the library but did not change it inside Odoo. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A CSS class name was updated in the spreadsheet module to match a recent library change. The button styling class was renamed from `o-sidePanelButton` to `o-button` to maintain consistency with the updated library. This ensures the version history panel buttons display correctly.
Original PR description
We recently renamed `o-sidePanelButton` to `o-button` in the library but did not change it inside Odoo.
Miscellaneous changes
Current behavior: In certain currencies, you have coin of values like 0.025 that requires more than 2 decimal places. But in the coin/bills view they were not correctly showed. Values like 0.025 would appear as 0.02 Steps to reproduce: - Create a new company using a currency that needs 3 decimal places (Bahraini Dinar) - Try to create coin/bills with a value like 0.025 - After saving the last part cannot be seen anymore opw-3950930 --- I confirm I have signed the CLA and read the PR
Original PR description
Current behavior: In certain currencies, you have coin of values like 0.025 that requires more than 2 decimal places. But in the coin/bills view they were not correctly showed. Values like 0.025 would appear as 0.02 Steps to reproduce: - Create a new company using a currency that needs 3 decimal places (Bahraini Dinar) - Try to create coin/bills with a value like 0.025 - After saving the last part cannot be seen anymore opw-3950930 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168011 Forward-Port-Of: odoo/odoo#167497
### Steps to reproduce: - Create a storable product with a vendor (in the pruchase tab) - Create a buy reordering rule with that vendor for that product - Select the reordering rule line and snooze it for one day - Create a sale order for #### > the snoozed reordering rule is triggered ### Cause of the issue: The `snoozed_untill` field of the orderpoint is not taken into account by the `_trigger_scheduler` to determine which auto-trigger orderpoint should be applied: https://gith
Original PR description
### Steps to reproduce: - Create a storable product with a vendor (in the pruchase tab) - Create a buy reordering rule with that vendor for that product - Select the reordering rule line and snooze it for one day - Create a sale order for #### > the snoozed reordering rule is triggered ### Cause of the issue: The `snoozed_untill` field of the orderpoint is not taken into account by the `_trigger_scheduler` to determine which auto-trigger orderpoint should be applied: https://github.com/odoo/odoo/blob/4f43eb2e69224c9cb271b6e2ca7533d929333985/addons/stock/models/stock_move.py#L2132-L2138 opw-3901613 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#165567
ZATCA updated the VAT exemption reason codes to be provided for 0% taxes. This commit aims to expand the list of existing tax exemption reason codes in odoo to include the new reason: VATEX-SA-OOS Description of the issue/feature this PR addresses: Currently the VAT exemption reasons defined in the l10n_sa_edi module do not include all the reasons listed by ZATCA Current behavior before PR: Current VAT exemption reasons do not include reason VATEX-SA-OOS, i.e: "Not subject to VAT" De
Original PR description
ZATCA updated the VAT exemption reason codes to be provided for 0% taxes. This commit aims to expand the list of existing tax exemption reason codes in odoo to include the new reason: VATEX-SA-OOS Description of the issue/feature this PR addresses: Currently the VAT exemption reasons defined in the l10n_sa_edi module do not include all the reasons listed by ZATCA Current behavior before PR: Current VAT exemption reasons do not include reason VATEX-SA-OOS, i.e: "Not subject to VAT" Desired behavior after PR is merged: Add VAT exemption reason VATEX-SA-OOS --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166104
In this PR fixes following bugs: - Subtasks don't set by-default to the configured stage. users have to manually set it after saving. - Expected: stages by default set upon creation. - the task name goes empty after selecting a project, even if you rewrite it and switch projects. This only happens in the Quick Add feature in the kanban view after enabling timesheets in the project settings. task-3706741 Description of the issue/feature this PR addresses: Current behavior b
Original PR description
In this PR fixes following bugs: - Subtasks don't set by-default to the configured stage. users have to manually set it after saving. - Expected: stages by default set upon creation. - the task name goes empty after selecting a project, even if you rewrite it and switch projects. This only happens in the Quick Add feature in the kanban view after enabling timesheets in the project settings. task-3706741 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#153607
Steps to reproduce: - Install Sales and Loyalty modules - Create a discount & loyalty program with type of 'Buy X get Y' and a reward product that has a quantity on-hand - Archive the discount & loyalty program - Check the quantity of the product you put as reward Current behavior before PR: The reward product lose its quantity when archiving the corresponding discount & loyalty program. This is happening because when archiving the program we archive the reward product too. https://
Original PR description
Steps to reproduce: - Install Sales and Loyalty modules - Create a discount & loyalty program with type of 'Buy X get Y' and a reward product that has a quantity on-hand - Archive the discount & loyalty program - Check the quantity of the product you put as reward Current behavior before PR: The reward product lose its quantity when archiving the corresponding discount & loyalty program. This is happening because when archiving the program we archive the reward product too. https://github.com/odoo/odoo/blob/17.0/addons/loyalty/models/loyalty_reward.py#L239 Desired behavior after PR is merged: We are now archiving just the free product that got created when we were creating the discount & loyalty program not the main product. This is happening only when the reward type is 'Product' opw-3909184 Forward-Port-Of: odoo/odoo#165225
A fix's term was changing during the fw-port, but it's pot file was not re-exported to match. Therefore, re-export so that it translates properly. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167745
Original PR description
A fix's term was changing during the fw-port, but it's pot file was not re-exported to match. Therefore, re-export so that it translates properly. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167745
- Remove the zero-rated tax from non-taxable tags as it is incorrectly applied, and instead, add it to items tagged with GST. - task - 3957555 Forward-Port-Of: odoo/odoo#167754
Original PR description
- Remove the zero-rated tax from non-taxable tags as it is incorrectly applied, and instead, add it to items tagged with GST. - task - 3957555 Forward-Port-Of: odoo/odoo#167754