Wednesday, June 5, 2024
5 changes · 17.0
Resolved issues and error corrections
Fixes an issue where sharing a spreadsheet could fail if a From/To global filter was left blank. Users can now share spreadsheets with empty date range filters without encountering an error.
Original PR description
Steps to reproduce: - insert a pivot in a spreadsheet - create a From/To global filter - leave the filter values empty - click on the Share button => boom because of `cell.value.toString()` `cannot read toString of undefined` opw-3971278 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures spreadsheets correctly recognize when a pivot table is still being used from another sheet. Users will no longer see active pivots incorrectly marked as unused, reducing the risk of accidental cleanup or confusion in the Data menu.
Original PR description
Steps to reproduce in 17.0: There's no way to reproduce the issue in 17.0 because the faulty getter in only called on positions in the active sheet (pivot autofill, global filter auto-matching) Steps to reproduce in saas-17.1: - insert a pivot in a blank spreadsheet - delete all pivot formulas - insert a new sheet - in the new sheet: - in A1: type "1" - in A2: =ODOO.PIVOT(A1) - activate the first sheet again - Open the Data menu => the pivot 1 is marked as being unused, even though it's used in the second sheet Task: 3859472 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents users from changing detailed stock movement information after an inventory transfer has been completed and locked. It avoids an error that could occur when editing the “Pick From” field on validated delivery orders, helping keep completed inventory records stable and reliable.
Original PR description
### Steps to reproduce: - In the inventory, create a delivery order for 1 unit of any product - Validate the picking and click on detailed operations - Click on the field of the move named "Pick From", type and create new #### > Traceback error ### Cause of the issue: You should not be able to edit the moves of a done locked picking. However the `quant_id` field is not set to `read_only` in this case: https://github.com/odoo/odoo/blob/c016a5306dd90b90c88e083cc0f0d2ae9c0b649f/addons/stock/views/stock_move_views.xml#L263-L267 ### Fix: We add the same `read_only` condition as for the other fields visible on the move. opw-3935214 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A spreadsheet interface style rule was updated to match a recent naming change in the shared library. This keeps the affected button styling working consistently in Odoo after the library rename.
Original PR description
We recently renamed `o-sidePanelButton` to `o-button` in the library but did not change it inside Odoo. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A CSS class name was updated in the spreadsheet module to match a recent library change. The button styling class was renamed from `o-sidePanelButton` to `o-button` to maintain consistency with the updated library. This ensures the version history panel buttons display correctly.
Original PR description
We recently renamed `o-sidePanelButton` to `o-button` in the library but did not change it inside Odoo.