Odoo Changelog — 2024-06-06

Thursday, June 6, 2024

75 changes · saas-17.1

Bug Fixes(3)

Resolved issues and error corrections

[FIX] web: fix traceback on qweb profiling views

Coresaas-17.1web

A compatibility issue with the updated editor library caused QWeb profiling views to fail when displaying debug information. The fix changes where Odoo adds its extra information so the profiling view loads reliably again.

Original PR description

With the update of ace to 1.32.3, the lib is formatting her cells by getting them with hardcoded position in a array (here: 0, 1 and 2). On our side we are adding our o_info as first element, so the lib returns a traceback because her elements are shifted.

After this commit, our info node is added after the lib nodes to not shift the all bunch.

runbot issue 55085



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#profiling#debug#qweb#stability

[FIX] sale_project: get customer invoices on project's updates

PR #167721

Coresaas-17.1sale_project

Fixed an issue where opening Customer Invoices from a project's profitability updates could show a misleading “record not found” message. The project view now links to the correct customer invoice, helping users review project revenue without interruption.

Original PR description

Steps to reproduce:
-------------------
- create a project
- create an invoice with Analytic Distribution for the project
- go to the project's updates
- in profitability section, click on "Customer Invoices"

Issue:
------
A notification appears:
```
It seems the record with ID X cannot be found. It might have been deleted.
```

Cause:
------
The arguments in JSON format are:
```
"["other_invoice_revenues", [["id", "in", [X]]], X]"
```
with X not corresponding to the invoice id.

They are determined by the method `_get_action_for_profitability_section`. In which the ids are `invoices_move_lines.ids`
(in `_get_revenues_items_from_invoices`).

Solution:
---------
Find the `account.move` from the `account.move.line`.

Note:
Introduced with the commit abd40a461c289bfe092784977077ceb1c7ef12f3

opw-3924836

#project profitability#customer invoices#invoicing

[FIX] l10n_employment_hero: provide default value in next() method

PR #62432

Enterprisesaas-17.1l10n_employment_hero

Employment Hero payslip fetching now handles cases where a tax code is not configured in Odoo taxes. This prevents an unexpected error during payroll import and helps businesses continue processing payslips even when some tax mapping data is absent.

Original PR description

Steps to reproduce:

- Run fetching payslip without provide the tax code in Odoo taxes

Current behaviour:

- Exception raised

Expected behaviour:

- Should not raise any exception

Explanation:

next() method is missing default value so it raised exception when
filtering return empty array and iter() returns None.

task-3897198

#payroll#employment-hero#taxes#payslip-import

Other(72)

Miscellaneous changes

[FW][FIX] point_of_sale: cannot change type to combo with variants

PR #168336

Coresaas-17.1point_of_sale

Current behavior: If a product has some variants you shouldn't be able to change his type to combo Steps to reproduce: - Create a product, and add some variants to it - Try to change his type to "Combo" - You shouldn't be able to do it, as combo product shouldn't have variants opw-3961311 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168242

Original PR description

Current behavior:
If a product has some variants you shouldn't be able to change his type to combo

Steps to reproduce:
- Create a product, and add some variants to it
- Try to change his type to "Combo"
- You shouldn't be able to do it, as combo product shouldn't have variants

opw-3961311
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#168242

With the update of ace to 1.32.3, the lib is formatting her cells by getting them with hardcoded position in a array (here: 0, 1 and 2). On our side we are adding our o_info as first element, so the lib returns a traceback because her elements are shifted. After this commit, our info node is added after the lib nodes to not shift the all bunch. runbot issue 55085 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Steps to reproduce: ------------------- - create a project - create an invoice with Analytic Distribution for the project - go to the project's updates - in profitability section, click on "Customer Invoices" Issue: ------ A notification appears: ``` It seems the record with ID X cannot be found. It might have been deleted. ``` Cause: ------ The arguments in JSON format are: ``` "["other_invoice_revenues", [["id", "in", [X]]], X]" ``` with X not corresponding to the invoice id. They are determined by the method `_get_action_for_profitability_section`. In which the ids are `invoices_move_lines.ids` (in `_get_revenues_items_from_invoices`). Solution: --------- Find the `account.move` from the `account.move.line`. Note: Introduced with the commit abd40a461c289bfe092784977077ceb1c7ef12f3 opw-3924836

Steps to reproduce: - Run fetching payslip without provide the tax code in Odoo taxes Current behaviour: - Exception raised Expected behaviour: - Should not raise any exception Explanation: next() method is missing default value so it raised exception when filtering return empty array and iter() returns None. task-3897198

## Issue: When creating an activity linked to a record like a lead, if we edit this activity, for example from To-Do to Meeting, we lose the context from the Lead and have a bad context based on the activity instead, resulting in an improper link in the calendar. ## Steps to reproduce: 1. Install CRM (this will also install the rest of the required modules). 2. Create or use an existing Lead. 3. Create a new To-Do activity. 4. Click on edit for this activity and change it to Meeting. 5. Now click on Open Calendar and place the activity. 6. Click on the calendar event we have just created, and we will see a link to "Activity". Click on it. ## Solution: To ensure the proper link to the Lead/Opportunity, we need to pass the right context when editing the activity. This issue arose from changes made in `activity_service.js` and the addition of the model `mail.activity.schedule`, which separates the edit and create functions, unlike the behavior we had in 16.0. opw-3942711 Before ![before](https://github.com/odoo/odoo/assets/6569390/f9671678-5e87-4ccc-b02f-3b277d6325f5) After ![after](https://github.com/odoo/odoo/assets/6569390/06b7d501-af39-40fa-9054-dcf06a00f9dc) Forward-Port-Of: odoo/odoo#167996

Steps to reproduce [17.0]: - Go to website (in "Edit" mode) > Click on the "Contact Us" button - Save the page > The menu will be saved with the "oe_edited_link" class applied to it. Technical explanation (one of many scenarios causing the bug) [1]: After the website headers redesign in [2], two header navbars were added (for the desktop view and mobile). Which means that the "Contact Us" field is duplicated in the DOM. When clicking on the "Contact Us" desktop link, the `LinkPopoverWidget` will initialize a popover on it. The bootstrap code is automatically adding `data-original-title` and 'title' attributes to the targeted link (see: [3]), and as a consequence, the field observer will take in consideration the mutations and copy the DOM in the mobile version, leading to save the link in the same state when the BS popover was applied to it (with the `oe_edited_link` class). Remarks: - This behaviour was detected on 17.0, but we target 15.0 here to prevent similar issues linked to duplicated fields with links in the DOM. - The bootstrap attributes mutations (as explained in [1]) are just an example of many possible mutations (filtered by `observerUnactive()` in the main editor observer) that can cause the issue... Since we cannot set filters for all these mutations in the fields' observer, we ignore the `oe_edited_link` (and all editor's rendering classes) when copying the field content to solve the issue here. The field observer logic needs to be refactored to probably disable / enable the fields' synchronization when the editor's observer is disabled / enabled. [2]: https://github.com/odoo/odoo/pull/119650 [3]: https://github.com/odoo/odoo/blob/15.0/addons/web/static/lib/bootstrap/js/tooltip.js#L664 opw-3938383 Forward-Port-Of: odoo/odoo#167619 Forward-Port-Of: odoo/odoo#166736

The main purpose of this patch is to optimize how the location queries are generated in saas-17.2 in `stock.orderpoint`: https://github.com/odoo/odoo/blob/dd2da708bc4a42bba9670b874282a2206d8f5ffe/addons/stock/models/stock_orderpoint.py#L366-L374 The generated query is the same in 17.0. The advantage of the `any` operator is clarity and simplicity in this case. In saas-17.2 due to the presence of another branch using `location_final_id` the generated queries are much more efficient with ```py dest_loc_domain = [ '|', '&', ('location_final_id', '!=', False), ('location_final_id', 'any', paths_domain), '&', ('location_final_id', '=', False), ('location_dest_id', 'any', paths_domain), ] ``` vs (current code in saas-17.2) ```py dest_loc_domain = expression.OR([dest_loc_domain, [ '|', '&', ('location_final_id', '!=', False), ('location_final_id.parent_path', '=like', location.parent_path + '%'), '&', ('location_final_id', '=', False), ('location_dest_id.parent_path', '=like', location.parent_path + '%'), ]]) ``` https://github.com/odoo/odoo/blob/88e75bb11053e3a16455f7d0e882cf2afd4b79a6/addons/stock/models/product.py#L311-L317 The version using the `any` operator is much faster: in an extreme case with 6K replenish locations the any-based query runs in 1m50s while the other runs in more than 3h. In effect this is an example query generated by the ORM without the use of `any` (3 replenish locations) ```sql SELECT "stock_move"."product_id", "stock_move"."location_id", SUM("stock_move"."product_qty") FROM "stock_move" LEFT JOIN "stock_location" AS "stock_move__location_id" ON ("stock_move"."location_id" = "stock_move__location_id"."id") LEFT JOIN "stock_location" AS "stock_move__location_final_id" ON ("stock_m ove"."location_final_id" = "stock_move__location_final_id"."id") WHERE ( ( ( ( ( ( ( ( ( "stock_move"."product_id" IN (16, 17, 18, 20, 21, 23, 24, 12, 13, 14, 25, 30, 26, 37, 31, 5, 8, 29, 32, 6, 28) ) AND ( "stock_move"."state" IN ('waiting', 'confirmed', 'assigned', 'partially_available') ) ) AND ( "stock_move"."location_final_id" IS NULL OR ( "stock_move__location_final_id"."id" IS NULL OR ( NOT ( ( "stock_move__location_final_id"."parent_path" :: text LIKE '1/7/8/18/%' ) ) ) ) ) ) AND ( "stock_move"."location _final_id" IS NOT NULL OR ( ( "stock_move"."location_dest_id" NOT IN ( SELECT "stock_location"."id" FROM "stock_location" WHERE ("stock_location"."parent_path" :: text LIKE '1/7/8/18/%') AND (( "stock_location"."company _id" IN (1)) OR "stock_location"."company_id" IS NULL ) ) ) OR "stock_move"."location_dest_id" IS NULL ) ) ) AND ( "stock_move"."location_final_id" IS NULL OR ( "stock_move__location_final_id"."id" IS NULL OR (NOT (("stock_move__location_final_id"."parent_path" :: text LIKE '1/7/8/17/%'))) ) ) ) AND ( "stock_move"."location_final_id" IS NOT NULL OR ( ( "stock_move"."location_dest_id" NOT IN ( SELECT "stock_location"."id" FROM "stock_locati on" WHERE ("stock_location"."parent_path" :: text LIKE '1/7/8/17/%') AND (("stock_location"."company_id" IN (1)) OR "stock_location"."company_id" IS NULL ) ) ) OR "stock_move"."location_dest_id" IS NULL ) ) ) AND ( "stock_ move"."location_final_id" IS NULL OR ( "stock_move__location_final_id"."id" IS NULL OR ( NOT (( "stock_move__location_final_id"."parent_path" :: text LIKE '1/7/8/34/%') ) ) ) ) ) AND ( "stock_move"."location_final_id" IS NOT NULL OR ( ( "stock_move"."location_dest_id" NOT IN ( SELECT "stock_location"."id" FROM "stock_location" WHERE ("stock_location"."parent_path" :: text LIKE '1/7/8/34/%') AND ( ("stock_location"."company_id" IN (1)) OR " stock_location"."company_id" IS NULL ) ) ) OR "stock_move"."location_dest_id" IS NULL ) ) ) AND ( ( ("stock_move__location_id"."parent_path" :: text LIKE '1/7/8/18/%') OR ("stock_move__location_id"."parent_path" :: text LIKE '1/7/8/17/%') ) OR ("stock_move__location_id"."parent_path" :: text LIKE '1/7/8/34/%') ) ) AND ( "stock_move"."company_id" IN (1) ) GROUP BY "stock_move"."product_id", "stock_move"."location_id" ORDER BY "stock_move"."product_id" ASC, "stock_move"."location_id" ASC ``` vs the query using `any` variant: ```sql SELECT "stock_move"."product_id", "stock_move"."location_id", sum("stock_move"."product_qty") FROM "stock_move" LEFT JOIN "stock_location" AS "stock_move__location_id" ON ("stock_move"."location_id" = "stock_move__location_id"."id") LEFT JOIN "stock_location" AS "stock_move__location_final_id" ON ("stock_m ove"."location_final_id" = "stock_move__location_final_id"."id") WHERE ( ( ( ( ( "stock_move"."product_id" IN (16, 17, 18, 20, 21, 23, 24, 12, 13, 14, 25, 30, 26, 37, 31, 5, 8, 29, 32, 6, 28) ) AND ( "stock_move"."state" IN ('waiting', 'confirmed', 'assigned', 'partially_available') ) ) AND ( "stock_move"."location_final_id" IS NULL OR ( "stock_move__location_final_id"."id" IS NULL OR ( NOT ( ( ( ("stock_move__location_final_id"."parent_path" :: text LIKE '1/7/8/18/%') OR ("stock_move__location_final_id "."parent_path" :: text LIKE '1/7/8/17/%') ) OR ("stock_move__location_final_id"."parent_path" :: text LIKE '1/7/8/34/%') ) ) ) ) ) ) AND ( "stock_move"."location_final_id" IS NOT NULL OR ( ( "stock_move"."location_dest_id" NOT IN ( SELECT "stock_location"."id" FROM "stock_location" WHERE ( ( ("stock_location"."parent_path" :: text LIKE '1/7/8/18/%') OR ("stock_location"."parent_path" :: text LIKE '1/7/8/17/%') ) OR ("stock_location"."parent_pa th" :: text LIKE '1/7/8/34/%') ) AND ( ("stock_location"."company_id" IN (1)) OR "stock_location"."company_id" IS NULL ) ) ) OR "stock_move"."location_dest_id" IS NULL ) ) ) AND ( ( ("stock_move__location_id"."parent_path" :: text LIKE '1/7/8/18/%') OR ("stock_move__location_id"."parent_path" :: text LIKE '1/7/8/17/%') ) OR ("stock_move__location_id"."parent_path" :: text LIKE '1/7/8/34/%') ) ) AND ( "stock_move"."company_id" IN (1) ) GROUP BY "stock_move"."product_id", "stock_move"."location_id" ORDER BY "stock_move"."product_id" ASC, "stock_move"."location_id" ASC ``` --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167553

Steps to reproduce: - Install Time off module - Create a public holiday with Working Hours 'calendar_id' - Go to env user Time off dashboard Current behavior before PR: The public holidays that has 'calendar_id' assigned to it will not be shown in Legend when checking the dashboard of the env user. This is happening because we assign the self 'hr.employee' with the employee_id in context https://github.com/odoo/odoo/blob/c6142d9f1432cfabedcaa7264af9e5bc8e538c20/addons/hr_holidays/models/hr_employee.py#L313 and in '_get_contextual_employee' we just check if employee_id exists in ctx or not https://github.com/odoo/odoo/blob/17.0/addons/hr_holidays/models/hr_employee.py#L388:L392 but we don't check the value so if ctx is like {'employee_id': None} it will return None. Desired behavior after PR is merged: We are now checking if the 'employee_id' in ctx has a valid value as if it is not we need to return the employee object of the env user. Other solution that we can add in this line https://github.com/odoo/odoo/blob/c6142d9f1432cfabedcaa7264af9e5bc8e538c20/addons/hr_holidays/models/hr_employee.py#L313 to check if the self._get_contetxtual_employee is None we assign self to self.env.user.employee_id opw-3863947 Forward-Port-Of: odoo/odoo#166548

Issue: =============== When a manufacturing order (MO) is created, the default components are automatically reserved and are made visible in the barcode module. However, even if these components are later unreserved, they will continue to be displayed in the barcode module. Resolution: ================ To address this issue, we've taken the step to avoid forcefully re-reserving the components when a component is unreserved. This resolves the persistent display of components in the barcode. Steps to Reproduce: ====================== 1. Create a manufacturing order (MO) and confirm it. 2. Navigate to the barcode module within the manufacturing order. 3. By default, the components are reserved, so they are visible in the barcode module. 4. Go to the form view of the MO in MRP and unreserve the components. 5. Check the barcode module again, and notice that the unreserved components are still visible. Expected Result: ================== After implementing the solution, When we opens the MO in the barcode module only reserved components should be visible. When a component is unreserved, it should no longer be visible in the barcode module for manufacturing order. task-3869731 Forward-Port-Of: odoo/enterprise#61827

Bug Fixes(3)

[FIX] web: fix traceback on qweb profiling views

[FIX] sale_project: get customer invoices on project's updates

[FIX] l10n_employment_hero: provide default value in next() method

Other(72)

[FW][FIX] point_of_sale: cannot change type to combo with variants

Bug Fixes(3)

[FIX] web: fix traceback on qweb profiling views

[FIX] sale_project: get customer invoices on project's updates

[FIX] l10n_employment_hero: provide default value in next() method

Other(72)

[FW][FIX] point_of_sale: cannot change type to combo with variants

[FW][FIX] pos_sale: correctly compute untaxed amount invoiced

[FW][FIX] pos_adyen: fix payment status when cancelling payment

[FW][FIX] web: add fallback for webclient translations

[FW][FIX] point_of_sale: allow coin/bills value with more decimal places

[FW][FIX] calendar: allow attendee removing itself

[FW][FIX] account: re-export pot file

[FW][FIX] spreadsheet: fix css rule

[FW][FIX] loyalty : Prevent archiving product when archive discount program

[FW][FIX] mail: editing activity from record will pass the proper context

[FW][FIX] web_editor: fix toggle button after editing a we-list input

[FW][FIX] point_of_sale: prevent error when changing product tracking

[FW][FIX] point_of_sale: prevent opening Product popup without options

[FW][CLA] Sign CLA for gussy72

[FW][FIX] pos_self_order: handle attribute images for JSON serialization

[FW][CLA] ngquang: sign Odoo CLA for ngquang

[FW][FIX] l10n_in_edi: withdraw zero rated tax from non taxable tags

[FW][FIX] hr(_contract)(_attendance): Make overtime computation contract-based

[FW][FIX] project: fixes subtask stage and empty display name

[FW][FIX] web: position properly graph legend tooltips

[FW][FIX] hr_holidays: search by description

[FW][IMP] hw_posbox_homepage: Add background image

[FW][FIX] analytic: analytic widget glitching line height

[FW][FIX] survey: fix labels in session chart

[FW][FIX] base_import: fix tooltip header color

[FW][FIX] l10n_it_edi: compute l10n_it_tax_representative_partner_id

[FW][FIX] hr_fleet: sync partner with the employee

[FW][I18N] l10n_lu: translate tax group names

[FW][FIX] web: take account decimal point in the input

[FW][PERF] sale: download smaller avatars in portal view

[FW][FIX] web_editor: display list in quick edit html_field

[FW][FIX] mail: chatter in chat window should scroll to recent

[FW][FIX] im_livechat: AttributeError: discuss.channel.livechat_visitor_id

[FW][FIX] l10n_it: add missing accounts to tax repartition lines

[FW][FIX] web_editor: prevent adding rendering classes on the field observer

[FW][FIX] hr_expense: use taxes from parent company

[FW][FIX] stock: simplify location domains

[FW][FIX] web: execute last pending action when multiple action requested

[FW][FIX] pos_online_payment: invoice order

[FW][FIX] hr_homeworking: 1 work location when remote

[FW][FIX] bus: fix websocket rate limiting tests with noble

[FW][CLA] signature for lingjiawen

[FW][FIX] website_sale{_product_configurator}: split sale tour

[FW][FIX] hr_holidays : Set env user as self if not employee in context

[FW][FIX] web_editor: fix component destroy error

[FW][IMP] pos: allow changing quantity of combo product

[FW][FIX] l10n_cl: fix to allow credit notes code 61 over purchase vendor bills code 46

[FW][FIX] planning: set proper space in planning calendar popover

[FW][FIX] sale_account_accountant: bank match payments of sale order

[FW][FIX] l10n_be_reports: _get_bce_number handle legacy values

[FW][FIX] account_batch_payment: compute correct batch amount

[FW][FIX] spreadsheet: fix css rule

[FW][FIX] l10n_be_hr_payroll: fix paid time off wizard traceback

[FW][FIX] sale_subscription: fix upsell cancellation

[FW][FIX] l10n_ar_edi: reset to draft button

[FW][FIX] l10n_be_hr_contract_salary: meal voucher amount not copied

[FW][FIX] l10n_ro_reports: Explicitly remove groupby from records

[FW][FIX] hr_appraisal_skills: resolved issue with updated skills evaluti…

[FW][FIX] mail: no crash on adding a new old activity

[FW][FIX] hr(_contract)(_attendance): Make overtime computation contract-based

[FW][FIX] helpdesk_timesheet: don't force UTC time on timesheets

[FW][FIX] sale_ebay: fix traceback on faulty credentials

[FW] 17.0 l10n mx edi fix test dynamic dates clbr

[FW][FIX] l10n_mx_edi: GI refund CFDI description

[FW][FIX] webiste_appointment: appointment type publishability

[FW][FIX] l10n_be_hr_payroll: fix missing column in eco voucher file

[FW][FIX]sale_amazon: picking sync failed message fix

[FW][FIX] l10n_cl_reports: Ensure "current year earnings" account balance ok in the report

[FW][FIX] l10n_dk_reports: update translation