Thursday, June 6, 2024
4 changes · saas-17.2
Resolved issues and error corrections
The calendar view now keeps the “more events” popover behind Odoo edit windows. This prevents confusing overlap when users open an event from a crowded calendar day and then choose to edit it.
Original PR description
This commit fixes a staking context (z-index) problem. Our modal has a 1055 z-index (`$zindex-modal`) and FullCalendar "More popover" has 9999. To avoid some overlapping we set the FullCalendar "More popover" to a lower value. Steps to reproduce: * Open Project * Select Field Service * Go to Calendar View * Click on "+X more" (where X is a number) * Click on an event in the FullCalendar popover * Click on Edit in our popover => Bug the FullCalendar popover overlap our modal --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A flaky automated test for the mail sidebar was corrected so it waits for the saved setting before checking results. This improves confidence in test results and reduces false failures in the release process.
Original PR description
Before this commit, the `open should update the value on the server` test was sometimes failing. This test opens a folded discuss sidebar category and asserts that its fold state was saved on the server. However, nothing guarantees that the RPC was triggered before asserting the server state, which is a source of non-determinism. This commit fixes the issue by ensuring the RPC is completed before checking the saved value. fixes runbot-66054.
The Knowledge portal test setup was adjusted so a portal-specific routing behavior is only tested within the relevant portal flow. This prevents unrelated tests from loading that behavior, reducing false failures and keeping quality checks more reliable.
Original PR description
In commit [1], a HOOT test was introduced for the custom router of the Knowledge portal webclient. However the `router` was added to `assets_unit_tests_setup` which is used to load assets that are common in a module for every test. Which is wrong since tests that do not concern the portal should not load the router patch. This commit replaces that test by tour steps in the knowledge_main_flow_tour_portal, which also validate that the router changes state correctly alongside with the URL. [1]: https://github.com/odoo/enterprise/commit/2348fa2e5946d4e711bbd14810f5825dd7e4c6cb task-3743416
This fix keeps automated web tours from stopping unexpectedly when an optional page element is not found. It restores more forgiving behavior, helping internal testing and guided flows run more reliably.
Original PR description
This commit [1] introduces `queryOne` to find element nodes in DOM. But, if `queryOne` fails to find the element it throws error which breaks the tour which wasn't the case before this change was introduced. There might be some scenarios where it might not affect if the node is found or not, but because of `queryOne` the tour will fail. So, to fix this we use `queryFirst` which doesn't throw error if it fails to find the node. 1: c0f3bdb928db5a119817710e260edfda9a2f40ac --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr