Original PR description

Problem: When a quotation is printed for a client in a different language that uses different decimal separators, the discounted price for optional products are not being displayed with the same decimal separators used throughout the quotation.

Purpose: The formats of the price should be consistent.

Steps to Reproduce on Runbot:
1. Install Sales
2. Enable Discounts in Setting > Sales
3. Create a quotation with a German customer and discounted optional products
4. Print the quotation
5. Observe the discounted price has inconsistent formatting (ex. shows 140.00 instead of 140,00 since German uses , as decimal separators)

opw-3853464

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#167688
Forward-Port-Of: odoo/odoo#165888

Original PR description

Current behavior:
Sometimes payment made with adyen where blocked in the "Waiting for
card" status when cancelling a payment. As the issue is not reproducible
consistantly I made a diagram to show what I think is happening.
It was probably happening because the last_adyen_status was emptied at
a wrong moment. To fix this we make sure that a real new payment request
is made before emptying it.
Before this fix when doing a cancel request, it would empty the
last_adyen_status

![Adyen Status](https://github.com/odoo/odoo/assets/32939472/fa2b03c5-7f45-4be9-86f0-21ee7fb57170)

opw-3427860
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#168056
Forward-Port-Of: odoo/odoo#165792

Original PR description

Issue:
======
list doesn't appear in quick edit of html_field

Steps to reproduce the issue:
=============================
- Go to any sale order
- Send by email
- Add a list inside the email
- It doesn't appear

Origin of the issue:
====================
Most of the templates have hardcoded `padding = 0px`, so when we convert a `p` element to a `ul` or `ol` element it will have have the same styling and we loose the default padding for the list elements.

Solution:
=========
We set the padding as null to remove any forced padding used.

opw-3900433

Forward-Port-Of: odoo/odoo#167916
Forward-Port-Of: odoo/odoo#165773

Original PR description

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:




---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#164643

Original PR description

Prior to this commit, if a reward product domain contained a field that was not loaded into the Point of Sale (PoS), the promotion would not function correctly. This commit resolves this issue by adding the missing fields, ensuring that the promotion operates as expected.

opw-3896038

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#164892

Original PR description

opw-3940549
opw-3943985
opw-3943909
opw-3937897
opw-3932111

Forward-Port-Of: odoo/odoo#166980

Original PR description

Before this commit, the attendees were not allowed to remove anyone from the event (including themselves) when editing the event in the form view. This was a problem that came after updating the views to OWL and also reverting the PR [#133504](https://github.com/odoo/odoo/pull/133504).

After this commit, the event attendees can perform attendee removals normally because we check inside the compute if it the current attendee was indeed an attendee right before the change is completed.

task-3948322

Forward-Port-Of: odoo/odoo#166696

Original PR description

Steps to reproduce:

- In Website edit mode.
- Drag and drop a "Form" snippet onto the page.
- Add a multi checkboxes field to the form.
- Edit the text of a checkboxes input.
- click on the toggle button next to this input.
- Bug: the button remains disabled. (next click is ok)

This bug occurs because when we search for the checkbox that should be
selected in the "values" variable (in the "_notifyCurrentState()"
function of the "we-list" widget), we search for it based on its ID in
the DOM. However, on the first click on the toggle, the ID has not yet
been defined in the DOM according to the "values" variable.

task-3901472

Forward-Port-Of: odoo/odoo#167842
Forward-Port-Of: odoo/odoo#165264

Original PR description

opw-3954458

Forward-Port-Of: odoo/odoo#167078

Original PR description

To facilitate the usage of the router in custom webclients like the Knowledge
portal, `url-state` conversion functions are attached to the router object to
allow patching them, in order to handle a custom router state.

task-3743416

Forward-Port-Of: odoo/odoo#166994

Original PR description

Problem:
There is taxes added to the gift card discount

Steps to reproduce:
- Install "Point of sale" app
- Go to Settings and activate gift cards
- Create a gift card (for ex 100€)
- Copy the code
- Open PoS > Add a product (more than the price of the gift card to understand better) > add the gift card
- The card value is not 100€ but more because it includes taxes

Solution:
Set an empty Array as tax will allow this.tax_ids to be evaluated as true in a if statement and will define an empty Array for the tax of the gift card

https://github.com/odoo/odoo/blob/7df8fc435c6ea199292f47954202d4f3c93b2629/addons/point_of_sale/static/src/app/store/models.js#L745-L749

opw-3862427

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#163928

Original PR description

**Description of the issue/feature this PR addresses:**
fine tuning of https://github.com/odoo/odoo/commit/f8182fb625eb3e20c85388d4c342553af4fe7ab9 to prevent an olverload of postgres.

@thle-odoo @sofiagvaladze I have update the commit. I use 'inselect' to reduce the query size.



---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#167439

Original PR description

Before this commit, loading an attribute value with an image would cause a TypeError due to the image data being of bytes type, which is not JSON serializable. This commit prevents this error by removing the image data before serialization.

opw-3957587

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#167765

Original PR description

starts. If the user language cannot be determined, it uses the one set in the html `lang` attribute.

If this language is not installed, the webclient translation route does not return lang parameters such as date fortmat. However, the JS code expects those parameters to be available and missing parameters lead to multiple errors (e.g. when calling `parseDatetime` which requires the date format).

This PR ignore the lang passed to this route if it is not installed in order for it to fallback to the context lang.

Steps to reproduce the issue:
- Create an html page and set the lang attribute value to the IETF Xhosa tag (xh-ZA)
- A request to `/web/webclient/translation` is made and an error is displayed in the console.

opw-3953457

Forward-Port-Of: odoo/odoo#167491

Original PR description

Before, if a bank transaction contain the sale order reference, the reconciliation model will try to reconcile with the invoices created from this sale order but ignore the payment records for those. This leads to situations where it looks like there were two payments on the invoices (one payment record and one bank transaction) while there is just one partial payment.

Steps to reproduce:
0/ Have default reconciliation models
1/ Create SO for 100$ and confirm invoice
2/ Partially pay invoice for 70$
3/ Create bank transaction with SO ref and same partner for 70$
4/ Match transaction => will match the 30$ residual of the invoice instead of 70$ payment

Now, the system will try to reconcile with the payments of those invoices first before considering invoice reconciliation.

opw-3904177

Forward-Port-Of: odoo/enterprise#62972

Original PR description

In the Payroll app with a Belgian company, we can do Reporting > Paid Time Off Allocation.
This opens a wizard and if we filled the department then the time off type, the app would crash because of a terrible sql query.

Also, the query was doing unnecessary subqueries that have been removed.

Task: 3878904

Forward-Port-Of: odoo/enterprise#62293

Original PR description

The aim of this commit is to make the code more robust and defensive by handling a bad value for the `vat` field.

Context:
Partners having a `partner.vat=False` were making the compact function crash.

Before the commit:
The flow crash even if the value shouldn't be processed.

After the commit:
The flow is smooth.

task-id: None

Forward-Port-Of: odoo/enterprise#63865

Original PR description

...d on foreign_currency_code received from odoofin

Send `include_foreign_currency` to odoofin to avoid throwing errors when odoofin returns `foreign_currency_code` and `amount_currency` for customers that don't have the fix.

Convert `foreign_currency_code` to corresponding `foreign_currency_id` in order to be displayed correctly alongside the amount in `account.bank.statement.line`

To avoid a validation error(Currency is not activated) pop up for every foreign currency resides in transactions received from Odoofin while fetching transactions, Automatically activating foreign currencies.

Remove foreign_currency_id and amount_currency from retrieved transactions in `Fetch Missing Transactions` flow in order to not break the flow in stable.(These fields will be added to `account.bank.statement.line.transient` in master)

Odoofin PR: https://github.com/odoo/odoofin/pull/265

task id: 2870614

Forward-Port-Of: odoo/enterprise#60337

Original PR description

Intended:
Generate pdfs is meant to run in every hour.
It was intention as well at creation and it shows from how nextcall is defined:

<field name="nextcall" eval="(DateTime.now() + timedelta(hours=1))"/>

Current behavior:
But regardless how nextcall is defined, now the cron runs in every month.

This is because interval_type is not explicitly defined on the cron and thus it takes default value - that is 'months'.

To correct the cron behavior, we explicitly define
 interval_number and interval_type

task-3960037

Forward-Port-Of: odoo/enterprise#63709
Forward-Port-Of: odoo/enterprise#63565

Original PR description

Include the version of Odoo in the UserAgent header of SIP requests so that the information is available to the provider.

Task-3940569

Forward-Port-Of: odoo/enterprise#63281
Forward-Port-Of: odoo/enterprise#62879

Original PR description

This reverts commit 819ed2a64d0f11f33190af0c804955e380242968.

opw-3955626 but there are many others

Forward-Port-Of: odoo/enterprise#63484

Original PR description

Before this commit, when adding an outdated activity from kanban activity widget, it crashed with the following errors:

`TypeError: cannot read property of undefined (reading `mail_template_ids`)`
`TypeError: Cannot read properties of undefined (reading 'toLocaleString')`

Steps to reproduce:
- on crm lead schedule call activity and make sure that activity is at least 1 month old
- book activity and save it
- try to access/edit activity

This happens because when the `get_today_call_activities` function is called. Function fetches fields during the records formatting, but it doesn't fetch `date_deadline` and `mail_template_ids`, therefore those fields remain undefined, hence the errors rise.

task-3945492

Forward-Port-Of: odoo/enterprise#63792

Original PR description

Handle barcode lookup api key and get from the tools to secure and avoid server action or any other unnecessary calls for getting API key.

Forward-Port-Of: odoo/enterprise#62245

Original PR description

In the salary configurator, we use a meal voucher amount by default: 7 .45€/worked day.
It should really copy the meal voucher amount from the contract instead.

Task:

Forward-Port-Of: odoo/enterprise#63851
Forward-Port-Of: odoo/enterprise#61655

Original PR description

Steps to reproduce:
1. Install the planning module and open it.
2. Open events in calendar view.
3. Click on any event.
4. In the calendar popover, observe the spacing around the percentage (%).

Issue:
There is inconsistency in spacing around the percentage (%).

Solution:
Add a space before the percentage and remove the space after it in the common calendar popover.

task-3908815

Forward-Port-Of: odoo/enterprise#62083