Monday, June 10, 2024
17 changes · master
Enhancements to existing features
Managers can now delete employee appraisals that are still waiting for confirmation, even if they do not have broader appraisal administration rights. This helps teams clean up draft or incorrect appraisal records more easily while keeping the change limited to unconfirmed appraisals.
Original PR description
This commit enables a manager, even without specific appraisal rights, to delete appraisals when they are in the "to confirm" state. Task-3777667
Resolved issues and error corrections
The spreadsheet pivot menu now shows the global filter option only for pivot header cells, preventing users from seeing an action that does not apply to regular pivot formulas. This reduces confusion and keeps spreadsheet filtering behavior aligned with the intended pivot workflow.
Miscellaneous changes
Update deferred entries settings text to be clearer and consistent with surrounding settings text updated in: https://github.com/odoo/odoo/pull/164539 task-3908720 Forward-Port-Of: odoo/enterprise#62039
Original PR description
Update deferred entries settings text to be clearer and consistent with surrounding settings text updated in: https://github.com/odoo/odoo/pull/164539 task-3908720 Forward-Port-Of: odoo/enterprise#62039
The test "Future Open Ended record not displayed" could fail if for some reason the domain used to fetchData is computed 1 second or more after the mocked datetime has been applied. In that case the domain constructed in AttendanceGanttModel contains the open ended record and the second assertion fails. Here we choose a safer mocked datetime. see build https://runbot.odoo.com/runbot/build/63759517 Forward-Port-Of: odoo/enterprise#64207
Original PR description
The test "Future Open Ended record not displayed" could fail if for some reason the domain used to fetchData is computed 1 second or more after the mocked datetime has been applied. In that case the domain constructed in AttendanceGanttModel contains the open ended record and the second assertion fails. Here we choose a safer mocked datetime. see build https://runbot.odoo.com/runbot/build/63759517 Forward-Port-Of: odoo/enterprise#64207
Since [1] the button never rendered due to the getter `showAddLeaveButton` not properly bound to the component. [1]: https://github.com/odoo/enterprise/commit/d18639785e622d97102227103d62ddb3a2716be6 Forward-Port-Of: odoo/enterprise#64205
Original PR description
Since [1] the button never rendered due to the getter `showAddLeaveButton` not properly bound to the component. [1]: https://github.com/odoo/enterprise/commit/d18639785e622d97102227103d62ddb3a2716be6 Forward-Port-Of: odoo/enterprise#64205
*: l10n_mx_edi_pos, pos_preparation_display, pos_settle_due Before this commit: ---  After this commit: --- Revised graphical interface for payment screen and update test tours to match  task-3888884 Forward-Port-Of: odoo/enterprise#62250
Original PR description
*: l10n_mx_edi_pos, pos_preparation_display, pos_settle_due Before this commit: ---  After this commit: --- Revised graphical interface for payment screen and update test tours to match  task-3888884 Forward-Port-Of: odoo/enterprise#62250
Versions -------- - 15.0e+ Steps ----- 1. If current UTC time is before 11:00, set user tz to Pacific/Niue; 2. if current UTC time is after 11:00, set user tz to Pacific/Kiritimati; 3. go to Helpdesk; 4. enable timesheets for a helpdesk team; 5. open a ticket of that helpdesk team; 6. start timer; 7. stop timer; 8. create timesheet. Issue ----- The date of the timesheet is set to the UTC date instead of the user date, which is one day off. Cause ----- The wizard creating
Original PR description
Versions -------- - 15.0e+ Steps ----- 1. If current UTC time is before 11:00, set user tz to Pacific/Niue; 2. if current UTC time is after 11:00, set user tz to Pacific/Kiritimati; 3. go to Helpdesk; 4. enable timesheets for a helpdesk team; 5. open a ticket of that helpdesk team; 6. start timer; 7. stop timer; 8. create timesheet. Issue ----- The date of the timesheet is set to the UTC date instead of the user date, which is one day off. Cause ----- The wizard creating timesheets adds a `Datetime.now()` value to `date`, which defaults to UTC time. Solution -------- Remove this line, allowing timesheets to be created with the default value, which does get adjusted for user timezone. opw-3834908 Forward-Port-Of: odoo/enterprise#63806 Forward-Port-Of: odoo/enterprise#63073
Steps to reproduce: - Open planning - Create a recurrence task for a user - Click on the slot and select the recurrence option and click on delete Issue: - You can see that no matter what the option is selected in form it is not reflected in delete dialog confirmation. So in this commit the recurrence option is synced in deleted conformation dialog task:3850839 Forward-Port-Of: odoo/enterprise#60601
Original PR description
Steps to reproduce: - Open planning - Create a recurrence task for a user - Click on the slot and select the recurrence option and click on delete Issue: - You can see that no matter what the option is selected in form it is not reflected in delete dialog confirmation. So in this commit the recurrence option is synced in deleted conformation dialog task:3850839 Forward-Port-Of: odoo/enterprise#60601
The issue: Inside the function _l10n_co_edi_generate_xml, the variable 'tax' at line 272 will be overridden by the 'account.tax' record which leads to a traceback in the second iteration, saying 'account.tax' object doesn't have a 'get' attribute Expected behavior: To not throw a traceback and generate the xml opw-3899575 Forward-Port-Of: odoo/enterprise#63277 Forward-Port-Of: odoo/enterprise#62290
Original PR description
The issue: Inside the function _l10n_co_edi_generate_xml, the variable 'tax' at line 272 will be overridden by the 'account.tax' record which leads to a traceback in the second iteration, saying 'account.tax' object doesn't have a 'get' attribute Expected behavior: To not throw a traceback and generate the xml opw-3899575 Forward-Port-Of: odoo/enterprise#63277 Forward-Port-Of: odoo/enterprise#62290
In previous commit https://github.com/odoo/enterprise/commit/099531438fe9ef7b008a2b281780ed3ee2175692 we added a new tag check. As we tought it was empty for non-nordic countries, we thought it was fine to have it in first place but happens it is sometimes filled in other countries but not with the payment reference, as in Switzerland. We now check to fill payment_ref, in order: 1. NtryDtls>RmtInf>Ustrd 2. NtryDtls>RmtInf>Strd>CdtrRefInf>Ref 3. Ntry>AddtlNtryInf (was buggy before https://g
Original PR description
In previous commit https://github.com/odoo/enterprise/commit/099531438fe9ef7b008a2b281780ed3ee2175692 we added a new tag check. As we tought it was empty for non-nordic countries, we thought it was fine to have it in first place but happens it is sometimes filled in other countries but not with the payment reference, as in Switzerland. We now check to fill payment_ref, in order: 1. NtryDtls>RmtInf>Ustrd 2. NtryDtls>RmtInf>Strd>CdtrRefInf>Ref 3. Ntry>AddtlNtryInf (was buggy before https://github.com/odoo/enterprise/pull/62703) 4. NtryDtls>RmtInf>Strd>AddtlRmtInf opw-3923665 opw-3971080 opw-3932651 opw-3918491 Forward-Port-Of: odoo/enterprise#64004
When the send receipt button is displayed in the receipt screen, it overflows the screen. This commit fixes the issue. Forward-Port-Of: odoo/enterprise#63988
Original PR description
When the send receipt button is displayed in the receipt screen, it overflows the screen. This commit fixes the issue. Forward-Port-Of: odoo/enterprise#63988
Button draft was not display on received vendor bills. opw-3903120 Forward-Port-Of: odoo/enterprise#64020
Original PR description
Button draft was not display on received vendor bills. opw-3903120 Forward-Port-Of: odoo/enterprise#64020
task-3597205 Forward-Port-Of: odoo/enterprise#63869 Forward-Port-Of: odoo/enterprise#59539
Original PR description
task-3597205 Forward-Port-Of: odoo/enterprise#63869 Forward-Port-Of: odoo/enterprise#59539
…on report steps to reproduce: - add new appraisal of employee and confirm it. - add new skills and update existing ones. - check the skill evaluation report issue: A newly created skill doesn't appear in the report since the previous skill level may contain null while creating new records. fix: Apply a left join on the report so that it can provide accurate results. also, add a subquery based on the last completed appraisal, since the last `appraisal_id` is updated on the pending
Original PR description
…on report steps to reproduce: - add new appraisal of employee and confirm it. - add new skills and update existing ones. - check the skill evaluation report issue: A newly created skill doesn't appear in the report since the previous skill level may contain null while creating new records. fix: Apply a left join on the report so that it can provide accurate results. also, add a subquery based on the last completed appraisal, since the last `appraisal_id` is updated on the pending state too. task-3810220 Forward-Port-Of: odoo/enterprise#64035 Forward-Port-Of: odoo/enterprise#60088
Purpose: -------- The frontend room view uses the "background-image" property to add a background image if one has been set on the room. This causes several 404 errors in qunit tests because the test room does not exist, resulting in a "room not found" exception when the browser tries to get the background image. This commit patches the view in the tests to remove the url part of the background-image property, so that the background image is not fetched anymore. In order to make th
Original PR description
Purpose: -------- The frontend room view uses the "background-image" property to add a background image if one has been set on the room. This causes several 404 errors in qunit tests because the test room does not exist, resulting in a "room not found" exception when the browser tries to get the background image. This commit patches the view in the tests to remove the url part of the background-image property, so that the background image is not fetched anymore. In order to make this patch possible, the background-image property value has been moved inside a getter. Task-3943099 Forward-Port-Of: odoo/enterprise#62990
The aim of this commit is to improve the perfomance of the datev features constrains checks. Context: Performance issue spotted on odoo.com prod. DB. Before the commit: Creating a partner takes up to 10 min. After the commit: Creating a new partner reduces the creation time to 2 min. task-id: None Forward-Port-Of: odoo/enterprise#64158 Forward-Port-Of: odoo/enterprise#63971
Original PR description
The aim of this commit is to improve the perfomance of the datev features constrains checks. Context: Performance issue spotted on odoo.com prod. DB. Before the commit: Creating a partner takes up to 10 min. After the commit: Creating a new partner reduces the creation time to 2 min. task-id: None Forward-Port-Of: odoo/enterprise#64158 Forward-Port-Of: odoo/enterprise#63971
Steps to reproduce: - Run fetching payslip without provide the tax code in Odoo taxes Current behaviour: - Exception raised Expected behaviour: - Should not raise any exception Explanation: next() method is missing default value so it raised exception when filtering return empty array and iter() returns None. task-3897198 Forward-Port-Of: odoo/enterprise#64072 Forward-Port-Of: odoo/enterprise#62432
Original PR description
Steps to reproduce: - Run fetching payslip without provide the tax code in Odoo taxes Current behaviour: - Exception raised Expected behaviour: - Should not raise any exception Explanation: next() method is missing default value so it raised exception when filtering return empty array and iter() returns None. task-3897198 Forward-Port-Of: odoo/enterprise#64072 Forward-Port-Of: odoo/enterprise#62432