Monday, June 10, 2024
17 changes · saas-17.1
Resolved issues and error corrections
This update fixes a previous issue where the HR Attendance Kiosk always displayed in English. Now, the kiosk automatically uses the company's preferred language, ensuring a more localized and user-friendly experience for employees accessing attendance records.
Original PR description
Currently, no language was passed to the HR Attendance Kiosk, so it would default to English. This change passes the language of the company partner to the kiosk mode in order to allow companies having the portal in their own language. task-3976591 Forward-Port-Of: odoo/odoo#168343
Miscellaneous changes
PURPOSE Fix various issues related to automatic source creation and naming involving auto increment to avoid uniqueness constraint issues. Notably * avoid always incrementing (e.g. same name should not increment); * do not fail to start counters at 0 when possible; * improve write / batch bad support; * correctly check uniqueness in utm.source.mixin currently done on wrong model; * fill holes in counter sequence instead of continuing above higher found counter;
Original PR description
PURPOSE
Fix various issues related to automatic source creation and naming involving
auto increment to avoid uniqueness constraint issues.
Notably
* avoid always incrementing (e.g. same name should not increment);
* do not fail to start counters at 0 when possible;
* improve write / batch bad support;
* correctly check uniqueness in utm.source.mixin currently done on wrong
model;
* fill holes in counter sequence instead of continuing above higher found
counter;
See sub commits for more details.
LINKS
Task-3874538 (odoo/odoo#162229) Do not create endless copies
Task-3837272 (odoo/odoo#159699) Incorrect UTM source enumeration
Forward-Port-Of: odoo/odoo#168439
Forward-Port-Of: odoo/odoo#164287**Steps:** - Go to project > task > archive a task - Open portal view of project > go to the same project - Filter the search view by choosing 'Archived' - Click on the archived task **Issue:** - Session error when trying to open the archive task **Cause:** - By clicking on the archived task, page is refreshed and it tries to open the kanban view again and hence gives session expire error **Fix:** - Hiding the archived filter as suggested by the specs of the task because it seems
Original PR description
**Steps:** - Go to project > task > archive a task - Open portal view of project > go to the same project - Filter the search view by choosing 'Archived' - Click on the archived task **Issue:** - Session error when trying to open the archive task **Cause:** - By clicking on the archived task, page is refreshed and it tries to open the kanban view again and hence gives session expire error **Fix:** - Hiding the archived filter as suggested by the specs of the task because it seems to be irrelevant in project sharing - Passing the correct context so that it will take all the tasks in counting and not just the active tasks. **Affected version**: saas-16.3 - master **Task**-3690536 Forward-Port-Of: odoo/odoo#150866
Current behavior before PR: - Cannot select projects with `company_id` = `False` when creating sale orders.  Desired behavior after PR is merged: - Allow to select projects with `company_id` = `False`.  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port
Original PR description
Current behavior before PR: - Cannot select projects with `company_id` = `False` when creating sale orders.  Desired behavior after PR is merged: - Allow to select projects with `company_id` = `False`.  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167144
The issue: When creating an invoice from multiple sale orders, each invoice line is going to be linked to the appropriate sale order line from each sale order, which will cause a singleton traceback when trying to access the is_downpayment field Expected behavior: to confirm the invoice Current Behavior: Singleton traceback opw-3878327 Forward-Port-Of: odoo/odoo#163766
Original PR description
The issue: When creating an invoice from multiple sale orders, each invoice line is going to be linked to the appropriate sale order line from each sale order, which will cause a singleton traceback when trying to access the is_downpayment field Expected behavior: to confirm the invoice Current Behavior: Singleton traceback opw-3878327 Forward-Port-Of: odoo/odoo#163766
**Steps to reproduce:** (!!! Spanish EDI credentials required !!!) - Install l10n_es_edi_sii - Switch to a Spanish company (e.g. ES Company) - Configure Spanish Localization - Create an invoice - Process it by the ES E-invoicing service - Once processed, an electronic document containing the response of the E-invoicing service is created (i.e. jsondump.json) **Issue:** When sending the invoice via "SEND & PRINT" button, the "jsondump.json" file is added in the attachments. opw-37209
Original PR description
**Steps to reproduce:** (!!! Spanish EDI credentials required !!!) - Install l10n_es_edi_sii - Switch to a Spanish company (e.g. ES Company) - Configure Spanish Localization - Create an invoice - Process it by the ES E-invoicing service - Once processed, an electronic document containing the response of the E-invoicing service is created (i.e. jsondump.json) **Issue:** When sending the invoice via "SEND & PRINT" button, the "jsondump.json" file is added in the attachments. opw-3720984 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167950
go to Point of sales -> choose menu a pos -> view order -> choose order has state 'New' -> chooose '(update)' -> server error  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167302
Original PR description
go to Point of sales -> choose menu a pos -> view order -> choose order has state 'New' -> chooose '(update)' -> server error  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167302
Current behavior: --- Expiry dates are computed from today's date and expiration time, it should be based on scheduled date. Steps to reproduce: --- 1. Go to Inventory 2. Go to Configuration > Operations Types 3. Click on Receipts 4. Check "Show Detailed Operations" box 5. Check "Pre-fill Detailed Operations" box 6. Go back to Inventory > Products 7. Create a new product 8. Go to the Inventory tab 9. At Tracking, put "By lots" 10. Check "Expiration date" Box 11. At "Expiration D
Original PR description
Current behavior: --- Expiry dates are computed from today's date and expiration time, it should be based on scheduled date. Steps to reproduce: --- 1. Go to Inventory 2. Go to Configuration > Operations Types 3. Click on Receipts 4. Check "Show Detailed Operations" box 5. Check "Pre-fill Detailed Operations" box 6. Go back to Inventory > Products 7. Create a new product 8. Go to the Inventory tab 9. At Tracking, put "By lots" 10. Check "Expiration date" Box 11. At "Expiration Date" input 10 12. Go back to Inventory > Receipts 13. Make a new receipt 14. At "Scheduled Date" input a new date 15. At "Add a line" add the product 16. Expiration date is today + 10 17. It should be new date + 10 Fix: --- Replaced today with scheduled_date opw-3813132 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167834 Forward-Port-Of: odoo/odoo#164179
**Steps:** Go to Sales > Products > Products Move to the tab of attributes and variants Create a new attribute with display type as multi-checkbox Add only one value for the attribute created Click on the website stat button **Issue:** When multi-checkbox has single value, it is not displayed on website **Cause:** Attributes selection is hidden if there is only one value available and it's not a custom value **Fix:** Disabling the feature of hiding attributes with single value wh
Original PR description
**Steps:** Go to Sales > Products > Products Move to the tab of attributes and variants Create a new attribute with display type as multi-checkbox Add only one value for the attribute created Click on the website stat button **Issue:** When multi-checkbox has single value, it is not displayed on website **Cause:** Attributes selection is hidden if there is only one value available and it's not a custom value **Fix:** Disabling the feature of hiding attributes with single value when display type is multi-checkbox **Affected Version:** 17.0 ~ master **Task**-3753005 Forward-Port-Of: odoo/odoo#157243
Issue: ====== Colorpicker disappears randomly when the selection is in the end column of the table. Steps to reptoduce the issue: ============================= - Go to notes - Add a table - Fill the first cell of the last column until the end - Select some content of the end of the text (we need the toolbar to have some part ouside the editable) - Try to change the color of the text/background - The toolbar disapears - You may need to do this multiple times to get the issue and
Original PR description
Issue: ====== Colorpicker disappears randomly when the selection is in the end column of the table. Steps to reptoduce the issue: ============================= - Go to notes - Add a table - Fill the…
Issue: ====== Colorpicker disappears randomly when the selection is in the end column of the table. Steps to reptoduce the issue: ============================= - Go to notes - Add a table - Fill the first cell of the last column until the end - Select some content of the end of the text (we need the toolbar to have some part ouside the editable) - Try to change the color of the text/background - The toolbar disapears - You may need to do this multiple times to get the issue and make sure to go to the toolbar by sliding the cursor over the visible right edge of the table first Origin of the issue: ==================== The right edge of the table is at the end of the editable so passing by it will trigger `_onMouseMove` which will detect that we are hovering on the td border of the table so it will add the class `o_col_resize` or `o_row_resize` to the editable. In `_updateToolbar` we check if we have one of those mentioned classes we don't show the toolbar so we hide it. That's why when hovering on a color in the colorpicker it will disappear. Note: The issue isn't always reproduceable because if we go so fast or so slow the hovering may not get detected or even get detected and then removed. Solution: ========= When we leave the editable, we toggle the resizeing classes if we are not in resizing state. opw-3950584 Forward-Port-Of: odoo/odoo#167480
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166788
Original PR description
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166788
Before this commit, when a product had multiple categories, it was shown in all its categories in the x/z reports. This commit changes the feature so that the product is only shown in one category (first in sequence). task-id: 3973199 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168171
Original PR description
Before this commit, when a product had multiple categories, it was shown in all its categories in the x/z reports. This commit changes the feature so that the product is only shown in one category (first in sequence). task-id: 3973199 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168171
With this commit whenever utm.source name is written it will check its uniquness (generating a unique name if necessary). [Reproduce] - Install marketing_automation - Have Campaign with a Template: - Access the Campaign's Template and go to the Settings tab. - Note down the NAME of the `utm.source` (found in the Advanced section, under the field "Name"). - Delete this template (which will also delete associated `mailing.mailing` records.) - Create new template (by returning to the Campaign
Original PR description
With this commit whenever utm.source name is written it will check its uniquness (generating a unique name if necessary). [Reproduce] - Install marketing_automation - Have Campaign with a Template: -…
With this commit whenever utm.source name is written it will check its uniquness (generating a unique name if necessary). [Reproduce] - Install marketing_automation - Have Campaign with a Template: - Access the Campaign's Template and go to the Settings tab. - Note down the NAME of the `utm.source` (found in the Advanced section, under the field "Name"). - Delete this template (which will also delete associated `mailing.mailing` records.) - Create new template (by returning to the Campaign form, opening an activity, creating template) - Open the Campaign's Template: - Disable read-only on the Name field in Advanced section (modify the `mailing.mailing.form` view). - Change its name to the previously noted `utm.source` NAME. - Save -> BUG: Trackback "The name must be unique" [Why this bug happens?] When you delete a template (`mailing.mailing`) related to a `utm.source`, the `utm.source` will still exist. Then, when attempting to change the `utm.source` name, the system is supposed to detect if the name already exists and generate a new unique name if necessary. However, due to the mechanism utilized in the function (ref.1), which searches for existing names based on existing templates (`mailing.mailing`), which you have deleted, the existing `utm.source` NAME won't be found. Consequently, the function mistakenly believes the name is unique and doesn't generate a new name, leading to the encountered error. (ref.1) `UtmMixin._get_unique_names` https://github.com/odoo/odoo/blob/205caa3d6539187009a8b8bbd1557e75fe045ff3/addons/utm/models/utm_mixin.py#L77 opw-3835704 Forward-Port-Of: odoo/enterprise#64071 Forward-Port-Of: odoo/enterprise#63360
For Greece, the ISO 3166 code (GR) and European Union code (EL) is not the same. Since this is a european report, we need the European Union code. opw-3890635 Forward-Port-Of: odoo/enterprise#64087
Original PR description
For Greece, the ISO 3166 code (GR) and European Union code (EL) is not the same. Since this is a european report, we need the European Union code. opw-3890635 Forward-Port-Of: odoo/enterprise#64087
In previous commit https://github.com/odoo/enterprise/commit/099531438fe9ef7b008a2b281780ed3ee2175692 we added a new tag check. As we tought it was empty for non-nordic countries, we thought it was fine to have it in first place but happens it is sometimes filled in other countries but not with the payment reference, as in Switzerland. We now check to fill payment_ref, in order: 1. NtryDtls>RmtInf>Ustrd 2. NtryDtls>RmtInf>Strd>CdtrRefInf>Ref 3. Ntry>AddtlNtryInf (was buggy before https://g
Original PR description
In previous commit https://github.com/odoo/enterprise/commit/099531438fe9ef7b008a2b281780ed3ee2175692 we added a new tag check. As we tought it was empty for non-nordic countries, we thought it was fine to have it in first place but happens it is sometimes filled in other countries but not with the payment reference, as in Switzerland. We now check to fill payment_ref, in order: 1. NtryDtls>RmtInf>Ustrd 2. NtryDtls>RmtInf>Strd>CdtrRefInf>Ref 3. Ntry>AddtlNtryInf (was buggy before https://github.com/odoo/enterprise/pull/62703) 4. NtryDtls>RmtInf>Strd>AddtlRmtInf opw-3923665 opw-3971080 opw-3932651 opw-3918491 Forward-Port-Of: odoo/enterprise#64004
Button draft was not display on received vendor bills. opw-3903120 Forward-Port-Of: odoo/enterprise#64020
Original PR description
Button draft was not display on received vendor bills. opw-3903120 Forward-Port-Of: odoo/enterprise#64020
Purpose: -------- The frontend room view uses the "background-image" property to add a background image if one has been set on the room. This causes several 404 errors in qunit tests because the test room does not exist, resulting in a "room not found" exception when the browser tries to get the background image. This commit patches the view in the tests to remove the url part of the background-image property, so that the background image is not fetched anymore. In order to make th
Original PR description
Purpose: -------- The frontend room view uses the "background-image" property to add a background image if one has been set on the room. This causes several 404 errors in qunit tests because the test room does not exist, resulting in a "room not found" exception when the browser tries to get the background image. This commit patches the view in the tests to remove the url part of the background-image property, so that the background image is not fetched anymore. In order to make this patch possible, the background-image property value has been moved inside a getter. Task-3943099 Forward-Port-Of: odoo/enterprise#62990