Monday, June 10, 2024
3 changes · saas-17.1
Resolved issues and error corrections
Point of Sale administrators now see product margin and cost information even when the Margins and Costs setting is turned off. This keeps the setting limited to regular POS users and ensures managers have the financial details they need during shop sessions.
Original PR description
Currently administrators for the POS app don't see margins and costs when the setting is disabled. The setting should only affect simple POS users and admins should always see the margins and costs. Steps to reproduce: ------------------- * Connect as admin * Go to the current user settings and make sure he is a POS administrator * Go the **Point of Sale** App * Go to setting, make sure **Margins and Costs** is disabled * Open a shop session * Select the information icon on a product > Margins and Costs are not shown Why the fix: ------------ Data loaded is different since using the new relational model https://github.com/odoo/odoo/commit/28b7d698be8255f933ba5314e44e7059746fc234 opw-3897694
Point of Sale combo products now keep the expected total price when taxes are included in the listed price. This prevents small rounding-related undercharges, such as a $7.00 combo appearing as $6.99 at checkout, improving price accuracy for sales staff and customers.
Original PR description
Problem: Combo product can have a price that is not the expected one Steps to reproduce: - Install "Point of Sale" app - Go to POS settings and go to the Tax settings - In the tab "Advanced Options", check "Included in Price" - Create a product of type "Combo", set the price to $7.00 - Add 3 combo choices with products prices as $7.00, $2.50 and $1.50 with no extra price - In the shop, sell this combo - The total price is $6.99 rather than $7.00 Cause: The condition supposed to fill the remaining price in the last orderline was always false opw-3897431 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where restaurant orders with products outside a specific kitchen display category could fail to show as updated when another display was set to all categories. This helps staff see order changes reliably across preparation displays, reducing the risk of missed items.
Original PR description
Currently, when a user has 2 pos preparation displays, one set on some categories the other on all, if you add on the order a product that is not in the categories of the first display, the order…
Currently, when a user has 2 pos preparation displays, one set on some categories the other on all, if you add on the order a product that is not in the categories of the first display, the order will show no changes. Steps to reproduce: ------------------- * Go to the **Kitchen display** App * Have two displays created * Display 1: `Product Categories`: Food * Display 2: `Product Categories`: All (Leave blank) * Go to the **Point of Sale** App * Open restaurant session * Select a table and add a drink to the order > Observations: The order button is not highlighted. Why the fix: ------------ Before the refactoring, the categories loaded for each display would use the function `_get_pos_category_ids()`. This function would return a list of all possible categories (ex: `[1, 2, 3, 4, 5]`) when the setting was set on all categories. After the refactoring, the categories loaded correspond to the setting of the display. Thus, in the case of a display on all categories it would return `[]`. At the end, we would end up concatenating stuff like `([5], [])` instead of `([5], [1, 2, 3, 4, 5])`. Only displays with categories set would be taken into account. opw-3923383