Monday, June 10, 2024
24 changes · saas-17.2
Resolved issues and error corrections
Fixes an issue where editing a spreadsheet pivot formula with an unexpected non-text value could cause autocomplete to crash. This makes pivot formula editing more reliable and prevents users from being blocked by accidental inputs.
Original PR description
The computation to autocomplete pivot group values was only supporting string-like group values. If a user were to write some random input, like a number, the code would crash. How to reproduce: - insert a pivot from the default crm pivot view on runbot - In B3, replace the content to =PIVOT.VALUE(1,"expected_revenue","create_date:month","04/2024",5,) -> it simply broke the domain - try to edit the cell, put your cursor between the 5 and the comma task-3976271
Invoice tax totals now apply rounding consistently when calculating untaxed amounts with price-included fixed and percentage taxes. This prevents small one-cent discrepancies on displayed invoice totals, improving accuracy for accounting documents.
Original PR description
Suppose 2 lines of 21.53 having: t1: fixed tax of 1, incl in price, include base amount t2: 21% price included tax The price_subtotal is computed as 21.53 / 1.21 - 1 = 16.79. So the untaxed amount of the invoice is 16.79 * 2 = 33.58. However, 33.59 is displayed on the invoice tax_totals. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix cleans up the chatter recipient area so the checkbox, “To” label, and suggested recipients appear in the right order and alignment. It makes the messaging interface easier to read and use, especially when no recipient has been selected yet.
Original PR description
1. alignment of the checkbox and the "To" text; 2. when there is no recipient, the suggested recipient list should be displayed after the "To" text; 3. give a ps-1 class to the recipient text; before:  after:   --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
For Greece, the ISO 3166 code (GR) and European Union code (EL) is not the same. Since this is a european report, we need the European Union code. opw-3890635 Forward-Port-Of: odoo/enterprise#64087
Original PR description
For Greece, the ISO 3166 code (GR) and European Union code (EL) is not the same. Since this is a european report, we need the European Union code. opw-3890635 Forward-Port-Of: odoo/enterprise#64087
In previous commit https://github.com/odoo/enterprise/commit/099531438fe9ef7b008a2b281780ed3ee2175692 we added a new tag check. As we tought it was empty for non-nordic countries, we thought it was fine to have it in first place but happens it is sometimes filled in other countries but not with the payment reference, as in Switzerland. We now check to fill payment_ref, in order: 1. NtryDtls>RmtInf>Ustrd 2. NtryDtls>RmtInf>Strd>CdtrRefInf>Ref 3. Ntry>AddtlNtryInf (was buggy before https://g
Original PR description
In previous commit https://github.com/odoo/enterprise/commit/099531438fe9ef7b008a2b281780ed3ee2175692 we added a new tag check. As we tought it was empty for non-nordic countries, we thought it was fine to have it in first place but happens it is sometimes filled in other countries but not with the payment reference, as in Switzerland. We now check to fill payment_ref, in order: 1. NtryDtls>RmtInf>Ustrd 2. NtryDtls>RmtInf>Strd>CdtrRefInf>Ref 3. Ntry>AddtlNtryInf (was buggy before https://github.com/odoo/enterprise/pull/62703) 4. NtryDtls>RmtInf>Strd>AddtlRmtInf opw-3923665 opw-3971080 opw-3932651 opw-3918491 Forward-Port-Of: odoo/enterprise#64004
Button draft was not display on received vendor bills. opw-3903120 Forward-Port-Of: odoo/enterprise#64020
Original PR description
Button draft was not display on received vendor bills. opw-3903120 Forward-Port-Of: odoo/enterprise#64020
Purpose: -------- The frontend room view uses the "background-image" property to add a background image if one has been set on the room. This causes several 404 errors in qunit tests because the test room does not exist, resulting in a "room not found" exception when the browser tries to get the background image. This commit patches the view in the tests to remove the url part of the background-image property, so that the background image is not fetched anymore. In order to make th
Original PR description
Purpose: -------- The frontend room view uses the "background-image" property to add a background image if one has been set on the room. This causes several 404 errors in qunit tests because the test room does not exist, resulting in a "room not found" exception when the browser tries to get the background image. This commit patches the view in the tests to remove the url part of the background-image property, so that the background image is not fetched anymore. In order to make this patch possible, the background-image property value has been moved inside a getter. Task-3943099 Forward-Port-Of: odoo/enterprise#62990
Ukranian translation doesn't seem to be pulled from Transifex for some reason. This commit adds in the missing translation. Task-3956036 Community: https://github.com/odoo/odoo/pull/168519
Original PR description
Ukranian translation doesn't seem to be pulled from Transifex for some reason. This commit adds in the missing translation. Task-3956036 Community: https://github.com/odoo/odoo/pull/168519
**Steps:** Go to Sales > Products > Products Move to the tab of attributes and variants Create a new attribute with display type as multi-checkbox Add only one value for the attribute created Click on the website stat button **Issue:** When multi-checkbox has single value, it is not displayed on website **Cause:** Attributes selection is hidden if there is only one value available and it's not a custom value **Fix:** Disabling the feature of hiding attributes with single value wh
Original PR description
**Steps:** Go to Sales > Products > Products Move to the tab of attributes and variants Create a new attribute with display type as multi-checkbox Add only one value for the attribute created Click on the website stat button **Issue:** When multi-checkbox has single value, it is not displayed on website **Cause:** Attributes selection is hidden if there is only one value available and it's not a custom value **Fix:** Disabling the feature of hiding attributes with single value when display type is multi-checkbox **Affected Version:** 17.0 ~ master **Task**-3753005 Forward-Port-Of: odoo/odoo#157243
Before this commit, when a product had multiple categories, it was shown in all its categories in the x/z reports. This commit changes the feature so that the product is only shown in one category (first in sequence). task-id: 3973199 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168171
Original PR description
Before this commit, when a product had multiple categories, it was shown in all its categories in the x/z reports. This commit changes the feature so that the product is only shown in one category (first in sequence). task-id: 3973199 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168171
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166788
Original PR description
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166788
This commit updates the logic to enable the modification of quantities for combo products in the cart. Task ID: 3872513 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167215 Forward-Port-Of: odoo/odoo#166695
Original PR description
This commit updates the logic to enable the modification of quantities for combo products in the cart. Task ID: 3872513 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167215 Forward-Port-Of: odoo/odoo#166695
Ukranian translation doesn't seem to be pulled from Transifex for some reason. This commit adds in the missing translation. Task-3956036 Enterprise: https://github.com/odoo/enterprise/pull/64106
Original PR description
Ukranian translation doesn't seem to be pulled from Transifex for some reason. This commit adds in the missing translation. Task-3956036 Enterprise: https://github.com/odoo/enterprise/pull/64106
Current behavior: --- Expiry dates are computed from today's date and expiration time, it should be based on scheduled date. Steps to reproduce: --- 1. Go to Inventory 2. Go to Configuration > Operations Types 3. Click on Receipts 4. Check "Show Detailed Operations" box 5. Check "Pre-fill Detailed Operations" box 6. Go back to Inventory > Products 7. Create a new product 8. Go to the Inventory tab 9. At Tracking, put "By lots" 10. Check "Expiration date" Box 11. At "Expiration D
Original PR description
Current behavior: --- Expiry dates are computed from today's date and expiration time, it should be based on scheduled date. Steps to reproduce: --- 1. Go to Inventory 2. Go to Configuration > Operations Types 3. Click on Receipts 4. Check "Show Detailed Operations" box 5. Check "Pre-fill Detailed Operations" box 6. Go back to Inventory > Products 7. Create a new product 8. Go to the Inventory tab 9. At Tracking, put "By lots" 10. Check "Expiration date" Box 11. At "Expiration Date" input 10 12. Go back to Inventory > Receipts 13. Make a new receipt 14. At "Scheduled Date" input a new date 15. At "Add a line" add the product 16. Expiration date is today + 10 17. It should be new date + 10 Fix: --- Replaced today with scheduled_date opw-3813132 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167834 Forward-Port-Of: odoo/odoo#164179
### Steps to reproduce: - Create a storable product with a vendor (in the pruchase tab) - Create a buy reordering rule with that vendor for that product - Select the reordering rule line and snooze it for one day - Create a sale order for #### > the snoozed reordering rule is triggered ### Cause of the issue: The `snoozed_untill` field of the orderpoint is not taken into account by the `_trigger_scheduler` to determine which auto-trigger orderpoint should be applied: https://gith
Original PR description
### Steps to reproduce: - Create a storable product with a vendor (in the pruchase tab) - Create a buy reordering rule with that vendor for that product - Select the reordering rule line and snooze it for one day - Create a sale order for #### > the snoozed reordering rule is triggered ### Cause of the issue: The `snoozed_untill` field of the orderpoint is not taken into account by the `_trigger_scheduler` to determine which auto-trigger orderpoint should be applied: https://github.com/odoo/odoo/blob/4f43eb2e69224c9cb271b6e2ca7533d929333985/addons/stock/models/stock_move.py#L2132-L2138 opw-3901613 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168201 Forward-Port-Of: odoo/odoo#165567
Issue: ====== Colorpicker disappears randomly when the selection is in the end column of the table. Steps to reptoduce the issue: ============================= - Go to notes - Add a table - Fill the first cell of the last column until the end - Select some content of the end of the text (we need the toolbar to have some part ouside the editable) - Try to change the color of the text/background - The toolbar disapears - You may need to do this multiple times to get the issue and
Original PR description
Issue: ====== Colorpicker disappears randomly when the selection is in the end column of the table. Steps to reptoduce the issue: ============================= - Go to notes - Add a table - Fill the…
Issue: ====== Colorpicker disappears randomly when the selection is in the end column of the table. Steps to reptoduce the issue: ============================= - Go to notes - Add a table - Fill the first cell of the last column until the end - Select some content of the end of the text (we need the toolbar to have some part ouside the editable) - Try to change the color of the text/background - The toolbar disapears - You may need to do this multiple times to get the issue and make sure to go to the toolbar by sliding the cursor over the visible right edge of the table first Origin of the issue: ==================== The right edge of the table is at the end of the editable so passing by it will trigger `_onMouseMove` which will detect that we are hovering on the td border of the table so it will add the class `o_col_resize` or `o_row_resize` to the editable. In `_updateToolbar` we check if we have one of those mentioned classes we don't show the toolbar so we hide it. That's why when hovering on a color in the colorpicker it will disappear. Note: The issue isn't always reproduceable because if we go so fast or so slow the hovering may not get detected or even get detected and then removed. Solution: ========= When we leave the editable, we toggle the resizeing classes if we are not in resizing state. opw-3950584 Forward-Port-Of: odoo/odoo#167480
go to Point of sales -> choose menu a pos -> view order -> choose order has state 'New' -> chooose '(update)' -> server error  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167302
Original PR description
go to Point of sales -> choose menu a pos -> view order -> choose order has state 'New' -> chooose '(update)' -> server error  --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167302
A fix's term was changing during the fw-port, but it's pot file was not re-exported to match. Therefore, re-export so that it translates properly. Also note that apparently some records are re-named in Enterprise version and were exported into the pot file (wiping the community names). This commit attempted to re-add those COM names, but this conflicts with the CI to check that a model translation does not have more than 1 term (e.g. can't have different names for the same record). The
Original PR description
A fix's term was changing during the fw-port, but it's pot file was not re-exported to match. Therefore, re-export so that it translates properly. Also note that apparently some records are re-named in Enterprise version and were exported into the pot file (wiping the community names). This commit attempted to re-add those COM names, but this conflicts with the CI to check that a model translation does not have more than 1 term (e.g. can't have different names for the same record). Therefore we leave the already exported enterprise terms. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168165 Forward-Port-Of: odoo/odoo#167745
**Steps to reproduce:** (!!! Spanish EDI credentials required !!!) - Install l10n_es_edi_sii - Switch to a Spanish company (e.g. ES Company) - Configure Spanish Localization - Create an invoice - Process it by the ES E-invoicing service - Once processed, an electronic document containing the response of the E-invoicing service is created (i.e. jsondump.json) **Issue:** When sending the invoice via "SEND & PRINT" button, the "jsondump.json" file is added in the attachments. opw-37209
Original PR description
**Steps to reproduce:** (!!! Spanish EDI credentials required !!!) - Install l10n_es_edi_sii - Switch to a Spanish company (e.g. ES Company) - Configure Spanish Localization - Create an invoice - Process it by the ES E-invoicing service - Once processed, an electronic document containing the response of the E-invoicing service is created (i.e. jsondump.json) **Issue:** When sending the invoice via "SEND & PRINT" button, the "jsondump.json" file is added in the attachments. opw-3720984 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167950
Currently, no language was passed to the HR Attendance Kiosk, so it would default to English. This change passes the language of the company partner to the kiosk mode in order to allow companies having the portal in their own language. task-3976591 Forward-Port-Of: odoo/odoo#168343
Original PR description
Currently, no language was passed to the HR Attendance Kiosk, so it would default to English. This change passes the language of the company partner to the kiosk mode in order to allow companies having the portal in their own language. task-3976591 Forward-Port-Of: odoo/odoo#168343
Steps to reproduce: - insert a pivot in a spreadsheet - create a From/To global filter - leave the filter values empty - click on the Share button => boom because of `cell.value.toString()` `cannot read toString of undefined` opw-3971278 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168147
Original PR description
Steps to reproduce: - insert a pivot in a spreadsheet - create a From/To global filter - leave the filter values empty - click on the Share button => boom because of `cell.value.toString()` `cannot read toString of undefined` opw-3971278 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168147
**Current behavior before PR:** if a partner is a member of any channel (eg, whatsapp channel) it will be displayed in the command palette even if he does not have any associated user.which will cause issues as you can not chat with partner who do not have any dedicated user. **Desired behavior after PR is merged:** partners with no dedicated users will not be displayed in the command palette to chat with when you enter @. Task-3815150 --- I confirm I have signed the CLA and rea
Original PR description
**Current behavior before PR:** if a partner is a member of any channel (eg, whatsapp channel) it will be displayed in the command palette even if he does not have any associated user.which will cause issues as you can not chat with partner who do not have any dedicated user. **Desired behavior after PR is merged:** partners with no dedicated users will not be displayed in the command palette to chat with when you enter @. Task-3815150 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166220 Forward-Port-Of: odoo/odoo#159239
Tour 'shop_buy_product' checks the correctness of manipulating products and their quantities in the cart and the payment step of the order. With the additional check on the payment step introduced by commit 023d549 the tour was failing due to the relatively late rpc request handling compared to immediate clicks of the tour. `shop/payment` page was rendered faster than the update cart rpc (`shop/cart/update_json`) was processed. Cart update resets the delivery method on the order causing t
Original PR description
Tour 'shop_buy_product' checks the correctness of manipulating products and their quantities in the cart and the payment step of the order. With the additional check on the payment step introduced by commit 023d549 the tour was failing due to the relatively late rpc request handling compared to immediate clicks of the tour. `shop/payment` page was rendered faster than the update cart rpc (`shop/cart/update_json`) was processed. Cart update resets the delivery method on the order causing the validation error. That is why the tour is split in 2 separate functional parts. Forward-Port-Of: odoo/odoo#166670
Reproduce: * Create a database without demo data * Complete some information related to the main company (i.e. from the database manager form) * Install `account` * In the settings, in debug mode, trigger the installation of the demo data manually Result: The data manually set on the company is overridden to be in US, making the demo data of `account` lose its localized aspect. If for some reason the CoA could not be reloaded, we even don't have any demo at all because `try_loading` won'
Original PR description
Reproduce: * Create a database without demo data * Complete some information related to the main company (i.e. from the database manager form) * Install `account` * In the settings, in debug mode, trigger the installation of the demo data manually Result: The data manually set on the company is overridden to be in US, making the demo data of `account` lose its localized aspect. If for some reason the CoA could not be reloaded, we even don't have any demo at all because `try_loading` won't do anything at all. Solution: Do not override value possibly set by the user in the database configuration. We use the company name as a heuristic. If there is already a chart template installed (because the installation of a `l10n` module triggered it), then we try to load the dynamic demo data when loading the demo XML file. Forward-Port-Of: odoo/odoo#168232 Forward-Port-Of: odoo/odoo#166315