Monday, June 10, 2024
19 changes · saas-17.3
Resolved issues and error corrections
This fixes a small visual issue on invoices when a second currency is enabled. The words between currency and payment term options now line up correctly, making the invoice form cleaner and easier to read.
Original PR description
Install account_accountant Activate Second currency Create an invoice => The "or" and the "in" are not aligned. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Arabic-English invoice report now avoids showing the same product name more than once when the description already includes it. This makes printed invoices clearer for customers and prevents duplicate or triplicate product lines when Arabic is enabled.
Original PR description
Problem: The arabic_english_invoice report displays product name twice since the description includes the product name by default. Solution:The report should only display the description if the description is not the same as the products' name. Otherwise, the report should display the products' name in the same language as the customer. Steps to Reproduce on Runbot: Install sale, l10n_sa, l10n_gcc_invoice Switch to SA Company Create a product with sales description Create an invoice with the product from step 3 Print the invoice report Observe the product name is displayed twice If Arabic is enabled as a language, the product name will be displayed three times, with the 3rd being in Arabic. Ticket link opw-3768196 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The accounting settings now use clearer wording to distinguish regular line discounts from early payment discounts. This helps users choose the right option and reduces confusion when configuring discount-related features.
Original PR description
We have two settings about discounts that are not linked to the same features (one is line discounts, and the other is Early Payment discounts). They are next to each other but not clear at all. Updating text on settings to differentiate between early payments and discounts. Enterprise PR: https://github.com/odoo/enterprise/pull/62039 task-3908720 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Demo mode registration for Peppol now follows the updated flow and correctly creates the required EDI user. The Peppol Services button is also hidden in demo mode, reducing confusion for users testing the setup.
Original PR description
The registration flow changed and the demo mode mocking was not adjusted properly, skipping the step of creating an edi user. Additionally, we need to hide Peppol Services button in demo mode by adding a non-stored `account_peppol_edi_mode` field. task-3971063 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Duplicating a regular spreadsheet pivot table no longer triggers a crash caused by global filter handling. The fix ensures Odoo-specific global filter logic is only applied to Odoo pivots, improving reliability when users work with spreadsheet pivot tables.
Original PR description
How to reproduce: - go to a runbot (starting saas-17.3, when we introduce the pivot tables) - insert a pivot table (spreadsheet pivot) (select a zone -> top bar menu > insert > pivot table) - go to its sidepanel and click "duplicate pivot" ==> crash The plugin PivotCoreGlobalFilterPlugin mishandles the command `DUPLICATE_PIVOT` as it does not differentiate Odoo pivot (which it should handle) and a non-odoo pivot. Task-3970711 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where highlighted messages in the chatter were not properly passed to the display area. Users can now more reliably see the message they searched for or were directed to, making navigation in conversations clearer.
Original PR description
Before this PR: Chatter passes `messageHighlight` in it's childEnv by fetching it using a getter. This getter is overridden in it's patch. But in the patch the `messageHighlight` is set after calling `super.setup`. So, when the getter is called `messageHighlight` is never set. So, `messageHighlight` never gets passed down to it's child. After this PR: We set `messageHighlight` before calling `super.setup`. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix makes Point of Sale demo setup behave more consistently by hiding setup choices when demo scenarios are already installed. It also ensures restaurant demo selection works across companies by creating the needed configuration when the restaurant option is installed.
Original PR description
1. When installing point_of_sale with demo, we should immediately hide the scenario options because all the scenarios are already installed. 2. When in a differenct company in demo mode, selecting a restaurant scenario when pos_restaurant is not yet installed should not only install the pos_restaurant module but also create the select scenario config.
This fixes an issue where employee grouping in the Attendance app could ignore filters selected by the user in the Gantt view. Business users will now see attendance information grouped only for the relevant employees, making filtered planning and review screens more accurate.
Original PR description
The current state of _read_group_employee_id ignores the user domain and thus filtering To fix this we apply the domain in the case a user_domain is used in the gantt view
The course content list now hides unwanted borders around disabled icon buttons. This keeps course pages looking cleaner and avoids visual confusion for learners browsing unavailable content.
Original PR description
## Issue In Course List, After v17.3 + There a topless border in icons where button is disabled. Which looks weird and doesn't make sense as we don't need any border there. ## Technical This issue came from this commit odoo@7d66dcb , where `disabled="1"` was added inside the button. The default `btn.disabled` has button outline in [bootstrap](https://github.com/odoo/odoo/blob/51af11c9180fe48ba3492ffd3402a22bde211318/addons/web/static/lib/bootstrap/dist/css/bootstrap.css#L3048-L3053) code. That's why the border is appearing there. ## After this PR There will be no borders where icon buttons are disabled. Task-3975450
This update fixes an internal automated test for chat messages so it no longer depends on timing quirks. It helps keep quality checks stable and reduces false failures in the mail app testing pipeline.
Original PR description
The `mark as read when opening chat window` test is incorrect. It receives a message outside the thread focus to have one unread message, then opens the chat window to verify the message is read. The `setFocus` parameter of the `contains` helper is used to remove focus, but it can only focus an element, not blur it. This causes the test to pass only due to the delay between opening the chat window and the mark as read RPC. Properly blurring the composer fixes the issue. fixes runbot-65485
This fixes an issue where customers could receive incorrectly formatted SMS messages from the point of sale. Customer text messages now use the proper message body, improving communication clarity after POS orders.
Original PR description
Before this commit: ==================== A broken SMS body message was sent to the customer. After this commit: =================== The SMS body is now accurately formatted and sent to the customer task -3969131
The attendance screen's In/Out Mode grouping has been corrected so users can filter and review attendance records as expected. This helps HR teams get more reliable views of employee check-in and check-out data without confusion.
Original PR description
task-3961391
This fixes an issue where saved favorite filters could be missed or shown inconsistently when created without a related active record. Users should now see the expected saved filters for the same action, improving reliability in search workflows.
Original PR description
This commit fixes a bug that was introduced by https://github.com/odoo/odoo/pull/163184. Bug Description: When a favorite filter is created from the search bar without an active_id in the global context, the embedded_parent_res_id variable is assigned a False value. However, since embedded_parent_res_id is an integer, it defaults to 0 in the database. Consequently, when retrieving filters for the same action, the newly created favorite filter appears because the system searches for a False value for embedded_parent_res_id , but a 0 value is stored in the database. Solution: Modify the action_domain to fetch both False and 0 values. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The spreadsheet context menu now shows the option to use a cell value as a global filter only for the appropriate pivot header cells. This avoids offering an action in cases where it should not apply, reducing confusion for users working with pivot-based spreadsheets.
Original PR description
The context menu (and clickable cell) `use_global_filter` should take the value of the underlying pivot formula, and apply it to the matching global filters. This works, but was supposed to work only for `ODOO.PIVOT.HEADER` formulas, and not simple `ODOO.PIVOT` formulas. This commit fixes the visibility of the `use_global_filter` option in the context menu, so that it is only visible for `ODOO.PIVOT.HEADER`. Also removed/changed tests that were testing that the menu was visible for positional `ODOO.PIVOT` formulas. Task: 3714696 X-original-commit: 746e71c86caf4b458d40759102dfd20a3236c16c
The appointment scheduling share availability button now keeps the proper visual placement on smaller screens. This avoids a confusing raised appearance and improves the booking interface for users on compact displays.
Original PR description
Fix the share availabilities button elevation happening on lower screen sizes. related PR: odoo/enterprise#51755 Task-3975976
The wording for deferred entry settings in Accounting has been updated to be clearer and more consistent with nearby settings. This helps users better understand the option when configuring accounting behavior.
Original PR description
Update deferred entries settings text to be clearer and consistent with surrounding settings text updated in: https://github.com/odoo/odoo/pull/164539 task-3908720
This update makes an internal automated test for attendance planning more stable by avoiding a timing issue. It helps reduce false build failures, making development and releases smoother without changing user-facing behavior.
Original PR description
The test "Future Open Ended record not displayed" could fail if for some reason the domain used to fetchData is computed 1 second or more after the mocked datetime has been applied. In that case the domain constructed in AttendanceGanttModel contains the open ended record and the second assertion fails. Here we choose a safer mocked datetime. see build https://runbot.odoo.com/runbot/build/63759517
The appointment scheduling Gantt view now correctly shows the button for adding closing days again. This restores a missing action that helps users block unavailable dates directly from the planning view.
Original PR description
Since [1] the button never rendered due to the getter `showAddLeaveButton` not properly bound to the component. [1]: https://github.com/odoo/enterprise/commit/d18639785e622d97102227103d62ddb3a2716be6
This fix improves the attendance Gantt view so previously active employees are included when expanding grouped results over a wider time window. It helps managers review attendance information more reliably, especially around employees who were active in the relevant period.
Original PR description
Increase window size for previously active employees