Tuesday, June 11, 2024
5 changes · saas-17.2
Resolved issues and error corrections
The Argentinian tax report filter now shows clear tax type names instead of technical object references. Selecting a tax type from the dropdown now correctly applies the filter, making reports easier and more reliable to use.
Original PR description
Fix display and functionality of tax type filter - Corrected the display of dropdown items to show tax type names instead of object references. - Updated the `onSelected` event handler to ensure the tax filter is correctly applied when a dropdown item is selected. opw-3976746
New or updated employee contracts now automatically use the right default vehicle cost values. This helps payroll teams avoid missing or incorrect fleet-related cost entries when assigning or changing a company car.
Original PR description
When a new contract is created (or if we change the vehicle_id on an existing one, it'll take the default value on the contract, or the previous contract value as default values for the cost
Fixed an issue that caused the scheduled Mail Fetch service to fail when the Chilean electronic invoicing module was installed. This keeps automated email processing running reliably for affected databases.
Original PR description
Currently, an error is generated when run 'Mail: Fetchmail Service' scheduled action. Step to produce: - Install the 'l10n_cl_edi' module. - And manually trigger the 'Mail: Fetchmail Service'…
Currently, an error is generated when run 'Mail: Fetchmail Service' scheduled action.
Step to produce:
- Install the 'l10n_cl_edi' module.
- And manually trigger the 'Mail: Fetchmail Service' scheduled action.
Stacktrace
```
TypeError: FetchmailServer.fetch_mail() got an unexpected keyword argument 'raise_exception'
File "odoo/tools/safe_eval.py", line 383, in safe_eval
return unsafe_eval(c, globals_dict, locals_dict)
File "ir.actions.server(128,)", line 1, in <module>
File "addons/mail/models/fetchmail.py", line 186, in _fetch_mails
return self.search([('state', '=', 'done'), ('server_type', '!=', 'local')]).fetch_mail(raise_exception=False)
ValueError: <class 'TypeError'>: "FetchmailServer.fetch_mail() got an unexpected keyword argument 'raise_exception'" while evaluating
'model._fetch_mails()'
File "odoo/addons/base/models/ir_cron.py", line 388, in _callback
self.env['ir.actions.server'].browse(server_action_id).run()
File "home/odoo/src/custom/trial/saas_trial/models/sentry.py", line 33, in run
res = super().run()
File "odoo/addons/base/models/ir_actions.py", line 972, in run
res = runner(run_self, eval_context=eval_context)
File "odoo/addons/base/models/ir_actions.py", line 802, in _run_action_code_multi
safe_eval(self.code.strip(), eval_context, mode="exec", nocopy=True, filename=str(self)) # nocopy allows to return 'action'
File "odoo/tools/safe_eval.py", line 397, in safe_eval
raise ValueError('%s: "%s" while evaluating\n%r' % (ustr(type(e)), ustr(e), expr))
```
The issue arises during the execution of the 'Mail: Fetchmail Service' scheduled action because the 'fetch_mail()' method call without argument, as we can see at [1], And this argument is added from this PR https://github.com/odoo/odoo/pull/152637.
link [1]: https://github.com/odoo/enterprise/blob/ba99dd4c236353c43376210a9aabcb0af5bd0299/l10n_cl_edi/models/fetchmail_server.py#L51
To resolve the issue, Add a default keyword argument at [2] to prevent an issue.
link [2]: https://github.com/odoo/enterprise/blob/ba99dd4c236353c43376210a9aabcb0af5bd0299/l10n_cl_edi/models/fetchmail_server.py#L51
sentry-5284073241Public visitors could trigger an error when selecting text or double-clicking in certain forum posts. This update checks that the toolbar option exists before changing it, preventing the page from breaking for forum users.
Original PR description
HOW TO REPRODUCE: ================= - website_helpdesk_forum addon shall be installed - Do not login (navigate as a public user) - Go to the Website > Forum > Help > any post - Double-click anywhere…
HOW TO REPRODUCE: ================= - website_helpdesk_forum addon shall be installed - Do not login (navigate as a public user) - Go to the Website > Forum > Help > any post - Double-click anywhere in the post body or select some text - You should get the following client error from `OdooEditor._updateToolbar: Cannot read properties of null (reading 'classList')` HOW TO FIX: =========== By ensuring the wysiwig toolbar unlink button is present in the page before adding classes to it. The bug seems to be in relation to the following PR odoo/odoo#147919, where the `OdooEditor._updateToolbar` method is slightly modified to ensure the toolbar unlink button is not visible initially, but forgets to check whether the element exists before hiding it. The bug can be spotted when `website_helpdesk_forum` is installed as it sets to 0 the level of karma required to answer a post while keeping the full edit rights (image and link) to 30 pts. As a consequence, the WYSIWYG is included in the post page even when requested by the public users, but the WYSIWYG toolbar does not include the unlink button. task-3932751 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes occasional failures in automated tests that verify Discuss channel subscriptions. The change makes the tests reliably detect when users join or leave channels, helping keep release validation stable without changing user-facing behavior.
Original PR description
Before this PR, some bus subscription tests were occasionally failing. These tests open Discuss and assert that bus subscriptions are correctly handled in different scenarios, such as joining/leaving a channel. To achieve this, they use the `waitForChannel` helper. Sometimes, the subscription is made before calling `waitForChannel`, which causes the test to fail. This PR replaces the `waitForChannel` method by adding a step when `bus_service.addChannel` is called. Since this setup can be done before opening Discuss, we ensure that the subscription is not missed. fixes runbot-61294,65319,61969