Tuesday, June 11, 2024
3 changes · saas-17.2
Resolved issues and error corrections
Public visitors could trigger an error when selecting text or double-clicking in certain forum posts. This update checks that the toolbar option exists before changing it, preventing the page from breaking for forum users.
Original PR description
HOW TO REPRODUCE: ================= - website_helpdesk_forum addon shall be installed - Do not login (navigate as a public user) - Go to the Website > Forum > Help > any post - Double-click anywhere…
HOW TO REPRODUCE: ================= - website_helpdesk_forum addon shall be installed - Do not login (navigate as a public user) - Go to the Website > Forum > Help > any post - Double-click anywhere in the post body or select some text - You should get the following client error from `OdooEditor._updateToolbar: Cannot read properties of null (reading 'classList')` HOW TO FIX: =========== By ensuring the wysiwig toolbar unlink button is present in the page before adding classes to it. The bug seems to be in relation to the following PR odoo/odoo#147919, where the `OdooEditor._updateToolbar` method is slightly modified to ensure the toolbar unlink button is not visible initially, but forgets to check whether the element exists before hiding it. The bug can be spotted when `website_helpdesk_forum` is installed as it sets to 0 the level of karma required to answer a post while keeping the full edit rights (image and link) to 30 pts. As a consequence, the WYSIWYG is included in the post page even when requested by the public users, but the WYSIWYG toolbar does not include the unlink button. task-3932751 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update brings the spreadsheet component to the latest version for Odoo 17.2 and fixes issues affecting charts, spreadsheet sizing, and paste behavior. Users should see more reliable spreadsheet interactions and fewer errors when working with charts or pasting content.
Original PR description
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/14317eeae [REL] 17.2.10 Task: 0 https://github.com/odoo/o-spreadsheet/commit/2e5e95105 [FIX] chart: deepCopy support…
### Contains the following commits: https://github.com/odoo/o-spreadsheet/commit/14317eeae [REL] 17.2.10 Task: 0 https://github.com/odoo/o-spreadsheet/commit/2e5e95105 [FIX] chart: deepCopy support object without prototype Task: 3950324 https://github.com/odoo/o-spreadsheet/commit/146b0a0ae [FIX] spreadsheet: fix `useSpreadsheetRect` Task: 3965147 https://github.com/odoo/o-spreadsheet/commit/1217b1e83 [FIX] composer: Prevent default paste in composer Task: 3864000 https://github.com/odoo/o-spreadsheet/commit/f7df2fd33 [DOC] update integration minimal setup Task: 3918013 Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
This fixes occasional failures in automated tests that verify Discuss channel subscriptions. The change makes the tests reliably detect when users join or leave channels, helping keep release validation stable without changing user-facing behavior.
Original PR description
Before this PR, some bus subscription tests were occasionally failing. These tests open Discuss and assert that bus subscriptions are correctly handled in different scenarios, such as joining/leaving a channel. To achieve this, they use the `waitForChannel` helper. Sometimes, the subscription is made before calling `waitForChannel`, which causes the test to fail. This PR replaces the `waitForChannel` method by adding a step when `bus_service.addChannel` is called. Since this setup can be done before opening Discuss, we ensure that the subscription is not missed. fixes runbot-61294,65319,61969