Wednesday, June 12, 2024
42 changes · saas-17.3
Resolved issues and error corrections
Restaurant point of sale users can now press Enter to confirm short text entries such as floor names, table names, and free-order notes. This prevents accidental multi-line input and makes common setup and editing actions faster and smoother.
Original PR description
When creating a new floor, the text popup allows multiple line input which isn't a good UX. In this commit, we introduce a props to the `TextInputPopup` dialog that allows confirmation of the input when pressing the `enter` key. We activate this option to the creation/renaming of (new) floor, renaming a table, and setting a note to a free order.
The Accounting tax form no longer shows a placeholder that simply repeated the field name. This small cleanup reduces visual clutter and makes the form feel clearer for users entering tax legal notes.
Original PR description
Removes a useless placeholder (because it's a repetition of the field name) for the field tax_legal_note that was added in this commit https://github.com/odoo/odoo/commit/4cfb19c6eb9603959eb459c22795c2585d8547a6 task-id: 3873054 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Invoice note lines can now expand across multiple lines instead of cutting off earlier text. This restores expected invoice editing behavior and helps users enter longer notes clearly.
Original PR description
Description of the issue this commit addresses: With the new merged product and label system on invoices, notes on invoices can't take multiple line anymore. This is not wanted. --- Steps to…
Description of the issue this commit addresses: With the new merged product and label system on invoices, notes on invoices can't take multiple line anymore. This is not wanted. --- Steps to reproduce: 1 - Install account 2 - Create a new invoice 3 - Add a note line 4 - Write text that should overflow the line/press enter. 5 - Instead of adding a line, first characters disappear to let last be shown --- Desired behavior after this commit is merged: Note on invoice lines should be able to be on multiple lines. --- Note on the fix: The error happened because the condition to use either an \<input\> for a section or a <textarea> for a section was mistaken. The note's <textarea> is inside the else of the section's \<input\> which's condition is "isSection". Problem is that isSection is a method and not an attribute so it would always return true. The attribute containing whether we are in a note line or not is props.isSection --- no task-feedback --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The tax selection dropdown now keeps tax names and tax scope labels visually separated, even when both are long. This prevents the two labels from appearing as one combined piece of text when users enter vendor bill lines.
Original PR description
Description of the issue this commit addresses: In some instances where the tax name and tax scope name take perfectly the space available in the tax widget's autocomplete, there is no space in between those two which make it seem like a single piece of text. This happens when the longest tax name also has the longest tax_scope. This is not wanted. --- Steps to reproduce: (Luckily, a perfect example is available in demo data) 1-Install l10n_be 2-Create a vendor bill 3-Add a line and open the tax cell's autocomplete 4-21% M.Cocont and Merchandise are joined --- Desired behavior after this commit is merged: In such scenarios, a space should be forced between the tax name and the scope. --- Note on the fix: Since there is always a tax name but not always a tax scope, I decided to add a left margin on the tax_scope. --- no task-feedback --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update corrects an internal method definition in the product barcode lookup feature. It helps prevent unintended behavior when barcode lookup logic is reused, improving reliability without changing user-facing workflows.
Original PR description
- The method signature was improper it was a mutable changing it to non mutable signature.
This fix prevents copied databases using Colombian DIAN e-invoicing from unintentionally contacting external services. It helps support teams investigate issues safely without risking changes or messages affecting production systems or customers.
Original PR description
This commit adds the missing neutralization necessary for the l10n_co_dian module introduced in [1] The purpose of the standard neutralization framework is to allow us to create database copies that will not interact with external systems in ways that could impact the production database (or if it is not possible to prevent the interactions, make sure that they are benign or won't result in actual changes), or impact the customers of the operator of the production database. This is mainly useful to allow safe support investigation on database duplicates. [1] https://github.com/odoo/enterprise/pull/57925
Fixed an issue where customized image names containing dots were not handled correctly during website generation. This prevents mismatches between stored scraped images and the images the generator looks for, helping generated websites display the intended visuals.
Original PR description
Fixed the bug where customized image names containing a dot (.) were not correctly reformed in the generator. The issue caused a mismatch between the image names in the scraper folder and the names searched for by the generator.
Miscellaneous changes
Since Commit 4c58d82c7e582c11eb967b6ed7c918a6da3ebd23 refactored `test_delivery_ui`, the check for the `payment_custom` module was moved to individual tests, however, the new `setUpClass` function now uses code that requires `payment_custom` and fails when the server tries to run tests. Solution: Move the initialization of `transfer_provider` to the individual tests instead of within the setup function. opw-3957075 Forward-Port-Of: odoo/odoo#169137 Forward-Port-Of: odoo/odoo#168792
Original PR description
Since Commit 4c58d82c7e582c11eb967b6ed7c918a6da3ebd23 refactored `test_delivery_ui`, the check for the `payment_custom` module was moved to individual tests, however, the new `setUpClass` function now uses code that requires `payment_custom` and fails when the server tries to run tests. Solution: Move the initialization of `transfer_provider` to the individual tests instead of within the setup function. opw-3957075 Forward-Port-Of: odoo/odoo#169137 Forward-Port-Of: odoo/odoo#168792
[ADD] l10n_us_account: Auto load the localization pack and related reports automatically Problem: Users, especially newer ones, don't have the experience; or don't know how to install modules manually to their database. This will create the incorrect idea that Odoo doesn't fulfill the minimum requirements to operate in the US. - Examples of those uninstalled requirements are ABA routing for payments, correct layout for checks, 1099 reports, and Avatax for tax calculation. Desired behav
Original PR description
[ADD] l10n_us_account: Auto load the localization pack and related reports automatically Problem: Users, especially newer ones, don't have the experience; or don't know how to install modules…
[ADD] l10n_us_account: Auto load the localization pack and related reports automatically Problem: Users, especially newer ones, don't have the experience; or don't know how to install modules manually to their database. This will create the incorrect idea that Odoo doesn't fulfill the minimum requirements to operate in the US. - Examples of those uninstalled requirements are ABA routing for payments, correct layout for checks, 1099 reports, and Avatax for tax calculation. Desired behavior:- Auto load the following when creating odoo US database - US Accounting: l10n_us_account - United States Localization: l10n_us - US Accounting Reports: l10n_us_reports - 1099 Reporting: l10n_us_1099 - US Checks Layout: l10n_us_check_printing - NACHA Payments: l10n_us_payment_nacha - Avatax: account_avatax Solution: Create new module l10n_us_account to separate the accounting dependent stuff and auto load it and l10n_us which is going to load the mentioned packages above for US-db. Task-3865230 Enterprise PR: https://github.com/odoo/enterprise/pull/60644 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#161709
Current behavior: When settling and invoicing a sale order in the PoS, the untaxed invoiced amount was not taking the pos order lines into account Steps to reproduce: - Create a sale order - Open a PoS and settle the sale order - Validate it - Go back to the original sale order and check the Untaxed Invoiced Amount. (The field might not be present in the form, you can add it with studio) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit
Original PR description
Current behavior: When settling and invoicing a sale order in the PoS, the untaxed invoiced amount was not taking the pos order lines into account Steps to reproduce: - Create a sale order - Open a PoS and settle the sale order - Validate it - Go back to the original sale order and check the Untaxed Invoiced Amount. (The field might not be present in the form, you can add it with studio) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167919 Forward-Port-Of: odoo/odoo#162634
Current behavior: --- When logged as a mass mailing user, in a mailing, using the editor, when applying a shape to an image, the image disappears. Steps to reproduce: --- 1. Make sure Marc Demo has the role User 2. Log in as Marc Demo 3. Create a new mailing 4. Select a template 5. Insert a picture 6. Select the picture 7. Change its shape to round 8. (preview works fine) 9. Save the mailing 10. Picture disappears Cause of the issue: --- When applying a shape to an image,
Original PR description
Current behavior: --- When logged as a mass mailing user, in a mailing, using the editor, when applying a shape to an image, the image disappears. Steps to reproduce: --- 1. Make sure Marc Demo has…
Current behavior: --- When logged as a mass mailing user, in a mailing, using the editor, when applying a shape to an image, the image disappears. Steps to reproduce: --- 1. Make sure Marc Demo has the role User 2. Log in as Marc Demo 3. Create a new mailing 4. Select a template 5. Insert a picture 6. Select the picture 7. Change its shape to round 8. (preview works fine) 9. Save the mailing 10. Picture disappears Cause of the issue: --- When applying a shape to an image, the resulting file is of mimetype 'image/svg+xml', when sending it to the server, the attachment is going to go through _check_contents https://github.com/odoo/odoo/blob/d752abb24d9b25bb6d10e411961447c8c8e28bba/odoo/addons/base/models/ir_attachment.py#L364 and if the mimetype is "xml_like", it will check for views write rights, without what the mimetype will be forced to text/plain. But in web_editor, when computing the image src https://github.com/odoo/odoo/blob/b6392e2c7dbc8e1ece326e28a9698801142714b7/addons/web_editor/models/ir_attachment.py#L34 if the mimetype is not a supported image type, src will be False. Fix: --- Override of _writeShape to use canvas to convert the image from svg to png. opw-3672798 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168528 Forward-Port-Of: odoo/odoo#159497
With an IT Company setup but without the withholding module: - Set fiscal position to split payment - Set tax on product to SP type tax - Click send and print to generate XML Error: XML generation is blocked with message "Invoices must have exactly one VAT tax set per line" This occurs because the system find 2 VAT taxes, but only the positive one should count for the validation Ticket [link](https://www.odoo.com/web#model=project.task&id=3945046) opw-3945046 Forward-Port-Of: odoo
Original PR description
With an IT Company setup but without the withholding module: - Set fiscal position to split payment - Set tax on product to SP type tax - Click send and print to generate XML Error: XML generation is blocked with message "Invoices must have exactly one VAT tax set per line" This occurs because the system find 2 VAT taxes, but only the positive one should count for the validation Ticket [link](https://www.odoo.com/web#model=project.task&id=3945046) opw-3945046 Forward-Port-Of: odoo/odoo#166893
Steps to reproduce: - Install eCommerce and `l10n_be` (to get a second company) - Enable online payment in the settings - Go to the payment provider and duplicate it for belgium company - Publish the payment provider - Make an invoice for a customer - Send or generate the link - Open the link in incognito - Pay the invoice Issues: When we create the `temp_move` we don't provide the `company_id` as such we will go in the compute which will fail. https://github.com/odoo/odoo/blob/f1
Original PR description
Steps to reproduce: - Install eCommerce and `l10n_be` (to get a second company) - Enable online payment in the settings - Go to the payment provider and duplicate it for belgium company - Publish the…
Steps to reproduce: - Install eCommerce and `l10n_be` (to get a second company) - Enable online payment in the settings - Go to the payment provider and duplicate it for belgium company - Publish the payment provider - Make an invoice for a customer - Send or generate the link - Open the link in incognito - Pay the invoice Issues: When we create the `temp_move` we don't provide the `company_id` as such we will go in the compute which will fail. https://github.com/odoo/odoo/blob/f1d6ad2645fcc206b43454400e2c70d1d23a4ee3/addons/account/models/account_journal.py#L363 https://github.com/odoo/odoo/blob/17d85347f92d813704d3f8faef366166bbbaa730/addons/account/models/account_move.py#L693 In this line we call the `_accessible_branches` method on the belgium company as expected, in this method we use `self.env.companies` (default company) and we do an intersection with the current company (belgium). This results in an empty recordset for the company. Later in the stock we face this instruction which ends up in an empty recordset error as we have an ensure one at the beggining of `_get_violated_lock_dates`. https://github.com/odoo/odoo/blob/f1d6ad2645fcc206b43454400e2c70d1d23a4ee3/addons/account/models/account_move.py#L4394 https://github.com/odoo/odoo/blob/f1d6ad2645fcc206b43454400e2c70d1d23a4ee3/addons/account/models/company.py#L370 Website solve it by copying the `public_user` and affecting it to the desired company. https://github.com/odoo/odoo/blob/9079b7038754ca4fe547086d3fe8947a4bb6ddce/addons/website/models/res_company.py#L43-L57 A potential approach to solve this problem could be to allow `public_user` to access all of the companies (possibly problematic w.r.t. security). The solution chosen for this PR is a local solution as it makes more sense for stable. opw-3859791 Forward-Port-Of: odoo/odoo#162058
KBC has been added to Mollie. Cards support refund. Refund is now checked based on payment method refund support, not brand. "Cleared" mapping has been added to done state in PayPal in order to properly support echeck. opw-3880431 Forward-Port-Of: odoo/odoo#162837
Original PR description
KBC has been added to Mollie. Cards support refund. Refund is now checked based on payment method refund support, not brand. "Cleared" mapping has been added to done state in PayPal in order to properly support echeck. opw-3880431 Forward-Port-Of: odoo/odoo#162837
Steps to reproduce: - Have two separate warehouses A & B - Enable 3-step delivery on warehouse A - Enable 'Resupply from warehouse A' in warehouse B - Set a product using that resupply route and trigger its ressuply (e.g. through a reordering rule) Issue: An error message pops up indicating that there are no rules could be found to resupply A/Output. Following the pull&push refactor in #156437, we changed the way the default 3-step delivery would work (with now a mix of pull & push ru
Original PR description
Steps to reproduce: - Have two separate warehouses A & B - Enable 3-step delivery on warehouse A - Enable 'Resupply from warehouse A' in warehouse B - Set a product using that resupply route and trigger its ressuply (e.g. through a reordering rule) Issue: An error message pops up indicating that there are no rules could be found to resupply A/Output. Following the pull&push refactor in #156437, we changed the way the default 3-step delivery would work (with now a mix of pull & push rules). This means that there are no longer any default pull rules to resupply the Output location. To avoid this, we add the missing rule, pulling from Stock -> Output, using the standard delivery rules for the eventual pack operation. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#164377
opw-3863382 Forward-Port-Of: odoo/odoo#168755
Original PR description
opw-3863382 Forward-Port-Of: odoo/odoo#168755
Steps to reproduce: - Install "Time Off" and `l10n_be` - "Time Off" -> "Reporting" -> "by Type" - Unselect the company with the time off Issues: All the time off will be shown, company selection will not be taken into account. This is due to a missing security rules. opw-3954393 Forward-Port-Of: odoo/odoo#168516
Original PR description
Steps to reproduce: - Install "Time Off" and `l10n_be` - "Time Off" -> "Reporting" -> "by Type" - Unselect the company with the time off Issues: All the time off will be shown, company selection will not be taken into account. This is due to a missing security rules. opw-3954393 Forward-Port-Of: odoo/odoo#168516
Currently administrators for the POS app don't see margins and costs when the setting is disabled. The setting should only affect simple POS users and admins should always see the margins and costs. Steps to reproduce: ------------------- * Connect as admin * Go to the current user settings and make sure he is a POS administrator * Go the **Point of Sale** App * Go to setting, make sure **Margins and Costs** is disabled * Open a shop session * Select the information icon on a product
Original PR description
Currently administrators for the POS app don't see margins and costs when the setting is disabled. The setting should only affect simple POS users and admins should always see the margins and costs. Steps to reproduce: ------------------- * Connect as admin * Go to the current user settings and make sure he is a POS administrator * Go the **Point of Sale** App * Go to setting, make sure **Margins and Costs** is disabled * Open a shop session * Select the information icon on a product > Margins and Costs are not shown Why the fix: ------------ Data loaded is different since using the new relational model https://github.com/odoo/odoo/commit/28b7d698be8255f933ba5314e44e7059746fc234 opw-3897694 Forward-Port-Of: odoo/odoo#168672 Forward-Port-Of: odoo/odoo#166294
Prior to this PR, colors of "Today" were inconsistent depending on the view in calendar, sometimes red, sometimes purple. There was also a contrast issue when switching to dark mode. This PR adjusts the color of "Today" to maintain color consistency and to provide contrast in bright mode and dark mode. task-3754159 Part of task-3575827 | Before | After | |--------|--------| |  |  |  | |  |  | |  |  | |  |  | --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168355 Forward-Port-Of: odoo/odoo#154856
This only adds an id to the div containing the date in the order receipt so that it can be xpath easily in the enterprise PR. Enterprise PR: odoo/enterprise#63966 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168270
Original PR description
This only adds an id to the div containing the date in the order receipt so that it can be xpath easily in the enterprise PR. Enterprise PR: odoo/enterprise#63966 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168270
Current behavior: If a product has some variants you shouldn't be able to change his type to combo Steps to reproduce: - Create a product, and add some variants to it - Try to change his type to "Combo" - You shouldn't be able to do it, as combo product shouldn't have variants opw-3961311 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168336 Forward-Port-Of: odoo/odoo#168242
Original PR description
Current behavior: If a product has some variants you shouldn't be able to change his type to combo Steps to reproduce: - Create a product, and add some variants to it - Try to change his type to "Combo" - You shouldn't be able to do it, as combo product shouldn't have variants opw-3961311 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168336 Forward-Port-Of: odoo/odoo#168242
Before, we could not send any simplified invoice for Bizkaia, because it would give error B4_2000026: "Las Claves indicadas no son compatibles". En las validaciones dice que "Las claves 51 y 52 sólo son compatibles entre sí" But normally we send 01 and 52 in case of a simplified invoice. By removing the 52 however, we see that we can send the simplified invoice. Also, elsewhere in the XML, it is already clearly indicated that the invoice is simplified anyways. So, the simple fix for n
Original PR description
Before, we could not send any simplified invoice for Bizkaia, because it would give error B4_2000026: "Las Claves indicadas no son compatibles". En las validaciones dice que "Las claves 51 y 52 sólo son compatibles entre sí" But normally we send 01 and 52 in case of a simplified invoice. By removing the 52 however, we see that we can send the simplified invoice. Also, elsewhere in the XML, it is already clearly indicated that the invoice is simplified anyways. So, the simple fix for now is to remove the 52 key if the agency is Bizkaia opw-3938800 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#167566
Since early June 2024, on new individual accounts, Stripe validates Indian mandate parameters even if they are irrelevant (e.g. mandates are not needed and won't be created). This prevents payments not compatible with Indian mandates from being made, like those made with MXN currency. With this fix, mandate parameters will be sent only if the payment's currency is supported by Indian mandates. Note: Accounts created before June 2024 or accounts linked to a platform created before June 2024
Original PR description
Since early June 2024, on new individual accounts, Stripe validates Indian mandate parameters even if they are irrelevant (e.g. mandates are not needed and won't be created). This prevents payments not compatible with Indian mandates from being made, like those made with MXN currency. With this fix, mandate parameters will be sent only if the payment's currency is supported by Indian mandates. Note: Accounts created before June 2024 or accounts linked to a platform created before June 2024 that have already used mandates are not affected by this bug. opw-3946505 Forward-Port-Of: odoo/odoo#168760 Forward-Port-Of: odoo/odoo#168465
Steps to reproduce ================== - Install mrp - Enable debug mode - Go to products - Open the "Acoustics Bloc Screens" form - Click on the "Forecasted" smart button - Click on the debug icon > "View access rights" A traceback occurs when evaluating the domain Cause of the issue ================== ir.actions.client is supposed to be a string but is an id in this case. `ir.model.search([["model", "=", action.res_model]])` returns nothing. [0] --- [0]: https://gith
Original PR description
Steps to reproduce ================== - Install mrp - Enable debug mode - Go to products - Open the "Acoustics Bloc Screens" form - Click on the "Forecasted" smart button - Click on the debug icon > "View access rights" A traceback occurs when evaluating the domain Cause of the issue ================== ir.actions.client is supposed to be a string but is an id in this case. `ir.model.search([["model", "=", action.res_model]])` returns nothing. [0] --- [0]: https://github.com/odoo/odoo/blob/c07181b20bf4f06b783136ffdb3b7a304be6b136/addons/web/static/src/webclient/actions/debug_items.js#L147 opw-3955762 Forward-Port-Of: odoo/odoo#168498
The field is translatable, but the default value wasn't being translated so new projects' tasks labels were always defaulting to English regardless of language. opw-3976888 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168567 Forward-Port-Of: odoo/odoo#168482
Original PR description
The field is translatable, but the default value wasn't being translated so new projects' tasks labels were always defaulting to English regardless of language. opw-3976888 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168567 Forward-Port-Of: odoo/odoo#168482
This traceback arises when the user tries to remove the Batch Limit value and test the imported file. To reproduce this issue: 1) Import a file with large data in any module 2) You see the Batch limit at the left side pannel 3) Remove the default "Batch Limit" value 4) Test the file 5) A traceback will encountered Error:- ``` TypeError: '<' not supported between instances of 'int' and 'str' ``` when the user removes the default batch limit its value will be an empty string.
Original PR description
This traceback arises when the user tries to remove the Batch Limit value and test the imported file. To reproduce this issue: 1) Import a file with large data in any module 2) You see the Batch…
This traceback arises when the user tries to remove the Batch Limit value and test the imported file.
To reproduce this issue:
1) Import a file with large data in any module
2) You see the Batch limit at the left side pannel
3) Remove the default "Batch Limit" value
4) Test the file
5) A traceback will encountered
Error:-
```
TypeError: '<' not supported between instances of 'int' and 'str'
```
when the user removes the default batch limit its value will be an empty string.
You can see in [1] that parseFloat('') is "NaN" so it directly assigns the limit as the value which is an empty string.
[1]
https://github.com/odoo/odoo/blob/2c40a55232fb501dd70b64f7ddbdc4244f365139/addons/base_import/static/src/import_data_sidepanel/import_data_sidepanel.js#L34-L36
which leads to a traceback when a comparison is done between int and str.
https://github.com/odoo/odoo/blob/106c343027e3bab1c94c414f30e914cf673cceec/odoo/models.py#L1318-L1319
After applying this commit will resolve the issue of getting an int value instead of a str.
sentry-5298904064
Forward-Port-Of: odoo/odoo#167323Before this PR, some bus subscription tests were occasionally failing. These tests open Discuss and assert that bus subscriptions are correctly handled in different scenarios, such as joining/leaving a channel. To achieve this, they use the `waitForChannel` helper. Sometimes, the subscription is made before calling `waitForChannel`, which causes the test to fail. This PR replaces the `waitForChannel` method by adding a step when `bus_service.addChannel` is called. Since this setup can b
Original PR description
Before this PR, some bus subscription tests were occasionally failing. These tests open Discuss and assert that bus subscriptions are correctly handled in different scenarios, such as joining/leaving a channel. To achieve this, they use the `waitForChannel` helper. Sometimes, the subscription is made before calling `waitForChannel`, which causes the test to fail. This PR replaces the `waitForChannel` method by adding a step when `bus_service.addChannel` is called. Since this setup can be done before opening Discuss, we ensure that the subscription is not missed. fixes runbot-61294,65319,61969 Forward-Port-Of: odoo/odoo#168438
This commit implements two changes to prevent search engines from crawling and indexing content on websites marked as neutralized: - Robots.txt update: The robots.txt field in the website database is updated with a rule disallowing all crawling (User-agent: * \n Disallow: /). - Robots meta tag injection: An XPath expression is used to inject a robots meta tag with content="noindex, nofollow" within the web.neutralize_banner view's <head> section. These combined changes ensure a strong sig
Original PR description
This commit implements two changes to prevent search engines from crawling and indexing content on websites marked as neutralized: - Robots.txt update: The robots.txt field in the website database is updated with a rule disallowing all crawling (User-agent: * \n Disallow: /). - Robots meta tag injection: An XPath expression is used to inject a robots meta tag with content="noindex, nofollow" within the web.neutralize_banner view's <head> section. These combined changes ensure a strong signal to search engines to not index neutralized databases. task-3895772 Forward-Port-Of: odoo/odoo#167963
Current Behaviour: - Currently, if the internet is slow and the user tries to open any action, which action target='new,' it takes time to open the action form in the browser, if the user clicks multiple times during this loading process, multiple instances of the same action will be displayed to the user. Steps to produce: - Open CRM and navigate to the activity view of CRM. - Select throttling as 'Slow 3G' in your browser network setting. - Now click multiple times on any scheduled act
Original PR description
Current Behaviour: - Currently, if the internet is slow and the user tries to open any action, which action target='new,' it takes time to open the action form in the browser, if the user clicks multiple times during this loading process, multiple instances of the same action will be displayed to the user. Steps to produce: - Open CRM and navigate to the activity view of CRM. - Select throttling as 'Slow 3G' in your browser network setting. - Now click multiple times on any scheduled activity to open an action. Expected Behaviour: - Only open the dialog for the last action requested when there are multiple actions requested with target='new'. Task-3750720 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166488 Forward-Port-Of: odoo/odoo#159236
Modules related to multiple countries are historically named without `l10n_` prefix. Also, it is not always linked to the country but just used for the `auto_install` feature like in `account_reports_cash_basis` for instance, where we don't want to make it sound like a localization feature. Forward-Port-Of: odoo/odoo#163730
Original PR description
Modules related to multiple countries are historically named without `l10n_` prefix. Also, it is not always linked to the country but just used for the `auto_install` feature like in `account_reports_cash_basis` for instance, where we don't want to make it sound like a localization feature. Forward-Port-Of: odoo/odoo#163730
When trying to reconcile to debit or credit lines with different currencies, we get a singleton error on `wizard.reco_currency_id` in `_compute_is_write_off_required` opw-3833477 Forward-Port-Of: odoo/enterprise#64418 Forward-Port-Of: odoo/enterprise#64011
Original PR description
When trying to reconcile to debit or credit lines with different currencies, we get a singleton error on `wizard.reco_currency_id` in `_compute_is_write_off_required` opw-3833477 Forward-Port-Of: odoo/enterprise#64418 Forward-Port-Of: odoo/enterprise#64011
[ADD] l10n_us_account: Auto load the localization pack and related reports automatically Problem: Users, especially newer ones, don't have the experience; or don't know how to install modules manually to their database. This will create the incorrect idea that Odoo doesn't fulfill the minimum requirements to operate in the US. - Examples of those uninstalled requirements are ABA routing for payments, correct layout for checks, 1099 reports, and Avatax for tax calculation. Desired behav
Original PR description
[ADD] l10n_us_account: Auto load the localization pack and related reports automatically Problem: Users, especially newer ones, don't have the experience; or don't know how to install modules…
[ADD] l10n_us_account: Auto load the localization pack and related reports automatically Problem: Users, especially newer ones, don't have the experience; or don't know how to install modules manually to their database. This will create the incorrect idea that Odoo doesn't fulfill the minimum requirements to operate in the US. - Examples of those uninstalled requirements are ABA routing for payments, correct layout for checks, 1099 reports, and Avatax for tax calculation. Desired behavior:- Auto load the following when creating odoo US database - US Accounting: l10n_us_account - United States Localization: l10n_us - US Accounting Reports: l10n_us_reports - 1099 Reporting: l10n_us_1099 - US Checks Layout: l10n_us_check_printing - NACHA Payments: l10n_us_payment_nacha - Avatax: account_avatax Solution: Create new module l10n_us_account to separate the accounting dependent stuff and auto load it and l10n_us which is going to load the mentioned packages above for US-db. Task-3865230 Community PR: https://github.com/odoo/odoo/pull/161709 Forward-Port-Of: odoo/enterprise#60644
In `pos_restaurant`, the user will see the upcoming appointment for each table underneath it. The text should be styled differently based on the situation. Late arrivals should be shown in red; future appointments should be shown with decreased opacity. During the refactoring in bb06fde, a bug was introduced that made the time computation invalid. This commit addresses the issue. Task: 3978801 Forward-Port-Of: odoo/enterprise#64218
Original PR description
In `pos_restaurant`, the user will see the upcoming appointment for each table underneath it. The text should be styled differently based on the situation. Late arrivals should be shown in red; future appointments should be shown with decreased opacity. During the refactoring in bb06fde, a bug was introduced that made the time computation invalid. This commit addresses the issue. Task: 3978801 Forward-Port-Of: odoo/enterprise#64218
When a new contract is created (or if we change the vehicle_id on an existing one, it'll take the default value on the contract, or the previous contract value as default values for the cost Forward-Port-Of: odoo/enterprise#64026
Original PR description
When a new contract is created (or if we change the vehicle_id on an existing one, it'll take the default value on the contract, or the previous contract value as default values for the cost Forward-Port-Of: odoo/enterprise#64026
The chilean law requires the date to be on top of the receipt. This is now the case. Community PR: odoo/odoo#168270 Forward-Port-Of: odoo/enterprise#63966
Original PR description
The chilean law requires the date to be on top of the receipt. This is now the case. Community PR: odoo/odoo#168270 Forward-Port-Of: odoo/enterprise#63966
Commit 36b238b934f1b7e4ddf1dfd6089d36ea0b8ac7eb introduced a new transparent way to save payment methods on a subscription. This new checkbox causes various bugs in the payment flow when paying an invoice linked to a subscription: - Stripe inline form was not updated when the save my payment method was checked; - Adyen implementation skips the override of `_initiatePaymentFlow` in `sale_subscription` to update the transaction route; - The token inline form is only shown for Demo and Raz
Original PR description
Commit 36b238b934f1b7e4ddf1dfd6089d36ea0b8ac7eb introduced a new transparent way to save payment methods on a subscription. This new checkbox causes various bugs in the payment flow when paying an invoice linked to a subscription: - Stripe inline form was not updated when the save my payment method was checked; - Adyen implementation skips the override of `_initiatePaymentFlow` in `sale_subscription` to update the transaction route; - The token inline form is only shown for Demo and Razorpay; - The checkbox of the automated payment sought may be that of another payment method. This commit addresses all the previously mentioned issues. opw-3893592 opw-3946899 Forward-Port-Of: odoo/enterprise#63788
Purpose ======= Do not crash when grouping by a property, instead we want to disable the group by like it has been done for the gantt view. Clean a test about the group by in the gantt view. Task-3876726 Forward-Port-Of: odoo/enterprise#64354 Forward-Port-Of: odoo/enterprise#62551
Original PR description
Purpose ======= Do not crash when grouping by a property, instead we want to disable the group by like it has been done for the gantt view. Clean a test about the group by in the gantt view. Task-3876726 Forward-Port-Of: odoo/enterprise#64354 Forward-Port-Of: odoo/enterprise#62551
plan_id coming from '/shop/cart/update' is always a string so plan is never found using browse fix is to cast the plan_id before browsing opw-3921644 Forward-Port-Of: odoo/enterprise#64021
Original PR description
plan_id coming from '/shop/cart/update' is always a string so plan is never found using browse fix is to cast the plan_id before browsing opw-3921644 Forward-Port-Of: odoo/enterprise#64021
By default, tables automatically adjust their width to accommodate the content of their cells, That causes table row to grow in size and make "X" button invisible. Here I'm constraining table layout so it doesn't matter how long the content of columns is [Reproduce] - Install documents - Add tag with a very long name - Go to all Documents, Select a document, Add the tag on a doc - BUG: "X" button is not visible* opw-3937326 BEFORE / AFTER https://github.com/odoo/enterprise/assets
Original PR description
By default, tables automatically adjust their width to accommodate the content of their cells, That causes table row to grow in size and make "X" button invisible. Here I'm constraining table layout so it doesn't matter how long the content of columns is [Reproduce] - Install documents - Add tag with a very long name - Go to all Documents, Select a document, Add the tag on a doc - BUG: "X" button is not visible* opw-3937326 BEFORE / AFTER https://github.com/odoo/enterprise/assets/33809926/5f2fc861-cd68-4478-8b8b-b8843b7d4944 Forward-Port-Of: odoo/enterprise#63279
Steps to reproduce: - Install Planning - Click on Schedule -> By Resource - Select multiple slots without a resource - Select a resource to add Issues: A traceback is shown because this line in the write function wasn't coded to work with recordset. https://github.com/odoo/enterprise/blob/70f0ce78ac5f976f93abd0b9ee239a998d6d7445/planning/models/planning.py#L803-L806 opw-3948517 Forward-Port-Of: odoo/enterprise#64217 Forward-Port-Of: odoo/enterprise#63450
Original PR description
Steps to reproduce: - Install Planning - Click on Schedule -> By Resource - Select multiple slots without a resource - Select a resource to add Issues: A traceback is shown because this line in the write function wasn't coded to work with recordset. https://github.com/odoo/enterprise/blob/70f0ce78ac5f976f93abd0b9ee239a998d6d7445/planning/models/planning.py#L803-L806 opw-3948517 Forward-Port-Of: odoo/enterprise#64217 Forward-Port-Of: odoo/enterprise#63450
Steps to reproduce ================== - Enable debug mode - Go to accounting app - reporting - balance sheet - three wheels on top right - click on the icon to show new columns -> Invalid portal target Cause of the issue ================== The uniqueRendererClass is used to target a portal for the dropdown, but that class isn't applied in the AccountReportListRenderer. https://github.com/odoo/odoo/pull/160566 opw-3974195 Forward-Port-Of: odoo/enterprise#64316
Original PR description
Steps to reproduce ================== - Enable debug mode - Go to accounting app - reporting - balance sheet - three wheels on top right - click on the icon to show new columns -> Invalid portal target Cause of the issue ================== The uniqueRendererClass is used to target a portal for the dropdown, but that class isn't applied in the AccountReportListRenderer. https://github.com/odoo/odoo/pull/160566 opw-3974195 Forward-Port-Of: odoo/enterprise#64316
Fix display and functionality of tax type filter - Corrected the display of dropdown items to show tax type names instead of object references. - Updated the `onSelected` event handler to ensure the tax filter is correctly applied when a dropdown item is selected. opw-3976746 Forward-Port-Of: odoo/enterprise#64252
Original PR description
Fix display and functionality of tax type filter - Corrected the display of dropdown items to show tax type names instead of object references. - Updated the `onSelected` event handler to ensure the tax filter is correctly applied when a dropdown item is selected. opw-3976746 Forward-Port-Of: odoo/enterprise#64252