Friday, June 14, 2024
18 changes · 17.0
Resolved issues and error corrections
This fix prevents spreadsheets from crashing when a date filter contains only empty or false values. Users can now group spreadsheet data with these filters without encountering an error, improving reliability for reports and dashboards.
Original PR description
Before this fix, when grouping by a date filter that only had "false" value, the global filter matching was causing a traceback trying to split a non existant month/year value. This commit fixes this behavior by checking for "false" in date filter and setting the matching filter to "undefied" OPW: 3776544 OPW: 3952358 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where creating a regular invoice after a down payment could incorrectly change the down payment line description. This keeps invoice references clear and prevents confusion when reviewing sales documents.
Original PR description
Steps to reproduce: -create sales order for some product. -create invoice for down payment. -create regular invoice. Issue: -Description of down payment get modified after creating regular invoice. Cause: -Credit note is also taken in consideration in modifying name of invoices. Fix: -Applied filter to only take customer invoice opw-3904918 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Peppol warning shown on partner records has been corrected so it no longer checks the partner's bank account. This helps users focus on the relevant recipient bank information during invoice send and print workflows, reducing confusion.
Original PR description
There was some miscommunication about the warning message in https://github.com/odoo/odoo/commit/2384a059e25f66117326d9bfde1e40b2dd493962 The warning on the partner should not check the bank account. What needs to be checked is the Recipient bank on the invoice, the warning should be visible in send & print. It is ok to add it in later versions where it is easier to add more warnings. Part of: task-3989435 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Timesheet revenue reporting now uses tax-excluded sales amounts for fixed-price products. This prevents revenue figures from being overstated when sales orders include taxes, giving managers more accurate project profitability reports.
Original PR description
Create a [TEST] Product with: - Invoicing Policy: Prepaid/Fixed Price product - Create on Order: Project & Task - Unit of Measure: Days Create a Sales Order with [TEST] prod and a tax Add a timesheet line on the recorded hours Go in Timesheet > Reporting > By Project Add the measure Timesheet Revenues Issue: Revenues are tax included, but should be tax excluded This occurs because we are computing the revenue using the sale order line price total opw-3864227
Fixes an issue where part of the live chat request process could run repeatedly by mistake. This helps ensure chat invitations are handled as intended, reducing the chance of duplicate or incorrect behavior for website visitors.
Original PR description
Some part of the `action_send_chat_request` method has been wrongly indented in [1]. As a result, this block is executed as part of a loop while it should not. This PR put the block of code out of the loop. [1]: https://github.com/odoo/odoo/pull/129770
The mobile emoji picker in Discuss now keeps horizontal scrolling within the category tabs instead of making the whole picker scroll sideways. This makes choosing emojis on small screens cleaner and easier to use.
Original PR description
**Before this PR:** When you open Emoji picker in discuss mobile view and screen size is enough small so that the categories tab overflows and shows horizontal scroll. And as it's parent div `o-mail-PickerContent-emojiPicker` doesn't have any fixed width set it's width also increases in response to the categories tab. Which will display the horizontal scroll on the whole parent div instead of the categories tab.  **After this PR:** This commit sets max-width 100% to it's `o-mail-PickerContent-emojiPicker` so, that the scrolling would only take effect on the categories tab.  **task**-[3950434](https://www.odoo.com/odoo/my-tasks/3950434?debug=&cids=2) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The change prevents conflicts when the same company registers multiple demo electronic invoicing services. This helps users complete demo Peppol and Italian electronic invoicing setup without being blocked by duplicate identifiers.
Original PR description
step:
-install l10n_it and account_peppol without demo data -setup a peppol demo account
-give your company a codigo fiscal
-settings > Italian Electronic Invoicing > check "Allow Odoo to process invoices"
-> constraint
This happens because when creating demo edi, the id_client is set as "demo{company_id}", but the id_client must be unique so when registering two edi services for the same company, there is a collision.
After this PR, we avoid the collision by adding the proxy_type to the demo id_client.
opw-3983974
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe Partner Ledger report had a confusing "hide 0 lines" filter option that didn't work properly and didn't make logical sense for the report. This fix removes the option from the default view by setting it to "never," ensuring users see all partner transactions clearly without unnecessary filtering options.
Original PR description
Issue: It is possible to select the option "hide 0 lines" in the partner ledger. For one, it does not make sense as if a partner appears, it means that there are transactions. Even if the balance is set to 0, we should display the transactions. And then, the option simply does not work in partner ledger. Solution: Put as a default value "never" so it does not show up. opw-3981939
This fix corrects an issue where VAT labels were appearing in follow-up reports even when customers didn't have a VAT number on file. The change ensures that the VAT label only displays when a VAT value actually exists, preventing confusing blank fields in customer communications.
Original PR description
Problem: When enhancing reports for 16.4 compatibility, a VAT label was added to the followup report. This label will display even when no `vat` value exists. Purpose: Revert line similar to previous versions where if a `vat` value is present, then show the value. Otherwise, show nothing. Steps to Reproduce: 1. Have a contact with no `vat` value 2. Create an invoice for that contact 3. Send a followup report to that contact. opw-3970003
Miscellaneous changes
- Create a partner, configure it correctly to generate a Peppol BIS xml (Peppol bis3 edi format, fill in peppol eas & peppol endpoint). For example, configure Deco Addict - Create a contact for that partner (e.g. could use Deco Addict, Addison Olson) - Create an invoice for that contact - Open Send & print -> the option to generate the xml file is not visible This is because `ubl_cii_format` field is defined on the parent partner and so we don't have a value for it in child partners. op
Original PR description
- Create a partner, configure it correctly to generate a Peppol BIS xml (Peppol bis3 edi format, fill in peppol eas & peppol endpoint). For example, configure Deco Addict - Create a contact for that partner (e.g. could use Deco Addict, Addison Olson) - Create an invoice for that contact - Open Send & print -> the option to generate the xml file is not visible This is because `ubl_cii_format` field is defined on the parent partner and so we don't have a value for it in child partners. opw-3958830 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169469 Forward-Port-Of: odoo/odoo#169243
**Description of the issue/feature this PR addresses:** Before this commit the field can be wrongly computed in multi user environment. @oco-odoo --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166837
Original PR description
**Description of the issue/feature this PR addresses:** Before this commit the field can be wrongly computed in multi user environment. @oco-odoo --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166837
Backport of odoo/odoo@7aca17cf6d6f8487ebba615bc4f2e6bde5e0c4a1 This commit force the datetime_picker's cells to have the same aspect ratio without any specific width or height on small screen. So the datetime_picker can take the all width space available and be always responsive as each cells share the same width and the same height to respect the aspect ratio. We backport this commit so on small screen the date picker has a smaller width and doesn't overflow anymore. Steps to reproduc
Original PR description
Backport of odoo/odoo@7aca17cf6d6f8487ebba615bc4f2e6bde5e0c4a1 This commit force the datetime_picker's cells to have the same aspect ratio without any specific width or height on small screen. So the datetime_picker can take the all width space available and be always responsive as each cells share the same width and the same height to respect the aspect ratio. We backport this commit so on small screen the date picker has a smaller width and doesn't overflow anymore. Steps to reproduce (Small screen/Mobile): * Open CRM * Click on a lead * Click on Expected Closing => Bug the date picker overflow on the left opw-3957058 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169228
Forward-Port-Of: odoo/odoo#169403 Forward-Port-Of: odoo/odoo#168839
Original PR description
Forward-Port-Of: odoo/odoo#169403 Forward-Port-Of: odoo/odoo#168839
3aa3a24c introduced a regression since textbbox is not available in Pillow < 8.0. Since focal has a lower version, this is breaking on odoosh and in PureFocal builds. Fixing it by making the call conditional. closes #162256 Forward-Port-Of: odoo/odoo#168683 Forward-Port-Of: odoo/odoo#168119
Original PR description
3aa3a24c introduced a regression since textbbox is not available in Pillow < 8.0. Since focal has a lower version, this is breaking on odoosh and in PureFocal builds. Fixing it by making the call conditional. closes #162256 Forward-Port-Of: odoo/odoo#168683 Forward-Port-Of: odoo/odoo#168119
Before this commit, clicking on absence button of any department shows all the employees of all the department instead of the absent employees of that department. This commit brings, the list view of absent employees of that department after clicking on absence button of any department. task-3919504 Forward-Port-Of: odoo/odoo#165560
Original PR description
Before this commit, clicking on absence button of any department shows all the employees of all the department instead of the absent employees of that department. This commit brings, the list view of absent employees of that department after clicking on absence button of any department. task-3919504 Forward-Port-Of: odoo/odoo#165560
Currently, a traceback is occurring when the user deletes the master data of project name 'internal' and tries to install another module. To reproduce this issue:- 1) Install `project_timesheet_holidays` without demo data 2) Delete all `My Timesheets` data from `Timesheets` 3) Delete all the `My tasks` from the project after removing the default filters 4) Now delete the `internal` task stage from project/configuration/task stages 5) Try to install the `MRP` module Error:- ```
Original PR description
Currently, a traceback is occurring when the user deletes the master data of project name 'internal' and tries to install another module. To reproduce this issue:- 1) Install…
Currently, a traceback is occurring when the user deletes the master data of project name 'internal' and tries to install another module. To reproduce this issue:- 1) Install `project_timesheet_holidays` without demo data 2) Delete all `My Timesheets` data from `Timesheets` 3) Delete all the `My tasks` from the project after removing the default filters 4) Now delete the `internal` task stage from project/configuration/task stages 5) Try to install the `MRP` module Error:- ``` ValueError: External ID not found in the system: hr_timesheet.internal_project_default_stage ``` When the user installs another module after deleting the project `internal`, a traceback trigger as the `external_id` is referenced to create a project for master data. https://github.com/odoo/odoo/blob/5a26d5173cc54bcbed18a251854c5e725c2ba3b4/addons/project_timesheet_holidays/models/res_company.py#L15 After applying this commit will resolve this issue. sentry-5344711392 Forward-Port-Of: odoo/odoo#166474
This commit fixes an issue introduced in 63285ce when merging `slide.slide.link` and `slide.slide.resource`. When a user would edit multiple resources at once, the compute done for the name would crash. This is caused by a read done on `self` instead a for loop, which causes a crash if `self` is a recordset. To fix this, the read on self is replaced by resource which would be a record inside of the recordset. task-3988760 --- I confirm I have signed the CLA and read the PR guidelin
Original PR description
This commit fixes an issue introduced in 63285ce when merging `slide.slide.link` and `slide.slide.resource`. When a user would edit multiple resources at once, the compute done for the name would crash. This is caused by a read done on `self` instead a for loop, which causes a crash if `self` is a recordset. To fix this, the read on self is replaced by resource which would be a record inside of the recordset. task-3988760 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169172
Previously, if a product had a vendor set with some minimum quantity, it wouldn't be displayed in the BoM Overview if the line quantity didn't match this minimum. This meant that if that vendor was the only one set for this product, then no resupply route would be displayed and no lead time would be found. This is an issue, as it's inconsistent with how it would actually work when creating a MO from that BoM. (i.e. create the PO to that vendor, but with its default price). Instead, when no s
Original PR description
Previously, if a product had a vendor set with some minimum quantity, it wouldn't be displayed in the BoM Overview if the line quantity didn't match this minimum. This meant that if that vendor was the only one set for this product, then no resupply route would be displayed and no lead time would be found. This is an issue, as it's inconsistent with how it would actually work when creating a MO from that BoM. (i.e. create the PO to that vendor, but with its default price). Instead, when no supplier is found for the right quantity, we display the first suitable vendor anyway, but with a different color. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168746 Forward-Port-Of: odoo/odoo#165573