Friday, June 14, 2024
3 changes
1 change
Resolved issues and error corrections
Uploading an empty XML file to a customer invoice no longer creates an unnecessary error report. The system now records this expected issue as a warning, reducing monitoring noise without changing the user workflow.
Original PR description
Currently, an exception is occurring when the user tries to upload an empty XML file in customer invoices.
Steps to produce:
1) Install `Accounting`
2) Try to upload an empty `XML` file in customer invoices.
3) In the backend a logger exception is encountered.
Error:-
```
ValueError: can only parse strings
File "addons/account/models/ir_attachment.py", line 38, in _decode_edi_xml
xml_tree = etree.fromstring(content)
File "src/lxml/etree.pyx", line 3255, in lxml.etree.fromstring
File "src/lxml/parser.pxi", line 1912, in lxml.etree._parseMemoryDocument
```
This causes noise in the sentry, So changing the exception to a warning can resolve this issue.
https://github.com/odoo/odoo/blob/14755d586a695df4c350f29e0c99c876c5811e4f/addons/account/models/ir_attachment.py#L40
sentry-4855416823
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr2 changes
Resolved issues and error corrections
The Partner Ledger report had a confusing "hide 0 lines" filter option that didn't work properly and didn't make logical sense for the report. This fix removes the option from the default view by setting it to "never," ensuring users see all partner transactions clearly without unnecessary filtering options.
Original PR description
Issue: It is possible to select the option "hide 0 lines" in the partner ledger. For one, it does not make sense as if a partner appears, it means that there are transactions. Even if the balance is set to 0, we should display the transactions. And then, the option simply does not work in partner ledger. Solution: Put as a default value "never" so it does not show up. opw-3981939
This fix corrects an issue where VAT labels were appearing in follow-up reports even when customers didn't have a VAT number on file. The change ensures that the VAT label only displays when a VAT value actually exists, preventing confusing blank fields in customer communications.
Original PR description
Problem: When enhancing reports for 16.4 compatibility, a VAT label was added to the followup report. This label will display even when no `vat` value exists. Purpose: Revert line similar to previous versions where if a `vat` value is present, then show the value. Otherwise, show nothing. Steps to Reproduce: 1. Have a contact with no `vat` value 2. Create an invoice for that contact 3. Send a followup report to that contact. opw-3970003