Saturday, June 15, 2024
13 changes · saas-17.1
Resolved issues and error corrections
This fixes live chat so visitors do not see an extra automated welcome message after an operator has already started the conversation. It keeps chat requests cleaner and prevents customers from receiving redundant greetings when moving between website pages.
Original PR description
Live chat displays a welcome message when the visitor opens the chat. However, when an operator sends a chat request, the welcome message is not necessary as the first operator message will act as a…
Live chat displays a welcome message when the visitor opens the chat. However, when an operator sends a chat request, the welcome message is not necessary as the first operator message will act as a welcome message. Before [1], chat requests data were inserted directly into the JS and the information about who opend the chat was given. However, the data is now fetched from the server and this information is missing. This PR adds this information so that the client can decide whether to display this message. Steps to reproduce this issue: - Go on the website as a visitor - Send a chat request from admin, send a first message - Navigate to another page with the visitor - The welcome message appears in addition to the operator message. [1]: https://github.com/odoo/odoo/pull/142155 Before:  After: 
Miscellaneous changes
- Create a partner, configure it correctly to generate a Peppol BIS xml (Peppol bis3 edi format, fill in peppol eas & peppol endpoint). For example, configure Deco Addict - Create a contact for that partner (e.g. could use Deco Addict, Addison Olson) - Create an invoice for that contact - Open Send & print -> the option to generate the xml file is not visible This is because `ubl_cii_format` field is defined on the parent partner and so we don't have a value for it in child partners. op
Original PR description
- Create a partner, configure it correctly to generate a Peppol BIS xml (Peppol bis3 edi format, fill in peppol eas & peppol endpoint). For example, configure Deco Addict - Create a contact for that partner (e.g. could use Deco Addict, Addison Olson) - Create an invoice for that contact - Open Send & print -> the option to generate the xml file is not visible This is because `ubl_cii_format` field is defined on the parent partner and so we don't have a value for it in child partners. opw-3958830 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169520 Forward-Port-Of: odoo/odoo#169243
There was some miscommunication about the warning message in https://github.com/odoo/odoo/commit/2384a059e25f66117326d9bfde1e40b2dd493962 The warning on the partner should not check the bank account. What needs to be checked is the Recipient bank on the invoice, the warning should be visible in send & print. It is ok to add it in later versions where it is easier to add more warnings. Part of: task-3989435 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.c
Original PR description
There was some miscommunication about the warning message in https://github.com/odoo/odoo/commit/2384a059e25f66117326d9bfde1e40b2dd493962 The warning on the partner should not check the bank account. What needs to be checked is the Recipient bank on the invoice, the warning should be visible in send & print. It is ok to add it in later versions where it is easier to add more warnings. Part of: task-3989435 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169438
Create a [TEST] Product with: - Invoicing Policy: Prepaid/Fixed Price product - Create on Order: Project & Task - Unit of Measure: Days Create a Sales Order with [TEST] prod and a tax Add a timesheet line on the recorded hours Go in Timesheet > Reporting > By Project Add the measure Timesheet Revenues Issue: Revenues are tax included, but should be tax excluded This occurs because we are computing the revenue using the sale order line price total opw-3864227 Forward-Port-Of: od
Original PR description
Create a [TEST] Product with: - Invoicing Policy: Prepaid/Fixed Price product - Create on Order: Project & Task - Unit of Measure: Days Create a Sales Order with [TEST] prod and a tax Add a timesheet line on the recorded hours Go in Timesheet > Reporting > By Project Add the measure Timesheet Revenues Issue: Revenues are tax included, but should be tax excluded This occurs because we are computing the revenue using the sale order line price total opw-3864227 Forward-Port-Of: odoo/odoo#168754
**Before this PR:** When you open Emoji picker in discuss mobile view and screen size is enough small so that the categories tab overflows and shows horizontal scroll. And as it's parent div `o-mail-PickerContent-emojiPicker` doesn't have any fixed width set it's width also increases in response to the categories tab. Which will display the horizontal scroll on the whole parent div instead of the categories tab.  **After this PR:** This commit sets max-width 100% to it's `o-mail-PickerContent-emojiPicker` so, that the scrolling would only take effect on the categories tab.  **task**-[3950434](https://www.odoo.com/odoo/my-tasks/3950434?debug=&cids=2) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166840
Problem --- When printing invoices involving different tax groups (from the actions in the invoice form view), the text baseline for the word 'on' and the rest of the text ("<tax_name> on <corresponding_amount>") in the taxes summary are different. (ie the word is misaligned) Steps --- IMPORTANT: the bug only appears on newer (~`0.13`) versions of `wkhtmltopdf` * create an invoice for 2 products, * make the products use different taxes, form at least 2 different tax groups (if needed co
Original PR description
Problem
---
When printing invoices involving different tax groups (from the actions in the invoice form view), the text baseline for the word 'on' and the rest of the text ("<tax_name> on <corresponding_amount>") in the taxes summary are different. (ie the word is misaligned)
Steps
---
IMPORTANT: the bug only appears on newer (~`0.13`) versions of `wkhtmltopdf`
* create an invoice for 2 products,
* make the products use different taxes, form at least 2 different tax groups (if needed configure in Accounting > Configuration > Taxes)
* Actions (cog) > print > Invoices => on the generated pdf the word 'on' is misaligned
Note
---
Fix tested on `wkhtmtopdf 0.13`.
On `wkhtmltopdf 0.12.6` -> already worked, but fix has no visual effect
---
opw-3940888
Forward-Port-Of: odoo/odoo#167247Backport of odoo/odoo@7aca17cf6d6f8487ebba615bc4f2e6bde5e0c4a1 This commit force the datetime_picker's cells to have the same aspect ratio without any specific width or height on small screen. So the datetime_picker can take the all width space available and be always responsive as each cells share the same width and the same height to respect the aspect ratio. We backport this commit so on small screen the date picker has a smaller width and doesn't overflow anymore. Steps to reproduc
Original PR description
Backport of odoo/odoo@7aca17cf6d6f8487ebba615bc4f2e6bde5e0c4a1 This commit force the datetime_picker's cells to have the same aspect ratio without any specific width or height on small screen. So the datetime_picker can take the all width space available and be always responsive as each cells share the same width and the same height to respect the aspect ratio. We backport this commit so on small screen the date picker has a smaller width and doesn't overflow anymore. Steps to reproduce (Small screen/Mobile): * Open CRM * Click on a lead * Click on Expected Closing => Bug the date picker overflow on the left opw-3957058 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169228
**Description of the issue/feature this PR addresses:** Before this commit the field can be wrongly computed in multi user environment. @oco-odoo --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166837
Original PR description
**Description of the issue/feature this PR addresses:** Before this commit the field can be wrongly computed in multi user environment. @oco-odoo --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#166837
Currently the "Force PDV" button for mercado pago is visible in debug mode no matter if you select "mercado_pago" as the payment provider or not. This PR makes it so that it is only visible if 'mercado_pago' is selected as a payment provider   task-3988847 Forward-Port-Of: odoo/odoo#169174
Original PR description
Currently the "Force PDV" button for mercado pago is visible in debug mode no matter if you select "mercado_pago" as the payment provider or not. This PR makes it so that it is only visible if 'mercado_pago' is selected as a payment provider   task-3988847 Forward-Port-Of: odoo/odoo#169174
Editing the `amount_currency` field of a product line in the "Journal Items" tab on an invoice is not really possible at the moment. On a technical level: The function `_compute_release_to_pay` assigns fields `release_to_pay` and `release_to_pay_manual`. Yet, it is only registered as compute function of `release_to_pay`. This behaviour is not correct; i.e. it causes a recomputation of the `amount_currency` field on the line mentioned above. In this commit a compute function for `rele
Original PR description
Editing the `amount_currency` field of a product line in the "Journal Items" tab on an invoice is not really possible at the moment. On a technical level: The function `_compute_release_to_pay`…
Editing the `amount_currency` field of a product line in the "Journal Items" tab on an invoice is not really possible at the moment. On a technical level: The function `_compute_release_to_pay` assigns fields `release_to_pay` and `release_to_pay_manual`. Yet, it is only registered as compute function of `release_to_pay`. This behaviour is not correct; i.e. it causes a recomputation of the `amount_currency` field on the line mentioned above. In this commit a compute function for `release_to_pay_manual` is introduced. It basically does the job that the old computation function did. To reproduce on runbot: 1. Create an invoice with a single line 2. Got to "Journal Items" 3. Edit the "Amount in currency" of the first line (product) 4. Save the invoice 5. The "Amount in currency" is reset to the original version. The same code also causes an issue in 17.0+; see https://github.com/odoo/odoo/pull/167014 Forward-Port-Of: odoo/enterprise#64695 Forward-Port-Of: odoo/enterprise#63336
__Current behavior before commit:__ When all slots from the first staff user/resource are taken, the `/appointment/<id>` page shows no availabilities even if the following users/resources still have slots. The user/resource selector is also not displayed. This means that it is not possible for a visitor to book an appointment as soon as the first one is fully booked. __Description of the fix:__ A new method `_get_slots_values` has been added to the `AppointmentController` class. This m
Original PR description
__Current behavior before commit:__ When all slots from the first staff user/resource are taken, the `/appointment/<id>` page shows no availabilities even if the following users/resources still have…
__Current behavior before commit:__ When all slots from the first staff user/resource are taken, the `/appointment/<id>` page shows no availabilities even if the following users/resources still have slots. The user/resource selector is also not displayed. This means that it is not possible for a visitor to book an appointment as soon as the first one is fully booked. __Description of the fix:__ A new method `_get_slots_values` has been added to the `AppointmentController` class. This method will compute the available slots for every possible user/resource until there is one that has slots available. And it starts by checking the default one. However if one is specifically selected by the visitor, it will be used even if there is no slots for it. This way the visitor can select it see that it has no availabilities but he can still switch user/resource with the selector. If there is no default nor selected user/resource then the slots are computed for all possible users/resources. A new test has been added to check if the shown staff user is the correct one and if the selector and calendar are visible even when the first one has no availabilities. __Example of steps to reproduce the issue:__ - Create a new `appointment.type` - Set the max scheduling days to 7 - Keep only one schedule time slot (e.g. Monday from 9:00 to 10:00) - Set **Availability on** to *Resources* - Put at least 2 courts in **Resources** - Click on `Share`, select **Assign to** *Any User/Resource* - Open the link - Book the slot of the first court - Come back the slot selector page -> No more slots available although the second court has still one opw-3862746 Forward-Port-Of: odoo/enterprise#62634
Problem: When enhancing reports for 16.4 compatibility, a VAT label was added to the followup report. This label will display even when no `vat` value exists. Purpose: Revert line similar to previous versions where if a `vat` value is present, then show the value. Otherwise, show nothing. Steps to Reproduce: 1. Have a contact with no `vat` value 2. Create an invoice for that contact 3. Send a followup report to that contact. opw-3970003 Forward-Port-Of: odoo/enterprise#64614
Original PR description
Problem: When enhancing reports for 16.4 compatibility, a VAT label was added to the followup report. This label will display even when no `vat` value exists. Purpose: Revert line similar to previous versions where if a `vat` value is present, then show the value. Otherwise, show nothing. Steps to Reproduce: 1. Have a contact with no `vat` value 2. Create an invoice for that contact 3. Send a followup report to that contact. opw-3970003 Forward-Port-Of: odoo/enterprise#64614
[ADD] account_accountant_check_printing: Add check number to bank rec desired behavior: If Checks are activated in the Accounting settings, add a new column in the Bank Reconciliation widget for payment_id.check_number, in optional=hide Reason: the Check Number is a very useful information to display in the Bank Reconciliation. solution: create new module dependent on accounting and account_check_printing modules and add the desired column and method there. Task-3869134 Forward-Por
Original PR description
[ADD] account_accountant_check_printing: Add check number to bank rec desired behavior: If Checks are activated in the Accounting settings, add a new column in the Bank Reconciliation widget for payment_id.check_number, in optional=hide Reason: the Check Number is a very useful information to display in the Bank Reconciliation. solution: create new module dependent on accounting and account_check_printing modules and add the desired column and method there. Task-3869134 Forward-Port-Of: odoo/enterprise#60849