[FIX] helpdesk: fix activity default filter

Clicking on an Activity group used to set a default filter, in effect of which
user will only see helpdesk tickets with HIS activites that are overdue/today.

This behaviour got temporarily removed and than reintroduced with (ref.1)
(ref.1) achieves that by adding default filters to the search views, it issue
persisted in the helpdesk view becase filters wern't present.

This commits adds filters to the helpdesk's search view so they can be used
by mechanisms (re)introdcuted in (ref.1)

(ref.1)
[FIX] mail: Fix activity default filter issue
https://github.com/odoo/odoo/commit/3d18b9faa1fdcf00d48091ad4be244ca00d33524

[Reproduce steps]
- Install helpdesk
- (optional) create a helpdesk ticket where:
    - current user has a future activity
    - other user has an overdue activity
- open ActivityMenu dropdown (clock icon ".fa-clock-o")
- BUG (ux issue): filters aren't present
    - (if optional): created ticket is shown (beside current user not having any overdue/today activity in there)

opw-3859535


https://github.com/odoo/enterprise/assets/33809926/ca77aa45-f842-41a3-b551-d27e4b87a83b

Forward-Port-Of: odoo/enterprise#63748

**Steps to reproduce:**
- Go to list view or kanban view.
- Select the document to preview in the inspector.
- Clear the input value of a required field (here, Name or Workspace), and click elsewhere or press 'Enter'.

**Issues:**
- _**Workspace field**_
  A validation error is raised when a Workspace name is cleared. However, an alert dialog is not displayed.

- _**Name field**_
 An alert dialog indicating a validation error is shown yet on clicking the `OK` button, the unnamed document is saved as is.
  
  Instead, the changes should be reverted.

**Causes:**
- _**Workspace field**_
  The `required` attribute was not added to `folder_id` field in the view. As a result, alert dialog was not shown.

- _**Name field**_
  The config mode never changes to 'edit'. Even when a user is editing an inspector field, the mode is 'readonly'. 
  As a result, the boolean `isInEdition` remains false and the code-block meant to be executed 
  on click of the confirm button of alert dialog does not execute as intended.

**Fix:**
- _**Workspace field**_
  The `required` attribute is forcefully set to true for the `folder_id` field so that an empty value for workspace 
   is not considered to be a 'validSelection' and the user faces an alert popup.

- _**Name field**_
  This PR fixes the issue by switching to edit mode whenever user changes the value of a document inspector field.

This PR also adds a testcase in `documents_kanban_tests.js` to ensure that the confirm ('OK') button works as intended.

Task: [3799280](https://www.odoo.com/web#id=3799280&menu_id=4722&cids=2&action=333&active_id=10888&model=project.task&view_type=form)

Forward-Port-Of: odoo/enterprise#64486
Forward-Port-Of: odoo/enterprise#59734

Currently, an error occurs when uploading an XML file to generate an invoice.

Step to produce:

- Install the 'l10n_mx_edi' module.
- Go to Accounting / Configuration / Accounting / Taxes, And delete all 'Exento' taxes.
- Go to Accounting / Configuration / Accounting / Tax Groups, And delete all 'Exento' Tax Group.
- Navigate to Accounting / Customers / Invoices, And upload an XML file to generate an invoice, 
- Ensure that the XML file contains the "TipoFactor" with a value of "Exento". (use this XML file [1]).

AttributeError: 'NoneType' object has no attribute 'id'

An error occurs when attempting to generate an invoice by uploading an XML file because system tries to retrieve an ID from the external_id of a tax group at [2] which is not available.

link [1]: https://github.com/odoo/enterprise/blob/1e3dfa7c6a57c251d77801c316818b5a9fae6cc5/l10n_mx_edi/tests/test_files/test_bill_import_extento.xml#L1

link [2]: https://github.com/odoo/enterprise/blob/1e3dfa7c6a57c251d77801c316818b5a9fae6cc5/l10n_mx_edi/models/account_move.py#L2381

To resolve the issue, Add a condition to ensure that an external_id of a tax group is available.

sentry-5312222893

Forward-Port-Of: odoo/enterprise#63874
Forward-Port-Of: odoo/enterprise#62257

Issue:
------
When we click on "Helpdesk Ticket" in the activities, we are redirected to the kanban view
(`helpdesk_ticket_view_kanban`), but no filter
is added.

Cause:
------
When going to the kanban view via activities,
the search view selected is
`helpdesk_ticket_view_search_analysis`,
which does not contain filters on the
`my_activity_date_deadline` field.

When we go to the kanban view via the "Tickets" button, we have the search view `helpdesk_tickets_view_search` which is correct. Via ticket button, we are taking `helpdesk_ticket_action_team` action that forces the search view with `helpdesk_tickets_view_search`.

Via ticket button:
helpdesk_tickets_view_search (priority: 20)
Via activity:
helpdesk_ticket_view_search_analysis (priority: 16)

16 is the default value for the `priority` field.

Solution:
---------
Set a priority lower than the default on the
`helpdesk_tickets_view_search` view,
to make sure it is selected.

opw-3976395

Forward-Port-Of: odoo/enterprise#64756

When task assignees have more than one task at the same time in field service, 
and tries to remove the planned date from one of the tasks,
A traceback will appear.

Steps to reproduce the error:
- Go to Field Service > Create a new task with the planned date and Assignees
- Create another task with the same planned date and Assignees > Save
- Now try to remove the planned date

Traceback:
```
AttributeError: 'bool' object has no attribute 'tzinfo'
  File "odoo/http.py", line 2254, in __call__
    response = request._serve_db()
  File "odoo/http.py", line 1829, in _serve_db
    return self._transactioning(_serve_ir_http, readonly=ro)
  File "odoo/http.py", line 1849, in _transactioning
    return service_model.retrying(func, env=self.env)
  File "odoo/service/model.py", line 134, in retrying
    result = func()
  File "odoo/http.py", line 1827, in _serve_ir_http
    return self._serve_ir_http(rule, args)
  File "odoo/http.py", line 1834, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "odoo/http.py", line 2059, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "odoo/addons/base/models/ir_http.py", line 220, in _dispatch
    result = endpoint(**request.params)
  File "odoo/http.py", line 740, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "addons/web/controllers/dataset.py", line 38, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "addons/web/controllers/dataset.py", line 34, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "odoo/api.py", line 458, in call_kw
    result = getattr(recs, name)(*args, **kwargs)
  File "addons/web/models/models.py", line 1011, in onchange
    todo = [
  File "addons/web/models/models.py", line 1014, in <listcomp>
    if field_name not in done and snapshot0.has_changed(field_name)
  File "addons/web/models/models.py", line 1127, in has_changed
    return self[field_name] != self.record[field_name]
  File "odoo/models.py", line 6608, in __getitem__
    return self._fields[key].__get__(self, self.env.registry[self._name])
  File "odoo/fields.py", line 1261, in __get__
    self.compute_value(recs)
  File "odoo/fields.py", line 1443, in compute_value
    records._compute_field_value(self)
  File "addons/mail/models/mail_thread.py", line 416, in _compute_field_value
    return super()._compute_field_value(field)
  File "odoo/models.py", line 4934, in _compute_field_value
    fields.determine(field.compute, self)
  File "odoo/fields.py", line 100, in determine
    return needle(*args)
  File "home/odoo/src/enterprise/saas-17.2/project_enterprise/models/project_task.py", line 227, in _compute_planning_overlap
    absolute_min_start = utc.localize(self[0].planned_date_begin)
  File "__init__.py", line 257, in localize
    if dt.tzinfo is not None:
```

https://github.com/odoo/enterprise/blob/74e8fa829cf17677ddcb29d91a0521d5d5b9a1b6/project_enterprise/models/project_task.py#L229-L230 When the user removes the planned date,
"planned_date_begin" and "date_deadline" will be False.
So it will lead to the above traceback.

sentry-5444639133

Forward-Port-Of: odoo/enterprise#63976

Steps to reproduce:
- create a new db `--without-demo=True -i l10n_ar`
- Load demo data

Issue:
Everything goes wild

Cause:

When we instantiate a database without demo data with l10n_ar, the res_partner(1) has the l10n_latam_identification_type_id field set to 'CUIT'. When loading demo data, a VAT number is assigned to res.partner(1)(*), which triggers a constraint error: https://github.com/odoo/odoo/blob/69e31db6ac90874ed6329599fca8f09709efd119/addons/l10n_ar/models/res_partner.py#L60-L61

Since res.partner(1) has the CUIT identification type, its VAT will be checked for correctness here: https://github.com/odoo/odoo/blob/69e31db6ac90874ed6329599fca8f09709efd119/addons/l10n_ar/models/res_partner.py#L106

The dummy VAT added with this PR causes the constraint error: https://github.com/odoo/odoo/commit/a171597d1904de992bcf0e0f606b4c6a4b70b725

(*)By default (even without demo data) there is a "MyCompany" partner: https://github.com/odoo/odoo/blob/7e58f5c5ee772f2a6b4dff7ad3279dc9242ea2b3/odoo/addons/base/data/res_partner_data.xml#L4-L13

Solution:
For 'main_partner' we don't set any vat number. Since some irregularities might happen, if the vat is necesarry for it, adding it to the specific module might be a better choice

commit:https://github.com/odoo/odoo/commit/a171597d1904de992bcf0e0f606b4c6a4b70b725 opw-3907520

Forward-Port-Of: odoo/odoo#169305
Forward-Port-Of: odoo/odoo#167062

Steps to reproduce:
[phonenumbers]
- Create a customer from Malaysia and add a phone number '123456789' -> it will be formatted '+60 12-345 6789'
- Create an invoice
- Confirm
- Click on Process Now

Issue:
There will be a warning "The Buyer’s contact phone number (BT-57) shall start with “0“ or “+”, followed by a maximum of 15 number and minimum 4 character after the “+“ or “0“ , if exist."

Solution:
Only keep digits and the "+" symbol

note:
The test has changed in order to be more realistic. That is, if I have a foreign contact I will:
- or use/set the correct format manually (if not, it should raise an error from the third-party api)
- or install `phonenumbers` to automatically format it (if not on a saas)

`phone_validation` is in 'auto_intsall' whenever `base` and `mail` are installed (and if the library `phonenumbers` is installed) and works as followed:
```
>>> import phonenumbers
>>> raw_phone = '(870)-931-0505'
>>> parsed_number = phonenumbers.parse(raw_phone, "US")
>>> phonenumbers.format_number(parsed_number, phonenumbers.PhoneNumberFormat.INTERNATIONAL)
'+1 870-931-0505'
```

opw-3912128

Forward-Port-Of: odoo/odoo#164717

__Explanation of the issue:__
Creating an allocation for multiple employees create children allocations for each individual employee concerned by that allocation. However, before this commit, refusing a parent allocation would refuse the children allocation, and validating it again would still create new children regardless. This behaviour is reminescent from the draft state which was the only way to modify an allocation

__Reproduce the issue:__
- Create a multiple-employee allocation
- Validate it
- Refuse it
- Validate it again
- Refuse it again
- An error should appear, saying: "Allocation request must be confirmed or validated in order to refuse it."

__How the issue was fixed:__
This commit synchronizes both parent and children allocations upon the write of the parent one, which will also update the children. Additionally, validating those parent allocations will now check if children allocations are present beforehand to avoid duplicating them.

task-3935358

Forward-Port-Of: odoo/odoo#165990

The main goal of this PR is to ensure that the `X` button or `Esc` shortcut (Dismiss feature) of the confirmation dialog 
is allowed to have a different behavior than the `Cancel` button.

At present, it performs the same action as the `Cancel` button but there might be cases when the dialog does not have 
a `Cancel` button and we still want to handle the dialog dismiss action.

To enable this, this PR adds an optional callback for `dismiss` operation to the dialogData.dismiss 
that will only be executed when a dialog is closed via of the `X` button or the `Escape` shortcut. 
Otherwise, it will execute the callback for `cancel` operation, if any.

This PR also adds/modifies some tests in `confirmation_dialog_tests.js` and `list_view_tests.js` 
to ensure that this new feature works as intended.

**Example Use Case:**
- Go to list view or kanban view.
- Select the document to preview in the inspector.
- Clear the input value of a required field (here, Name or Workspace), and click out or press 'Enter'.
- Dismiss the alert dialog via the "X" button or the "Esc" shortcut.

**Issue:**
An alert dialog indicating a validation error is shown when a field value is cleared. 
Yet, on closing the dialog, the unnamed document is saved as is.

Instead, the changes should be reverted.

**Cause:**
The dismiss operation is never handled in case of alert dialog for invalid selection. 
Hence, by default, it applies the changes made to the field.

**Fix:**
The alert dialog for invalid selection is different from the ones which are simply used to display warnings 
or alert messages because they do not need to perform any action upon dismissing the dialog.

In this case, we want to prevent any invalid changes from being applied. 
It is achieved by calling the `leaveEditMode` method which discards them and switches the config mode. 
Hence, we do something similar to what is done on the click of `OK` button, on dismissing the dialog as well. 
This behavior is introduced because even if the user discards the dialog, any change that is not valid should not be applied.

Task: [3799280](https://www.odoo.com/web#id=3799280&menu_id=4722&cids=2&action=333&active_id=10888&model=project.task&view_type=form)

Forward-Port-Of: odoo/odoo#169129
Forward-Port-Of: odoo/odoo#166103

This error occurs when we create a new sales order, then proceed to create an
invoice within that sales order, and finally attempt to open the
``Accrued Revenue Entry`` from the action button.

Steps to reproduce:

- Install the ``sale_management`` and ``account_accountant`` modules
- Create new sales orders > ``Confirm`` > ``Create Invoice`` button >
  Down Payment in % > ``Confirm`` > ``Sale Order`` smart button
- Go to action button > ``Accrued Revenue Entry``

Traceback : 
``AssertionError precision_rounding must be positive, got 0.0``

At [1] within ``o.order_line``, we are encountering an issue where
``precision_rounding`` is being retrieved as zero. This is leading to an error.

This commit will fix the above error by implementing a check for the 
``is_downpayment`` in the order line.

[1]: https://github.com/odoo/odoo/blob/34b651de35b986db404a3950866bed7bc7e1fae2/addons/account/wizard/accrued_orders.py#L174

sentry-4857910663

Forward-Port-Of: odoo/odoo#165014