Friday, June 21, 2024
4 changes · saas-17.2
Resolved issues and error corrections
Fixed an issue that could cause an error when using the Scan button on Vendor Bills with debug mode enabled. This improves reliability for accounting users scanning Indian vendor bill QR codes without changing the normal workflow.
Original PR description
Steps to reproduce ================== 1. Go to the Accounting module 2. Open Vendor Bills 3. Click on the Scan button with debugger mode ON => Hence gives traceback Cause of the issue ================== The Issue was due to the `BillQrScan` component doing the props validation same as the `Dialog` component, the `slots` object is a mandatory prop for Dialog component but not needed for `BillQrScan`. This commit solves the traceback generating due to props validation on `BillQrScan` component.
This fixes an unreliable automated test for VoIP audio input switching. The change helps prevent false test failures, making release validation more stable without changing the user experience.
Original PR description
"Switch audio input" test failed in an undeterminitic manner on this line: https://github.com/odoo/enterprise/blob/e808e583e9d406735a05dab42bf24f8b89899b67/voip/static/tests/softphone/device_selection_dialog.test.js#L54 After clicking the "Call" button, func `makeCall` has asynchronous call before setTimeout: https://github.com/odoo/enterprise/blob/e808e583e9d406735a05dab42bf24f8b89899b67/voip/static/src/core/user_agent_service.js#L268 https://github.com/odoo/enterprise/blob/e808e583e9d406735a05dab42bf24f8b89899b67/voip/static/src/core/user_agent_service.js#L284 It may happen that because of the asynchronous call, our `advanceTime(5000)` is executed before we call `setTimeout` in `makeCall`. To avoid this, we check the dom change to make sure the asynchronous call has finished before we continue.
Updates the rental stock test suite so it matches recent inventory behavior for negative procurements. This helps ensure rental orders continue to be validated correctly when returns or adjustments create negative stock movements.
Original PR description
Adapt the tests to match the changes done community-side to properly handle negative procurements. Community PR: odoo/odoo#165100
This fixes an issue where opening an employee's work information in debug mode could show an error after clearing the working hours field. The change keeps the Employee Contracts screen usable for administrators and support teams when validating or troubleshooting employee contract data.
Original PR description
Steps to reproduce: ------------------- - Install `Employee Contracts` module - Go to `Employees` and open any employee with a contract - Click on `Work Information` tab - Set `Working Hours` to nothing and save - Activate debug mode - Click again on `Work Information` tab Issue: ------ Error : `Invalid props for component 'ContractWarningTooltip'`. Cause: ------ In debug mode, we activate the validation of the props, and since there are not declared on the widget component, it is raising an error. Solution: --------- Set the default props (`standardWidgetProps`) on the widget component. opw-3972488