Thursday, June 27, 2024
6 changes
2 changes
Resolved issues and error corrections
This update fixes several internal test helpers used by Odoo's web module, making automated tests better reflect real user screens and behavior. It improves confidence that calendar views, date-time validation, relationship handling, and breadcrumb loading work correctly before changes reach users.
This fixes an error that could appear after opening a dialog from an employee record and then returning through the breadcrumb. Users can now close those dialogs and navigate back normally without seeing an “Invalid controller to restore” crash.
Original PR description
- Open the Employees app;
- Open the record of an employee, that have the onbording plan link in
the chatter (for instance Abigail Peterson in runbot);
- Click on the onbording plan;
- Close the onbording plan dialog;
- Click on the Employees link in the breadcrumb to came back to the
employees multi-record view;
Before this commit, a traceback was raised : `Invalid controller to
restore`. This issue occurs because when we load from a link/URL
(loadState), the controllers list is updated from the actions found in
the URL, this is done to be able to recreate the controllers (the
breadcrumb) from the URL.
This behavior is correct when the action has a target other than “new”
(i.e., when it's not a dialog). In the case of a target "new" (a dialog)
the controllers shouldn't be modified, to be able to interact with the
breadcrumb when the dialog is closed.
Now, only when the action has a target different from "new", the
controllers are updated from the URL.3 changes
Resolved issues and error corrections
This fixes how subscription-related sales permission checks are tested by placing them with the module where they belong. It helps keep validation reliable for subscription sales and stock flows without changing day-to-day user behavior.
Original PR description
Related: odoo/enterprise#60912 https://github.com/odoo/enterprise/pull/65331/files#r1651151330
1 change
Resolved issues and error corrections
The Marketing Automation template form was displaying a duplicate button that wasn't functional or needed. This update removes that button from the interface, cleaning up the user experience and reducing confusion about available actions.
Original PR description
Before this PR: In Marketing Automation, upon opening a template form view, a duplicate button is displayed which won't be used. After this PR: Duplicate button is now hidden. Task - 3994775
This update corrects an internal planning calendar test so it checks the expected event end time consistently. It also fixes the test setup to use a defined timezone, reducing false test failures caused by different machine settings.
Original PR description
Before this commit, a planning calendar test was wrong. In this test, we resized two events to make them end at 14:30 but then check that they end at 15:30 which is inconsistent. This commit adds a mockDate with a defined timezone which will prevent the test to depend on the machine local timezone.
The reporting option to hide lines with zero amounts now ignores informational text columns such as VAT numbers or countries. This helps users keep financial reports focused on meaningful amount-based entries without being blocked by non-financial details.
Original PR description
Some reports display some informational columns (like the VAT for a partner, or the country of origin). These columns sometimes prevent the `Hide Lines at 0` option to correctly do its work: the desired behavior of this option is to hide the lines where the amounts are null. It shouldn't care about the "informational" columns, that are usually always present This commit force the `Hide Lines at 0` feature to ignore columns displaying information other than float, integer of monetary ones. task-4006235