Friday, June 28, 2024
4 changes · saas-17.2
Resolved issues and error corrections
This change fixes an intermittent failure in an automated test for creating mail discussion channels. It improves the reliability of internal quality checks without changing how users experience the product.
Original PR description
Before this PR, the `can create a new channel` test was sometimes failing. This test asserts that the `/discuss/channel/messages` route is called using the step API. However, creating a new channel also sets the last seen message of the user. Most of the time, the test ended before this step but when it didn't, the test would fail as this step is not verified. This PR ignore this step as it is not relevant for the current test. runbot-68993
This fix makes Odoo's web testing tools handle simulated clicks more like real user clicks. It helps prevent tests from failing or missing behavior when earlier pointer events are intentionally stopped, improving confidence in web interface testing.
Original PR description
Before this commit, when using HOOT pointer event helpers such as `click`, preventing the `pointerup`, `mouseup` or `touchend` event would prevent the final `click` event to be dispatched. Now, the `click` event can be dispatched regardless, as it would be during an actual user-triggered click. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix restores validation for user and partner timezone selections, helping prevent invalid timezone values from being saved. It matters because accurate timezone settings support correct scheduling, messaging, and date/time display across Odoo.
Original PR description
In odoo/odoo#154177 it was apparently decided that validating callable selections is unnecessary, leading to the lang and timezone fields not being validated anymore. Nothing to be done for the lang as it relies on the installed langs and thus the corresponding database, however the tz list has effectively been static / global since odoo/odoo#26496 (f11d143f00add145f1a05b51968108e46b96ca87). So initialise `tz` with the precomputed value instead of the function which returns the precomputed value. cherry-pick of ff8ac5d13cd6bb
Users can now download all attachments from a chatter message without encountering an error. The fix corrects the download link so it works reliably from newer page URLs, reducing disruption when sharing or retrieving project-related files.
Original PR description
Steps to reproduce: ------------------- - Install `Project` module (for test purpose) - Open any project and create a task - Post a message with multiple attachments - Select "Download Files" in the message options Issue: ------ Traceback Cause: ------ Calling directly the route without starting with `/`. The issue started since the following commit [1] because we changed how the URLs are generated; Before: `localhost/web#id=55&...` After: `localhost/odoo/project/5/tasks/55` With these changes, since the download URL don't start with `/`, the browser will try to download the file from the current URL who, combined with the download URL, is not a real route. [1] https://github.com/odoo/odoo/commit/c63d14a0485a553b74a8457aee158384e9ae6d3f Solution: --------- Add `/` at the beginning of the download URL. opw-4009021