Saturday, June 29, 2024
8 changes · saas-17.3
Miscellaneous changes
This requires adding the following elements to the customer invoice / credit note / sales receipt: - The recipient's SIREN/SIRET if any - Customer address, if different from billing address - Delivery address, if different from billing address - Type of operation: goods delivery, service delivery or mixed operation - Option to pay VAT on a debit basis All of that should be added as long as the issuer is french The billing/delivery addresses are customizable on a per-invoice basis S
Original PR description
This requires adding the following elements to the customer invoice / credit note / sales receipt: - The recipient's SIREN/SIRET if any - Customer address, if different from billing address - Delivery address, if different from billing address - Type of operation: goods delivery, service delivery or mixed operation - Option to pay VAT on a debit basis All of that should be added as long as the issuer is french The billing/delivery addresses are customizable on a per-invoice basis See: https://www.legifrance.gouv.fr/jorf/id/JORFTEXT000046383394 task-3856826 **Documentation PR:** odoo/documentation#9820 Forward-Port-Of: odoo/odoo#171330 Forward-Port-Of: odoo/odoo#162458
Before this commit it was possible to remove employees with ongoing contracts. This commit adds a check to prevent this case. task: 3930155 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170289 Forward-Port-Of: odoo/odoo#166338
Original PR description
Before this commit it was possible to remove employees with ongoing contracts. This commit adds a check to prevent this case. task: 3930155 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170289 Forward-Port-Of: odoo/odoo#166338
Before this commit, when using HOOT pointer event helpers such as `click`, preventing the `pointerup`, `mouseup` or `touchend` event would prevent the final `click` event to be dispatched. Now, the `click` event can be dispatched regardless, as it would be during an actual user-triggered click. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171170
Original PR description
Before this commit, when using HOOT pointer event helpers such as `click`, preventing the `pointerup`, `mouseup` or `touchend` event would prevent the final `click` event to be dispatched. Now, the `click` event can be dispatched regardless, as it would be during an actual user-triggered click. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171170
Currently, an error occurs when producing a manufacturing order for a product whose tracking is by lot. Step to produce: - Install the 'mrp' module (ensure developer mode is enabled). - Go to Settings / Technical / Sequences & Identifiers / Sequences, Open 'stock.lot.serial' and add ''%default_code-%(month)s%(y)s-' as a prefix. - Create a new product by lots, Open 'Manufacturing Orders' and create an order with that new product. - Confirm this order, And then click on mark as done and
Original PR description
Currently, an error occurs when producing a manufacturing order for a product whose tracking is by lot. Step to produce: - Install the 'mrp' module (ensure developer mode is enabled). - Go to…
Currently, an error occurs when producing a manufacturing order for a product whose tracking is by lot. Step to produce: - Install the 'mrp' module (ensure developer mode is enabled). - Go to Settings / Technical / Sequences & Identifiers / Sequences, Open 'stock.lot.serial' and add ''%default_code-%(month)s%(y)s-' as a prefix. - Create a new product by lots, Open 'Manufacturing Orders' and create an order with that new product. - Confirm this order, And then click on mark as done and apply immediate production ```TypeError: %d format: a real number is required, not dict``` An error occurs when attempting to produce a manufacturing order of a product which have lot by serial numbers because the system tries to generate an invalid serial number at [1]. link [1]: https://github.com/odoo/odoo/blob/c7d420b077490108794f513e9ff21b0d850f57af/addons/stock/models/stock_production_lot.py#L89 To resolve the issue, raise a user error for an invalid sequence. sentry-5343084412 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170916 Forward-Port-Of: odoo/odoo#165620
Clicking on the doc link for the "Packages" setting returns a 404 error. The structure of the Inventory documentation has been changed and it seems there was a missing redirection rule for this doc. This commit fixes the URL of the doc link. Forward-Port-Of: odoo/odoo#171020 Forward-Port-Of: odoo/odoo#170983
Original PR description
Clicking on the doc link for the "Packages" setting returns a 404 error. The structure of the Inventory documentation has been changed and it seems there was a missing redirection rule for this doc. This commit fixes the URL of the doc link. Forward-Port-Of: odoo/odoo#171020 Forward-Port-Of: odoo/odoo#170983
[FIX] account: fix lines of reverse move The button "Reverse and Create Invoice" allows the user to reverse the current Invoice, and create a copy in one button. When pressing it, all Notes and Sections are lost Solution: Include 'line_section' & 'line_note' in creating the reverse move task-id#3940541 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170925
Original PR description
[FIX] account: fix lines of reverse move The button "Reverse and Create Invoice" allows the user to reverse the current Invoice, and create a copy in one button. When pressing it, all Notes and Sections are lost Solution: Include 'line_section' & 'line_note' in creating the reverse move task-id#3940541 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170925
…atch payment Create a branch company and switch to it Activate SEPA Direct Debit (SDD) and add Creditor Identifier Activate Batch Payments Add a SEPA bank account on the Bank journal Add a SEPA bank account on a partner Create SEPA mandate for the partner bank account on the Bank journal Make an invoice to the partner Register payment with payment method "SEPA Direct Debit" Go to Accounting>Customer>Payments Select the payment > Hit 'Create Batch' Validate creted batch Issue: A
Original PR description
…atch payment Create a branch company and switch to it Activate SEPA Direct Debit (SDD) and add Creditor Identifier Activate Batch Payments Add a SEPA bank account on the Bank journal Add a SEPA bank…
…atch payment
Create a branch company and switch to it
Activate SEPA Direct Debit (SDD) and add Creditor Identifier
Activate Batch Payments
Add a SEPA bank account on the Bank journal
Add a SEPA bank account on a partner
Create SEPA mandate for the partner bank account on the Bank journal
Make an invoice to the partner
Register payment with payment method "SEPA Direct Debit"
Go to Accounting>Customer>Payments
Select the payment > Hit 'Create Batch'
Validate creted batch
Issue: A traceback will raise
```py
File "[...]/enterprise/account_sepa_direct_debit/models/account_payment.py", line 117, in _sdd_xml_gen_header
create_xml_node_chain(InitgPty, ['Id','OrgId','Othr','Id'], company_id.sdd_creditor_identifier)
File "[...]/odoo/tools/xml_utils.py", line 109, in create_xml_node_chain
current_node.text = last_node_value
File "src/lxml/etree.pyx", line 1039, in lxml.etree._Element.text.__set__
File "src/lxml/apihelpers.pxi", line 747, in lxml.etree._setNodeText
File "src/lxml/apihelpers.pxi", line 735, in lxml.etree._createTextNode
File "src/lxml/apihelpers.pxi", line 1538, in lxml.etree._utf8
TypeError: Argument must be bytes or unicode, got 'bool'
```
This occurs because we assign the credit identifier to the branch
company, but when validating the batch the system exports the
sdd xml using the company found on the journal
https://github.com/odoo/enterprise/blob/88d25bd184585143f39011947263e928b14551e5/account_batch_payment/models/account_batch_payment.py#L343
so the parent company that have no Creditor Identifier defined
After adding the Creditor Identifier on the parent company and trying
again the validation an error will block the action
"""Trying to generate a Direct Debit XML file containing payments from
another company than that file's creditor."""
opw-3943103
Forward-Port-Of: odoo/enterprise#64277Duplicate emails were being sent out to employees because employees were being searched from user ids for each company, but each search was not filtered by the company. So if there was a user that had multiple employee records, all of their employee records on every company would be pulled up for every company on their database that had timesheet notifications on. For example if there were 4 companies and the employee had an employee record for each of them they would receive 16 emails in total.
Original PR description
Duplicate emails were being sent out to employees because employees were being searched from user ids for each company, but each search was not filtered by the company. So if there was a user that had multiple employee records, all of their employee records on every company would be pulled up for every company on their database that had timesheet notifications on. For example if there were 4 companies and the employee had an employee record for each of them they would receive 16 emails in total. 4 for each employee record. Adding to the search domain to only look for employees on the current company defined by the for loop avoids these duplicate emails. This is similar to a fix that was done on the manager notification emails here: https://github.com/odoo/enterprise/pull/52808 opw-3748426 Forward-Port-Of: odoo/enterprise#64291