Tuesday, July 2, 2024
19 changes · 17.0
Resolved issues and error corrections
This update removes an unnecessary check from a stock picking batch test that was failing due to inconsistent record ordering. It helps keep automated nightly builds reliable without changing business functionality.
Original PR description
### Issue: The `test_backorder_batching_2` is failling on the nightly community build of 17.0 because the order of the final records is not the same. ### Fix: The problematic assert on the product identity was not important and has been removed. Follow up of commit 386b32e --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Website editors can now change the padding of images in the Masonry snippet instead of being forced to use no padding. The default remains unchanged, so existing pages keep their current look unless editors choose to customize it.
Original PR description
When the grid mode was added in commit [1], the "Padding" grid option was impacting all the grid items at the same time. This was not looking good in the "Masonry" snippet, because the images would…
When the grid mode was added in commit [1], the "Padding" grid option was impacting all the grid items at the same time. This was not looking good in the "Masonry" snippet, because the images would have the same padding as the text grid items, while it would look better if they could take the whole space. The padding was therefore forced to 0 px for this snippet images (see commit [2]), preventing this option from having an impact on them. However, the "Padding" option was improved in commit [3], allowing the padding to be set on the grid items individually. There is therefore no need to block this option for the "Masonry" images anymore. This commit removes the CSS rules preventing the "Padding" option from being applied on "Masonry" images. Note that the default padding is still set to 0 px, as it looks better, but it can now be modified with the option. Also note that the CSS rule about not showing the padding highlights was not working, as it was forgotten and not adapted when doing commit [3]. [1]: https://github.com/odoo/odoo/commit/cc406afcea7bf5846233a9f97a4a8ac5f618f3ec [2]: https://github.com/odoo/odoo/commit/85b352af319edec84407f2046cf795b4e5503460 [3]: https://github.com/odoo/odoo/commit/11418cc6f0afcc8e14869f4f38ae0d6d462ac712 task-3970022
Odoo now avoids trying to cancel the same Google Calendar event more than once when recurrence changes and separate cancellations overlap. This reduces synchronization errors and keeps calendar updates more reliable for users.
Original PR description
This commit addresses an issue where events removed due to changes in their recurrence rules from Google, and those cancelled separately on Google, could be attempted to be cancelled twice in Odoo. opw-3997021 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes the automated test setup for a Project Kanban blank screen issue. It helps ensure the Project app continues to catch and prevent this display problem in future updates.
Original PR description
task-3744319
This fixes where a website-specific styling correction is applied, so it no longer affects the broader web module unnecessarily. It helps keep website appearance settings handled correctly while reducing the risk of unintended side effects elsewhere.
Original PR description
In commit [1], the `o-map-omit` SCSS function has been modified in order to fix the values of CSS variables that would have been wrongly set to `'True'` or `'False'`, instead of boolean `true` and `false`. However, the issue only happened in "website", so the code should not have been added in this function which is located in the "web" module, because it is really website-specific. This commit moves this fix in the website `o-map-force-nulls` function instead. [1]: https://github.com/odoo/odoo/commit/e01b861b89546ab5d7b5ce8269b06e9b7a845835 Related to opw-3957157
This fix makes an automated mail test more dependable by waiting properly for the expected channel subscription update. It helps reduce false test failures in validation runs, improving confidence in releases without changing user-facing behavior.
Original PR description
Before this PR, the `Channel subscription is renewed when channel is manually added` test was sometimes failing. This test ensures the bus subscription is renewed when the user joins a channel. To do this, the test relies on the `assert.step` API: the channel is added, we wait for a tick, and then we assert that the step was correctly registered. However, a tick is sometimes not enough. This PR replaces the usage of QUnit's tep API with the web one that waits for the step to be triggered, which is far more robust. fixes runbot-61018
This fixes an unreliable automated test for the Mail app that could sometimes get stuck due to timing issues. It helps keep quality checks stable so message display behavior remains protected without false failures.
Original PR description
The `Message shows up even if channel data is incomplete` test sometimes fails. This test ensures that a message received on a partially known channel still appears. To achieve this, the test needs to manually refresh the bus subscription and wait for this subscription to complete before sending a notification on the bus. Sometimes, the notification occurs before `waitUntilSubscribe` is called. Consequently, the `waitForSubscribe` function hangs because the expected subscription for the test has already been completed. This PR resolves this issue. runbot-59270
The live chat support page test now waits for all live chat assets to finish loading instead of relying on a fixed delay. This reduces false test failures and helps ensure required resources such as translations, styling, and fonts are available before the page check completes.
Original PR description
Before this PR, the live chat support page test was sometimes failing. This test ensures all the Odoo modules are successfully loaded on the support page. Until now, the test was waiting 1 second, which might be enough to load Odoo modules but not all the live chat assets. If the live chat assets are still loading when the browser instance is closed, the promise rejects and the test fails. This test now ensures all the live chat assets are loaded beforehand. This change is beneficial because it also ensures that runtime assets such as translations, live chat CSS, or fonts are properly loaded as well. This PR fixes this issue. runbot-60514
Delivery slips no longer show an internal placeholder when a delivery address has no name. This keeps printed delivery documents clean and avoids confusing text appearing for customers or warehouse staff.
Original PR description
Problem: Placeholders were added in 17.0 to be used when switching to Studio mode. However, this placeholder will appear on the printed report if the `res.partner` has no name. Creating a `Delivery Address` for a `res.partner` does not require a name due to its type. Purpose: Hide this placeholder in cases were `Delivery Address` record does not have a `name` set. Steps to Reproduce: 1) Enable `Signatures` for deliveries 2) Create a new `Delivery Address` with no `name` for an existing `res.partner` record 3) Create a SO -> confirm -> sign delivery 4) Print `Delivery Slip` opw-3988100
The Documents trash folder warning now displays the configured number of days before permanent deletion instead of showing an undefined value. This helps users understand how long deleted documents remain recoverable.
Original PR description
Steps: - Open documents - Open trash - Check the forever deletion warning Actual result: - Number of days displayed is "undefined" Expected result - Number of days displayed is the one from system parameter opw-3961023
This update resolves a testing problem in the Peru electronic invoicing module where automated tests were failing due to a recent change in how the system handles external service calls. The fix ensures that tests can properly validate the cancellation status checking functionality without being blocked by testing restrictions.
Original PR description
PR #62452 (15.0+) added extra IAP calls that retry requesting the cancellation status in case the cancellation was not processed yet. In odoo/odoo#122663 (17.0+), IAP calls were disabled in tests. When fw-porting the first PR above, this change of behaviour in 17.0 was not taken into account meaning that the tests kept failing in 17.0+. We fix this by applying the same strategy as #62452 - patch the thread to remove the testing attribute during IAP calls. runbot-64793
Miscellaneous changes
Avoid the installation of Odoo windows version in unsafe places. Forward-Port-Of: odoo/odoo#170356
Original PR description
Avoid the installation of Odoo windows version in unsafe places. Forward-Port-Of: odoo/odoo#170356
Add a domain so deprecated accounts aren't suggested in expenses. task-3974053 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171415 Forward-Port-Of: odoo/odoo#168704
Original PR description
Add a domain so deprecated accounts aren't suggested in expenses. task-3974053 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171415 Forward-Port-Of: odoo/odoo#168704
**Steps to reproduce:** - Open "Configure Document Layout" in settings. - Add only an image in the company_details section. **Issue:** - The customer added only an image to company_details in their production version 15.2. However, after migrating to version 17, the image appears in company_details but does not show up in the document preview. In version 15.2, there were some changes to company details that caused this issue https://github.com/odoo/odoo/pull/122438. - Due to these chan
Original PR description
**Steps to reproduce:** - Open "Configure Document Layout" in settings. - Add only an image in the company_details section. **Issue:** - The customer added only an image to company_details in their…
**Steps to reproduce:** - Open "Configure Document Layout" in settings. - Add only an image in the company_details section. **Issue:** - The customer added only an image to company_details in their production version 15.2. However, after migrating to version 17, the image appears in company_details but does not show up in the document preview. In version 15.2, there were some changes to company details that caused this issue https://github.com/odoo/odoo/pull/122438. - Due to these changes, company_details is processed with the html2plaintext() function, which removes all the tags from company_details and only links and text will remain. - This function does not recognize the image element and removes it along with other elements. I have prepared a fix that recognizes the image element from company_details and prevents it from getting discarded. - Video reference from RunBot version 17: https://drive.google.com/file/d/1Ml62xIV1mhwKwU8KRHdc-qfTFCZhEqY0/view?usp=sharing - I have also added a test case for html2plaintext function in test_html2plaintext function by backporting this method from master. OPW : [3945490](https://www.odoo.com/odoo/my-tasks/3945490?cids=2) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169027
same as: https://github.com/odoo/odoo/pull/159321 opw-3786308 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170807
Original PR description
same as: https://github.com/odoo/odoo/pull/159321 opw-3786308 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170807
**Description of the issue/feature this PR addresses:** Singleton errror when try to read private events because the convert_to_cache does not accept multiple records **Current behavior before PR:** Create some private events for marc demo and with admin user go to calendar and change to list view. The singleton error appears. This error is cause by this commit https://github.com/odoo/odoo/commit/764f18f18a45175142f56161f6eb9e8b5aa4086c but the real probles is the convert_to_cache call
Original PR description
**Description of the issue/feature this PR addresses:** Singleton errror when try to read private events because the convert_to_cache does not accept multiple records **Current behavior before PR:** Create some private events for marc demo and with admin user go to calendar and change to list view. The singleton error appears. This error is cause by this commit https://github.com/odoo/odoo/commit/764f18f18a45175142f56161f6eb9e8b5aa4086c but the real probles is the convert_to_cache call **Desired behavior after PR is merged:** Admin can access to all records without error cc @Tecnativa --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170635 Forward-Port-Of: odoo/odoo#170566
Separate tax tags have been done to be able to differentiate taxes for ec sales report Task: 3978307 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168729
Original PR description
Separate tax tags have been done to be able to differentiate taxes for ec sales report Task: 3978307 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168729
Current behaviour: --- Product name can overflow from the label box Expected behaviour: --- Truncate the name if it's too long Steps to reproduce: --- 1. Go to Inventory > Products > Lots/Serial Numbers 2. Open one Serial Number > open its product 3. Rename product with long name 4. Go back to Lots/Serial Numbers 5. Select the Serial Number with renamed product 6. Click on Print > PDF 7. Barcode is out of the box Cause of the issue: --- Caused by: https://github.com/odoo/o
Original PR description
Current behaviour: --- Product name can overflow from the label box Expected behaviour: --- Truncate the name if it's too long Steps to reproduce: --- 1. Go to Inventory > Products > Lots/Serial Numbers 2. Open one Serial Number > open its product 3. Rename product with long name 4. Go back to Lots/Serial Numbers 5. Select the Serial Number with renamed product 6. Click on Print > PDF 7. Barcode is out of the box Cause of the issue: --- Caused by: https://github.com/odoo/odoo/commit/a5924bfe11cd9324e2ba056e0ac1d449aed730c8 Fix: --- Reverting: https://github.com/odoo/odoo/commit/a5924bfe11cd9324e2ba056e0ac1d449aed730c8 opw-3819349 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#169226
**Issue:** When computing payment state of an expense, we check the amount of "reversal_move_id" field as if it was a Many2one, which triggers a traceback when it contains several records. **Steps to reproduce:** Unable to reproduce 2 reversal moves for a sheet move directly from version 16.0. However, it was possible to reverse the sheet move several times in version 14.0. If upgrading a 14.0 database to 16.0 with such moves, a traceback is raised in "_compute_payment_state" method. o
Original PR description
**Issue:** When computing payment state of an expense, we check the amount of "reversal_move_id" field as if it was a Many2one, which triggers a traceback when it contains several records. **Steps to reproduce:** Unable to reproduce 2 reversal moves for a sheet move directly from version 16.0. However, it was possible to reverse the sheet move several times in version 14.0. If upgrading a 14.0 database to 16.0 with such moves, a traceback is raised in "_compute_payment_state" method. opw-3997248 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171092