Description of the issue/feature this PR addresses:
-------------------

Auto-cancelling Time Offs when editing public holidays was added in Jun 2022 ([see PR](https://github.com/odoo/odoo/pull/81225)) , but the cancellation of Time Offs wasn't updated to also remove the link to timesheets. If the user attempts to manually delete a timesheet linked to a Time Off (`holiday_id`​ in `hr.leave`​), they will be asked to cancel the Time Off which by this point had already been auto-cancelled, and as long as the link exists (regardless of cancellation) the timesheet cannot be deleted from the user frontend.

This PR adds an override call to unlink the timesheets before the leave (the inital validated timeoff) is force canceled.

Current behavior before PR:
-------------------
Steps to reproduce:
1. Create and validate an arbitrary Time Off, checking that it also creates a timesheet entry.
2. Create a new public holiday spanning the entire duration of the Time Off created in (1)
3. Attempt to delete the timesheet entry created in (1), if it is not already deleted.

Although you will be asked to cancel the timeoff first, that is not possible because the timeoff will be auto-cancelled by this point, making the deletion of the timesheet impossible.

Desired behavior after PR is merged:
-------------------

At step 3, user should be able to delete the timesheet associated to the timeoff.

Task-3697074

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#168223
Forward-Port-Of: odoo/odoo#154321

## Pull Request HOOT (PRHOOT) - part 19

Part 1: https://github.com/odoo/odoo/pull/152930
Part 2: https://github.com/odoo/odoo/pull/153018
Part 3: https://github.com/odoo/odoo/pull/153023
Part 4: https://github.com/odoo/odoo/pull/153203
Part 5: https://github.com/odoo/odoo/pull/153425
Part 6: https://github.com/odoo/odoo/pull/153700
Part 7: https://github.com/odoo/odoo/pull/154054
Part 8: https://github.com/odoo/odoo/pull/154579
Part 9: https://github.com/odoo/odoo/pull/155073
Part 10: https://github.com/odoo/odoo/pull/155639
Part 11: https://github.com/odoo/odoo/pull/156255 / https://github.com/odoo/enterprise/pull/58135
Part 12: https://github.com/odoo/odoo/pull/156869
Part 13: https://github.com/odoo/odoo/pull/158384 / https://github.com/odoo/enterprise/pull/59019
Part 14: https://github.com/odoo/odoo/pull/158916
Part 15: https://github.com/odoo/odoo/pull/160292 / https://github.com/odoo/enterprise/pull/59971
Part 15.5: https://github.com/odoo/odoo/pull/166463
Part 16: https://github.com/odoo/odoo/pull/166311
Part 17: https://github.com/odoo/odoo/pull/168328
Part 18: https://github.com/odoo/odoo/pull/171004 / https://github.com/odoo/enterprise/pull/65657

Enterprise: https://github.com/odoo/enterprise/pull/65767

This pull requests brings various improvements and fixes to Hoot and the Odoo unit test ecosystem. See the different commit messages for more details.

Note: these changes are made in stable to avoid having to support multiple versions of the HOOT API. As such, these changes are intended to be strictly limited to unit tests as to not put the rest of the code base at risk.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#171242

When the grid mode was added in commit [1], the "Padding" grid option was impacting all the grid items at the same time. This was not looking good in the "Masonry" snippet, because the images would have the same padding as the text grid items, while it would look better if they could take the whole space. The padding was therefore forced to 0 px for this snippet images (see commit [2]), preventing this option from having an impact on them.

However, the "Padding" option was improved in commit [3], allowing the padding to be set on the grid items individually. There is therefore no need to block this option for the "Masonry" images anymore.

This commit removes the CSS rules preventing the "Padding" option from being applied on "Masonry" images. Note that the default padding is still set to 0 px, as it looks better, but it can now be modified with the option. Also note that the CSS rule about not showing the padding highlights was not working, as it was forgotten and not adapted when doing commit [3].

[1]: https://github.com/odoo/odoo/commit/cc406afcea7bf5846233a9f97a4a8ac5f618f3ec
[2]: https://github.com/odoo/odoo/commit/85b352af319edec84407f2046cf795b4e5503460
[3]: https://github.com/odoo/odoo/commit/11418cc6f0afcc8e14869f4f38ae0d6d462ac712

task-3970022

Forward-Port-Of: odoo/odoo#168013

Problem:
For an Italian public company, when sending an invoice there is no warning triggered when the field "Origin Document Type" is empty

Steps to reproduce:
- Install "Contacts" and "Accounting" apps
- Create an Italian company and set its fiscal localization
- Create a new Italian contact and fill out the "Destination Code" with a six-digit code
- Create an invoice for this contact, in the "Electronic Invoicing" tab, leave the field "Origin Document Type" empty
- Confirm the invoice and click on "Send & Print", there is no warning saying that the field "Origin Document Type" must be filled out

Cause:
Errors in the conditions

Note:
Modification in the get_records_action because self.id returns an id of type NewId which raise an error (see below) in this fix workflow because it is called in an onchange function. self.ids[0] returns an id of type int

Error raised: TypeError: Object of type NewId is not JSON serializable

Steps to reproduce:
- Do the 4 first steps as above
- Create a second invoice with another customer which is not a public italian administration (can be from another country)
- Select the invoices and click on "Send & Print" in the "Actions" button

opw-3844664

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#162776

**Steps to reproduce the bug:**
- Enable multi-step routes in the general settings.
- Go to the warehouse settings:
    - Select 3 steps for Outgoing Shipments.
- Create a storable product “P1”.
- Create a sales order with the following details:
    - Customer: Azure Interior
    - Product: 3 units of P1
- Confirm the sales order

- Go to the pick picking
- Set the quantity to 1 unit
- Validate the pick and create a backorder
- Go to the pack step and validate it

- Return to the pick backorder and validate it for 2 units
- Create a return from this backorder
- Validate the return
- Go back to the sales order

**Problem:**
The delivered quantity is set to -2 instead of 0. When the return is validated, the “_compute_qty_delivered” function is triggered, which uses both outgoing and incoming moves. The “_get_outgoing_incoming_moves” method is called to retrieve these moves. However, for return moves, we only check if the `location_dest` is not set to customer usage and if `move.to_refund` is not false, without verifying that the source location is from the customer.

opw-3962062

Forward-Port-Of: odoo/odoo#170787

This error occurs when the user drag & drop the newly created calendar event and select ``This and Following events`` in ``Edit Recurrent event``

Steps to reproduce:
- Install ``Calendar`` module
- Create a new event from the Calendar view
- Edit event -> Enable ``Recurrent``
- Now click on any day from ``Repeat on`` and remove the day which is selected by 
  default (eg: if Tuesday is the default then select Monday and unselect Tuesday)
- Save and Unarchive it and go back to the calendar view
- Now drag & drop the newly created event to anywhere and select 
  ``This and Following events`` in ``Edit Recurrent event``

Traceback: 
``ValueError: not enough values to unpack (expected 1, got 0)``

The error on line [1] occurs because ``recurrence_id`` is not found in ``self``. This issue stems from a change made in commit [2], where ``recurrency`` was set to ``True``. Consequently, when an event is archived, ``recurrency`` remains ``True``, but the event lacks a ``recurrence_id``. This absence of ``recurrence_id`` in ``self`` at line [1] triggers an error. However, before this commit, the expected behavior was that when an event is archived, ``recurrency`` should be set to ``False``.

This commit will fix the error by passing ``false`` for ``update_recurrence`` when ``recurrence_id`` is not present.

[1]: https://github.com/odoo/odoo/blob/d7cfef9c51461a595f3f46c7b91e5c56241d4af3/addons/calendar/models/calendar_event.py#L1196
[2]: https://github.com/odoo/odoo/commit/48e3f725a2506ca63336a131661542cacc6f1ab5

sentry-5462902179

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#169040

**Traceback:**
```python
('helpdesk.helpdesk_team_menu', 393, 'Helpdesk > Configuration > Helpdesk Teams', 559):
 Traceback (most recent call last):
   File "/tmp/tmpkjz256np/migrations/base/tests/test_mock_crawl.py", line 255, in crawl_menu
    self.mock_action(action_vals)
   File "/tmp/tmpkjz256np/migrations/base/tests/test_mock_crawl.py", line 412, in mock_action
    mock_method(model, view, fields_list, domain, group_by)
   File "/tmp/tmpkjz256np/migrations/base/tests/test_mock_crawl.py", line 441, in mock_view_form
    [data] = record.read(fields_list)
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 3540, in read
    return self._read_format(fnames=fields, load=load)
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 3751, in _read_format
    vals[name] = convert(record[name], record, use_display_name)
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 6631, in __getitem__
    return self._fields[key].__get__(self, self.env.registry[self._name])
   File "/home/odoo/src/odoo/17.0/odoo/fields.py", line 1207, in __get__
    self.compute_value(recs)
   File "/home/odoo/src/odoo/17.0/odoo/fields.py", line 1389, in compute_value
    records._compute_field_value(self)
   File "/home/odoo/src/odoo/17.0/addons/mail/models/mail_thread.py", line 424, in _compute_field_value
    return super()._compute_field_value(field)
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 4875, in _compute_field_value
    fields.determine(field.compute, self)
   File "/home/odoo/src/odoo/17.0/odoo/fields.py", line 102, in determine
    return needle(*args)
   File "/home/odoo/src/enterprise/17.0/helpdesk_timesheet/models/helpdesk_team.py", line 22, in _compute_total_timesheet_time
    [('helpdesk_ticket_id', 'in', helpdesk_timesheet_teams.ticket_ids.filtered(lambda x: not x.stage_id.fold).ids)],
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 6110, in filtered
    return self.browse([rec.id for rec in self if func(rec)])
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 6110, in <listcomp>
    return self.browse([rec.id for rec in self if func(rec)])
   File "/home/odoo/src/enterprise/17.0/helpdesk_timesheet/models/helpdesk_team.py", line 22, in <lambda>
    [('helpdesk_ticket_id', 'in', helpdesk_timesheet_teams.ticket_ids.filtered(lambda x: not x.stage_id.fold).ids)],
   File "/home/odoo/src/odoo/17.0/odoo/fields.py", line 2907, in __get__
    return super().__get__(records, owner)
   File "/home/odoo/src/odoo/17.0/odoo/fields.py", line 1182, in __get__
    recs._fetch_field(self)
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 3777, in _fetch_field
    self.fetch(fnames)
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 3827, in fetch
    fetched = self._fetch_query(query, fields_to_fetch)
   File "/home/odoo/src/odoo/17.0/odoo/models.py", line 3920, in _fetch_query
    rows = self.env.cr.fetchall()
 MemoryError
```
**Summary of changes:**
Previously, the code `helpdesk_timesheet_teams.ticket_ids.filtered( lambda x: not x.stage_id.fold).ids)` generating O(n) queries leading to a memory error when dealing with large numbers of tickets (e.g., 60k+ for this customer).

This commit refactors the code to use the search method instead. this approach reduces the number of queries to O(1) and significantly improves performance for customers with a large number of helpdesk tickets.

UPG - [1776915](https://upgrade.odoo.com/web#id=1776915&cids=1&menu_id=107&action=150&model=upgrade.request&view_type=form)
TASK - [3995988](https://www.odoo.com/odoo/my-tasks/3995988?cids=2)

Forward-Port-Of: odoo/enterprise#65615

When creating a timesheet from the ticket view form, an access error is raised if the active company is different from the company of its project.

Step to reproduce:
- install helpdesk_sale_timesheet
- open helpdek
- open configuration menu -> helpdesk teams
- select a team with the visibility set on 'invited portal users'
- enable the 'billing' feature, and add a project on this team
- select as active company any company other than the one set on the project selected before
- select an existing ticket, or create a new one on the team
- try creating a new timesheet Validation error is raised

Source of the issue:
If no company_id is given in the vals_list, the default company_id used by analytic line model is the active company. The issue is not present on task, because the key 'company_id' is correctly set in the '_timesheet_preprocess' method. This method is overwritten in the helpdesk_sale module and the updates done in it prevent the correct setting of the 'company_id' later on.

Solution:
Ensure that the 'company_id' key is present and consistent when creating a new timesheet from the ticket form view.

version: 16.0 - master

task - 3581941

Forward-Port-Of: odoo/enterprise#65835
Forward-Port-Of: odoo/enterprise#50150

When renting with deliveries, if it's about a kit with subkit and
shared component, the return will not be correct

To reproduce the issue:
1. In Settings, enable "Rental Transfers"
2. Create a kit K as follow:
   - K
     - C1
       - C2
       - C3
     - C2
3. Confirm a rental with 1 x K

Error: in the return, there are two lines for each C2, which makes
sense since each line is linked to a different kit. However, the
quantity on each line is incorrect: 2 instead of 1

When generating the SM of the return, we first generate the values
https://github.com/odoo/odoo/blob/8db471e74238481a5429f0fcf8fbce1c0960ff27/addons/stock/models/stock_rule.py#L205-L206
In `_push_prepare_move_copy_values`, at some point, we adapt the
quantity of the returned SM based on the other SM of the SO. To do
so, we only consider the SM with the same product (among other
conditions). This criterion is not strict enough: for instance, when
looking at C2 of K, we take its quantity *and* we also take C2 of C1,
which is incorrect. Of course, we do the same when looking at C2 of
C1, hence the incorrect quantities.

OPW-3996074

Forward-Port-Of: odoo/enterprise#65787
Forward-Port-Of: odoo/enterprise#65758

### Original issue:
When creating a debit note on a bill from a purchase order with the option 'copy_lines', the field 'Purchase Order' in the lines is not populated.

### Steps to reproduce:
- Install Purchase, Inventory apps and the l10n_co_edi module
- Switch to a Colombian company
- Go to Accounting > Configuration > Accounting > Journals
- In the Vendor Bill journal > Advanced Settings, uncheck the 'Electronic invoicing UBL 2.1 (Colombia)' option
- Go to Purchase > Orders > Purchase Orders, create a new one and confirm it
- 'Receive Products' and 'Validate'
- Go back to the Purchase order
- 'Create Bill' and 'Confirm'
- From actions, choose 'Debit Note'
- In the wizard, tick 'Copy Lines', select a 'Concepto Nota de Débito' and 'Create Debit Note'
- Display the Purchase Order field in the Invoice Line tab is visible, it should not be populated

### Cause:
This bug is due to another fix that have been badly made because no tests were there. Most of the content of enterprise/l10n_co_edi/wizards/account_debit_note.py:_prepare_default_values is not called when it is supposed to and called when it's not. 

In the 'Create Debit Note' wizard view there is an option to copy the lines and so, autopopulate them. This option is not displayed for Debit Notes generated from Credit Notes because the lines would be negative. 
(https://github.com/odoo/odoo/blob/47eff65afdba3a2a8283342d8b636657f1fac317/addons/account_debit_note/wizard/account_debit_note_view.xml#L16) 

The logic of this option is located in the module account_debit_note: https://github.com/odoo/odoo/blob/2a02ba4de1c823bcdef0e8b6b6373fa27b5587a1/addons/account_debit_note/wizard/account_debit_note.py#L64, the line_ids value is filled with a default value if copy_lines is False. If left empty, the lines are copied from the original account.move. 

In this commit, https://github.com/odoo/enterprise/commit/c738f14d4ac88d508b6b75747788f5867eb71a68 we are trying to manually populate the lines of a debit note when it is generated from a credit note. But the code is made so that the lines are always copied. 

So in this other commit https://github.com/odoo/enterprise/commit/fa65a1ff8cb7333a3339438513d1eeb5d5f9690e there is a correction to take the copy_lines into consideration. But it breaks the precedent fix as Debit Notes of Credit Notes always have copy_lines to False. So the code to copy the lines manually is actually never called for Debit Notes of Credit Notes (which is the only case we want it to be called in). But is called every time copy_lines is set to True therefore ignoring the actual code to copy the lines in the module account_debit_note. 

In the context of the bug of this PR, the problem comes from the manual copying of lines that is missing the value purchase_order_id.

### Solution:
Changing the logic of the _prepare_default_values function:
- if not a Colombian company or not a debit note of a credit note, stop here
       - we let the logic in account_debit_note copy the lines (or not) depending on copy_lines.
- if the debit note comes from a credit note, we copy the lines and return

With this flow, the lines will not be copied manually so the value purchase_order_id will be populated.

opw-3962301

Forward-Port-Of: odoo/enterprise#65528
Forward-Port-Of: odoo/enterprise#64689

## Pull Request HOOT (PRHOOT) - part 19

Part 1: https://github.com/odoo/odoo/pull/152930
Part 2: https://github.com/odoo/odoo/pull/153018
Part 3: https://github.com/odoo/odoo/pull/153023
Part 4: https://github.com/odoo/odoo/pull/153203
Part 5: https://github.com/odoo/odoo/pull/153425
Part 6: https://github.com/odoo/odoo/pull/153700
Part 7: https://github.com/odoo/odoo/pull/154054
Part 8: https://github.com/odoo/odoo/pull/154579
Part 9: https://github.com/odoo/odoo/pull/155073
Part 10: https://github.com/odoo/odoo/pull/155639
Part 11: https://github.com/odoo/odoo/pull/156255 / https://github.com/odoo/enterprise/pull/58135
Part 12: https://github.com/odoo/odoo/pull/156869
Part 13: https://github.com/odoo/odoo/pull/158384 / https://github.com/odoo/enterprise/pull/59019
Part 14: https://github.com/odoo/odoo/pull/158916
Part 15: https://github.com/odoo/odoo/pull/160292 / https://github.com/odoo/enterprise/pull/59971
Part 15.5: https://github.com/odoo/odoo/pull/166463
Part 16: https://github.com/odoo/odoo/pull/166311
Part 17: https://github.com/odoo/odoo/pull/168328
Part 18: https://github.com/odoo/odoo/pull/171004 / https://github.com/odoo/enterprise/pull/65657

Communtiy: https://github.com/odoo/odoo/pull/171242

This pull requests brings various improvements and fixes to Hoot and the Odoo unit test ecosystem. See the different commit messages for more details.

Note: these changes are made in stable to avoid having to support multiple versions of the HOOT API. As such, these changes are intended to be strictly limited to unit tests as to not put the rest of the code base at risk.

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/enterprise#65767

Steps to Reproduce:
 -------------------
 1. Install hr_contract_salary module, create an advantage.
 2. In the advantages 'Display Type' field should be 'Always selected'.
 3. Leave the res_field_id field empty.
 4. Put this advantage as Mandatory Advantage for another field.
 5. Open Recruitement App, create and send an offer.
 6. Go to Offers smart button and open the Offer link.
 7. There will be an Internal Server Error.

 To resolve this issue we'll just continue wherever the res_field_id is not set. Because
 if the res_field_id is not set it'll have no value which in return gives False(bool) which
 can't be appended.

 Traceback:

```py
 Traceback (most recent call last):
  File "/home/odoo/src/odoo/17.0/odoo/http.py", line 1770, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/home/odoo/src/odoo/17.0/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/home/odoo/src/odoo/17.0/odoo/http.py", line 1797, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/home/odoo/src/odoo/17.0/odoo/http.py", line 1914, in dispatch
    return self.request.registry['ir.http']._dispatch(endpoint)
  File "/home/odoo/src/odoo/17.0/odoo/addons/base/models/ir_http.py", line 222, in _dispatch
    result = endpoint(**request.params)
  File "/home/odoo/src/odoo/17.0/odoo/http.py", line 725, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/home/odoo/src/enterprise/17.0/hr_contract_salary/controllers/main.py", line 231, in salary_package
    values = self._get_default_template_values(contract, offer)
  File "/home/odoo/src/enterprise/17.0/hr_contract_salary/controllers/main.py", line 131, in _get_default_template_values
    values = self._get_salary_package_values(contract, offer)
  File "/home/odoo/src/enterprise/17.0/hr_contract_salary/controllers/main.py", line 411, in _get_salary_package_values
    mapped_benefits, mapped_dependent_benefits, mandatory_benefits, mandatory_benefits_names, benefit_types, dropdown_options_2, dropdown_group_options, initial_values_2 = self._get_benefits_values(contract, offer)
  File "/home/odoo/src/enterprise/17.0/hr_contract_salary/controllers/main.py", line 397, in _get_benefits_values
    dependent_name = dependent_benefit.field + '_' + dependent_benefit.display_type
TypeError: unsupported operand type(s) for +: 'bool' and 'str'
```

Forward-Port-Of: odoo/enterprise#62255