Friday, July 5, 2024
4 changes · saas-17.2
Resolved issues and error corrections
Users can now duplicate recurring shifts in Planning without being interrupted by the recurring shift edit window. This fixes a workflow issue and makes schedule copying behave as expected.
Original PR description
Currently, it is impossible to duplicate a recurring shift, because the "Edit Recurring Shift" modal opens instead. This PR fixes it by preventing this modal from opening and copying the shift as it should. The problem is that the "dragPillDrop" method will open the modal if the shift is recurring, no matter if you are trying to copy it or not. To fix it, a condition was added to check if the shift is being copied or not, and if so, it won't open the modal. task-3978527
The salary configurator now correctly disables benefit values when the required related benefit is not selected. This prevents loaded offers from keeping invalid benefit choices, helping HR teams produce accurate contract offers.
Original PR description
When we are loading an offer in the salary configurator, if values are set to a benefit that depends on another one which is disabled. You are keeping the value of the contract, and it is not disabled as it should because the mandatory benefit is not set.
We've got this issue because the variable in the loop has the same name as the one we really need declared before ('mandatoryBenefitSelected').
We also remove the loop and the split, as it is already done in the function 'updateDependentBenefits' that is called.
TASK-ID: NONEThis fixes an issue where the starred message counter could stay outdated in another browser tab after a starred message was deleted. The counter is now updated from the server, so users see a consistent and reliable count across tabs.
Original PR description
Before this PR, the star message counter was not updated on message deletion on tabs that were unaware of the message. Steps to reproduce the issue: - Open two tabs and log in as admin. - Star a message; the counter should show 1 on both tabs. - Reload one tab without accessing the channel. - Delete the starred message from the other tab. - Notice that the star counter on the second tab still shows 1. The issue arose because the client-side star counter updated based on partial information, specifically only when the message was starred. If the message had not been fetched, this information was unavailable. This PR resolves the issue by removing the client-side computation and implementing a server-side notification instead. runbot-61305,62004
Fixes an issue where applicants entering an invalid LinkedIn URL on a job application briefly saw a warning that then disappeared. The warning now remains visible when needed, helping applicants correct their information before submitting.
Original PR description
steps to reproduce -go to host/jobs -go to any job -put a wrong linkedin url -> the message is not displayed (after a blink) reason https://github.com/odoo/enterprise/pull/65011 this pr adds a js function (checkRedundant) that remove the warning message no matter what if its check are successful fix adds a condition and parma to check if the warning message should be removed or not task-4010892 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr