Monday, July 8, 2024
34 changes · saas-17.3
Enhancements to existing features
Mobile point of sale screens now place dialog action buttons on the left for easier, more consistent use. The update also tightens customer list spacing and adds clearer separation between receipt screen order actions.
Original PR description
Additionally: - We remove excessive spaces in the customer list. - Put a gap between "New Order" and "Resume Order" buttons in the receipt screen. Task id : 3964834
Resolved issues and error corrections
The navigation bar now shows the Home Menu toggle at the correct screen size, preventing it from overlapping with the app icon when users resize the browser. This improves the visual quality and usability of the app header on medium-width screens.
Original PR description
Since commit [1], the NavBar actually removes the parts/buttons specific to small/desktop-like screens instead of hidding them with responsive classes. This commit adapts also the HomeMenu toggle icon's breakpoint to match `isSmall`, avoiding a ugly overlap between `md` and `lg` breakpoints. Steps to reproduce: - open an app with a resolution > 992px - resize the viewport below 992px => the app's icon and HomeMnu one are overlapping opw-4033259 [1]: odoo/enterprise@a586702247e5dbe3690377d19cc84f7ab54e77ee
Miscellaneous changes
[FIX] l10n_dk: fix some accounts' type Some accounts are set as "Expense" but it should be "Cost of revenue" Change them to 'expense_direct_cost' type task-id#3983710 enterprise-pr#[66202](https://github.com/odoo/enterprise/pull/66202) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168838
Original PR description
[FIX] l10n_dk: fix some accounts' type Some accounts are set as "Expense" but it should be "Cost of revenue" Change them to 'expense_direct_cost' type task-id#3983710 enterprise-pr#[66202](https://github.com/odoo/enterprise/pull/66202) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168838
Versions -------- - 17.0+ Steps ----- 1. Go to working schedules; 2. try to modify duration days. Issue ----- Any change gets undone immediately. Cause ----- Commit https://github.com/odoo/odoo/commit/bbae19cc630cb629adabbc54e7fa96f23a4359d8 added `calendar_id.hours_per_day` to the dependent fields of the `_compute_duration_days` method. Because modifications happen on temporary records, any modification will now trigger a recompute, overwriting the manual values. Solution
Original PR description
Versions -------- - 17.0+ Steps ----- 1. Go to working schedules; 2. try to modify duration days. Issue ----- Any change gets undone immediately. Cause ----- Commit https://github.com/odoo/odoo/commit/bbae19cc630cb629adabbc54e7fa96f23a4359d8 added `calendar_id.hours_per_day` to the dependent fields of the `_compute_duration_days` method. Because modifications happen on temporary records, any modification will now trigger a recompute, overwriting the manual values. Solution -------- Remove `calendar_id.hours_per_day` from `api.depends`. Having the fields editable is preferable over triggering recomputes ASAP. opw-3999825 Forward-Port-Of: odoo/odoo#171109
Before that commit, it was possible to register several times the same template extension. This can lead to crash in some occasions. For example consider the template ```xml <t t-name="A"> <div attr="a" /> </t> ``` and its extension ```xml <t t-name="B" t-inherit="A" t-inherit-mode="extension"> <xpath expr=".//div[@attr='a']" position="attributes"> <attribute name="attr">b</attribute> </xpath> </t> ``` In that case, when building the template A with B registered
Original PR description
Before that commit, it was possible to register several times the same template extension. This can lead to crash in some occasions. For example consider the template
```xml
<t t-name="A">
<div attr="a" />
</t>
```
and its extension
```xml
<t t-name="B" t-inherit="A" t-inherit-mode="extension">
<xpath expr=".//div[@attr='a']" position="attributes">
<attribute name="attr">b</attribute>
</xpath>
</t>
```
In that case, when building the template A with B registered twice, the first application of B to A will succeed while the second application will cause a crash (no target found for the xpath).
Here we prevent multiple registering of the same template extensions. Note that this is similar to what happens when the same js module is received several times: odoo.define has no effect after the first registering.
Forward-Port-Of: odoo/odoo#172246Steps: - Add "rate" field via Studio in the currency form - Try to create a currency Actual result: - Traceback due to rate computation ```python currency.rate = (currency_rates.get(currency.id) ) / currency_rates.get(to_currency.id) TypeError: unsupported operand type(s) for /: 'NoneType' and 'float' ``` Expected result: - Default rate value is 1.0 (cf 16.0) opw-4039324 Caused-By: https://github.com/odoo/odoo/commit/9353a6f9ba81926c7002b3ca5b53ac66fed9aebd --- I confirm
Original PR description
Steps: - Add "rate" field via Studio in the currency form - Try to create a currency Actual result: - Traceback due to rate computation ```python currency.rate = (currency_rates.get(currency.id) ) / currency_rates.get(to_currency.id) TypeError: unsupported operand type(s) for /: 'NoneType' and 'float' ``` Expected result: - Default rate value is 1.0 (cf 16.0) opw-4039324 Caused-By: https://github.com/odoo/odoo/commit/9353a6f9ba81926c7002b3ca5b53ac66fed9aebd --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172211
When mail totp is enforced, users are required to perform the MFA step after signup, before signin. The authentication is partial and the user is set to None. This causes the signup request to fail at the mail template rendering step with an access right error even though the registration is actually successful. Steps to reproduce: - Install apps `auth_totp_mail_enforce` and `website` - Login with admin user - In Settings: - Enable "Enforce two-factor authentication", set it to "All
Original PR description
When mail totp is enforced, users are required to perform the MFA step after signup, before signin. The authentication is partial and the user is set to None. This causes the signup request to fail at the mail template rendering step with an access right error even though the registration is actually successful. Steps to reproduce: - Install apps `auth_totp_mail_enforce` and `website` - Login with admin user - In Settings: - Enable "Enforce two-factor authentication", set it to "All users" - Set "Customer Account" to "Free sign up" - In a clean session (private browsing), try to sign up an account Old behavior: 403 error New behavior: 2FA page opw-3968129 Forward-Port-Of: odoo/odoo#169594
Issue --> When editing the account code for an `account.account` record with a large number of related `account.move.lines`, the method `_compute_always_tax_exigible` get called down the compute tree on all related `account.move` records. This leads to a MemoryError as the underlying field_cache expands beyond the allocated memory limit. Solution --> Disable the prefetcher in the loop to reduce the number of allocations made to the field_cache. Benchmarks --> Memory utiliz
Original PR description
Issue --> When editing the account code for an `account.account` record with a large number of related `account.move.lines`, the method `_compute_always_tax_exigible` get called down the compute tree on all related `account.move` records. This leads to a MemoryError as the underlying field_cache expands beyond the allocated memory limit. Solution --> Disable the prefetcher in the loop to reduce the number of allocations made to the field_cache. Benchmarks --> Memory utilization before PR -->  Reference flamegraph --> https://drive.google.com/file/d/1ptI8mOfvaACFmuwIEiN5f0rFRueu9h46/view?usp=drive_link After PR -->  Reference flamgraph --> https://drive.google.com/file/d/1dcaLz3jrDmkX96WagAylkL1V--dz9jNQ/view?usp=drive_link opw-3957975 Forward-Port-Of: odoo/odoo#171122
Problem: When you click on the On Hand smart button from a product variant, it will show the on hand quantity for all of the product's variants. Purpose: Clicking on the On Hand smart button from a product variant should show only the on hand quantity for that specific product variant. Steps to Reproduce on Runbot: 1. Create a storable product with an attribute that has two values to create two product variants 2. Purchase stock for both product variants 3. Receive the purchased produ
Original PR description
Problem: When you click on the On Hand smart button from a product variant, it will show the on hand quantity for all of the product's variants. Purpose: Clicking on the On Hand smart button from a product variant should show only the on hand quantity for that specific product variant. Steps to Reproduce on Runbot: 1. Create a storable product with an attribute that has two values to create two product variants 2. Purchase stock for both product variants 3. Receive the purchased products 4. Enable Storage Locations in Settings > Inventory 5. Navigate to one of the product variants and click on the On Hand smart button 6. Observe that it shows the on hand quantity for both product variants opw-3988374 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171306
Purpose ======= Considering that the user isn't admin, has enough karma to delete a post comment but not enough karma to delete a post. When the user deletes a comment, fix the warning alert saying that he doesn't have enough karma even though he has. Specification ============= Changing the condition to display the warning in the xml to use the comment unlink required karma instead of the post one. There is no comment can_unlink field so rebuilding the can_unlink condition. Task-4001
Original PR description
Purpose ======= Considering that the user isn't admin, has enough karma to delete a post comment but not enough karma to delete a post. When the user deletes a comment, fix the warning alert saying that he doesn't have enough karma even though he has. Specification ============= Changing the condition to display the warning in the xml to use the comment unlink required karma instead of the post one. There is no comment can_unlink field so rebuilding the can_unlink condition. Task-4001283 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172167 Forward-Port-Of: odoo/odoo#170130
Forward-Port-Of: odoo/odoo#172203
Original PR description
Forward-Port-Of: odoo/odoo#172203
In [1] when the translation conditions were adapted to allow restricted editors to translate, the general editability right was wrongly impacted, making the user believe a page could be edited when it was not the case. This commit restores the editability condition and limits the translatability to records that can be modified by the restricted editor user. A `_check_user_can_modify` is introduced to enable customization. Steps to reproduce (described in terms of expected behavior):
Original PR description
In [1] when the translation conditions were adapted to allow restricted editors to translate, the general editability right was wrongly impacted, making the user believe a page could be edited when…
In [1] when the translation conditions were adapted to allow restricted editors to translate, the general editability right was wrongly impacted, making the user believe a page could be edited when it was not the case. This commit restores the editability condition and limits the translatability to records that can be modified by the restricted editor user. A `_check_user_can_modify` is introduced to enable customization. Steps to reproduce (described in terms of expected behavior): - Install `website_sale` and `website_event` - Add a language to the website - Assign the following rights to a non-admin user: - Website: Restricted editor - Sale: Administrator - Event: No right - Log in as that user - Go to the contact us page: - Edit: nothing should be possible - Translate: not available - Go to a product page: - Edit: blocks can be dropped in fields, texts can be changed - Translate: available and texts can be changed - Go to an event page: - Edit: nothing should be possible - Translate: not available [1]: https://github.com/odoo/odoo/commit/1bcc0733c9af52c6cf38b12f24ff6ed96314bec4 Forward-Port-Of: odoo/odoo#171990 Forward-Port-Of: odoo/odoo#170102
Steps to reproduce the bug: - Create a storable product “P1”: - Create a reorder rule: - Min qty: 5 - Route: Buy - Click the “To order” button Problem: The button does not become invisible; the page must be refreshed to see the update. This can lead to user error if the user clicks the “order once” button a second time. opw-3994600 Forward-Port-Of: odoo/odoo#171968
Original PR description
Steps to reproduce the bug:
- Create a storable product “P1”:
- Create a reorder rule:
- Min qty: 5
- Route: Buy
- Click the “To order” button
Problem:
The button does not become invisible; the page must be refreshed to see the update. This can lead to user error if the user clicks the “order once” button a second time.
opw-3994600
Forward-Port-Of: odoo/odoo#171968Previously, the action to retrieve traces fetched all records irrespective of their relationship with the specific Mass Mailing. This commit refines the retrieval process to only include traces associated with the corresponding Mass Mailing. [Reproduce] - Install mass_mailing - Open Email Marketing, Create new mass_mailing with Recipients set to "Contact" - Send to all - Select "Opened" (or any of the others control panel actions) - BUG: list is not empty, it should! (same for the other
Original PR description
Previously, the action to retrieve traces fetched all records irrespective of their relationship with the specific Mass Mailing. This commit refines the retrieval process to only include traces associated with the corresponding Mass Mailing. [Reproduce] - Install mass_mailing - Open Email Marketing, Create new mass_mailing with Recipients set to "Contact" - Send to all - Select "Opened" (or any of the others control panel actions) - BUG: list is not empty, it should! (same for the other control traces) Generalization: Note that in the steps above we used Recipients set to "Contact" it will render buggy behavior with any recipients, however in this way we have existing contact traces that show up opw-3959467 Forward-Port-Of: odoo/odoo#168304
Forward-Port-Of: odoo/odoo#172084
Original PR description
Forward-Port-Of: odoo/odoo#172084
Before this commit, the getFiltersMatchingPivot was prone to errors when the input that is supposed to be generated automatically has been wrongly formed by the user. After this commit, the function is more robust and has sensible defaults. OWP: 3952358 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172028 Forward-Port-Of: odoo/odoo#171630
Original PR description
Before this commit, the getFiltersMatchingPivot was prone to errors when the input that is supposed to be generated automatically has been wrongly formed by the user. After this commit, the function is more robust and has sensible defaults. OWP: 3952358 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172028 Forward-Port-Of: odoo/odoo#171630
Before this PR, the star message counter was not updated on message deletion on tabs that were unaware of the message. Steps to reproduce the issue: - Open two tabs and log in as admin. - Star a message; the counter should show 1 on both tabs. - Reload one tab without accessing the channel. - Delete the starred message from the other tab. - Notice that the star counter on the second tab still shows 1. The issue arose because the client-side star counter updated based on partial info
Original PR description
Before this PR, the star message counter was not updated on message deletion on tabs that were unaware of the message. Steps to reproduce the issue: - Open two tabs and log in as admin. - Star a message; the counter should show 1 on both tabs. - Reload one tab without accessing the channel. - Delete the starred message from the other tab. - Notice that the star counter on the second tab still shows 1. The issue arose because the client-side star counter updated based on partial information, specifically only when the message was starred. If the message had not been fetched, this information was unavailable. This PR resolves the issue by removing the client-side computation and implementing a server-side notification instead. runbot-61305,62004 Forward-Port-Of: odoo/odoo#169936
In a grouped kanban view, drag and drop a record from a group which contains a lot of records and has the "Load more" displayed in the bottom (i.e. which contains more records than the limit). Before this commit, the drag&dropped record was displayed twice: once where it was dropped (which is fine), and once from where it was dragged (which is wrong). This happened because we didn't correctly synchronize the reload of the column (which must be done because there're more records than the limit
Original PR description
In a grouped kanban view, drag and drop a record from a group which contains a lot of records and has the "Load more" displayed in the bottom (i.e. which contains more records than the limit). Before…
In a grouped kanban view, drag and drop a record from a group which contains a lot of records and has the "Load more" displayed in the bottom (i.e. which contains more records than the limit). Before this commit, the drag&dropped record was displayed twice: once where it was dropped (which is fine), and once from where it was dragged (which is wrong). This happened because we didn't correctly synchronize the reload of the column (which must be done because there're more records than the limit, and we "removed" one record from the column) and the update on the moved record (s.t. it belongs to the correct column). As a consequence, we reloaded the column before updating the record, so it was still part of the original column. This commit fixes the issue by splitting the logic of the _removeRecords function: before, it altered the records locally (to filter out removed records) and updated the count, and, if necessary, it reloaded the list. Now, _removeRecords is only responsible to update the list locally, which must be done directly as we want the user to get a direct feedback of the move. In the flows where a reload might be necessary, we do it afterwards. In the case of a moveRecord, we can then do it after the update on the record. opw-3891269 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171880 Forward-Port-Of: odoo/odoo#171411
[IMP] l10n_tr: improve turkey's tax structure Adding new accounts Adding entirely new taxes Restructure the tax and tax group Create new tax report Reason: Enhance the user-experience in turkey Task-3924220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172056 Forward-Port-Of: odoo/odoo#167258
Original PR description
[IMP] l10n_tr: improve turkey's tax structure Adding new accounts Adding entirely new taxes Restructure the tax and tax group Create new tax report Reason: Enhance the user-experience in turkey Task-3924220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172056 Forward-Port-Of: odoo/odoo#167258
Forward-Port-Of: odoo/odoo#172070
Original PR description
Forward-Port-Of: odoo/odoo#172070
Replace Sales Analysis By Customers with Sales Analysis Per Customers opw-3999628 Forward-Port-Of: odoo/odoo#171286
Original PR description
Replace Sales Analysis By Customers with Sales Analysis Per Customers opw-3999628 Forward-Port-Of: odoo/odoo#171286
steps to reproduce -go to host/jobs -go to any job -put a wrong linkedin url -> the message is not displayed (after a blink) reason https://github.com/odoo/enterprise/pull/65011 this pr adds a js function (checkRedundant) that remove the warning message no matter what if its check are successful fix adds a condition and parma to check if the warning message should be removed or not task-4010892 Description of the issue/feature this PR addresses: Current behavior before PR
Original PR description
steps to reproduce -go to host/jobs -go to any job -put a wrong linkedin url -> the message is not displayed (after a blink) reason https://github.com/odoo/enterprise/pull/65011 this pr adds a js function (checkRedundant) that remove the warning message no matter what if its check are successful fix adds a condition and parma to check if the warning message should be removed or not task-4010892 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#170693
**Crash Prevention:** Added validation to ensure a certificate is selected before saving and publishing, preventing errors. **Creation Restriction:** Removed the option to create certifications from the front-end to avoid incomplete setups, requiring back-end customization. **Code cleanup**: Remove an unused template. Task-3940344 Forward-Port-Of: odoo/odoo#167740
Original PR description
**Crash Prevention:** Added validation to ensure a certificate is selected before saving and publishing, preventing errors. **Creation Restriction:** Removed the option to create certifications from the front-end to avoid incomplete setups, requiring back-end customization. **Code cleanup**: Remove an unused template. Task-3940344 Forward-Port-Of: odoo/odoo#167740
[FIX] l10n_dk_reports: fix account type of DK report tests By fixing the type of the account "Purchase of goods" from expense to expense_direct_cost the test now takes the new first expense account which is now "Freight costs" and not "Purchase of goods" anymore task-id#3983710 odoo-pr#[168838](https://github.com/odoo/odoo/pull/168838) Forward-Port-Of: odoo/enterprise#66202
Original PR description
[FIX] l10n_dk_reports: fix account type of DK report tests By fixing the type of the account "Purchase of goods" from expense to expense_direct_cost the test now takes the new first expense account which is now "Freight costs" and not "Purchase of goods" anymore task-id#3983710 odoo-pr#[168838](https://github.com/odoo/odoo/pull/168838) Forward-Port-Of: odoo/enterprise#66202
**Version:** - saas-16.3 **Step to reproduce:** - In the sign app, open the sign template iframe view. - When zooming in, the 'Sign Now' button breaks the text and creates extra space in the breadcrumb. **Issue:** Currently, the sign now button text creates extra spacing. **Solution:** Add the CSS class so that it will not create additional spacing task-3977792 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port
Original PR description
**Version:** - saas-16.3 **Step to reproduce:** - In the sign app, open the sign template iframe view. - When zooming in, the 'Sign Now' button breaks the text and creates extra space in the breadcrumb. **Issue:** Currently, the sign now button text creates extra spacing. **Solution:** Add the CSS class so that it will not create additional spacing task-3977792 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/enterprise#64648
Steps to reproduce ================== - Open "Documents" app - Select any workspace - Click dropdown next to "Upload" - Select "Share" - Select "Download and Upload" from the "Allows to" radio buttons - Select "Share" Solution ======== Use the same solution as - https://github.com/odoo/enterprise/commit/f3320efad924623ea553847538c6244459a734d5 - https://github.com/odoo/enterprise/commit/2c6716e7f619423414b615015bf86fbd11256953 - https://github.com/odoo/enterprise/commit/2820
Original PR description
Steps to reproduce ================== - Open "Documents" app - Select any workspace - Click dropdown next to "Upload" - Select "Share" - Select "Download and Upload" from the "Allows to" radio buttons - Select "Share" Solution ======== Use the same solution as - https://github.com/odoo/enterprise/commit/f3320efad924623ea553847538c6244459a734d5 - https://github.com/odoo/enterprise/commit/2c6716e7f619423414b615015bf86fbd11256953 - https://github.com/odoo/enterprise/commit/2820230bf722d602540943ff9f17bd72e991bea9 opw-3990839 Forward-Port-Of: odoo/enterprise#65207
## Steps to reproduce: - Install **Timesheets** and **payroll** apps. - Create a copy of the (**Standard 40 hours/week**) working schedule but remove **Wednesday** working hours. - Create a new **employee**, and set his Working Hours to the newly created working schedule. - Create a new **_running_** **contract** for the newly created employee with the newly created working schedule. - Go to **Timesheets** app, and search for the newly created employee. - **Add a line** for a project and r
Original PR description
## Steps to reproduce: - Install **Timesheets** and **payroll** apps. - Create a copy of the (**Standard 40 hours/week**) working schedule but remove **Wednesday** working hours. - Create a new…
## Steps to reproduce: - Install **Timesheets** and **payroll** apps. - Create a copy of the (**Standard 40 hours/week**) working schedule but remove **Wednesday** working hours. - Create a new **employee**, and set his Working Hours to the newly created working schedule. - Create a new **_running_** **contract** for the newly created employee with the newly created working schedule. - Go to **Timesheets** app, and search for the newly created employee. - **Add a line** for a project and register 8 hours in each day from Monday to Saturday. - Switch the view to Day, Notice how for both Wednesday and Saturday, no overtime is shown. +08:00 should be shown for each as both are non-working days per the newly created working schedule. **(Issue 2)** ## Investigation: - The overtime text comes from https://github.com/odoo/enterprise/blob/1720b5578998b28c91c6820a63ecbd397297c47f/timesheet_grid/static/src/components/employee_overtime_indication/employee_overtime_indication.xml#L8 using `overtimeIndication()` getter https://github.com/odoo/enterprise/blob/1720b5578998b28c91c6820a63ecbd397297c47f/timesheet_grid/static/src/components/employee_overtime_indication/employee_overtime_indication.js#L34 - For the off days - (Wed, Sat, Sun) in our example -, the `allocated_hours` (`this.props.allocated_hours`) = ZERO - And so `shouldShowHours()` returns `false` https://github.com/odoo/enterprise/blob/1720b5578998b28c91c6820a63ecbd397297c47f/timesheet_grid/static/src/components/employee_overtime_indication/employee_overtime_indication.js#L19-L21 - which makes `overtimeIndication()` returns null. That's why no overtime text is shown for off-days - Note that `allocated_hours` is `undefined` for rows that represent employee hours of the current week opw-3718279 Forward-Port-Of: odoo/enterprise#64624 Forward-Port-Of: odoo/enterprise#60048
Currently, it is impossible to duplicate a recurring shift, because the "Edit Recurring Shift" modal opens instead. This PR fixes it by preventing this modal from opening and copying the shift as it should. The problem is that the "dragPillDrop" method will open the modal if the shift is recurring, no matter if you are trying to copy it or not. To fix it, a condition was added to check if the shift is being copied or not, and if so, it won't open the modal. task-3978527 Forward-Port-Of: o
Original PR description
Currently, it is impossible to duplicate a recurring shift, because the "Edit Recurring Shift" modal opens instead. This PR fixes it by preventing this modal from opening and copying the shift as it should. The problem is that the "dragPillDrop" method will open the modal if the shift is recurring, no matter if you are trying to copy it or not. To fix it, a condition was added to check if the shift is being copied or not, and if so, it won't open the modal. task-3978527 Forward-Port-Of: odoo/enterprise#65881
Steps: -------- - Install Field Service module - Now, go to the field service's configuration - Click on Time and Material invoicing - Make the new Task - Add products - Now in internal user, give users access right level > sale: own document only - Now login as a user who has user access right level - After login, go to field service module - Open that task in which sale order automatically generated, access error comes Issue: ------- - An user who has user access rights level tr
Original PR description
Steps: -------- - Install Field Service module - Now, go to the field service's configuration - Click on Time and Material invoicing - Make the new Task - Add products - Now in internal user, give…
Steps: -------- - Install Field Service module - Now, go to the field service's configuration - Click on Time and Material invoicing - Make the new Task - Add products - Now in internal user, give users access right level > sale: own document only - Now login as a user who has user access right level - After login, go to field service module - Open that task in which sale order automatically generated, access error comes Issue: ------- - An user who has user access rights level trying to read other user sale order. Cause: --------- - In this **PR enterprise-31363** added a new field pricelist_id on model project.task.This field is computed in _compute_currency_id.However user have no access to read record, therefore raises an access error for internal user. Fix: ----- - A sudo is used in method _compute_currency_id to be able to open the task but can not see sale order stat button. task-3610485 Forward-Port-Of: odoo/enterprise#66098 Forward-Port-Of: odoo/enterprise#52677
Steps to reproduce: - set a customer with Belgian VAT and check one with German VAT - Create sales: * one for the Belgian company using the 0% EU sale taxe * another for the German company using the 0% tax for construction (provider §13b) - Go To Statement Reports > EC Sales List Issue: Only the invoice for the Belgian company should appear in the report EC Sales 60 tag should not be present only tags in (41, 42, 21) source: https://apps.datev.de/help-center/documents/1017530 op
Original PR description
Steps to reproduce: - set a customer with Belgian VAT and check one with German VAT - Create sales: * one for the Belgian company using the 0% EU sale taxe * another for the German company using the 0% tax for construction (provider §13b) - Go To Statement Reports > EC Sales List Issue: Only the invoice for the Belgian company should appear in the report EC Sales 60 tag should not be present only tags in (41, 42, 21) source: https://apps.datev.de/help-center/documents/1017530 opw-3923031 Forward-Port-Of: odoo/enterprise#65958 Forward-Port-Of: odoo/enterprise#65098
When we are loading an offer in the salary configurator, if values are set to a benefit that depends on another one which is disabled. You are keeping the value of the contract, and it is not disabled as it should because the mandatory benefit is not set. We've got this issue because the variable in the loop has the same name as the one we really need declared before ('mandatoryBenefitSelected'). We also remove the loop and the split, as it is already done in the function 'updateDependentB
Original PR description
When we are loading an offer in the salary configurator, if values are set to a benefit that depends on another one which is disabled. You are keeping the value of the contract, and it is not disabled as it should because the mandatory benefit is not set.
We've got this issue because the variable in the loop has the same name as the one we really need declared before ('mandatoryBenefitSelected').
We also remove the loop and the split, as it is already done in the function 'updateDependentBenefits' that is called.
TASK-ID: NONE
Forward-Port-Of: odoo/enterprise#66124Steps to reproduce: ------------------- 1. Set the user with 'project > user' access rights level and nothing else. Remove every rights that are related to account/analytic accounting from the user (see record rules, access rights, groups, ...). 2. When opening the Project app, an Access Error occurs (related to 'account.analytic.line'). Fix: ------------------- The progress bar that appears when grouping tasks by project in the gantt view should be able to display the sum of the timeshe
Original PR description
Steps to reproduce: ------------------- 1. Set the user with 'project > user' access rights level and nothing else. Remove every rights that are related to account/analytic accounting from the user (see record rules, access rights, groups, ...). 2. When opening the Project app, an Access Error occurs (related to 'account.analytic.line'). Fix: ------------------- The progress bar that appears when grouping tasks by project in the gantt view should be able to display the sum of the timesheets amount per project even if the user has no access to 'account.analytic.line'. task-3973256 Forward-Port-Of: odoo/enterprise#65873 Forward-Port-Of: odoo/enterprise#63922
The week starts (index 0) on Monday python side, and on Sunday Javascript side. To be able to have both function, the part where we add 7 days to `daysToLastWeekWed` or `days_to_last_weekWed` needs to be done the same way on both sides: from Wednesday to Sunday: * index 2 (WE) to 6 (SU) in Python * index 3 (WE) to 6 (SA) and 0 (SU) in Javascript. Forward-Port-Of: odoo/enterprise#66203
Original PR description
The week starts (index 0) on Monday python side, and on Sunday Javascript side. To be able to have both function, the part where we add 7 days to `daysToLastWeekWed` or `days_to_last_weekWed` needs to be done the same way on both sides: from Wednesday to Sunday: * index 2 (WE) to 6 (SU) in Python * index 3 (WE) to 6 (SA) and 0 (SU) in Javascript. Forward-Port-Of: odoo/enterprise#66203
Forward-Port-Of: odoo/enterprise#65976
Original PR description
Forward-Port-Of: odoo/enterprise#65976