Tuesday, July 9, 2024
12 changes · 17.0
Resolved issues and error corrections
This fixes a problem that could prevent the Argentina withholding module from being installed again after removal. Businesses using this localization can now reinstall the module without running into a tax setup validation error.
Original PR description
Uninstall l10n_ar_withholding Install again l10n_ar_withholding Issue: Reinstall will fail with error odoo.exceptions.ValidationError: Invoice and credit note distribution should each contain exactly one line for the base. This occurs because the system attempt to create a tax repartition line in existing tax instead of updating the data opw-3946193
The loyalty test flow was adjusted so automated checks run in a more consistent order. This helps reduce false failures in validation systems, making releases more dependable without changing the customer-facing loyalty features.
Original PR description
Steps order in the tests was causing an underterministic behavior when the test was run on the runbot. We change the order of the steps to try to make the test more deterministic and consistent. Runbot Error: 57047
Creating a new Discuss channel now keeps the exact capitalization and accents entered by the user. This prevents names from being unintentionally changed, making channels clearer and more respectful of users' language and naming choices.
Original PR description
Before this commit, when creating a channel from the discuss sidebar, the name of the channel would be transformed to lower case and stripped of accents. This happens because the same cleaned term used for searching gets used to define the name of the new channel. This commit fixes the issue by using the unaltered search term. Before:  After: 
This change adjusts when the Turkish localization migration runs during package upgrades. It helps prevent upgrade failures caused by a missing asset-related value, making the upgrade process more reliable for affected users.
Original PR description
[FIX] l10n_tr: Fix migration script's execution phase This is a follow up to https://github.com/odoo/odoo/pull/167258 When we trigger the upgrade button of the package, We get an error that 'create_asset' field is null even that field has a default value The issue is not specified yet, Reaching the upgrade team to get their input changing the phase from 'post-' to 'end-' task-id#3924220 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Paid orders in Point of Sale can now be found when users search using the date format configured on their system. This makes order lookup more reliable and avoids confusion for staff working with localized date formats.
Original PR description
Before this commit, searching for paid orders using the system's date format was not possible due to the lack of proper date parsing and formatting in the search fields. opw-4008489 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The point-of-sale loyalty flow now avoids errors when a reward product has been archived. This keeps checkout and reward handling stable even when older or inactive products remain linked to loyalty rewards.
Original PR description
This commit adds a check to prevent errors when a reward product is archived. opw-4012282 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The event registration page now lets the Add to Calendar button follow the site's configured secondary button style. This keeps event pages visually consistent when a business customizes its website theme.
Original PR description
## Issue: Due to having 'text-bg-secondary' in our Add to Calendar button, if we modify the secondary button style for the website theme, the new style for the secondary button will not be applied properly even though it's a secondary button. ## Steps to reproduce: 1. Install website_event. 2. Modify the secondary button style for the theme (i.e set it to outline) 3. Check the button inside events > register an event. ## Solution: We could get rid of the class 'text-bg-secondary' for this button which will make the button to keep same style and still be "responsive" to theme changes. opw-3869252
This fixes an issue where deleting accounting entries with attachments could fail for companies not using German localization. It also makes batch deletion handling more efficient when several related messages are removed at once.
Original PR description
Since unlinking `ir.attachment` is done after removing the record from the database, and the cache is already invalidated, we cannot browse `res_id` anymore. Also improve the prefetching for all messages being unlinked at the same time if related to different moves.
This fix makes Odoo report the actual invalid field name when a grouped read request contains a field that does not exist. It helps users and support teams diagnose configuration or reporting mistakes faster by avoiding misleading error messages.
Original PR description
When calling read_group() with an invalid field name, the error message was misleading, indicating the last aggregated field name instead of the field that was invalid (non-existant on the model) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents an error in point-of-sale Viva Wallet payments when failed transaction notifications do not include expected reference data. Instead of crashing while processing the notification, the system now detects the missing information and raises a controlled error so staff can be notified appropriately.
Original PR description
An error occurs when the system tries to retrieve 'session_id' at [1] from 'MerchantTrns' but it is not available. Because of failed transactions (Ref: https://developer.viva.com/webhooks-for-payments/transaction-failed/#response-example) link [1]: https://github.com/odoo/odoo/blob/319cf81da8f16df21900f26bd6d8b4fc686e72eb/addons/pos_viva_wallet/models/pos_payment_method.py#L113 To resolve this issue, add a condition to check if 'MerchantTrns' is not available in 'data_webhook' then raise an error as send notification. Sentry - 5466498742 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Product badges or ribbons in the online shop now keep the background color selected by website editors. This ensures promotional labels display as intended, improving product presentation and reducing editing frustration.
Original PR description
Steps to reproduce: - Go to Shop page on website - Enable edit mode - Pick a product and create a new Badge/Ribbon - Change the background color - Bug -> the bg-color is not set. Issue : ribbon bg-color is not set on the product. Cause : The !important attribute has been duplicated in the CSS rule since [1] and [2]. As a result, the background colour CSS rule for the ribbon is broken due to having !important twice. [1]: https://github.com/odoo/odoo/commit/c6f4929f65b899736c556f8f0bb7824883a6d893 [2]: https://github.com/odoo/odoo/commit/9ee115b58342b3e0dbc11081e7ff752c10f8bfa9 fix : After removing the '!important' attribute from the create and write methods, we only encounter the '!important' attribute once. As a result, the ribbon background color is applied to the product. opw-3964071
Updated the accounting module's test procedures to comply with German audit trail requirements, which mandate that financial moves cannot be deleted. The fix ensures that only moves associated with the specific test company are removed during testing, while preserving the audit trail integrity required by law.
Original PR description
Since the audit trail is mandatory in Germany, we cannot remove moves or any documents related. We only need to remove the moves linked to the company of the tour.