Tuesday, July 9, 2024
2 changes · saas-17.2
Resolved issues and error corrections
This fixes an error that could occur when Viva Wallet payment responses were sent to the point of sale. The change helps ensure payment updates reach the POS reliably without disrupting the cashier workflow.
Original PR description
With commit [1], we removed the method ``_get_bus_channel_name``, but at line [2], it's still referenced, which causes an error. AttributeError: ``'pos.session' object has no attribute '_get_bus_channel_name'`` This commit will fix the issue by using ``_notify`` for calling the notification bus. [1]-https://github.com/odoo/odoo/commit/3836aad466c6c111f0f0d33c357a1c7a5150f3fd [2]-https://github.com/odoo/odoo/blob/5633d590decc6e8989c0f454a355e965f072f967/addons/pos_viva_wallet/models/pos_payment_method.py#L133 sentry-5562979975 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents manufacturing order overviews from crashing when the same product is configured as both a component and a by-product in a bill of materials. Users will now be protected from a setup that could trigger an endless processing loop, improving reliability when reviewing manufacturing orders.
Original PR description
Steps to reproduce: - Manufacturing > Products > Bills of Material > New - Add any item as component then the same item as by-product - Confirm - Operations > Manufacturing Order > New - Pick the…
Steps to reproduce: - Manufacturing > Products > Bills of Material > New - Add any item as component then the same item as by-product - Confirm - Operations > Manufacturing Order > New - Pick the product associated to your newly created BoM - Confirm > Overview What happens and why: Odoo raises an RPC error due to an infinite recursion between _get_components_data and _get_replenishment_lines. Both calls are made before the manufacturing order line is flagged as processed so the functions are mutually dependent on the other finishing first. The looping call is conditionally called when document_in and document_out are the same, which seems to be why the stock moves 'move_in' (component) and 'move_out' (by-product) need to be configured this way on the BoM. Why is this an error: This prevents the user from accessing the overview of a valid MO. What this fix does: Moves the flag to before the looping call can be made, so the recursive call does not propagate infinitely. opw-4013371 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr