Daily updates from Odoo
Thursday, July 11, 2024
8 changes · 17.0
Resolved issues and error corrections
This fix corrects the Quick Create feature in the Calendar Studio editor, which was incorrectly disabled and couldn't be toggled. The issue was caused by reading the wrong property name and not properly saving the disabled state. Users can now correctly enable and disable Quick Create functionality when customizing calendar views.
Original PR description
Steps to reproduce ================== - Install web_studio,calendar - Go to calendar - Open studio => In the sidebar, Quick Create is disabled but should be enabled Toggling it does nothing Cause of the issue ================== The value was incorrectly read from `archInfo.hasQuickCreate` Solution ======== `hasQuickCreate` -> `quickCreate` This shows a second issue: Now that it's enabled, we can't disable it. This is because we remove the attribute instead of setting it to false If we don't pass the attribute, it will keep it's default value (true) https://github.com/odoo/odoo/blob/2afce223268c4ee1ac3c98a6108b1390be82716b/addons/web/static/src/views/calendar/calendar_arch_parser.js#L34 opw-4023026
This fix resolves an issue where decimal quantities were being incorrectly rounded to whole numbers when adjusting inventory in the barcode app for products with package contents. The system now properly preserves decimal precision based on the configured decimal settings, ensuring accurate inventory adjustments for fractional quantities.
Original PR description
## Issue: - When adjusting inventory for a product with packages from the barcode app, quantities that are not whole numbers will be rounded to the nearest whole number. ## Steps To Reproduce: -…
## Issue: - When adjusting inventory for a product with packages from the barcode app, quantities that are not whole numbers will be rounded to the nearest whole number. ## Steps To Reproduce: - Create a product and include two other products in its packaging, specifying a non-whole number for the contained quantity. - In the barcode app, adjust the inventory by adding the created product and then save the changes. - Click on the small pen icon to modify the product's details. - Observe that when adding the quantities with decimal values, they get rounded up to the nearest whole number. ## Solution: - In the `_increment` function, when the initial `value` is not a decimal (it does not contain a '.'), the fraction variable is not set, and the rounding defaults to 0. It's important to note that this issue does not occur when the `value` is a decimal, as the split function operates correctly. - To resolve this issue, instead of relying on the number of digits after the '.' in the `value`, we set the precision based on what is defined in the 'decimal.precision' model. This approach not only addresses the current issue but also resolves the underlying problem initially discussed in this PR https://github.com/odoo/enterprise/pull/53378 opw-3896929 Forward-Port-Of: odoo/enterprise#65619 Forward-Port-Of: odoo/enterprise#62505
This fix resolves an issue where clicking the general ledger action button didn't properly expand parent account lines when the hierarchy view was enabled. Previously, the action would open but leave parent accounts collapsed, making it difficult for users to see the full account structure they needed. Now the parent lines automatically unfold when the action is triggered, making the feature work as intended.
Original PR description
Before this commit, when clicking on the action with the hierarchy enabled, the parent line were not unfolded which cause the purpose of the action to be useless. task-3839845
This fix resolves an intermittent error that occurred in the French accounting dashboard when the tax journal was temporarily removed during nightly tests. The issue caused the system to crash with a key error. This update ensures the dashboard remains stable and functional even when journal data changes unexpectedly.
Original PR description
If you run the nightly builds of TestAccountJournalDashboard, sometimes the tax journal is withdrew from the dashboard -> key error initial pr: https://github.com/odoo/enterprise/pull/66346 opw-4004375
This fix addresses an issue where bank transactions without identifiers were being incorrectly filtered during import. Previously, when providers returned transactions without IDs, only the first transaction would import while others with empty identifiers were skipped. The system now properly handles these edge cases by ignoring transactions with empty identifiers in the filtering logic.
Original PR description
The aim of this commit is fixing the filtering of transactions when transactions have an empty identifier. Even if it's shouldn't be the case, it happens that providers return transactions without an identifier. In this case, it will always importe the first transaction and not the others as they have a similar id (an empty string). Now, we ignore in the filter these transactions. opw-4014171
This fix corrects how percentage-based reconciliation models distribute amounts across multiple lines. Previously, the system was incorrectly calculating percentages based on remaining balances after each line, resulting in incorrect distributions. Now percentages are correctly applied to the original statement line amount, ensuring accurate financial reconciliation.
Original PR description
The current code is taking the residual amount instead of the statement line amount. When doing a reco model 'percentage_st_line' on 1000: Line 1 - 74% Line 2 - 24% Line 3 - 2% We get: 1000 * 0.74 = 740 (1000 - 740) * 0.24 = 62.4 (1000 - 740 - 62.4) * 0.02 = 3.95 Instead of: 1000 * 0.74 = 740 1000 * 0.24 = 240 1000 * 0.02 = 20 task_id: 3940370 Forward-Port-Of: odoo/enterprise#62884
Fixed an issue where the settle due accounts button was not always displayed on the partner details screen in the Point of Sale. The button is now always shown, with the label changing to "Deposit Money" when there's no amount due and "Settle Due Accounts" when there is an outstanding balance. This provides a better user experience and clearer guidance for staff handling customer payments.
Original PR description
The settle due accounts was not always shown on the partner screen. Now it's always shown, and when the user doesn't have any amount due the text changes to "Deposit Money" instead of "Settle Due Accounts" Steps to reproduce: ------------------- * Install pos_settle_due module * Open PoS session * Open partner list * Click on details for any partner with no due > Observation: The "Settle Due Accounts" button is missing Why the fix: ------------ We always show the button, but change the text to better match the behavior. If there is no amount due the text says "Deposit Money" and when the user has some amount due it says "Settle Due Accounts" opw-3925397 Forward-Port-Of: odoo/enterprise#65762
This fix resolves an issue where partner commissions were not being calculated when a quotation template was added to a commission plan's rules. The system now properly checks the sale order's quotation template when determining which commission rules apply, ensuring commissions are correctly generated even when using templates.
Original PR description
Steps to reproduce ------------------- - create a commission plan with: product category: "All" rate: R capped: True max commission: >>> - create a partner level with the created commission plan -…
Steps to reproduce
-------------------
- create a commission plan with:
product category: "All"
rate: R capped: True
max commission: >>>
- create a partner level with the created commission plan
- create a partner with the created partner level
- create a product in the correct category with price P
- create a quotation template with the created product
- create a sale order with the partner as referrer
- add the quotation template (the product is added automatically)
- confirm
- create the invoice, confirm it and register the payment
At this moment, a purchase order is created (the commission) If we repeat these steps with a new sale order,
the amount of the purchase order will increase as expected.
- add a quotation template on the commission plan (in the rules)
- repeat the creation of a sale order.
No commission is added (purchase order line).
Cause:
------
We have no template when calling `_match_rules`.
However, our plan has a default template.
The result is that no rules are found.
Solution:
---------
Fallback on the sale order's template
if it is not a subscription.
opw-3933323