Friday, July 12, 2024
13 changes · 17.0
Resolved issues and error corrections
Employee avatars in the organization chart are no longer downloaded twice when chart data is loaded. This reduces unnecessary data transfer and helps the chart load more efficiently without changing what users see.
Original PR description
Before this commit, the avatar for the employees in the org chart is loaded by the URL but also when we fetched the data. This commit avoid fetching image fields with `hierarchy_read`.
This fixes a small issue in the German localization where an account update did not pass back the normal save result. It helps keep automated checks and dependent processes aligned with standard Odoo behavior.
Original PR description
Turns out there's a test that checks that the return value from the super() call in write is returned in the override. See `TestOverrides.test_write()`. So we need to return the value from the super().write().
This fixes an issue where users with limited permissions could trigger an unexpected error when trying to add property fields. The interface now relies on the user’s known permissions to block unavailable changes more gracefully, avoiding confusing tracebacks.
Original PR description
Currently if there are no IR rules preventing a low right user to write on a record, no error notification will appear when the user tries to add a property field to the child model since no error is raised in the checkDefinitionWriteAccess method. If this user does not have access rights on the model of the parent record an unwanted traceback will appear since nothing prevents him from trying to add a property field to the model Here we're using the canChangeDefinition which is loaded by checkingAccessRight on the user at the start of the component startup Task-3815748 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where exported timesheet reports could shift values into the wrong columns when a timesheet line had no task. This keeps task, description, and hours information in the correct places so downloaded reports are easier to trust and use.
Original PR description
Steps to reproduce: ------------------- - Install `Task Logs` module - Go to `Timesheets` - Create a timesheet line in the project `Research & Development` and give a description (but set no task) - Go to `Project` and open `Research & Development` project settings - Click on `Actions` button and select `Timesheets` to download report - Open the downloaded report Issue: ------ The `Task` column contains the `Description` of the timesheet, and the `Hours` value is in the `Description` column. Cause: ------ If the timesheet line has no task and generating report only for one project, the cell value will not be created for the timesheet line. Solution: --------- If the column `Task` (or `Project`) exist, create the cell anyway. opw-3984479
Long titles in certain mobile form views now wrap cleanly instead of cutting words in the middle. This makes task titles and similar form headings easier to read on smaller screens.
Original PR description
Before this commit, there was a (xss specific) form view rule preventing the oe_title content to be displayed properly. In the task form view, in mobile, the title is a textarea, and long titles were displayed with words cut in the middle. The removed rule had been introduced a long time ago, for the kanban quick create form view [1], but it was probably a mistake. [1] https://github.com/odoo/odoo/commit/d18d08f01a589053e40c7af1fd4dd59c13aaa625 Task 4045168 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixed an issue where long product names could cause lot or serial number PDF labels to overlap with the barcode area. This keeps printed inventory labels readable and prevents barcode scanning problems.
Original PR description
Current behavior: --- When printing a Lot/Serial Number, if the product name is too long, the content overlaps. Steps to reproduce: --- 1. Go to Inventory > Products > Lots/Serial Numbers 2. Open one Serial Number > open its product 3. Rename product with long name 4. Go back to Lots/Serial Numbers 5. Select the Serial Number with renamed product 6. Click on Print > PDF 7. Barcode is out of the box Cause of the issue: --- Caused by: https://github.com/odoo/odoo/commit/95880f43c59c061f2a971ba8f41f9912139b798a div was changed to span without changing the css opw-3819349 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Fixes an error that could block users from replenishing products after the subcontractor resupply route was deleted. The replenishment screen now continues to work instead of crashing, improving reliability for inventory and subcontracting workflows.
Original PR description
This error occurs when we delete the specific ``Resupply Subcontractor on Order`` route and subsequently attempt to replenish the product. Steps to reproduce: - Install the ``stock`` and…
This error occurs when we delete the specific ``Resupply Subcontractor on Order`` route and subsequently attempt to replenish the product. Steps to reproduce: - Install the ``stock`` and ``mrp_subcontracting`` module - Inventory > Configuration > Settings > Warehouse > Activate Multi-Step Routes - Go to routes and delete ``Resupply Subcontractor on Order`` - Now go to any product > Click on ``Replenish`` Traceback: ``AttributeError 'NoneType' object has no attribute 'id'`` At [1], this error occurs when we try to access an attribute called ``id`` on an object that is actually None. This commit will fix the above error by returning the value of ``domains`` if the route is not present in the ``_get_allowed_route_domain`` method. [1]: https://github.com/odoo/odoo/blob/731766aa03ad4cf14349169faab3957c710bc002/addons/mrp_subcontracting/wizard/product_replenish.py#L13 sentry-5514962307 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Long task and project titles now move to the next line without splitting words in form views. This improves readability and makes records with lengthy names easier to review.
Original PR description
- Ensure that long task titles wrap to the next line without breaking words in the task and project form view. task-4045168 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The embedded document viewer is now available from the shared web module instead of being tied to manufacturing. This prevents warnings when installing Maintenance and lets equipment request forms display embedded content correctly without adding an unnecessary Manufacturing dependency.
Original PR description
**`embed viewer` widget is in `mrp` but used in `maintenance`** Impacted versions: - 17.0 Steps to reproduce: 1. Install the `maintenance` module. Current behavior: You will see a warning the `embed_viewer` widget is not registered. Expected behavior: The `embed_viewer` widget should be loaded correctly in the `hr_equipment_request_view_form` view. This moved `embed_viewer` widget from `mrp` module to `web`. This way, the `maintenance` module can also make use of the widget without unnecessarily depending on `mrp`. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Signing date fields now use the date format configured for the database language settings. This ensures documents show dates consistently with company or regional preferences during signing.
Original PR description
Steps to reproduce: - Install "Sign" - With debug -> Settings -> Translations -> Languages - Open "English (US)" and change date format to "%d/%m/%Y" - Open "Sign" and add a document - Add a date box - Send the document - Open it using the link - Click on the date box Issues: The date format used in the date box isn't the one specified in the db. opw-3977905
A test in the Kenya OSCU stock integration was temporarily commented out because it was producing inconsistent results and blocking automated staging checks. This does not change customer-facing functionality, but helps keep the development validation process moving while the underlying test issue is investigated.
Original PR description
The test test_send_invoice_and_credit_note needs a certain order in the vendor bill lines, but it seems to reverse this indeterministically and we have not figured out yet exactly why. (adding sequence, or de-doubling method names did not help) Hence we comment it for the moment.
Long titles in the helpdesk ticket form now move to the next line without splitting words. This makes tickets easier to read and prevents awkward text breaks in the interface.
Original PR description
- Ensure that long task titles wrap to the next line without breaking words in the helpdesk ticket form view. task-4045168
A visual bug in the sign template has been fixed where users were seeing duplicate scroll bars. The issue was caused by the toolbar on the left side taking up too much space. The fix adjusts how the toolbar's height is calculated to prevent the content from overflowing, resulting in a cleaner, more professional appearance.
Original PR description
Issue: -------------------- When you open a sign template you can see there are double scroll bars on the iframe Cause: ---------------------- The sign item toolbar placed on the left side is given 100% height and 1px border which is causing the iframe body to overflow Solution: ----------------------------- The 100% height given to the toolbar is changed with -webkit-fill-available task-4014519