Friday, July 12, 2024
2 changes · saas-17.2
Resolved issues and error corrections
Opening cell comment threads now waits properly for messages to load before continuing. This reduces the chance of inconsistent behavior in automated checks and helps keep the spreadsheet experience stable, even though no customer-facing issue was observed.
Original PR description
When opening a message thread on cells, the request fetching the messages is not properly awaited. We didn't find any actual issue with this (in prod or in tests), but this is the kind of things leading to non-deterministic tests. So we prefer to fix it.
A problem in the disallowed expenses reporting query has been corrected. This helps prevent reporting errors in accounting flows that include fleet-related expense data, improving reliability of test and reporting results.
Original PR description
The aim of this commit is to fix an issue in the sql query generated by the `account_disallowed_expenses` module that was covered by the `account_disallowed_expenses_fleet` during the runbot testing. runbot-71011