Friday, July 12, 2024
8 changes · saas-17.4
Resolved issues and error corrections
Fixed an issue where the preview shown from a folded chat bubble could remain open after the user moved the mouse away. This keeps the chat interface behavior consistent and prevents lingering message previews from cluttering the screen.
Original PR description
Before this commit, chat bubble preview was sometimes not closing itself on hover away. When a chat window is folded, it shows a bubble. By mouse-hovering it, it previews the last message in…
Before this commit, chat bubble preview was sometimes not closing itself on hover away. When a chat window is folded, it shows a bubble. By mouse-hovering it, it previews the last message in conversation. This preview is expected to be shown until mousehovering on chat bubble and in the preview itself. This was sometimes not working because the inner-code of `useHover()` required syncing with a rendering. If the hover action is quick enough, the rendering does not observe the transition from ``` isHover: true -> isHover: false -> isHover: true ``` And thus it thinks the chat bubble is kept hovering. This worked sometimes because by changes the "X" to close a chat bubble triggers a delayed rendering. This commit fixes the issue by ensuring that all transition of `isHover` are fully observed, so that the UI always matches its inner value. `isHover` is kept as a boolean, but the trick is for read to side-effect a read on a indefinitely increasing integer, so that the inner `useState` properly observes all transition change to sync the rendering. The pattern used looks like well-known `autofocus` pattern but this is hidden in implementation detail of a plain boolean value.
This fixes a setup issue that caused Live Chat tests to crash when run locally. It helps developers validate Live Chat changes more reliably without affecting day-to-day users.
Original PR description
Follow up of https://github.com/odoo/odoo/pull/171073 and https://github.com/odoo/odoo/issues/171919
Fixes a crash with livechat test suite when run locally.
```
module_loader.js:139 Uncaught (in promise) Error: Error while loading "@web/views/form/form_view":
TypeError: Cannot use 'in' operator to search for 'form' in undefined
at ModuleSetLoader.startModule (module_loader.js:139:1)
at ModuleSetLoader.startModule (module_set.hoot.js:466:1)
at ModuleSetLoader.setup (module_set.hoot.js:448:1)
at describeDrySuite (module_set.hoot.js:117:1)
at async Runner.dryRun (runner.js:660:1)
at async Promise.all (:8069/web/tests/index 0)
at async runTests (module_set.hoot.js:332:1)
```
at
```js
viewRegistry.addValidation({
type: { validate: (t) => t in session.view_info },
Controller: { validate: (c) => c.prototype instanceof Component },
"*": true,
});
```This update fixes crashes triggered during broad automated navigation tests after recent framework changes. It removes unsupported view references so affected screens in mailing contacts and manufacturing open reliably in the appropriate Odoo edition.
Original PR description
The commits https://github.com/odoo/odoo/commit/f1749d3299957e2949e0b78653266a5397bb213c and https://github.com/odoo/odoo/commit/847e5c984a6873954686503886e1874b78c75951 have introduced some bugs detected by the test clickall. We fix those bugs here. Runbot build: https://runbot.odoo.com/runbot/build/65237075
Message reaction buttons now have slightly more spacing from the seen indicator in chat messages. This prevents crowded reactions from overlapping the indicator, making message activity easier to read.
Original PR description
Before this commit: The message seen indicator was inside the message bubble, causing reactions positioned below it to overlap when there were many reactions. After this commit: The reaction buttons no longer overlap with the message seen indicator. This was done by reducing their negative margin from -8px to -4px.
Fixed an issue that could cause an error when opening a Point of Sale order form. The order line name is now supplied where needed behind the scenes, keeping the form usable without changing what users see.
Original PR description
Currently, there's a client error when trying to access the form view of a `pos.order`. The form view uses the widget `product_label_section_and_note_field` to display the `product_id` of an order line, but this widget requires a name to be passed. The fix here is to add the name of the order line in the view and make it invisible. Note: This wasn't an issue until https://github.com/odoo/odoo/pull/172186, which added some logic on the name. Backport of https://github.com/odoo/odoo/pull/172779
The Project To-Do module demo data now avoids a Mac-specific installation issue caused by emoji handling. This helps teams using Apple chip Macs install and test the module reliably with sample data.
Original PR description
Before this commit, it is impossible to install project_todo with demo data on Mac with Apple chip because lxml library cannot process correctly the emoji. This commit defines the emoji in html code to be able to install the module with demo data on a Mac.
This update prevents errors that appeared when opening manufacturing-related screens after recent view-handling changes. It moves enterprise-only Gantt references out of community definitions and removes an unsupported tablet view setting, helping users access these screens reliably.
Original PR description
The commits https://github.com/odoo/odoo/commit/f1749d3299957e2949e0b78653266a5397bb213c and https://github.com/odoo/odoo/commit/847e5c984a6873954686503886e1874b78c75951 have introduced some bugs detected by the test clickall. We fix those bugs here. Runbot build: https://runbot.odoo.com/runbot/build/65237075
This change fixes an internal automated test for spreadsheet comments so it checks the intended hover behavior consistently. It helps reduce false test failures, making development and release validation more dependable without changing user-facing features.