Tuesday, July 16, 2024
28 changes · saas-17.1
Resolved issues and error corrections
This change updates an automated loyalty test so it creates its own customer record instead of relying on optional demo data. This helps prevent false test failures and improves confidence in the point-of-sale loyalty feature without changing customer-facing behavior.
Original PR description
Before this commit, the test `test_change_reward_value_with_language` was using a partner only available in demo data. This commit removes the use of demo data in the test by using a partner created in the test itself. Runbot error: 70611, 70477, 70419, 70480
Miscellaneous changes
NOTE: to speed up the merge process of https://github.com/odoo/odoo/pull/170785, I've cherry-picked the changes that were not yet merged in other PRs. In mrp bom kanban view, it is written "clatt" instead of "class". This commit changes that. (cherry picked from commit 758d3b80d6b1ce035a48fab42b7cab68e4ed7024) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read t
Original PR description
NOTE: to speed up the merge process of https://github.com/odoo/odoo/pull/170785, I've cherry-picked the changes that were not yet merged in other PRs. In mrp bom kanban view, it is written "clatt" instead of "class". This commit changes that. (cherry picked from commit 758d3b80d6b1ce035a48fab42b7cab68e4ed7024) Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173151
Steps to reproduce ================== - Install hr_skills,web_studio - Go to Employees - Open any record - Add a new resume entry without description - Save - Click on the actions gear - Print > Print Resume => `Odoo India pvt. Ltd` is displayed in the report in place of the missing description Solution ======== Use the new data-oe-demo attribute made for demo data inside studio opw-4033434 Forward-Port-Of: odoo/odoo#173167
Original PR description
Steps to reproduce ================== - Install hr_skills,web_studio - Go to Employees - Open any record - Add a new resume entry without description - Save - Click on the actions gear - Print > Print Resume => `Odoo India pvt. Ltd` is displayed in the report in place of the missing description Solution ======== Use the new data-oe-demo attribute made for demo data inside studio opw-4033434 Forward-Port-Of: odoo/odoo#173167
When importing a module through `base_import_module`, it does not have a path on the file system. Because of this the SVG shapes could not be located from the file system for imported modules. This commit falls back to `ir_attachment` record that contains the imported module file in case the module was an imported one. Steps to reproduce: - Have a module within a zip that contains a block with an image shape. (e.g. zip `website_coconuts` from [1]) - Install `base_import_module`. - G
Original PR description
When importing a module through `base_import_module`, it does not have a path on the file system. Because of this the SVG shapes could not be located from the file system for imported modules. This commit falls back to `ir_attachment` record that contains the imported module file in case the module was an imported one. Steps to reproduce: - Have a module within a zip that contains a block with an image shape. (e.g. zip `website_coconuts` from [1]) - Install `base_import_module`. - Go to 'Apps' in debug mode. - Import the zipped module with `Import Module`. => The image obtained through the `/web_editor/image_shape` route was not retrieved and a "module not found" warning appeared in the logs. [1]: https://github.com/odoo/odoo/commit/43f18e0863c779493f7b0ed82c37acb8344d9ae3 task-2888647 Forward-Port-Of: odoo/odoo#172917 Forward-Port-Of: odoo/odoo#94161
Steps to reproduce: - Create a lot tracked product. - Update the "On Hands" quantity of the product and assign it a lot name. - Create a delivery order with this product with a quantity that is available in the stock. - Mark it as to do. - Click on "Detailed Operations" smart button. - Decrease the quantity of the move line. - Select it and click on "Put in Pack". Expected behavior: The new quantity is put in pack and the quantity of the move line remains the same. Actual behavior:
Original PR description
Steps to reproduce: - Create a lot tracked product. - Update the "On Hands" quantity of the product and assign it a lot name. - Create a delivery order with this product with a quantity that is available in the stock. - Mark it as to do. - Click on "Detailed Operations" smart button. - Decrease the quantity of the move line. - Select it and click on "Put in Pack". Expected behavior: The new quantity is put in pack and the quantity of the move line remains the same. Actual behavior: The whole quantity is reserved again. The original move line is split into two move lines: one with the packed quantity and another one with the remaining quantity. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172732
When a user scans an attendee's QR code with a barcode reader, the system opens a registration confirmation dialog. If multiple QR codes are scanned in succession, the dialogs stack on top of each other. This requires the user to manually close each one, which is time-consuming. To streamline this process, the system will now automatically close the previous registration confirmation dialog when a new QR code is scanned. This change should expedite the ticket scanning process. task-4047455
Original PR description
When a user scans an attendee's QR code with a barcode reader, the system opens a registration confirmation dialog. If multiple QR codes are scanned in succession, the dialogs stack on top of each other. This requires the user to manually close each one, which is time-consuming. To streamline this process, the system will now automatically close the previous registration confirmation dialog when a new QR code is scanned. This change should expedite the ticket scanning process. task-4047455 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172783
similar to https://github.com/odoo/odoo/pull/129310 Currently, users cannot edit the bottom part of `payment_terms` and `fiscal_position`, as these are conditional blocks. This commit adds empty divs that will be interpreted by odoo-editor as editable. opw-3558001 Forward-Port-Of: odoo/odoo#172777
Original PR description
similar to https://github.com/odoo/odoo/pull/129310 Currently, users cannot edit the bottom part of `payment_terms` and `fiscal_position`, as these are conditional blocks. This commit adds empty divs that will be interpreted by odoo-editor as editable. opw-3558001 Forward-Port-Of: odoo/odoo#172777
This commits only just add partnerlist tour methods required for this fix https://github.com/odoo/enterprise/pull/65762 opw-3925397 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171633 Forward-Port-Of: odoo/odoo#171260
Original PR description
This commits only just add partnerlist tour methods required for this fix https://github.com/odoo/enterprise/pull/65762 opw-3925397 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171633 Forward-Port-Of: odoo/odoo#171260
Fiscal position using 2 taxes including in price are not working in PoS. If you use the fiscal position only the tax should change, not the total price, as both tax are included in price. Steps to reproduce: ------------------- * Create two taxes that are included in price * Create a fiscal position matching those 2 taxes * Create a product using the first tax * Open PoS session, and add the product to the order * Price should be for example 100€ * Now change the fiscal position to the
Original PR description
Fiscal position using 2 taxes including in price are not working in PoS. If you use the fiscal position only the tax should change, not the total price, as both tax are included in price. Steps to…
Fiscal position using 2 taxes including in price are not working in PoS. If you use the fiscal position only the tax should change, not the total price, as both tax are included in price. Steps to reproduce: ------------------- * Create two taxes that are included in price * Create a fiscal position matching those 2 taxes * Create a product using the first tax * Open PoS session, and add the product to the order * Price should be for example 100€ * Now change the fiscal position to the one you created > Observation: Price of the product changed when it shouldn't have Why the fix: ------------ When computing the price of the product with a fiscal position, if the previous tax is included in price and the new one is also included in price, the price of the product shouldn't change. So instead of recomputing the price of the product with the new tax based on the previous tax excluded price. We just use the price of the product opw-3952604 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172079 Forward-Port-Of: odoo/odoo#169223
Problem: When registering for an Event, an `event.registration record` is created. Odoo will send a reminder email to these registered customers using the `Event: Reminder` email template. This template uses the `get_date_range_str` method inside `event.registration` to calculate what the start date (`event_begin_date`) is and then decides which dynamic string to use (today, tomorrow, etc). However, this field is stored in UTC and uses a separate `date_tz` field to calculate what timezone shoul
Original PR description
Problem: When registering for an Event, an `event.registration record` is created. Odoo will send a reminder email to these registered customers using the `Event: Reminder` email template. This…
Problem: When registering for an Event, an `event.registration record` is created. Odoo will send a reminder email to these registered customers using the `Event: Reminder` email template. This template uses the `get_date_range_str` method inside `event.registration` to calculate what the start date (`event_begin_date`) is and then decides which dynamic string to use (today, tomorrow, etc). However, this field is stored in UTC and uses a separate `date_tz` field to calculate what timezone should be used. This `date_tz` context is missing, leading to emails with the wrong subject and body content. Purpose: Pass in the event's timezone to ensure that calculations involving the date_begin field display correctly. Steps to Reproduce: 1) Create an Event 2) Set the timezone to America/Los Angeles 3) Set the times to 6:00 pm - 10:00pm (leading to different day in UTC compared to PST) 4) Register customers to create `event.registration` records 5) Trigger `get_date_range_str` function, either via Email Template or SA 6) Check which string is returned based on time delta opw-3993058 Forward-Port-Of: odoo/odoo#172599 Forward-Port-Of: odoo/odoo#169682
To reproduce the bug: 1. Add a video to a product media. 2. In the eCommerce app, go to the product page and switch to the added video. 3. Decrease the browser page width and try to click the play/pause button. The play/pause button is located under the arrow HTML element, making it unclickable. This is because the page is not responsive, and the size of the container element is fixed at 400px. To fix this, I propose making the element responsive and decreasing the height of the arrow e
Original PR description
To reproduce the bug: 1. Add a video to a product media. 2. In the eCommerce app, go to the product page and switch to the added video. 3. Decrease the browser page width and try to click the play/pause button. The play/pause button is located under the arrow HTML element, making it unclickable. This is because the page is not responsive, and the size of the container element is fixed at 400px. To fix this, I propose making the element responsive and decreasing the height of the arrow elements. opw-3986105 Forward-Port-Of: odoo/odoo#172229
Description of the issue/feature this PR addresses: Unimplemented delivery_types for delivery carriers lead to 500 Current behavior before PR: During an odoo version update or by replacing one delivery app by another, it can happen that the shipping method is not implemented (see delivery_carrier.py#rate_shipment method). This will lead to a 500 Internal Server Error when opening the checkout page that contains the delivery method select. Desired behavior after PR is merged: Instead of a 5
Original PR description
Description of the issue/feature this PR addresses: Unimplemented delivery_types for delivery carriers lead to 500 Current behavior before PR: During an odoo version update or by replacing one delivery app by another, it can happen that the shipping method is not implemented (see delivery_carrier.py#rate_shipment method). This will lead to a 500 Internal Server Error when opening the checkout page that contains the delivery method select. Desired behavior after PR is merged: Instead of a 500 Internal Server Error (full show stopper), the error message "Shipment rate not found" is returned. The interface displays the error messages like other errors and it is ensured, that the user cannot proceed when selecting an erroneous delivery carrier. -- I confirm I have signed the CLA and read the PR guidelines at [www.odoo.com/submit-pr](http://www.odoo.com/submit-pr) Forward-Port-Of: odoo/odoo#169008
### [FIX] product: add domain on ptav filter Steps: - Install sale. - If user using odoo for 3-4 for years then user probably have more then 200 ptavs in db.. Issue: - It'll display limit warning instead of filter in most of cases. Cause: - Have larger number of ptavs. Fix: - Add domain to only search active ptav and has related active product. opw-3827751 Forward-Port-Of: odoo/odoo#168705
Original PR description
### [FIX] product: add domain on ptav filter Steps: - Install sale. - If user using odoo for 3-4 for years then user probably have more then 200 ptavs in db.. Issue: - It'll display limit warning instead of filter in most of cases. Cause: - Have larger number of ptavs. Fix: - Add domain to only search active ptav and has related active product. opw-3827751 Forward-Port-Of: odoo/odoo#168705
With this commit we allow to change/add analytic distribution on a posted line in quick edit mode. opw-3561831 Forward-Port-Of: odoo/odoo#144562
Original PR description
With this commit we allow to change/add analytic distribution on a posted line in quick edit mode. opw-3561831 Forward-Port-Of: odoo/odoo#144562
Turns out there's a test that checks that the return value from the super() call in write is returned in the override. See `TestOverrides.test_write()`. So we need to return the value from the super().write(). Forward-Port-Of: odoo/odoo#172524
Original PR description
Turns out there's a test that checks that the return value from the super() call in write is returned in the override. See `TestOverrides.test_write()`. So we need to return the value from the super().write(). Forward-Port-Of: odoo/odoo#172524
Since 8777973edd25314df6ed0327d3f27edcf62f274b, the list data are retrieved with `web_search_read`. However, the payload was not minimal as it contains all attributes of the fields (name, store, sortable, etc.). This commit reduces the payload by only requesting what is needed. Task: 4052706 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at
Original PR description
Since 8777973edd25314df6ed0327d3f27edcf62f274b, the list data are retrieved with `web_search_read`. However, the payload was not minimal as it contains all attributes of the fields (name, store, sortable, etc.). This commit reduces the payload by only requesting what is needed. Task: 4052706 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173123
Description of the issue/feature this PR addresses: - In v17.0, the default value of 'analytic plan' (analytic_plan_id) has not been set in setting. - Analytic plan has config_parameter is set as "[analytic.analytic_plan_projects](https://github.com/odoo/odoo/blob/758ced91f8cb220a003a49b01e047b507f8509d7/addons/project/models/res_config_settings.py#L18-L22)" However, the default key was set different "[account.plan_projects](https://github.com/odoo/odoo/blob/758ced91f8cb220a003a49b01e047b507
Original PR description
Description of the issue/feature this PR addresses: - In v17.0, the default value of 'analytic plan' (analytic_plan_id) has not been set in setting. - Analytic plan has config_parameter is set as…
Description of the issue/feature this PR addresses: - In v17.0, the default value of 'analytic plan' (analytic_plan_id) has not been set in setting. - Analytic plan has config_parameter is set as "[analytic.analytic_plan_projects](https://github.com/odoo/odoo/blob/758ced91f8cb220a003a49b01e047b507f8509d7/addons/project/models/res_config_settings.py#L18-L22)" However, the default key was set different "[account.plan_projects](https://github.com/odoo/odoo/blob/758ced91f8cb220a003a49b01e047b507f8509d7/addons/analytic/data/analytic_data.xml#L13)" - And during the migration from v16.0 to v17.0, the default key generated in v16.0 is [removed](https://github.com/odoo/upgrade/blob/20faf7ba48595c61fc028ba1b4cf278d2c44e3cc/migrations/analytic/saas~16.5.1.1/pre-migrate.py#L10-L18) in saas~16.5 and new key will be set which this only "account.plan_projects" . - Because of the incorrect key value of 'analytic plan'(analytic_plan_id) is null. **Steps to reproduce:** - Install project module. - Go to Setting > Projects > got to Analytics section in that Analytic Plan. - Default analytic plan value is not there. **Solution:** - Set the correct key `analytic.project_plan` for the 'analytic_plan_id' field. **Current behavior in 16.0 :**  **Current behavior in 17.0 before pr:**  **Desired behavior after PR is merged:**  task-3941668 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172123
When the document is filled in with the OCR values, we need to use the document's company context, otherwise it can lead to inconsistent values being selected. For example, the payment terms of a supplier are company dependent, so we need the right company context to select the one from the company of the invoice. Related task: [#3902741](https://www.odoo.com/odoo/project.task/3902741?cids=1) Forward-Port-Of: odoo/enterprise#66168
Original PR description
When the document is filled in with the OCR values, we need to use the document's company context, otherwise it can lead to inconsistent values being selected. For example, the payment terms of a supplier are company dependent, so we need the right company context to select the one from the company of the invoice. Related task: [#3902741](https://www.odoo.com/odoo/project.task/3902741?cids=1) Forward-Port-Of: odoo/enterprise#66168
Steps to reproduce ================== - Install hr_skills,web_studio - Go to Employees - Open any record - Add a new resume entry without description - Save - Click on the actions gear - Print > Print Resume => `Odoo India pvt. Ltd` is displayed in the report in place of the missing description Cause of the issue ================== With the new report editor in 16.4, some demo data have been added directly inside the report templates as default content. The assumption was
Original PR description
Steps to reproduce ================== - Install hr_skills,web_studio - Go to Employees - Open any record - Add a new resume entry without description - Save - Click on the actions gear - Print >…
Steps to reproduce ================== - Install hr_skills,web_studio - Go to Employees - Open any record - Add a new resume entry without description - Save - Click on the actions gear - Print > Print Resume => `Odoo India pvt. Ltd` is displayed in the report in place of the missing description Cause of the issue ================== With the new report editor in 16.4, some demo data have been added directly inside the report templates as default content. The assumption was that it would be displayed inside the report editor, but outside, since the field would have a value, the value would take over. The default content if displayed when the field value is falsy. In this case, the default content is used instead of the empty description. Solution ======== Introduce a new attribute, data-oe-demo, to be used inside the report editor. This doesn't have the drawbacks of the default content as we can choose to only display it inside the report editor --- [commit]: https://github.com/odoo/odoo/commit/a45c6c545ffdcee3bb50b3455884b8296e5d6a7c opw-4033434 Forward-Port-Of: odoo/enterprise#66660
before this commit, if some customization has to be done for changing the workflow of invoice generation, i.e., to keep the auto generated invoice in draft state the entire function has to be rewritten after this commit, a hook is introduced _process_auto_invoice which will post the invoice, later to alter this flow just need to inherit this function Forward-Port-Of: odoo/enterprise#66305 Forward-Port-Of: odoo/enterprise#66200
Original PR description
before this commit, if some customization has to be done for changing the workflow of invoice generation, i.e., to keep the auto generated invoice in draft state the entire function has to be rewritten after this commit, a hook is introduced _process_auto_invoice which will post the invoice, later to alter this flow just need to inherit this function Forward-Port-Of: odoo/enterprise#66305 Forward-Port-Of: odoo/enterprise#66200
This addresses several issues: - on 'register_consumed_materials' & 'register_byproducts' quality checks, the quantity entered and the selected lot were not saved - make this view clearer by separating the product and the other fields - 'print' & 'next' barcode triggers were sometimes capitalized, making them inoperant - fix component remaining quantity when no producing quantity has been set - generate a new pdf for barcodes: add print barcode & new ghostscript version seems t
Original PR description
This addresses several issues: - on 'register_consumed_materials' & 'register_byproducts' quality checks, the quantity entered and the selected lot were not saved - make this view clearer by separating the product and the other fields - 'print' & 'next' barcode triggers were sometimes capitalized, making them inoperant - fix component remaining quantity when no producing quantity has been set - generate a new pdf for barcodes: add print barcode & new ghostscript version seems to solve some erratic scanning problems task: 3987346 Forward-Port-Of: odoo/enterprise#65396
The settle due accounts was not always shown on the partner screen. Now it's always shown, and when the user doesn't have any amount due the text changes to "Deposit Money" instead of "Settle Due Accounts" Steps to reproduce: ------------------- * Install pos_settle_due module * Open PoS session * Open partner list * Click on details for any partner with no due > Observation: The "Settle Due Accounts" button is missing Why the fix: ------------ We always show the button, but change
Original PR description
The settle due accounts was not always shown on the partner screen. Now it's always shown, and when the user doesn't have any amount due the text changes to "Deposit Money" instead of "Settle Due Accounts" Steps to reproduce: ------------------- * Install pos_settle_due module * Open PoS session * Open partner list * Click on details for any partner with no due > Observation: The "Settle Due Accounts" button is missing Why the fix: ------------ We always show the button, but change the text to better match the behavior. If there is no amount due the text says "Deposit Money" and when the user has some amount due it says "Settle Due Accounts" opw-3925397 Forward-Port-Of: odoo/enterprise#65912 Forward-Port-Of: odoo/enterprise#65762
Before this commit, when you drag and drop a resizeable sign item from one page to another, it was not possible to resize the item: it was buggy because the updated sign item changed the page and the resize function had the old object binded to it. After this commit, it is possible resizing the sign items when clicking the border without any problems, from any page. This was obtained by re-binding the updated sign item to the resize function. task-4032512 Forward-Port-Of: odoo/enterprise#
Original PR description
Before this commit, when you drag and drop a resizeable sign item from one page to another, it was not possible to resize the item: it was buggy because the updated sign item changed the page and the resize function had the old object binded to it. After this commit, it is possible resizing the sign items when clicking the border without any problems, from any page. This was obtained by re-binding the updated sign item to the resize function. task-4032512 Forward-Port-Of: odoo/enterprise#65990
**Current behavior:** If a portal or public user causes a rental order to get confirmed, rental transfer pickings won't get created if the DB user has the setting enabled. **Expected behavior:** The transfer should be created with respect to the user of the database, not the external users. **Steps to reproduce:** 1. Enable rental transfers 2. Create a rental order to a portal user 3. In a fresh browser, open the preview link as the portal user 4. Sign & Pay for the order 5.
Original PR description
**Current behavior:** If a portal or public user causes a rental order to get confirmed, rental transfer pickings won't get created if the DB user has the setting enabled. **Expected behavior:** The transfer should be created with respect to the user of the database, not the external users. **Steps to reproduce:** 1. Enable rental transfers 2. Create a rental order to a portal user 3. In a fresh browser, open the preview link as the portal user 4. Sign & Pay for the order 5. See that no transfers got created **Cause of the issue:** We use the `env.user` to determine whether the transfers should be generated. **Fix:** Use the creator of the order to decide to create the transfer. opw-3933511 Forward-Port-Of: odoo/enterprise#66302
Before this PR: In the sign module, there are inconsistencies with the alignment of texts and icons, in both the portal and backend interfaces. After this PR: This fix addresses alignment issues and ensures consistency between the portal and backend interfaces. Now, texts and icons in the sign appear aligned and consistent across both interfaces. Forward-Port-Of: odoo/enterprise#63983
Original PR description
Before this PR: In the sign module, there are inconsistencies with the alignment of texts and icons, in both the portal and backend interfaces. After this PR: This fix addresses alignment issues and ensures consistency between the portal and backend interfaces. Now, texts and icons in the sign appear aligned and consistent across both interfaces. Forward-Port-Of: odoo/enterprise#63983
Enhanced the `_compute_l10n_in_state_id` method in the `AccountMove` model by adding a dependency on the `l10n_in_pos_session_ids` field. This ensures that the state computation is triggered when POS sessions are updated, improving the accuracy of state determination for moves related to POS sessions. Forward-Port-Of: odoo/odoo#173270
Original PR description
Enhanced the `_compute_l10n_in_state_id` method in the `AccountMove` model by adding a dependency on the `l10n_in_pos_session_ids` field. This ensures that the state computation is triggered when POS sessions are updated, improving the accuracy of state determination for moves related to POS sessions. Forward-Port-Of: odoo/odoo#173270
Clear the EDI document errors and the blocking_level when the action to abandon cancel posted moves is called. Fixed the following case: 1. Stamp a customer invoice (Could you test with a Mexican record) 2. Request EDI cancellation (In this case must be generated a cancel error from the PAC, maybe the customer does not accept the cancellation) 3. Ensure that in step 2, the EDI document has an error message 4. Call the action to abandon the EDI cancellation Without this commit, the EDI
Original PR description
Clear the EDI document errors and the blocking_level when the action to abandon cancel posted moves is called. Fixed the following case: 1. Stamp a customer invoice (Could you test with a Mexican record) 2. Request EDI cancellation (In this case must be generated a cancel error from the PAC, maybe the customer does not accept the cancellation) 3. Ensure that in step 2, the EDI document has an error message 4. Call the action to abandon the EDI cancellation Without this commit, the EDI document returns to `send`, but the record presents the error. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172169
before this commit, a traceback was showing on creating product variant steps to reproduce: * click create button in product, traceback will be showing after this commit, without any traceback product is created traceback is introduced in: https://github.com/odoo/odoo/commit/758ced91f8cb220a003a49b01e047b507f8509d7 traceback details:  super()._compute_display_name() File "/da
Original PR description
before this commit, a traceback was showing on creating product variant steps to reproduce: * click create button in product, traceback will be showing after this commit, without any traceback…
before this commit, a traceback was showing on creating product variant steps to reproduce: * click create button in product, traceback will be showing after this commit, without any traceback product is created traceback is introduced in: https://github.com/odoo/odoo/commit/758ced91f8cb220a003a49b01e047b507f8509d7 traceback details:  super()._compute_display_name() File "/data/build/enterprise/sale_renting/models/product_product.py", line 14, in _compute_display_name super()._compute_display_name() File "/data/build/odoo/addons/l10n_gcc_invoice/models/product.py", line 23, in _compute_display_name product.display_name = re.sub(r'(\d)(\s)([\u0600-\u06FF])', repl, product.display_name) File "/usr/lib/python3.10/re.py", line 209, in sub return _compile(pattern, flags).sub(repl, string, count) TypeError: expected string or bytes-like object --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#172240