Tuesday, July 16, 2024
2 changes · saas-17.3
Resolved issues and error corrections
This fixes a visual issue where text could disappear when users hovered over SelectMenu buttons, especially in areas like Studio's view selector. The change aligns the button styling with the newer Bootstrap version, improving consistency across normal and dark mode views.
Original PR description
As of Bootstrap 5.3 (commit 058212e12b5079eba870bde9775fe98f27928935), buttons with class `.btn` should have an additional class specifying the subtype of button (https://getbootstrap.com/docs/5.3/components/buttons/#base-class) Before this commit, when hovering a SelectMenu, no specific behavior was set, and sometimes (in Studio -- View Selector in XMLEditor), hovering the button made the text disappear. After this commit, this is fixed. A few instances of SelectMenu were tested (Studio, knowledge), and in dark mode as well. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents a crash when users drag autofill on spreadsheet formulas linked to pivot data. Pivot-specific autofill is disabled in this edge case so spreadsheets continue using the standard autofill behavior instead.
Original PR description
Steps to reproduce: - create a spreadsheet pivot with a measure - in a cell, type =PIVOT.VALUE(1, "<the measure>") - (the result is an error, that's expected) - autofill the formula up => boom the odoo pivot specific autofill should be disabled (it should be the normal autofill) TypeError: pivot.getPivotHeaderFormattedValue is not a function at PivotAutofillPlugin._tooltipFormatPivotHeader (pivot_autofill_plugin.js:649:1) at PivotAutofillPlugin.getTooltipFormula (pivot_autofill_plugin.js:130:1) at Object.apply (autofill.js:71:1) at AutofillGenerator.next (o_spreadsheet.js:54774:1) at AutofillPlugin.computeNewCell (o_spreadsheet.js:55010:1) at AutofillPlugin.autofill (o_spreadsheet.js:54893:1) at AutofillPlugin.select (o_spreadsheet.js:54959:1) at AutofillPlugin.handle (o_spreadsheet.js:54825:1) at Model.dispatchToHandlers (o_spreadsheet.js:66774:1) at o_spreadsheet.js:66714:1 Task: 3987035