Odoo Changelog — 2024-07-18

Thursday, July 18, 2024

2 changes

Bug Fixes(2)

Resolved issues and error corrections

[FW][FIX] account: always get tax tags using the base term when they are translatable

Enterprise17.0accountaccount_reportsl10n_multilangHIGH

This fix resolves an issue where tax report lines were showing zero values when users switched to a translated language. The problem occurred because tax tag names were being translated, but the report formulas that reference these tags were not. The fix ensures that tax tags are always matched using the base English language to maintain consistency between report formulas and tag names.

Original PR description

To reproduce the issue:

1) Make an invoice using a tax impacting some tag
2) Add a tanslation to that tag
3) Switch the user language to the one you added a translation for 4) Open the tax report: the line the tag is linked to has a value of 0 ===> It should contain the value you added in 1)

l10n_multilang makes the 'name' field of account.account.tag translatable. Because of that, it is important to always check the tags matching a report expression's formula using en_US as the language, to make sure the formula of the report expression matches the tag name (since that expression's formula is not translatable).

community: https://github.com/odoo/odoo/pull/170041

Forward-Port-Of: odoo/enterprise#65030

#tax-reporting#multilingual#localization#data-accuracy

[FIX] sale_subscription: avoid making payment with negative amount

PR #64098

Enterprise17.0sale_subscriptionHIGH

Fixed a critical issue where subscription invoices with negative amounts (credit notes) could incorrectly charge customers instead of refunding them. The system now blocks automatic payments for negative amounts and flags these invoices for manual review, preventing unintended charges while maintaining data integrity.

Original PR description

Before, when the subscription cron create recurring invoices, it might create a credit note in case some already invoiced non recurring product had his ordered quantity set back to zero.
The payment transaction created for this credit note will take the absolute total without taking into account the type of the entry process. This leads to a transaction charging the amount to the client instead of refunding him.

As we don't want to allow automatic refund because it could lead to catastrophe if a bug occurs, we decide to prevent the payment request if the amount is negative. In that case, we keep the draft invoice and keep the "payment_exception" flag to avoid running the subscription invoice cron again on that contract.

opw-3874964

#payment#subscription#invoice#refund#bug-fix

To reproduce the issue: 1) Make an invoice using a tax impacting some tag 2) Add a tanslation to that tag 3) Switch the user language to the one you added a translation for 4) Open the tax report: the line the tag is linked to has a value of 0 ===> It should contain the value you added in 1) l10n_multilang makes the 'name' field of account.account.tag translatable. Because of that, it is important to always check the tags matching a report expression's formula using en_US as the language, to make sure the formula of the report expression matches the tag name (since that expression's formula is not translatable). community: https://github.com/odoo/odoo/pull/170041 Forward-Port-Of: odoo/enterprise#65030

Before, when the subscription cron create recurring invoices, it might create a credit note in case some already invoiced non recurring product had his ordered quantity set back to zero. The payment transaction created for this credit note will take the absolute total without taking into account the type of the entry process. This leads to a transaction charging the amount to the client instead of refunding him. As we don't want to allow automatic refund because it could lead to catastrophe if a bug occurs, we decide to prevent the payment request if the amount is negative. In that case, we keep the draft invoice and keep the "payment_exception" flag to avoid running the subscription invoice cron again on that contract. opw-3874964