Friday, July 19, 2024
10 changes · 17.0
Resolved issues and error corrections
This fixes dependency requirements so the system continues to work correctly with Python 3.11 after changes made for Python 3.12. It reduces the risk of installation or upgrade issues for environments still using Python 3.11.
Original PR description
The adaptation for 3.12 broke some of the 3.11 packages compatibility This commit should fix them. See #173788 for more info
The shop page layout now keeps the “Sort by” dropdown in the right place when the search bar is hidden and multiple pricelists are available. This prevents a misplaced control from disrupting the shopping experience and makes the page easier for customers to use.
Original PR description
Steps: -Go to your /shop page. -Disable the search bar from the editor. -Configure several pricelists as selectable. Issue: When the search bar is disabled and multiple pricelists are selectable,'Sort by' dropdown does not align correctly, causing it to appear in the middle of the page instead of to the left, just after the pricelists. Fix: Applied the me-auto class to the 'Sort by' dropdown, ensuring it aligns correctly to the left within its container. opw-3994784 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Dragging items using handles now keeps them properly inside their container instead of letting them slip past the bottom edge. This improves the reliability and polish of drag-and-drop interactions in the web interface.
Original PR description
Before this commit, when dragging elements with draggable hooks, the Y coordinate of the dragged element was not correctly clamped within its container. This is because its own height wasn't taken into account and it could overflow on the bottom. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Inventory administrators can now open product records even when related taxes use accounting tags. This removes an access error that blocked inventory users in localized company setups without requiring extra accounting permissions.
Original PR description
Problem
---------
Curently, an inventory admin cannot access a product that has a tax with a tax tag set.
1 - Have 'stock_account' installed with the requirements for it
2 - Have a loca such as l10n_cz installed
3a - Remove 'Demo' user's privilieges:
- Purchase
- Accounting
- Sales
3b - Set Inventory as Administrator
4 - Make sure 'Demo' has access to the demo loca company (create one if
necessary)
5 - Connect with 'Demo' and change to the loca company
6 - Go to Inventory -> Products
7 - Open any product
-> Should be welcomed with a 'invalid access right' error.
Objective
---------
Allow an inventory admin to access the products.
Solution
---------
Add a new readonly access rule on account.account.tag for inventory admin.
opw-4038926
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThis fixes a display issue where the color picker could be partially hidden when editing button styles in mass mailing templates. Users can now select text and fill colors from the sidebar without the picker being cut off, improving the email design workflow.
Original PR description
Issue: ====== Half of the colorpicker isn't visible in the sidebar toolbar. Steps to reproduce the issue: ============================= - Go to mass mailing and choose any template with a button. -…
Issue: ====== Half of the colorpicker isn't visible in the sidebar toolbar. Steps to reproduce the issue: ============================= - Go to mass mailing and choose any template with a button. - Click on the button, make it a link. - Choose style as custom in the sidebar - Click on the circles for text color or fill color - Colorpicker is not position correctly. Origin of the issue: ==================== See commit: https://github.com/odoo/odoo/commit/88c16966b6b2d29d464ac3b43cc4998d3f4fe0e2 Solution: ========= Fixing this issue properly would require huge changes to how the SnippetsMenu is constructed and would most likely require going back to the slow iframe with all the assets inside. That would not be a desirable outcome, especially in a stable version. With that in mind, and considering the issue doesn't exist in saas-17.1, we decided it was a prime example where a local change in the popper.js library was actually the best fix. The library is very unlikely to be updated in a stable version and the change won't reach saas-17.1. co-authored with dmo-odoo opw-3984170
The reseller directory now handles reseller records that do not have a country set. This prevents an error page and keeps the expected fallback behavior of showing all resellers when no country-specific match is available.
Original PR description
Steps to reproduce: - Go to Contact - Select Abigail Peterson - Set her as a company, don't fill the field country - In Partner assignment, set partner level, activation, level weight - Cick on go to website - Back to Resellers What happens: Error with traceback ending in "TypeError: 'bool' object is not subscriptable". This is due to the country field of a reseller not being filled in, the resellers page tries to load the list of all countries with resellers and displays either resellers of the user's country or all resellers if no match is found. If any reseller's country is not filled in there is no 'country.id' to access leading to the error above. Expected behavior: Fallback: Show all partners when user's country has no resellers (as described in the file itself by comments). opw-4042404 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes an issue where some filtered searches could fail because the system generated invalid database instructions. The change helps keep Odoo searches and business logic reliable when using affected filters.
Original PR description
Parentheses were missing; so the generated SQL failed to execute.
This fix resolves an issue where new helpdesk tickets displayed "name - #False" in the title bar instead of just "name" when the ticket reference number hadn't been assigned yet. After saving, the ticket reference will display correctly. This improves the user experience by removing confusing placeholder text from the interface.
Original PR description
How to reproduce (on 17.0 onwards): - Helpdesk -> new ticket form - set the name of the ticket (do not save the record) - then, set a partner to a existing partner - The display_name on the top displays 'name - #False' Expeceted behavior: - instead of displaying 'name - #False', it should display 'name' if the ticket_ref is not defined yet. After this commit, the display_name only displays the ticket_ref (#ID) if it exists. Test have been added for this purpose. Task: 3893076
This update improves the user experience by hiding the Field Service section in project forms when it contains no relevant settings. The section now only appears in debug mode when using the basic Field Service module, but displays normally when the Field Service Reports module is installed with additional settings available.
Original PR description
When `industry_fsm` is installed, the form of `project.project` contains a section `Field Service` with only one setting (`is_fsm`). This option is only visible in only visible in debug mode, so the whole section should be displayed only under this conditon. => The group `base.group_no_one` has been added to the section. When `industry_fsm_report` is installed, another setting appears under that section (`worksheet_template_id`), so the section should be displayed. => The group that is added in `industry_fsm` is removed then. task-3916982
A test for knowledge base access controls was using the wrong user type for validation. The test now correctly uses an internal employee user instead of a portal user, ensuring that access control rules are properly tested for the intended user category. This fix ensures the security testing is accurate.
Original PR description
This commit changes the user for the test `:TestWKnowledgeSecurity.test_models_as_user` which should test ACLs for internal users. Initially it used `portal_user`, which is not internal but portal. It is now replaced by `employee`. task-4059967 Forward-Port-Of: odoo/enterprise#66869