Saturday, July 20, 2024
8 changes · saas-17.4
Miscellaneous changes
Before this commit, some calendar didn't show multiple days events in day and week modes. This commit enables the day slots in every calendar to show these events. opw-3933140 opw-3981108 Forward-Port-Of: odoo/odoo#173651 Forward-Port-Of: odoo/odoo#172729
Original PR description
Before this commit, some calendar didn't show multiple days events in day and week modes. This commit enables the day slots in every calendar to show these events. opw-3933140 opw-3981108 Forward-Port-Of: odoo/odoo#173651 Forward-Port-Of: odoo/odoo#172729
The `account` module adds the `tax_string` field to product forms: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/views/product_view.xml#L76 That field calls `Model(account.tax).compute_all()`: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/product.py#L71 That method needs access to `account.account.tag` records: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/acco
Original PR description
The `account` module adds the `tax_string` field to product forms: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/views/product_view.xml#L76 That field…
The `account` module adds the `tax_string` field to product forms: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/views/product_view.xml#L76 That field calls `Model(account.tax).compute_all()`: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/product.py#L71 That method needs access to `account.account.tag` records: https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L563 https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L632 https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L648 https://github.com/odoo/odoo/blob/ceb8b785fba1055deeff8d9075ccc707f2317278/addons/account/models/account_tax.py#L671 Internal users were able to read `account.tax` and `account.tax.repartition.line` records, but they couldn't read `account.account.tag` records. So, this lead to the absurd situation where a user with permissions to read products (like stock, PoS or event users) couldn't be able to see the product form anymore whenever that product happened to have a tax with a repartition line with a tag: https://github.com/odoo/odoo/assets/973709/1801eef5-8f1a-4883-8051-858cdd457e74 This is a regression from Odoo 14, introduced in https://github.com/odoo/odoo/pull/74138 and https://github.com/odoo/odoo/pull/73602. I'm granting all internal users read permission over `account.account.tag`, just like the one they have for `account.tax` and `account.tax.repartition.line`. BTW that's the fix suggested by Odoo helpdesk. @moduon MT-4390 OPW-3636032 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#152169 Forward-Port-Of: odoo/odoo#146787
**Description of the issue/feature this PR addresses:** based on the fact that `PCVIII1` + `PCVIII2` are just independent subcategories which must be also available in `PCVIII3` or `PCVIII4` and therefore are the base for the sum of `PCVIII` which should not have an independent tag in the future anyway **Current behavior before PR:** Incomplete information based on these tags in the current and changed balance sheet **Desired behavior after PR is merged:** Having a proper and complete p
Original PR description
**Description of the issue/feature this PR addresses:** based on the fact that `PCVIII1` + `PCVIII2` are just independent subcategories which must be also available in `PCVIII3` or `PCVIII4` and therefore are the base for the sum of `PCVIII` which should not have an independent tag in the future anyway **Current behavior before PR:** Incomplete information based on these tags in the current and changed balance sheet **Desired behavior after PR is merged:** Having a proper and complete picture of the current accounts available in the balance sheet Enterprise PR: https://github.com/odoo/enterprise/pull/64747 Info: @wt-io-it --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171410
Description of the issue/feature this PR addresses: Add new contributor Rosen Vladimirov cla-file Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173805
Original PR description
Description of the issue/feature this PR addresses: Add new contributor Rosen Vladimirov cla-file Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173805
This PR is created in order to sing the odoo CLA and contribute to Odoo. needed for --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173717
Original PR description
This PR is created in order to sing the odoo CLA and contribute to Odoo. needed for --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173717
tldr: The init function should not be used in this case for creating records. Doing so results in errors. The content of this init function can be safely moved to the post-init hook The problem: In saas~17.2, creating a company with a country can result in the installation of its accompanying localisation. If it is a European country, this will trigger the installation of base_vat too. If project_timesheet_holdiays is installed this can result in the installation of base_vat failing. The
Original PR description
tldr: The init function should not be used in this case for creating records. Doing so results in errors. The content of this init function can be safely moved to the post-init hook The problem: In…
tldr: The init function should not be used in this case for creating records. Doing so results in errors. The content of this init function can be safely moved to the post-init hook The problem: In saas~17.2, creating a company with a country can result in the installation of its accompanying localisation. If it is a European country, this will trigger the installation of base_vat too. If project_timesheet_holdiays is installed this can result in the installation of base_vat failing. The init method described on res_company in project_timesheet_holidays is triggered when the res_partner model is extended, for instance, in base_vat when adding fields. The registry will contain these fields, but the accompanying fields will not yet have been written to the db. When the project and task are created, a chain of dependencies result in the company's partner being read. In turn, a query is issued using fields from the registry that aren't yet written to the DB, resulting in an SQL error. Solution: Move the content of this method to the post-init hook. This is safe to do and works the same way. task-id: 4060907 Forward-Port-Of: odoo/odoo#173719
This homogenizes the address format we send for each location and adds the terms and conditions and delivery date. This makes the customer invoice PDF that Avatax generates more complete and less confusing for users and their customers. task-3894745 Forward-Port-Of: odoo/enterprise#66868
Original PR description
This homogenizes the address format we send for each location and adds the terms and conditions and delivery date. This makes the customer invoice PDF that Avatax generates more complete and less confusing for users and their customers. task-3894745 Forward-Port-Of: odoo/enterprise#66868
After finally checking with a full-fledged accounting customer which is verified by tax lawyers and auditors these changes are needed to show the exact same result as left behind battle tested in `15.0` - `PCVIII` is a sum of `PCVIII3` + `PCVIII4` and those can be part of `PCVIII1` or `PCVIII2` This needs also be reflected in `ABII4` if the balance needs to be mirrored. Actually it should be similar presented in `ABII4`, but was not yet done. This might need some account tags to be adapted
Original PR description
After finally checking with a full-fledged accounting customer which is verified by tax lawyers and auditors these changes are needed to show the exact same result as left behind battle tested in `15.0` - `PCVIII` is a sum of `PCVIII3` + `PCVIII4` and those can be part of `PCVIII1` or `PCVIII2` This needs also be reflected in `ABII4` if the balance needs to be mirrored. Actually it should be similar presented in `ABII4`, but was not yet done. This might need some account tags to be adapted in Odoo Community `l10n_at` CoA, but let's start from here as it is secured and tested information. Info: @wt-io-it Forward-Port-Of: odoo/enterprise#64747