Tuesday, July 23, 2024
27 changes · saas-17.1
Miscellaneous changes
Before this commit : In Draft Invoice/bill if we change fiscal position then it's not updating tax and account in existing lines. After this commit : In the Draft Invoice/bill if we change in fiscal position then it will update the tax and account in existing lines. Task - 3619055 Forward-Port-Of: odoo/odoo#153172
Original PR description
Before this commit : In Draft Invoice/bill if we change fiscal position then it's not updating tax and account in existing lines. After this commit : In the Draft Invoice/bill if we change in fiscal position then it will update the tax and account in existing lines. Task - 3619055 Forward-Port-Of: odoo/odoo#153172
Have a partner with district filled Create a Sale Order Print report Issue: District is missing opw-4020494 Forward-Port-Of: odoo/odoo#173166 Forward-Port-Of: odoo/odoo#172323
Original PR description
Have a partner with district filled Create a Sale Order Print report Issue: District is missing opw-4020494 Forward-Port-Of: odoo/odoo#173166 Forward-Port-Of: odoo/odoo#172323
Specification: In the daterange widget, if the second date field is required and left empty, the field should be marked as invalid and be colored red. Expected behavior: if the second field is empty so that fields should be highlighted in red. Task-3786540 Forward-Port-Of: odoo/odoo#162000
Original PR description
Specification: In the daterange widget, if the second date field is required and left empty, the field should be marked as invalid and be colored red. Expected behavior: if the second field is empty so that fields should be highlighted in red. Task-3786540 Forward-Port-Of: odoo/odoo#162000
Before this commit, if a settings app doesn't have settings (for instance if a setting header is not selected), the no content helper was always shown. The issue with this, is that the settings page is not a multi-record view, it's a customize form view, the content helper, it should only be shown if a search is performed and that no setting is found. This commit, fix this, and allow the no content helper to appear only if a search is performed and no setting is found. opw-4016050 Forward
Original PR description
Before this commit, if a settings app doesn't have settings (for instance if a setting header is not selected), the no content helper was always shown. The issue with this, is that the settings page is not a multi-record view, it's a customize form view, the content helper, it should only be shown if a search is performed and that no setting is found. This commit, fix this, and allow the no content helper to appear only if a search is performed and no setting is found. opw-4016050 Forward-Port-Of: odoo/odoo#174092 Forward-Port-Of: odoo/odoo#174059
A company that is carrying out a project financed with public money has the obligation to have the CUP code (and also the CIG) indicated on the purchase invoices. For non-PA customers, those fields are visible but not required and when filled in, will be presented in the XML. task-4032771 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173682
Original PR description
A company that is carrying out a project financed with public money has the obligation to have the CUP code (and also the CIG) indicated on the purchase invoices. For non-PA customers, those fields are visible but not required and when filled in, will be presented in the XML. task-4032771 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173682
Steps to reproduce: - Create a storable product. - Create a picking with it and validate. - Try to change the product type to consumable. Not allowed because there is a move done. - Archive the product. - Try to change the product type. No user error is raised... Excepted behaviour: It should not be possible to change the product type even if the product is archived, as it causes inconsistencies. Task 4058450 --- I confirm I have signed the CLA and read the PR guidelines at www.od
Original PR description
Steps to reproduce: - Create a storable product. - Create a picking with it and validate. - Try to change the product type to consumable. Not allowed because there is a move done. - Archive the product. - Try to change the product type. No user error is raised... Excepted behaviour: It should not be possible to change the product type even if the product is archived, as it causes inconsistencies. Task 4058450 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173901 Forward-Port-Of: odoo/odoo#173526
Steps to reproduce: ------------------- * Activate discount on lines on user parameters * Change the pricelist config to show discount to the customers * Open a PoS session with the modified pricelist * Create an order and apply some discount on the lines * Invoice and pay the order > Observation: On the invoice pdf you should have a line saying "Price discount from X -> X" but it's not there Why the fix: ------------ Before the fix we were comparing the `price_unit` on the line and
Original PR description
Steps to reproduce: ------------------- * Activate discount on lines on user parameters * Change the pricelist config to show discount to the customers * Open a PoS session with the modified pricelist * Create an order and apply some discount on the lines * Invoice and pay the order > Observation: On the invoice pdf you should have a line saying "Price discount from X -> X" but it's not there Why the fix: ------------ Before the fix we were comparing the `price_unit` on the line and the `lst_price` of the product. But if a discount was applied on the line the price unit is not affected, and so the line was never shown. To fix this we compare the `total_price` of the line with the `lst_price` multiplied by the quantity on the line. opw-4019107 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#173687 Forward-Port-Of: odoo/odoo#172754
Currently, if you create a combo product, or modify an existing product into a combo product, the previous tax field is saved. Steps to reproduce: ------------------- * Create a new storable product with a tax set * Modify the product type to `Consumable` * Save > Observation: Next to the price we see "(=... tax incl) Why the fix: ------------ Combo products are not meant to have taxes set. It is confirmed by the fact that the field becomes invisible when we have combo products. Tax
Original PR description
Currently, if you create a combo product, or modify an existing product into a combo product, the previous tax field is saved. Steps to reproduce: ------------------- * Create a new storable product with a tax set * Modify the product type to `Consumable` * Save > Observation: Next to the price we see "(=... tax incl) Why the fix: ------------ Combo products are not meant to have taxes set. It is confirmed by the fact that the field becomes invisible when we have combo products. Taxes are computed once the product is added to the cart depending on the taxes of the products chosen. opw-4004978 Forward-Port-Of: odoo/odoo#172358
Steps to reproduce: - Install `l10n_fr_invoice_addr` - Switch to french company - Change "Colors" in "Document Layout" settings - Go to an invoice and click the "Preview" button Because of the inconsistent HTML tags used, the invoice styling wouldn't get applied to the columns added by `l10n_fr_invoice_addr`. This commit improves consistency with the pre-existing HTML hence fixing that issue See: #172497 task-4056046 Forward-Port-Of: odoo/odoo#174071 Forward-Port-Of: odoo/odoo#1732
Original PR description
Steps to reproduce: - Install `l10n_fr_invoice_addr` - Switch to french company - Change "Colors" in "Document Layout" settings - Go to an invoice and click the "Preview" button Because of the inconsistent HTML tags used, the invoice styling wouldn't get applied to the columns added by `l10n_fr_invoice_addr`. This commit improves consistency with the pre-existing HTML hence fixing that issue See: #172497 task-4056046 Forward-Port-Of: odoo/odoo#174071 Forward-Port-Of: odoo/odoo#173299
Currently, when website snippets were translated and they had special characters in them, they would be escaped before adding them as the `data-name` attribute of the snippet, which escaped them again. When the snippet would be selected, the sidebar would get that `data-name` attribute and use it as the title, resulting in the characters still being escaped. This commit fixes that by not escaping the name beforehand, but only when used in raw HTML. Example of the problem (Mur d'images): !
Original PR description
Currently, when website snippets were translated and they had special characters in them, they would be escaped before adding them as the `data-name` attribute of the snippet, which escaped them again. When the snippet would be selected, the sidebar would get that `data-name` attribute and use it as the title, resulting in the characters still being escaped. This commit fixes that by not escaping the name beforehand, but only when used in raw HTML. Example of the problem (Mur d'images):  Forward-Port-Of: odoo/odoo#174018 Forward-Port-Of: odoo/odoo#173808
Users without administrative rights were unable to refund transactions because the call to `_send_refund_request` was made without `sudo`. This commit adds both the necessary `sudo` to bypass the access rights check on the transaction's payment acquirer and a manual access rights check on the transaction itself to prevent abusing RPC calls. opw-4033356 Forward-Port-Of: odoo/odoo#173953 Forward-Port-Of: odoo/odoo#173663
Original PR description
Users without administrative rights were unable to refund transactions because the call to `_send_refund_request` was made without `sudo`. This commit adds both the necessary `sudo` to bypass the access rights check on the transaction's payment acquirer and a manual access rights check on the transaction itself to prevent abusing RPC calls. opw-4033356 Forward-Port-Of: odoo/odoo#173953 Forward-Port-Of: odoo/odoo#173663
Problem: When attempting to paste text (either via right-click -> paste or using CTRL-V) into the chatter of a shared project, the action fails. This issue was caused by the addition of `event.preventDefault()` in the `ProjectSharingFormController` form. This does not affect the description field as it is also managed by `OdooEditor`. Steps to reproduce: 1. Share a project with a user. 2. Impersonate the user and navigate to the project from the portal. 3. Select a task. 4. Attempt to
Original PR description
Problem: When attempting to paste text (either via right-click -> paste or using CTRL-V) into the chatter of a shared project, the action fails. This issue was caused by the addition of `event.preventDefault()` in the `ProjectSharingFormController` form. This does not affect the description field as it is also managed by `OdooEditor`. Steps to reproduce: 1. Share a project with a user. 2. Impersonate the user and navigate to the project from the portal. 3. Select a task. 4. Attempt to paste something into the chatter. opw-4046529 Forward-Port-Of: odoo/odoo#173329
EAS codes 0037 and 0215 have been deprecated as of OpenPeppol eDEC codelists v8.9 https://docs.peppol.eu/edelivery/codelists/changelog.html We will place a warning in stable and remove it in master. no task Forward-Port-Of: odoo/odoo#173316
Original PR description
EAS codes 0037 and 0215 have been deprecated as of OpenPeppol eDEC codelists v8.9 https://docs.peppol.eu/edelivery/codelists/changelog.html We will place a warning in stable and remove it in master. no task Forward-Port-Of: odoo/odoo#173316
Update Cla for Openforce --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168681
Original PR description
Update Cla for Openforce --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#168681
The adaptation for 3.12 broke some of the 3.11 packages compatibility This commit should fix them. See #173788 for more info Forward-Port-Of: odoo/odoo#173913
Original PR description
The adaptation for 3.12 broke some of the 3.11 packages compatibility This commit should fix them. See #173788 for more info Forward-Port-Of: odoo/odoo#173913
When stock is not installed, the override of _fsm_ensure_sale_order in industry_fsm_stock doesn't auto-confirm sale order, so the test `test_qty_to_invoice_from_fsm` failed because the `qty_to_invoice` was set to 0 if the order was not confirmed. With this PR, the order is confirmed in the test flow if stock is not installed. opw-[4061485](https://www.odoo.com/web#id=4061485&view_type=form&model=project.task) Forward-Port-Of: odoo/enterprise#67116
Original PR description
When stock is not installed, the override of _fsm_ensure_sale_order in industry_fsm_stock doesn't auto-confirm sale order, so the test `test_qty_to_invoice_from_fsm` failed because the `qty_to_invoice` was set to 0 if the order was not confirmed. With this PR, the order is confirmed in the test flow if stock is not installed. opw-[4061485](https://www.odoo.com/web#id=4061485&view_type=form&model=project.task) Forward-Port-Of: odoo/enterprise#67116
Steps to reproduce: - Projects > Field Service > New - Pick a customer but no assignee - Products > Add any product - Back to task > Sale order > Other info tab What happens: No salesperson is set. Expected behavior: salesperson is the first assignee on the task if any, current user if not (first assignee as in the first listed on the task, which sorts them alphabetically). opw-4026074 opw-4015184 (duplicate) Forward-Port-Of: odoo/enterprise#66404
Original PR description
Steps to reproduce: - Projects > Field Service > New - Pick a customer but no assignee - Products > Add any product - Back to task > Sale order > Other info tab What happens: No salesperson is set. Expected behavior: salesperson is the first assignee on the task if any, current user if not (first assignee as in the first listed on the task, which sorts them alphabetically). opw-4026074 opw-4015184 (duplicate) Forward-Port-Of: odoo/enterprise#66404
Currently, log level error message occur when no company is found during scheduled actions run at line [1]. This commit changes 'logger.error' to 'logger.warning' to log a message instead of an error since this is not an actual error in the code base. [1]-https://github.com/odoo/enterprise/blob/ddc81ed35a6738739647db868c13236673695cff/l10n_ke_edi_oscu/models/res_company.py#L437-L438 sentry-5608113473 Forward-Port-Of: odoo/enterprise#66799
Original PR description
Currently, log level error message occur when no company is found during scheduled actions run at line [1]. This commit changes 'logger.error' to 'logger.warning' to log a message instead of an error since this is not an actual error in the code base. [1]-https://github.com/odoo/enterprise/blob/ddc81ed35a6738739647db868c13236673695cff/l10n_ke_edi_oscu/models/res_company.py#L437-L438 sentry-5608113473 Forward-Port-Of: odoo/enterprise#66799
Steps to Reproduce: ----------- - Install sale planning. - Create a sale order with a plan product. - Navigate to the Planning app > Schedule > By Resource. - Click on a cell in the "Open Shifts" line. - Select a resource. - Save and close. - Check the shift resource. Issue: ---------- The shift is not being created in the open shift section based on the parameters selected by the user. Fix: ---------- When creating a shift from the open shift section, it
Original PR description
Steps to Reproduce: ----------- - Install sale planning. - Create a sale order with a plan product. - Navigate to the Planning app > Schedule > By Resource. - Click on a cell in the "Open Shifts" line. - Select a resource. - Save and close. - Check the shift resource. Issue: ---------- The shift is not being created in the open shift section based on the parameters selected by the user. Fix: ---------- When creating a shift from the open shift section, it should generate shifts according to the parameters selected by the user, such as resource, date, etc. task-3919549 Forward-Port-Of: odoo/enterprise#64203
Steps: - Install l10n_nl_reports - Open GL for the year 2024 - Export XAF -> Period numbers are displayed from 401 to 412, instead of 01 to 12 in the exported file opw-3999985 Forward-Port-Of: odoo/enterprise#67127 Forward-Port-Of: odoo/enterprise#67098
Original PR description
Steps: - Install l10n_nl_reports - Open GL for the year 2024 - Export XAF -> Period numbers are displayed from 401 to 412, instead of 01 to 12 in the exported file opw-3999985 Forward-Port-Of: odoo/enterprise#67127 Forward-Port-Of: odoo/enterprise#67098
…ights The setup of the password from a related field would throw errors to user with accountant rights but no administration (settings) rights. This showed other access rights problems with the SBR implementation. The way we want to work with this is: an accountant without settings rights can set up the password through the wizard if no password is stored on the company (for databases that didn't start SBR with the status info module). Once the password is set and is correct (it is the ri
Original PR description
…ights The setup of the password from a related field would throw errors to user with accountant rights but no administration (settings) rights. This showed other access rights problems with the SBR implementation. The way we want to work with this is: an accountant without settings rights can set up the password through the wizard if no password is stored on the company (for databases that didn't start SBR with the status info module). Once the password is set and is correct (it is the right one for the certificate), it shouldn't ask the user to put it again and is thus hidden in the wizard. ticket-4024344 Forward-Port-Of: odoo/enterprise#66096
Previously, we added support for self-withholding taxes, which do not need to be reported in the XML file. Hence, tax lines that contain a tax with a code ZZ (for customer invoices)/ ZZ, 07 (for vendor bills) are filtered out. However, when we compute the total amounts these are not filtered out, leading to a discrepancy in sums. We should filter out such tax lines when computing totals as well. See other commit: https://github.com/odoo/enterprise/commit/af8f364cc1f09cc1f9159b326a7f59
Original PR description
Previously, we added support for self-withholding taxes, which do not need to be reported in the XML file. Hence, tax lines that contain a tax with a code ZZ (for customer invoices)/ ZZ, 07 (for vendor bills) are filtered out. However, when we compute the total amounts these are not filtered out, leading to a discrepancy in sums. We should filter out such tax lines when computing totals as well. See other commit: https://github.com/odoo/enterprise/commit/af8f364cc1f09cc1f9159b326a7f59c6524380be opw-3958518 Forward-Port-Of: odoo/enterprise#67012 Forward-Port-Of: odoo/enterprise#66918
Moved iot.box view technical information to "Technical Information" tab. Task: 4033301 Forward-Port-Of: odoo/enterprise#66306
Original PR description
Moved iot.box view technical information to "Technical Information" tab. Task: 4033301 Forward-Port-Of: odoo/enterprise#66306
Before this commit, when posting a manually modified closing entry, the entire move would be refreshed, and all user-modified information would be erased. This occurred because, when accessing the action_periodic_vat_entries, the current tax closing move was overwritten. This commit changes this behavior by adding a flag to the method, indicating whether it is called from the _close_tax_period function. If so, it only updates moves that are different from the tax closing of the current compan
Original PR description
Before this commit, when posting a manually modified closing entry, the entire move would be refreshed, and all user-modified information would be erased. This occurred because, when accessing the action_periodic_vat_entries, the current tax closing move was overwritten. This commit changes this behavior by adding a flag to the method, indicating whether it is called from the _close_tax_period function. If so, it only updates moves that are different from the tax closing of the current company. Additionally, when selecting only one company within a tax unit, it sometimes happened that, when closing the main company, the dependent closings to post (depending_closings_to_post) were empty because the moves were not generated yet for the other companies. Task: 3987807 Forward-Port-Of: odoo/enterprise#65645
### **Steps to reproduce:** - install Timesheets module. - Go to To Validate. - Click on All Timesheets. ### **Issue:** - The notification message is not displaying when clicking on validate in pivot and kanban views ### **Solution:** - The problem seems to be from a mismatch in parameters when triggering the validation action. PR-https://github.com/odoo/enterprise/pull/44455 task-3925639 Forward-Port-Of: odoo/enterprise#62945
Original PR description
### **Steps to reproduce:** - install Timesheets module. - Go to To Validate. - Click on All Timesheets. ### **Issue:** - The notification message is not displaying when clicking on validate in pivot and kanban views ### **Solution:** - The problem seems to be from a mismatch in parameters when triggering the validation action. PR-https://github.com/odoo/enterprise/pull/44455 task-3925639 Forward-Port-Of: odoo/enterprise#62945
Only a few templates are fetched when the user tries to sync all the templates from the `WhatsApp Business Account` form view. Problem: The API request used to fetch all templates incorporates pagination. In the current scenario, the next URL to the subsequent page is included in the response, but we are not using it. Also, the limit parameter is not utilized in our API request to restrict the number of templates on a single page. Consequently, by default, 25 templates are received on the
Original PR description
Only a few templates are fetched when the user tries to sync all the templates from the `WhatsApp Business Account` form view. Problem: The API request used to fetch all templates incorporates pagination. In the current scenario, the next URL to the subsequent page is included in the response, but we are not using it. Also, the limit parameter is not utilized in our API request to restrict the number of templates on a single page. Consequently, by default, 25 templates are received on the first page. As a result, only templates received on the first page are being created or updated(i.e. 25). Solution: The limit to fetch 200 templates on a single page is added to obtain 200 templates in the first request. However, if there are more than 200 templates, the remaining ones will be fetched from the next page. This process will continue in a loop until all templates are received. Task-3903321 Forward-Port-Of: odoo/enterprise#62460
Steps to reproduce: - Create a shipping method with sendcloud as provider. - In the field 'Default package type' create a package type and set 'Max Weight'(e.g 1kg). - Create a sales order, Add shipping, and select sendcloud. - Add 'Total order weight'(e.g 0.5kg) - Click 'Get rate' Returned rate for shipping is unusually big ammout. Before this commit: For sendcloud shipping if sendcloud_default_package_type_id is set, max_weight is stored in kilograms. When checking if the pack
Original PR description
Steps to reproduce: - Create a shipping method with sendcloud as provider. - In the field 'Default package type' create a package type and set 'Max Weight'(e.g 1kg). - Create a sales order, Add…
Steps to reproduce: - Create a shipping method with sendcloud as provider. - In the field 'Default package type' create a package type and set 'Max Weight'(e.g 1kg). - Create a sales order, Add shipping, and select sendcloud. - Add 'Total order weight'(e.g 0.5kg) - Click 'Get rate' Returned rate for shipping is unusually big ammout. Before this commit: For sendcloud shipping if sendcloud_default_package_type_id is set, max_weight is stored in kilograms. When checking if the package needs to be splitted, the target_weight is not being converted whereas the total_weight is.(check link at the bottom for details) Also in shipping rate request for sendcloud `max_weight` was sent in kilograms with `unit` being 'gram'. After this commit: `max_weight` is converted into grams before adding to the shipping rate request. split shipping code: https://github.com/odoo/enterprise/blob/d3b39fe78bc0ae366d32e80e325e89d2a4bb353c/delivery_sendcloud/models/sendcloud_service.py#L160-L162 opw-4035569 Forward-Port-Of: odoo/enterprise#66594