Friday, July 26, 2024
12 changes · 17.0
Resolved issues and error corrections
The point of sale IoTBox startup shortcut now stops the running Odoo service before launching it manually, instead of restarting it. This prevents startup failures caused by the service already using the required address, improving reliability for support and maintenance tasks.
Original PR description
`odoo` alias on IoTBox is meant to start Odoo with cli. It used to restart the service before starting by cli, causing a `address already in use` error. Replaced `restart` by `stop` to avoid restarting the service.
The Upload button is no longer shown in the general Journal Entries view because uploads from there cannot be linked to a specific journal and always fail. Users can still upload documents when working within a specific journal, keeping the option available where it works correctly.
Original PR description
To replicate the issue: 1. Go to Accounting app 2. Click on the Accounting menu => Journal Entries 3. Click the button Upload 4. After selecting a file, an error is raise, saying that "The journal in…
To replicate the issue: 1. Go to Accounting app 2. Click on the Accounting menu => Journal Entries 3. Click the button Upload 4. After selecting a file, an error is raise, saying that "The journal in which to upload the invoice is not specified." Cause: In the view for Journal Entries, there isn't a particular journal associated with it, so there is no definition the journal in which the document should be uploaded. Before 17.0, the document was uploaded to a default journal. Without a default journal, the error is raised. This renders the button useless in this view, as it will always raise an error after the user has selected a file to upload. Fix: The button should not be shown in the Journal Entries view (through Accounting => Journal Entries). But if the user is in a specific journal (for example, navigating from Accounting Dashboard => Miscellaneous Operations), the button should be shown. To do so, the account move list and kanban controllers in bills_upload check if the default move type is 'entry', and if so, whether there is an active id in the context. This allows differentiating between the specific journals or the general Journal Entries view. opw-4029227 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Miscellaneous changes
Description of the issue/feature this PR addresses: Real information was used as a demo data partner, which caused complaints from the company which was the owner of this information Current behavior before PR: Data of the affected company available for demo databases Desired behavior after PR is merged: Data replaced for a fake demo company Task: [4071645](https://www.odoo.com/odoo/project/1625/tasks/4071645?cids=3) --- I confirm I have signed the CLA and read the PR guidelines a
Original PR description
Description of the issue/feature this PR addresses: Real information was used as a demo data partner, which caused complaints from the company which was the owner of this information Current behavior before PR: Data of the affected company available for demo databases Desired behavior after PR is merged: Data replaced for a fake demo company Task: [4071645](https://www.odoo.com/odoo/project/1625/tasks/4071645?cids=3) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#174301
Issue: ====== Image changes aren't auto saved. Steps to reproduce the issue: ============================= - Add cover snippet and text-image snipets - Change cover image or the image in the text-image snippet - Don't click anywhere after that - Switch tab to A/B testing for example - Go back to mail body - The image changes aren't saved Origin of the issue and solution: ================================= When we choose an image from the media dialog, we loose the focus from t
Original PR description
Issue: ====== Image changes aren't auto saved. Steps to reproduce the issue: ============================= - Add cover snippet and text-image snipets - Change cover image or the image in the…
Issue: ====== Image changes aren't auto saved. Steps to reproduce the issue: ============================= - Add cover snippet and text-image snipets - Change cover image or the image in the text-image snippet - Don't click anywhere after that - Switch tab to A/B testing for example - Go back to mail body - The image changes aren't saved Origin of the issue and solution: ================================= When we choose an image from the media dialog, we loose the focus from the editable which means `onWysiwygBlur` is not called and as consequence `commitChanges` isn't called too. Since the flow of the destroy and the `commitChanges` in `onWysiwygBlur` are in parallel, the following happens: - We don't update the value in the blur flow because we will wait for some promises which may take some time and the component gets destroyed and we never call the `updateValue` at the end of the function. - Now in the `commitChanges` coming from `onWillUnmount` we need to pass the `urgent` flag in mass_mailing too. opw-3947516 Forward-Port-Of: odoo/odoo#172312
Problem --- The `sequence` field of product attributes has no default, This causes ordering bugs in the frontend when using handles. Steps --- * go to product attributes list view * move the last element to the top (to ensure a full reordering) * create a new product attribute *PA* > go back to the list view * => it appears at the bottom of the list * => its sequence appears to be 0 to the frontend but is actually NULL * move it one place up * => *PA* and the item after it
Original PR description
Problem --- The `sequence` field of product attributes has no default, This causes ordering bugs in the frontend when using handles. Steps --- * go to product attributes list view * move the last element to the top (to ensure a full reordering) * create a new product attribute *PA* > go back to the list view * => it appears at the bottom of the list * => its sequence appears to be 0 to the frontend but is actually NULL * move it one place up * => *PA* and the item after it now have the sequence numbers 0, 1 * refresh * => the two last items move to the top, crisscrossing with the previous 2 first items which also have sequence 0, 1 Cause --- The frontend always assume click-and-drag sortable lists are already sorted, but this assumption is wrong when we have a record with a NULL `sequence`, because it will appears at the end of the ORDERBY SQL query but be converted to 0 frontend-side. opw-3937263 Forward-Port-Of: odoo/odoo#174397
Current behavior before PR: -Resized column widths were lost when moving the top row down or the second row up. -This happened because the new widths after resizing were only applied to the `<td>` elements of the first `<tr>.` Desired behavior after PR is merged: -When moving the top row down or second row up, column widths are copied from the first row to the second row. -Tables don't lose resizing after moving the first row up or down. task-4019025 --- I confirm I hav
Original PR description
Current behavior before PR: -Resized column widths were lost when moving the top row down or the second row up. -This happened because the new widths after resizing were only applied to the `<td>` elements of the first `<tr>.` Desired behavior after PR is merged: -When moving the top row down or second row up, column widths are copied from the first row to the second row. -Tables don't lose resizing after moving the first row up or down. task-4019025 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#171695
Was always failing because of an invalid signature Forward-Port-Of: odoo/odoo#174217
Original PR description
Was always failing because of an invalid signature Forward-Port-Of: odoo/odoo#174217
Currently when importing an order from sale to pos, if the price was set manually, changing the partner associated with the order will set back the price to the original product sale price. Steps to reproduce: ------------------- * Make a new quotation in **sales** * Change the unit price of a product * Confirm quotation * Open the pos shop session * Import the newly created quotation to be settled * Change the partner > Observation: The price set manually changes to the product sale
Original PR description
Currently when importing an order from sale to pos, if the price was set manually, changing the partner associated with the order will set back the price to the original product sale price. Steps to…
Currently when importing an order from sale to pos, if the price was set manually, changing the partner associated with the order will set back the price to the original product sale price. Steps to reproduce: ------------------- * Make a new quotation in **sales** * Change the unit price of a product * Confirm quotation * Open the pos shop session * Import the newly created quotation to be settled * Change the partner > Observation: The price set manually changes to the product sale price Why the fix: ------------ When changing the partner of a sale order we compute all the line that have to recompute their prices: https://github.com/odoo/odoo/blob/57f1b0bd502938a6d50244896e71df73705584b5/addons/point_of_sale/static/src/js/models.js#L2918-L2920 We see that when we settle an order, `price_manually_set` is set to false. In this example, if we set it to true it would solve the issue but we cannot use it, see with https://github.com/odoo/odoo/commit/70668ee3c3e2c1dd213903b44f4d36cc8ac9fa29 . Instead what we can do is to use `price_automatically_set` and set it to true. This does not undo the previously mentionned commit and fixes this current issue. This variable was created in https://github.com/odoo/odoo/commit/067299539116b55a449f022706c395dda2177829 opw-4001497 Forward-Port-Of: odoo/odoo#172205
Steps to reproduce: - Edit any product's 'Description for delivery orders' (inventory tab) - Create a delivery for this product (or confirm sale order to create one automatically) - Print delivery slip (Correct formatting) - Validate delivery - Print delivery slip once more (Description loses linebreaks) This is only for looks, but it's a document the end user will see so there are concerns about it looking unprofessional. This formatting error is due to us not being able to use a fie
Original PR description
Steps to reproduce: - Edit any product's 'Description for delivery orders' (inventory tab) - Create a delivery for this product (or confirm sale order to create one automatically) - Print delivery slip (Correct formatting) - Validate delivery - Print delivery slip once more (Description loses linebreaks) This is only for looks, but it's a document the end user will see so there are concerns about it looking unprofessional. This formatting error is due to us not being able to use a field element after remaking the order lines to group related products in python. opw-4040127 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#174495
This is a complement to previous fix https://github.com/odoo/odoo/commit/649a7f185dca806af3b3d54a1e4390b9baff79c6 in which the use case where both companies have "Round Globally" set as "Rounding Method" was not handled. **Steps to reproduce:** - Install Sales & Accounting - Create a second company with a different currency (e.g. AED) than the first one (e.g. USD) - Configure the rounding factor of the currency of the second company to 1.000000 - Configure the default company of the curre
Original PR description
This is a complement to previous fix https://github.com/odoo/odoo/commit/649a7f185dca806af3b3d54a1e4390b9baff79c6 in which the use case where both companies have "Round Globally" set as "Rounding…
This is a complement to previous fix https://github.com/odoo/odoo/commit/649a7f185dca806af3b3d54a1e4390b9baff79c6 in which the use case where both companies have "Round Globally" set as "Rounding Method" was not handled. **Steps to reproduce:** - Install Sales & Accounting - Create a second company with a different currency (e.g. AED) than the first one (e.g. USD) - Configure the rounding factor of the currency of the second company to 1.000000 - Configure the default company of the current user to the second company - Switch to the second company - In Accounting settings, set "Rounding Method" to "Round Globally" - Switch to the first company - In Accounting settings, set "Rounding Method" to "Round Globally" - Create a SO: * Customer: [any] * Order Lines: [any line with a tax] - Save the SO - Edit the SO by changing the price unit of the product !!! Make sure that the tax amount has a decimal part - Save the SO **Issue:** In the chatter, the note about the new value of the tracked field Total is different from the Total value shown in the SO. Also, in Customer Preview, the total to pay shown on the upper-left of the page is different than the total shown in the SO details. opw-3814058 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr Forward-Port-Of: odoo/odoo#174560
`stdnum` library incorrectly sets `zeep` `Transport` timeout, resulting in some requests hanging for 15 minutes. With this monkeypatch the timeout will be set correctly. The monkeypatch is a full copy of the original code except for adding `operational_timeout` to the `Transport` initialization. The monkeypatch can be removed when https://github.com/arthurdejong/python-stdnum/issues/444 is resolved and the version is upgraded. Related zeep github issue: https://github.com/mvantellingen/
Original PR description
`stdnum` library incorrectly sets `zeep` `Transport` timeout, resulting in some requests hanging for 15 minutes. With this monkeypatch the timeout will be set correctly. The monkeypatch is a full…
`stdnum` library incorrectly sets `zeep` `Transport` timeout, resulting in some requests hanging for 15 minutes. With this monkeypatch the timeout will be set correctly. The monkeypatch is a full copy of the original code except for adding `operational_timeout` to the `Transport` initialization. The monkeypatch can be removed when https://github.com/arthurdejong/python-stdnum/issues/444 is resolved and the version is upgraded. Related zeep github issue: https://github.com/mvantellingen/python-zeep/issues/140 This fix was already merged but reverted due to an unexpected side-effect: Original commit: https://github.com/odoo-dev/odoo/commit/11062f6f77ed1292c6db9d64985dddeb46d354c8 Revert: https://github.com/odoo-dev/odoo/commit/de9df2ba5c15d399d6906ef54f3e4ac9f063a175 The issue originated from a dependency issue in the `zeep` library in [Ubuntu 22.04](https://packages.ubuntu.com/jammy/python3-zeep). The `python3-platformdirs` dependency is missing in there, yet it is used in that version of `zeep`. This missing dependency used to be hidden by the [chains of `try ... except ImporError` of `stdnum`](https://github.com/arthurdejong/python-stdnum/blob/d5666b8bfe379688a38bb0fd6764a8c536dd3c75/stdnum/util.py#L254). That means that it's another import from the chain that was used. So to reduce the possibility of introducing a similar bug and catch such errors, the original code from `get_soap_client` of `stdnum` has been fully copied. opw-3980718 Forward-Port-Of: odoo/odoo#174199 Forward-Port-Of: odoo/odoo#173359
Description of the issue/feature this PR addresses: - Updated the condition of groups for shipping_field as suggested in the previous PR https://github.com/odoo/odoo/pull/173162#discussion_r1686292899 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr opw - [4044861](https://www.odoo.com/odoo/project.task/4044861?cids=2) Forward-Port-Of: odoo/odoo#174031
Original PR description
Description of the issue/feature this PR addresses: - Updated the condition of groups for shipping_field as suggested in the previous PR https://github.com/odoo/odoo/pull/173162#discussion_r1686292899 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr opw - [4044861](https://www.odoo.com/odoo/project.task/4044861?cids=2) Forward-Port-Of: odoo/odoo#174031