Thursday, August 1, 2024
5 changes · saas-17.4
Resolved issues and error corrections
This update fixes a failing automated sales workflow test related to product attribute values. It helps keep the sales module validation stable so future updates can be checked reliably before release.
Original PR description
See runbot build error 66468
Shipping volume now accounts for the actual product volume instead of only counting quantities. This makes shipping-related volume information more accurate for warehouse and delivery planning.
Original PR description
Not really the shipping volume if we only count the quantity without the volume. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a problem in guided tours where skipped steps could still try to show a pointer on an invalid target, causing an error. Guided flows should now continue more reliably when a step is inactive or bypassed.
Original PR description
Since https://github.com/odoo/odoo/pull/168829, when a step is not active, the search of the trigger (anchor) is bypassed and "true" is returned for stepEl. So, if the showPointerDuration parameter is greater than 0, the element taken into account for the pointer is true while it should be an element. This is where there is an error. Then, in the case where the step is bypassed (!isActive), then we skip the whole action.
This fixes an issue in website/app guided tours where the on-screen pointer could be shown even when there was no valid item to point to. The change prevents confusing or broken tour behavior, making guided walkthroughs more reliable for users.
Original PR description
When a step is not active, we return true to bypass the trigger search. As a result, it is then true (instead of the element) that is passed to pointer.pointTo() which triggers the bug. In order to overcome this problem, we avoid going into this part of the code in the case where stepEl is true. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The Australian payroll termination payslip test is now fixed to use a consistent employee age. This prevents date-related test failures caused by different tax withholding rates after age 60, helping keep payroll validation reliable.
Original PR description
Termination test failed because the employee's age was over 60 now, which gets a lower withholding rate. This commit sets a freezetime so a fixed age is used.