Wednesday, August 7, 2024
8 changes · 17.0
Resolved issues and error corrections
Channel member lists now place people in the Offline category only when they are truly offline. Users who are away, bots, or marked as on leave remain grouped as online, making team availability in discussions clearer and more accurate.
Original PR description
**Current behavior before PR:** If a partner has `im_status` set to `away/bot` or is on leave, causing their `im_status` to be suffixed with `leave_`, they were placed into the `Offline` category. While except if they are `offline` they should have been placed in `Online` category. **Desired behavior after PR is merged:** If a member has `offline/im_partner` status, only then they are placed into `Offline` category. **Task**-[4101827](https://www.odoo.com/odoo/project.task/4101827) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix prevents the scroll-down button in the Website Text Cover block from stretching to fill the full height when the block is set to 100% height. It keeps the page design looking correct and avoids a visible layout issue for website visitors and editors.
Original PR description
Since version 17.0, there is an issue with the Text Cover snippet where the scroll button becomes deformed and takes up the entire height of the snippet when the scroll down button is toggled and the snippet is set to 100% height. The problem occurs because the `.s_text_cover` CSS rule `.s_text_cover > *` applies `min-height: inherit;` to all direct children, including the scroll button. To resolve this, the CSS rule has been updated to exclude the scroll button from inheriting the minimum height by adding a `:not(.o_scroll_button)` selector. task-4091232
The project profitability panel now uses clearer internal names for the “Other Costs” and “Other Revenues” sections, preventing them from clashing with other panel sections. This helps ensure profitability information displays reliably without changing the business workflow.
Original PR description
This commit's purpose is to rename the other costs & other revenues section to avoid id conflict with other section of the project profitability panel. Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update makes an automated test for module imports less sensitive to the order of log messages, reducing false failures in validation runs. If the test does fail, the relevant logs are now easier to see, helping teams diagnose issues faster without affecting end users.
Original PR description
In some cases, this test can fail if the logs are not exactly in the expected order. See some examples here: https://runbot.odoo.com/runbot/build/66341605 https://runbot.odoo.com/runbot/build/66320898 https://runbot.odoo.com/runbot/build/66320884 After this commit, the order of the logs does not matter for the test. Also, in case the test does fail, the logs are visible in the traceback (instead of being suppressed by the log catcher) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
A failing automated test was relocated to the Website module because it depends on Website-specific functionality. This helps keep test results reliable and prevents unrelated modules from failing due to missing dependencies.
Original PR description
[Test](https://runbot.odoo.com/runbot/build/66575239) was failing as website module is not dependency for test_assetsbundle, but we were trying to call website model. As a solution, test was moved from test_assetsbundle to website. The test was always failing, but we didn't catch it before as we were not testing said module. --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Portal users who only have access to a shared task can now open that task's attached documents from the Tasks page. Previously, the document button sent them to the project documents page, which they could not access, causing an unexpected redirect back to the portal home page.
Original PR description
Steps to reproduce: - Create a project and a task - Attach a file to the task - Share the task with Joel Willis (portal user) - DO NOT share the project with him - Log in as Joel Willis (portal user) - Click Tasks > '1 Document' button next to project name This is necessary for the xpath in 852cb8eab813da9d8f3beee4bcfdf953d20a89b4 to function. This redirects back to portal home menu. This happens because the button leads to projects/id/documents, which Joel Willis has not been granted access to. The expectation would be a redirection to tasks/id/documents instead, as portal > projects handles this use case, and we curently do not have a way to share documents attached to a specific task through portal. opw-4009258 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix ensures that a disconnected electronic scale is shown as disconnected in Odoo's IoT device status. This helps POS users avoid relying on stale device information when a scale is no longer available.
Original PR description
**Before commit** - When the electronic scale is disconnected, its connection status is not updated. **After commit** - When the electronic scale is disconnected, the status of the electronic scale…
**Before commit** - When the electronic scale is disconnected, its connection status is not updated. **After commit** - When the electronic scale is disconnected, the status of the electronic scale will be updated. **Error Description** - If you have a digital scale that is connected and selected for use in POS. - The status of IoT devices is updated via the router `/hw_proxy/status_json` and the function `get_status()` - However, the status of the digital scale is not updated when it is disconnected. This leads to the scale still reporting that it is connected when calling the `get_status()` function. The scale status is updated via `self._status` https://github.com/odoo/odoo/blob/8ff2381901e4920434eaee73f8c265fc67271c99/addons/hw_drivers/iot_handlers/drivers/SerialScaleDriver.py#L110-L114 However `self._status` is not updated when disconnected. https://github.com/odoo/odoo/blob/8ff2381901e4920434eaee73f8c265fc67271c99/addons/hw_drivers/iot_handlers/drivers/SerialBaseDriver.py#L129-L144 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fix corrects a bug in the payroll test system where incorrect payslip data was being generated for Belgium payroll structures. The test utility was mistakenly using the wrong structure type parameter, causing tests to fail with incorrect data. This fix ensures payroll tests run correctly across different regional configurations.
Original PR description
The default _generate_payslip method is using structure type instead of structure. Therefore it generates wrong payslip under BE structure.