Odoo Changelog — 2024-08-08

Thursday, August 8, 2024

1 change · 17.0

Bug Fixes(1)

Resolved issues and error corrections

[FIX] l10n_fr_reports/17.0.1.0: Add sequence in report lines

Enterprise17.0l10n_fr_reportsHigh impact

This fix resolves a critical error that occurred when viewing the French "Intermediate Management Balances" financial report after upgrading from version 16 to version 17. The report was failing to display due to incorrect ordering of report line items. By adding proper sequencing to the report lines, the fix ensures that parent report sections are loaded before their child sections, allowing the report to display correctly on migrated databases.

Original PR description

**Description**

A [recent](https://github.com/odoo/enterprise/commit/76d9188767e26c4ae1f815334af5ca3ac6c5fcdf) change in the l10n_fr_reports **IMB - Intermediate management balances** created a new child and parent hierarchy between report lines that never existed before. This causes a traceback when opening the report on migrated databases. 
The report lines must be loaded in an order where parent lines come before their children. The sorting of `account.report.line` model is by `sequence, id`, where `sequence` column (if unchanged) remains null, causing lines to be sorted by `id`. The change caused larger id records to be assigned as the parent of smaller id records, violating the required hierarchy and raising a traceback.


**Traceback :** 

  ```py
  File "/home/odoo/src/enterprise/17.0/account_reports/models/account_report.py", line 4386, in get_report_information
    'lines': self._get_lines(options, all_column_groups_expression_totals=all_column_groups_expression_totals, warnings=warnings),
  File "/home/odoo/src/enterprise/17.0/account_reports/models/account_report.py", line 2123, in _get_lines
    parent_generic_id = line_cache[line.parent_id]['id'] if line.parent_id else None # The parent line has necessarily been treated in a previous iteration
KeyError: account.report.line(338,)
```


**steps to reproduce**
1. install 'l10n_fr' and 'account_accountant' in a demo database of version 16
2. migrate it to version 17.
3. go to Reporting->Profit and Loss (Fr company should be selected)
4. Change Report to "IMB - Intermediate management balances"

Note:  This PR is created by this [suggestion](https://github.com/odoo/upgrade/pull/6267#issuecomment-2244373973).

#French localization#financial reporting#migration#bug fix

**Description** A [recent](https://github.com/odoo/enterprise/commit/76d9188767e26c4ae1f815334af5ca3ac6c5fcdf) change in the l10n_fr_reports **IMB - Intermediate management balances** created a new child and parent hierarchy between report lines that never existed before. This causes a traceback when opening the report on migrated databases. The report lines must be loaded in an order where parent lines come before their children. The sorting of `account.report.line` model is by `sequence, id`, where `sequence` column (if unchanged) remains null, causing lines to be sorted by `id`. The change caused larger id records to be assigned as the parent of smaller id records, violating the required hierarchy and raising a traceback. **Traceback :** ```py File "/home/odoo/src/enterprise/17.0/account_reports/models/account_report.py", line 4386, in get_report_information 'lines': self._get_lines(options, all_column_groups_expression_totals=all_column_groups_expression_totals, warnings=warnings), File "/home/odoo/src/enterprise/17.0/account_reports/models/account_report.py", line 2123, in _get_lines parent_generic_id = line_cache[line.parent_id]['id'] if line.parent_id else None # The parent line has necessarily been treated in a previous iteration KeyError: account.report.line(338,) ``` **steps to reproduce** 1. install 'l10n_fr' and 'account_accountant' in a demo database of version 16 2. migrate it to version 17. 3. go to Reporting->Profit and Loss (Fr company should be selected) 4. Change Report to "IMB - Intermediate management balances" Note: This PR is created by this [suggestion](https://github.com/odoo/upgrade/pull/6267#issuecomment-2244373973).