Friday, August 9, 2024
4 changes · saas-17.4
Resolved issues and error corrections
Selecting an emoji in a new chat now properly marks the sender as active, so sending an emoji-only message adds them to the conversation. This prevents missed membership updates and makes chat behavior more reliable for users.
Original PR description
Purpose of the commit: Previously, when a new channel was created, sending an emoji as a message did not add the sender as a member. This was because selecting an emoji did not trigger the `notifyIsTyping`. To address this issue, `notifyIsTyping` is now triggered when an emoji is selected in the composer. task-4100450
This update prevents an error when users delete several PDF attachments linked to German invoices at the same time. It keeps attachment cleanup working reliably for German accounting records without changing normal invoicing behavior.
Original PR description
To reproduce (on runbot w/ demo datas) - Install l10n_de - Switch to "DE Company" - Create an invoice and add 2 or more PDF documents - Switch to debug mode - Go to menu: Settings / Technical /…
To reproduce (on runbot w/ demo datas)
- Install l10n_de
- Switch to "DE Company"
- Create an invoice and add 2 or more PDF documents
- Switch to debug mode
- Go to menu: Settings / Technical / Database Structure / Attachments
- Search for the added documents, select them all and try to delete them
=> This raise the following error:
```
Traceback (most recent call last):
File "/data/build/odoo/odoo/models.py", line 5961, in ensure_one
_id, = self._ids
^^^^
ValueError: too many values to unpack (expected 1)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
..
File "/data/build/odoo/odoo/addons/base/models/ir_attachment.py", line 610, in unlink
res = super(IrAttachment, self).unlink()
File "/data/build/odoo/odoo/models.py", line 4326, in unlink
func(self)
File "/data/build/odoo/addons/l10n_de/models/ir_attachment.py", line 25, in _except_audit_trail
if move and move.posted_before and move.country_code == 'DE':
^^^^^^^^^^^^^^^^^^
File "/data/build/odoo/odoo/fields.py", line 1204, in __get__
record.ensure_one()
File "/data/build/odoo/odoo/models.py", line 5964, in ensure_one
raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: account.move(347, 347)
```
---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-prThe Discuss sidebar now keeps the "Direct Messages" title steady when users expand or collapse the section. This removes a small visual distraction and makes navigation feel smoother.
Original PR description
**Current behavior before PR:** The title "Direct Messages" in the discuss sidebar used to flicker (move up and down) when expanding or folding the section. **Desired behavior after PR is merged:** The flickering issue is fixed, so now the title "Direct Messages" remains in place when the section is expanded or folded. **task**:4100682 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This update stabilizes automated checks for the Attendance Gantt view by preventing unrelated messaging timers from affecting test results. It helps reduce false test failures and improves confidence in future attendance planning changes, without changing user-facing functionality.
Original PR description
In AttendanceGanttModel, open ended records have their dateStopField set to the current moment. So, depending on the way time passes, the gantt pills can have different ending columns. In the…
In AttendanceGanttModel, open ended records have their dateStopField set to the current moment. So, depending on the way time passes, the gantt pills can have different ending columns. In the hr_attendance_gantt tests, we use the hoot helper runAllTimers that accelerates time based on the registered timeouts. Since https://github.com/odoo/odoo/pull/175422, the service imStatusService registers timeouts with delay of 30 minutes. So runAllTimers often needs to advance time by steps of 30 minutes, sometimes more nondeterministically. This means that sometimes time has to advance more than 1 hours and this make some assertions on the pill ending columns fail. Here similarly to what is done in https://github.com/odoo/enterprise/pull/67088, we remove some services/main components only used by mail, so that imStatusService is no longer there and does no longer interfer with ours tests. We also take the oportunity to replace some calls to selectGanttRange by some clicks on the previous/next buttons. In that way, the intention behind the tests is clearer and time has to advance a bit less. This also corrects the wrong fix https://github.com/odoo/enterprise/pull/68033. Build 66645450