Wednesday, August 14, 2024
2 changes · master
Resolved issues and error corrections
This fix prevents users from changing the refund status of a salary attachment once it has already been used in payslips. This helps protect payroll accuracy by avoiding inconsistent records after payroll processing has begun.
Original PR description
TaskID: 4040011
Scanning a barcode found in the lookup service no longer fails when the product has no image available. The product can still be created or updated from the barcode data, with the missing image simply skipped.
Original PR description
Issue: Traceback is encountered when scanning a barcode that is available in the barcodelookup api but doesn't have image. Example barcode: 9780349410159 - Traceback: `AttributeError: 'dict' obiect has no attribute 'content'` This is because of the inconsistent return value of `barcode_lookup_request`. If it succeeds, it returns a `Response` object but if not, it returns a `dict`. To fix the traceback, we check if the fetching of image failed by checking if the returned value is a `dict`. If so, we just skip the image assignment for the product.