Monday, August 19, 2024
3 changes · saas-17.4
Resolved issues and error corrections
Chat bubbles were adjusted to use valid page structure and display more clearly in dark mode. This helps users better recognize chat channels, especially when icons have transparent areas.
Original PR description
Before this PR, chat bubbles were using button elements inside another button element. It's not valid HTML and can be replaced by a simple div. This PR also adds a dark mode-friendly background to the bubble. This makes the bubble more visible when an image with transparency is used as a channel icon. Before:  After: 
This fix prevents an unexpected system error when users create or register payments before configuring outstanding accounts. Users will now avoid a technical crash and continue to receive the intended business validation message if setup is incomplete.
Original PR description
Since aa07813918480b0b6beae74ccdbe3656ef6a3a56, we make a query to display a warning if duplicated payments already exist, but if user did not set any outstanding account, we get a SyntaxError from psycopg2. With this commit, we avoid checking `outstanding_account_ids` in the query, this is not an issue since at the end, we raise an UserError when validating the payment if no outstanding account is set. Steps: - Make sure there is no outstanding accounts set on the company nor on the bank journal's payment method lines - Either register a payment from invoice view or create a customer payment -> Error: `psycopg2.errors.SyntaxError: syntax error at or near ")"` opw-4099204
This fix ensures uploaded website background images display correctly even when their file URLs include spaces. It prevents broken blog or website visuals after users add images through the editor.
Original PR description
Before this commit the img url in the css background-image property was not quoted, this led to background not being displayed when URL contained spaces (char "%20"). [Reproduce] - Open blog, upload new background image via Editor - BUG: image not displayed opw-4089093