Odoo Changelog — 2024-08-21

Wednesday, August 21, 2024

3 changes · saas-17.2

Bug Fixes(3)

Resolved issues and error corrections

[FIX] stock: don’t show lot_name when use & create lot is True

Coresaas-17.2stock

This fixes a stock delivery form issue where an unnecessary serial/lot creation field appeared when both selecting existing lots and creating new lots were enabled. Users now see the appropriate field when choosing serial numbers, reducing confusion during delivery processing.

Original PR description

Steps to reproduce the bug:
- Go to the delivery operation type:
    - set to True "use_existing_lots" and "use_create_lots"
- Create a storable product “P1” tracked by SN
- Create a delivery with one unit of P1
- Confirm it
- Click on the detailed operation to select the serial number

Problem:
The 'Lot_name' field is displayed, but since the operation type
has both `use_existing_lots` and `use_create_lots` set to True,
the 'Lot_name' field should not be displayed.

https://github.com/odoo/odoo/blob/4da8c6ebca024b31278a946aef55cc37f0210b33/addons/stock/models/stock_move.py#L606-L610

https://github.com/odoo/odoo/blob/4da8c6ebca024b31278a946aef55cc37f0210b33/addons/stock/views/stock_move_views.xml#L294-L297
|
|
|
|
|
FYI: https://github.com/odoo/odoo/commit/b771eadf8f6a70cbbb01481f362c89b41796d671#diff-55c6314416a6a400da6acd5018d161a55eeeb0e3008fec8828121e3dd12be0ebL550

opw-[4113887](https://www.odoo.com/web#id=4113887&view_type=form&model=project.task)

#inventory#deliveries#serial numbers#lots

[FIX] sale: factor in pos down payments when settling in sale

PR #176553

Coresaas-17.2pos_salesaleMEDIUM

Sales orders with down payments taken through Point of Sale can now be invoiced without errors. This ensures draft invoices are created correctly when settling quotations that include POS down payments.

Original PR description

Steps to reproduce:
- Sale > Quotations > New
- Set customer and product
- POS > Quotation/Order > Apply down payment > Pay
- Sale > Quotation > Create invoice > Create draft

Error because the down payment line is missing an account_id, as a result of this commit 50ce3ce1d98958241667d1122273abccd59874b7 we would pass account_id = False in vals_list sometimes, causing the account_id not to be filled in or inferred later.

opw-4064906

---
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

#point-of-sale#down-payments#invoicing

[FIX] mail: disable screen-sharing in mobile OS

PR #177371

Coresaas-17.2mail

The screen-sharing button is now hidden during mail calls on mobile devices because current mobile browsers do not support this feature. This avoids misleading users into trying to enable permissions for something that cannot work on their device.

Original PR description

This feature is not available in mobile OS at the time of this commit [1]:

- Safari on iOS 17.5
- Chrome for Android 127
- Firefox for Android 127

Therefore the button should not be shown, otherwise it mistakenly gives the impression that user could make it work by enabling screen-sharing permission which is not possible on mobile OS.

opw-4108833

[1]: https://caniuse.com/mdn-api_mediadevices_getdisplaymedia

<img width="333" alt="Screenshot 2024-08-21 at 13 26 13" src="https://github.com/user-attachments/assets/ead3281d-2ef4-412e-8d4f-edab4a85b1e9">

#mobile#screen sharing#calls

Steps to reproduce the bug: - Go to the delivery operation type: - set to True "use_existing_lots" and "use_create_lots" - Create a storable product “P1” tracked by SN - Create a delivery with one unit of P1 - Confirm it - Click on the detailed operation to select the serial number Problem: The 'Lot_name' field is displayed, but since the operation type has both `use_existing_lots` and `use_create_lots` set to True, the 'Lot_name' field should not be displayed. https://github.com/odoo/odoo/blob/4da8c6ebca024b31278a946aef55cc37f0210b33/addons/stock/models/stock_move.py#L606-L610 https://github.com/odoo/odoo/blob/4da8c6ebca024b31278a946aef55cc37f0210b33/addons/stock/views/stock_move_views.xml#L294-L297 | | | | | FYI: https://github.com/odoo/odoo/commit/b771eadf8f6a70cbbb01481f362c89b41796d671#diff-55c6314416a6a400da6acd5018d161a55eeeb0e3008fec8828121e3dd12be0ebL550 opw-[4113887](https://www.odoo.com/web#id=4113887&view_type=form&model=project.task)

Steps to reproduce: - Sale > Quotations > New - Set customer and product - POS > Quotation/Order > Apply down payment > Pay - Sale > Quotation > Create invoice > Create draft Error because the down payment line is missing an account_id, as a result of this commit 50ce3ce1d98958241667d1122273abccd59874b7 we would pass account_id = False in vals_list sometimes, causing the account_id not to be filled in or inferred later. opw-4064906 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

This feature is not available in mobile OS at the time of this commit [1]: - Safari on iOS 17.5 - Chrome for Android 127 - Firefox for Android 127 Therefore the button should not be shown, otherwise it mistakenly gives the impression that user could make it work by enabling screen-sharing permission which is not possible on mobile OS. opw-4108833 [1]: https://caniuse.com/mdn-api_mediadevices_getdisplaymedia <img width="333" alt="Screenshot 2024-08-21 at 13 26 13" src="https://github.com/user-attachments/assets/ead3281d-2ef4-412e-8d4f-edab4a85b1e9">