Thursday, August 22, 2024
10 changes · 17.0
Resolved issues and error corrections
Spreadsheet charts now use the updated Chart.js setting for legend label colors. This keeps chart legends displaying with the intended colors after the Chart.js upgrade, improving visual consistency for users.
Original PR description
# Description With the upgrade to Chart.js version 4.3, the configuration for setting legend label colors has changed. The `fontColor` key is now deprecated, and the `color` key must be used instead. This update was previously overlooked in the Odoo chart plugin. This commit resolves the issue by updating the Odoo chart plugin to correctly use the color key for setting legend label colors. Task: [4111089](https://www.odoo.com/odoo/project/2328/tasks/4111089) --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This change makes an internal automated test for real-time notifications less likely to fail during busy server periods. It helps keep the testing pipeline stable without changing customer-facing behavior.
Original PR description
Before this PR, the `receive notifications from a channel` test was sometimes failing. This test waits for the channel to be registered before sending the notification. This flow has many async points: - bus service to worker to start it - bus service to worker to initialize it - worker to bus service to acknowledge the initialization - bus service to worker to add the channel The `waitUntilSubscribe` helper waits up to 500ms, but when runbot is heavily used, it can take a bit longer. This PR increases the delay to ensure the flow can complete within the given time. runbot-75076
Project task status labels now use the translations configured in the database instead of always showing the default text from translation files. This ensures teams working in multiple languages see their customized task state names consistently in the task form.
Original PR description
Versions -------- - 17.0+ Steps ----- 1. Activate a second language on the database; 2. enable debug mode; 3. go to Settings / Technical / Database Structure / Fields; 4. look for the `state` field of the `project.task` model; 5. change the name's translation of the of the `01_in_progress` value; 6. go to a task to select the state. Issue ----- It still shows the original translation. Cause ----- The JS side fetches the translations straight from the .po file instead of looking for translations stored in the database. Solution -------- The translations of the labels are already stored in `this.props.record.fields[this.props.name].selection`, as used in `super`'s `options` getter. Retrieving these, custom translations do take effect. opw-4009326
The donation payment page now handles cases where no preset donation amounts are configured. This prevents an error when a donor clicks the custom amount field, keeping the donation flow usable.
Original PR description
In the `/donation/pay` route, a TypeError occurs when trying to edit the custom amount if no predefined amounts are set. This happens because the script attempts to set the 'value' property of a null element. Issue introduced in commit: d7e49acf0df0f8043ade969ffea6decfe111690f Steps to Reproduce: 1. Go to `/donation/pay` without any predefined amounts. 2. Click on the custom amount field. This commit fixes the issue by ensuring the element exists before attempting to set its value. task-4103208
Inventory move records now refresh their reference when the related operation type changes. This prevents outdated references from appearing in move history, making stock traceability and searches more reliable.
Original PR description
### Steps to reproduce: - Install Inventory module - Create a move from any operation - Save this move and keep the reference > Change the operation type and save again - Navigate to Moves History - Search for the move with the old reference ### Current behavior before PR: The move will be shown in the moves history with the old reference. This is happening because when changing the opertaion type it doesn't trigger the compute of the reference. https://github.com/odoo/odoo/blob/17.0/addons/stock/models/stock_move.py#L265 ### Desired behavior after PR is merged: We added the picking_id.name as a dependant field for the reference so when it is changed the computation method of the reference will be triggered to update the reference. opw-4062591
The settings dropdown now adjusts its width on smaller screens so it no longer gets cut off. Longer menu item labels are shortened visually, making the menu easier to use on mobile devices.
Original PR description
Before this commit, the cog dropdown was getting clipped on mobile for longer widths Steps to reproduce: - Project> Open any project > Open any task. - Click on the cog button - Minimize the window or switch to mobile view After this commit, the width of the dropdown adjusts accordingly to prevent clipping. And the text of dropdown items is truncated. Task: 3763899
Invoice PDFs now consistently use the paper format of the company that issued the invoice. This prevents invoices from being generated with different layouts depending on whether they are created immediately or through scheduled processing.
Original PR description
This commit ensures that creating an invoice PDF always uses the invoice company paperformat. Invoice PDF could be generated in one of 2 ways (after clicking the invoice `send & print` button): 1. Non-cron: Either use a single invoice, or multiple invoices with the `download` option checked. 2. Cron: Create PDFs for multiple invoices with no `download` option. The 2 ways would generate differently styled PDFs if the default company had a different paperformat from that of the invoice company. This happened because the paperformat for cron-generated PDFs would be retrieved from the default company and not from the invoice company. task-4046055 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
This fixes a naming mistake in the expense module so migrated tax amounts continue to use the correct currency-based field. It helps prevent confusion or incorrect behavior around expense tax values after the earlier technical change.
Original PR description
The technical refactor in [1] renamed the tax amount in currency from `amount_tax` to `tax_amount_currency`. However, in some instances, it was mistakenly renamed to `tax_amount`, including in the commit description. This commit corrects this minor oversight. [1]: https://github.com/odoo/odoo/commit/68fbdc96 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
The mail call interface no longer shows the screen-sharing button on mobile operating systems where screen sharing is not supported. This prevents users from seeing an option that cannot work on their device and reduces confusion during calls.
Original PR description
This feature is not available in mobile OS at the time of this commit [1]: - Safari on iOS 17.5 - Chrome for Android 127 - Firefox for Android 127 Therefore the button should not be shown, otherwise it mistakenly gives the impression that user could make it work by enabling screen-sharing permission which is not possible on mobile OS. opw-4108833 [1]: https://caniuse.com/mdn-api_mediadevices_getdisplaymedia <img width="333" alt="Screenshot 2024-08-21 at 13 26 13" src="https://github.com/user-attachments/assets/ead3281d-2ef4-412e-8d4f-edab4a85b1e9">
This fixes a printing issue where edited document columns could appear off-center or stack awkwardly on paper. The editor’s layout spacing adjustments now apply only on screen, so printed documents use cleaner print-friendly alignment.
Original PR description
Currently, the editor uses the bootstrap grid system for the column layouts and the editor CSS rules changes the paddings and the margins of the columns. When the user prints a document, the columns can go one under the other but the paddings and margins set are still applied. As a result, the columns appear off-centered on printing devices. To fix that issue, we will scope the CSS rules that adjust the paddings and margins of the columns to the screen devices. This way, the rules won't be applied when printing the document. task-3664950 --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr