Daily updates from Odoo
Friday, August 23, 2024
6 changes
1 change
Resolved issues and error corrections
The task portal now avoids sending users to empty timesheet pages when they do not have permission to view any related timesheets. It also checks timesheets across all levels of subtasks, making the link behavior clearer and reducing confusion for limited-access users.
Original PR description
Currently, when a user has a limited access to timesheets, it is possible that he has access to a task, but that he has no access to the timesheets of its children task. This make a strange use case where the user clicks on the link to be redirected to a page without any timesheet. This fix aims to change that. Solution : change the link to the timesheets into a span if none of the timesheets are accessible by the current user. task - 3978484 version saas-17.2 Description of the issue/feature this PR addresses: Current behavior before PR: Desired behavior after PR is merged: --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
4 changes
Resolved issues and error corrections
Accounting report titles now match their updated menu names, avoiding confusion for users navigating reports. PDF exports also include proper side margins so report content no longer runs to the edge of the page.
Original PR description
In this commit: https://githu.com/odoo/enterprise/pull/67611/commits/982eaa3867576f581e5f12fa649a281d9407278b We renamed some reports menu item but we didn't change the name on top of the ui of the reports so there was a discordance. Before this commit the side of the pdf were extended to the side of the page. To resolve that issue adding a margin on the content of the pdf is enough. task: 4127269
The field service worksheet setup test now waits until the template window has fully closed before continuing. This reduces false failures in automated checks and helps keep the feature validation more reliable.
Original PR description
Before this commit, when the step on the `fsm_task_form_tour` tour saves the worksheet template creation, the save action will take some times to be able to generate a new worksheet model for that worksheet template. The problem is the tour does not wait enough time before doing the next steps. This commit adds a step to wait the form view dialog of the worksheet template is closed before doing the other steps. runbot-72641
The restaurant appointment screen now shows the correct booking icon again. This fixes a visual mistake from a previous change, helping staff recognize booking actions more easily.
Original PR description
In commit ed556a111ead0c9a1fe517173cc97c495d0d6ac7 the booking icon was replaced by mistaked. In this commit we revert to the original one.
This fixes an automated test that could fail because it clicked a pager button before it was ready. The change makes the test wait until the button is enabled, improving test reliability without changing user-facing behavior.
Original PR description
The tour changes the number of elements in the pager. We then check that the number of elements do change in the list. But the button stay disabled longer, which implies that we try to click on it too soon in the tour, failing it. We should wait for the button to be enabled before clicking on it. runbot-74835
1 change
Resolved issues and error corrections
This fix resolves a test failure in the partner commission module where salespeople lacked the necessary permissions to view sale order templates. The change ensures that the sale order template field is properly visible during testing, allowing the commission plan rules test to run successfully without demo data.
Original PR description
Before this commit, the salesmen did not had the right group and the test crashed with the following error when the test was run without demo data:
```
FAIL: TestCommissions.test_commission_plan_rules_with_template
Traceback (most recent call last):
File "/data/build/enterprise/partner_commission/tests/test_commissions.py", line 221, in test_commission_plan_rules_with_template
form.sale_order_template_id = so_template
File "/data/build/odoo/odoo/tests/form.py", line 326, in __setattr__
self[field_name] = value
File "/data/build/odoo/odoo/tests/form.py", line 331, in __setitem__
assert field_info is not None, f"{field_name!r} was not found in the view"
AssertionError: 'sale_order_template_id' was not found in the view
```
runbot task: 70916 and 73195
https://runbot.odoo.com/web/#id=70916&view_type=form&model=runbot.build.error&menu_id=405&cids=1 https://runbot.odoo.com/web/#id=73195&view_type=form&model=runbot.build.error&menu_id=405&cids=1