Odoo Changelog — 2024-08-25

Sunday, August 25, 2024

3 changes · saas-17.2

Other(3)

Miscellaneous changes

[FW][FIX] mrp_subcontracting_account_enterprise: correctly calculate report

Enterprisesaas-17.2

Original PR description

Steps to reproduce the bug:

- Create a storable product P1 with the following BoM:
    - Type: Subcontracting
    - Subcontractor: Azure Interior
    - Components:
        - C1: 1 unit (price of C1: $10)
    - Cost of P1: $10

- Create a purchase order:
    - Product: P1
    - Quantity: 100 units

- Confirm the purchase order.

-  Receive 99 units and create a backorder for 1 unit.

- Go to Manufacturing > Reporting > Production Analysis.

Problem:

The "Total Subcontracting Cost / Unit" is $40 instead of $20. This
occurs because, in the SQL query, when performing the left join
between `stock_move_move_rel` and `stock_move`, the moves appear
duplicated as they have the same `move_orig_id`. Consequently, when
calculating the total quantity, it results in
`(99 + 99) = 198 * $20 = $3960`, but the total is only divided by the
quantity of one move, leading to $3960 / 99 = $40.

opw-[4061947](https://www.odoo.com/web#id=4061947&view_type=form&model=project.task)

Forward-Port-Of: odoo/enterprise#68834
Forward-Port-Of: odoo/enterprise#68778

[FW][FIX] quality: order “quality.check” by “quality.point”

PR #68856

Enterprisesaas-17.2

Original PR description

Steps to reproduce the bug:
- Create a storable product “P1”
    - Create a 3 quality.point:
         - 1st per operation:
         - 2nd per product
         - 3rd per quantity

- Create a receipt picking with 2 unit of P1
- Mark as to do
- Try to do the “quality.check”

Problem:
The 'quality.check' is not ordered by the 'quality.point' defined in the product because the 'quality.check' measured by 'move_line' is created when the 'stock.move.line' is created before the other type, so it is proposed first.

https://github.com/odoo/enterprise/blob/fbc3ce9d690ab8c5ccf5b0f46748aec8901575a1/quality_control/models/stock_move_line.py#L31

https://github.com/odoo/enterprise/blob/fbc3ce9d690ab8c5ccf5b0f46748aec8901575a1/quality_control/models/stock_move_line.py#L54-L55


opw-3870095

Forward-Port-Of: odoo/enterprise#62107
Forward-Port-Of: odoo/enterprise#61132

[FW][FIX] website_sale: revert of 2d6e7c75eeb87cd85fa28ca0519a9734554c3437

PR #177836

Coresaas-17.2website_sale

Original PR description

Steps to reproduce:
- Install `website_sale`, `sale_purchase_inter_company_rules`
- Set the second website for "My Company (Chicago)" and as the domain put "http://2.localhost:8069/"
- Create an SO on San Francisco company and save it without confirming
- Execute the following SQL command:
```sql
update sale_order set website_id=2, company_id=2, pricelist_id=null where id=41; -- here put the id of the SO
```
- Now open the website app and select Website 2.

Issues:
Internal error, this is due to the fact that we're raising a UserError here.

https://github.com/odoo/odoo/blob/79ad7396b15a9e26e812f2f2151241fa5bf76e18/addons/website_sale/models/website.py#L365-L373

While a better solution is searched the best one for stable is to remove the
UserError.

opw-4054699

Forward-Port-Of: odoo/odoo#176926

Steps to reproduce the bug: - Create a storable product P1 with the following BoM: - Type: Subcontracting - Subcontractor: Azure Interior - Components: - C1: 1 unit (price of C1: $10) - Cost of P1: $10 - Create a purchase order: - Product: P1 - Quantity: 100 units - Confirm the purchase order. - Receive 99 units and create a backorder for 1 unit. - Go to Manufacturing > Reporting > Production Analysis. Problem: The "Total Subcontracting Cost / Unit" is $40 instead of $20. This occurs because, in the SQL query, when performing the left join between `stock_move_move_rel` and `stock_move`, the moves appear duplicated as they have the same `move_orig_id`. Consequently, when calculating the total quantity, it results in `(99 + 99) = 198 * $20 = $3960`, but the total is only divided by the quantity of one move, leading to $3960 / 99 = $40. opw-[4061947](https://www.odoo.com/web#id=4061947&view_type=form&model=project.task) Forward-Port-Of: odoo/enterprise#68834 Forward-Port-Of: odoo/enterprise#68778

Steps to reproduce the bug: - Create a storable product “P1” - Create a 3 quality.point: - 1st per operation: - 2nd per product - 3rd per quantity - Create a receipt picking with 2 unit of P1 - Mark as to do - Try to do the “quality.check” Problem: The 'quality.check' is not ordered by the 'quality.point' defined in the product because the 'quality.check' measured by 'move_line' is created when the 'stock.move.line' is created before the other type, so it is proposed first. https://github.com/odoo/enterprise/blob/fbc3ce9d690ab8c5ccf5b0f46748aec8901575a1/quality_control/models/stock_move_line.py#L31 https://github.com/odoo/enterprise/blob/fbc3ce9d690ab8c5ccf5b0f46748aec8901575a1/quality_control/models/stock_move_line.py#L54-L55 opw-3870095 Forward-Port-Of: odoo/enterprise#62107 Forward-Port-Of: odoo/enterprise#61132

Steps to reproduce: - Install `website_sale`, `sale_purchase_inter_company_rules` - Set the second website for "My Company (Chicago)" and as the domain put "http://2.localhost:8069/" - Create an SO on San Francisco company and save it without confirming - Execute the following SQL command: ```sql update sale_order set website_id=2, company_id=2, pricelist_id=null where id=41; -- here put the id of the SO ``` - Now open the website app and select Website 2. Issues: Internal error, this is due to the fact that we're raising a UserError here. https://github.com/odoo/odoo/blob/79ad7396b15a9e26e812f2f2151241fa5bf76e18/addons/website_sale/models/website.py#L365-L373 While a better solution is searched the best one for stable is to remove the UserError. opw-4054699 Forward-Port-Of: odoo/odoo#176926