Monday, August 26, 2024
2 changes · saas-17.2
Resolved issues and error corrections
This fix prevents an intermittent failure when opening report variants and their sections in accounting reports. It improves reliability for automated checks and helps ensure users can navigate report sections consistently.
Original PR description
The tour `test_sections_tour` fails undeterministically. It fails after opening the the variant, then opening another section of it. The issue is that we try to open the second section just before the preloading of this section happens. The opening of it enters `loadReportOptions`, has no loadingCallNumber as it is the first opening. We then stop at the call to `get_options`. Then, the preloading can happen (which is why it's undeterministic). We enter the `if` in `preLoadClosedSections`, as the options are not yet of the second section. We then increment loadingCallNumber, which means it's not in sync with the call that was made to the python. If the options call comes back now, we don't remake a call with the new loadingCallNumber. runbot-75429 runbot-74795
Products configured to keep selling when out of stock will no longer show a “Temporarily out of stock” warning in the ecommerce wishlist. This avoids confusing shoppers and keeps the wishlist messaging aligned with the merchant’s selling settings.
Original PR description
When the product has the "continue selling" box when "out-of-stock" checked, and you add the product to the wishlist from ecommerce, "Temporarily out of stock" message/warning will appear in the…
When the product has the "continue selling" box when "out-of-stock" checked, and you add the product to the wishlist from ecommerce, "Temporarily out of stock" message/warning will appear in the wishlist. To Reproduce on Runbot: 1. Make sure ecommerce module is installed 2. Go to a storable product (for example: Cable Management Box) 3. In the sales tab, make sure the option "Continue Selling" for Out-of-Stock field is checked 4. Go to ecommerce, search for the product (here, let's search for Cable Management Box), click on it 5. Click on add to wishlist 6. Go to wishlist. 7. We'll see "Temporarily out of stock" message. But, we don't want this because we want to continue selling even if it's out of stock, and don't want to customer to get confused with the message. So, since the message/warning doesn't align with the concept of continue selling when out of stock, we want to get rid of the message/warning if the product has "continue selling" box checked. opw-4121929